Review: golang-github-aquasecurity-go-gem-version 0.0~git20201115.8eed6fe-1
Package Information
| Description | library for parsing RubyGems versions and version constraints go-gem-version is a library for parsing RubyGems versions and version constraints, and verifying versions against a set of constraints. go-gem-version can sort a collection of versions properly, handles prerelease versions, etc. Versions used with go-gem-version must follow RubyGems versioning policy. |
|---|---|
| Maintainer | Debian Go Packaging Team <team+pkg-go@tracker.debian.org> |
| Changed By | Juan Manuel Méndez Rey <juan.mendezr@proton.me> |
| Sponsor | tsimonq2@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/go-team/packages/golang-github-aquasecurity-go-gem-version.git (browse) |
| Closes | #1152492 |
| Tracker | https://tracker.debian.org/pkg/golang-github-aquasecurity-go-gem-version |
| Uploaded | 2 days ago |
New Package Report
.changes
| Architecture | source all |
|---|---|
| Distribution | unstable |
| Date | Fri, 30 Oct 2026 03:06:55 +0100 |
| Source | golang-github-aquasecurity-go-gem-version |
| Version | 0.0~git20201115.8eed6fe-1 |
| Changed-By | Juan Manuel Méndez Rey <juan.mendezr@proton.me> |
Changelog
golang-github-aquasecurity-go-gem-version (0.0~git20201115.8eed6fe-1) unstable; urgency=medium . * Initial release (Closes: #1152492)
.dsc
| Section | golang |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | golang-github-aquasecurity-go-gem-version-dev deb golang optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Source: https://github.com/aquasecurity/go-gem-version Upstream-Name: go-gem-version Upstream-Contact: https://github.com/aquasecurity/go-gem-version/issues Files: * Copyright: 2020 Teppei Fukuda <knqyf263@gmail.com> License: Apache-2.0 Comment: Upstream has no copyright notice (LICENSE carries the unfilled Apache-2.0 appendix and no file has a header). Teppei Fukuda wrote every commit in the upstream history. Files: debian/* Copyright: 2026 Juan Manuel Méndez Rey <juan.mendezr@proton.me> License: Apache-2.0 Comment: Debian packaging is licensed under the same terms as upstream License: Apache-2.0 Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at . https://www.apache.org/licenses/LICENSE-2.0 . Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. Comment: On Debian systems, the complete text of the Apache version 2.0 license can be found in "/usr/share/common-licenses/Apache-2.0".
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 1 day ago.
Report
DFSG NEW review for golang-github-aquasecurity-go-gem-version version 0.0~git20201115.8eed6fe-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
The tree is a single Apache-2.0 work: one top-level LICENSE with the unmodified Apache License 2.0 text (its appendix still carries the [yyyy] [name of copyright owner] placeholder, and no source file has a copyright or licence header). debian/copyright is DEP-5, its Files: * stanza names Teppei Fukuda with a Comment explaining that the holder comes from the upstream history rather than from any notice in the tree, debian/* has its own stanza (2026 Juan Manuel Méndez Rey, Apache-2.0), and the stand-alone Apache-2.0 paragraph points at /usr/share/common-licenses/Apache-2.0, which is where the full text belongs. Nothing non-free, no vendored third-party code, no generated or built files, no images/fonts/data of unclear provenance. Apache-2.0 is DFSG-free and compatible with everything the library imports (x/xerrors, go-version, testify are all build-only from Debian).
Packaging
A conventional dh-make-golang/pkg-go package: single Architecture: all -dev package, debhelper compat 14, dpkg-build-api (= 1), dh-go/--with=golang with the golang buildsystem, Standards-Version 4.7.4 against Policy 4.7.4.1, Vcs-* and Homepage set, Salsa CI and gbp.conf present. Build-Depends are exactly the three modules the source imports (go-version, x/xerrors at build time; testify under <!nocheck> for the test run), all present in the archive; the Depends of the -dev package carry the two runtime imports. No patches. DH_GOLANG_EXCLUDES := examples keeps the three example main programs out of both the build and the installed source (DH_GOLANG_EXCLUDES_ALL defaults to true from compat 12), so no example binaries land in /usr/bin. Changelog is a single initial release on unstable closing the ITP; the date matches its weekday.
Issues
None.
Verified ◂
LICENSE: full Apache License 2.0 text, unmodified; the appendix is unfilled (Copyright [yyyy] [name of copyright owner]), which theFiles: *Comment in debian/copyright records. This is the only licence text in the tree.- Grep for
Copyright,(C),©,SPDX-License-Identifier,Licensed under,Permission is hereby granted,GNU ...,Apache License,Mozilla Public,public domainover the tree (excluding .pc/) returns hits only inside LICENSE's own Apache wording plus the reformatted licence paragraph in debian/copyright; no file carries its own copyright or licence notice, so there is no holder for debian/copyright to omit. The pre-scan's author check agrees. version.go,constraint.go,version_collection.go,*_test.goare original Go code; comments merely link to the RubyGemsversion.rb/requirement.rbsources, and nothing is copied from them, so no RubyGems attribution is needed.- Other upstream files —
.gitignore,README.md,go.mod,go.sum,.github/workflows/test.yml,examples/{comparison,constraint,sort}/main.go— are ordinary configuration/documentation/code under the same Apache-2.0; they are matched byFiles: *. debian/*is covered by theFiles: debian/*stanza (2026 Juan Manuel Méndez Rey, Apache-2.0);debian/salsa-ci.ymlis the five-line Salsa CI include template with no separate authorship.- No binary, generated, minified or vendored content anywhere in the tree; no
vendor/directory. The orig tarball (go-gem-version/:.github/,.gitignore,constraint.go,constraint_test.go,examples/,go.mod,go.sum,LICENSE,README.md,version.go,version_collection.go,*_test.go) matches the reviewed tree, and the debian tarball contains only the files present underdebian/— nodebian/patchesand no.pc/in either tarball. - Build dependencies checked with
apt-cache:dh-go1.69 (providesdh-sequence-golang),golang-github-aquasecurity-go-version-dev0.0~git20210121.637058c-2 (the rewritten module that carriespkg/part, whichversion.goimports),golang-github-stretchr-testify-dev1.11.1-2,golang-golang-x-xerrors-dev, anddpkg-dev1.23.11 providingdpkg-build-api (= 1). All are in the archive and satisfiable. dpkg-build-api (= 1)makesRules-Requires-Rootdefault tono(man dpkg-build-api: "dpkg-buildpackage defaults to Rules-Requires-Root value no"), so its absence from debian/control is not a fault.--with=golangis redundant becausedh-goprovidesdh-sequence-golang, but harmless; thegolangbuildsystem anddh_golangboth exist at the declared dependency (/usr/share/perl5/Debian/Debhelper/Buildsystem/golang.pm,/usr/bin/dh_golang).- The test step needs testify:
dh_auto_testrunsgo test -von the build targets, the<!nocheck>marking is right at compat 14. - The package declares
Testsuite: autopkgtest-pkg-gowith nodebian/tests/control, which is the pkg-go convention; autopkgtest is not installed on the reviewing system, so I did not verify how that suite is resolved (see unconfirmed). - uscan found the packaged version as the newest upstream release (upstream
0.0~git20201115.8eed6fe, packaged0.0~git20201115.8eed6fe). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (Apache-2.0).
Not confirmed ◂
- Whether anyone other than Teppei Fukuda appears in the upstream commit history cannot be checked from the package; debian/copyright's holder and its Comment rest on the maintainer's statement about the upstream history.
- The ITP number #1152492 in the changelog and the two Vcs-* URLs were not verified (no network access).
- How autopkgtest handles
Testsuite: autopkgtest-pkg-gowithout debian/tests/control could not be checked here; the autopkgtest document shipped with Policy lists implicit control files only for Ruby and Perl, but autopkgtest itself is not installed.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader was emailed about the review 1 day ago.
Review Information
accepted — allocated to awm 1 day ago, started 1 day ago, completed 1 day ago.