Review: golang-github-aquasecurity-jfather 0.0.8-1
Package Information
| Description | Parse JSON with line numbers and more! This is a JSON parsing module that provides additional information during the unmarshalling process, such as line numbers, columns etc. You should not use this package unless you need the line/column metadata, as unmarshalling is typically much slower than the encoding/json package. |
|---|---|
| Maintainer | Debian Go Packaging Team <team+pkg-go@tracker.debian.org> |
| Changed By | Juan Manuel Méndez Rey <juan.mendezr@proton.me> |
| Sponsor | tsimonq2@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/go-team/packages/golang-github-aquasecurity-jfather.git (browse) |
| Closes | #1152527 |
| Tracker | https://tracker.debian.org/pkg/golang-github-aquasecurity-jfather |
| Uploaded | 2 days ago |
New Package Report
.changes
| Date | Fri, 30 Oct 2026 09:32:13 +0100 |
|---|---|
| Source | golang-github-aquasecurity-jfather |
| Version | 0.0.8-1 |
| Changed-By | Juan Manuel Méndez Rey <juan.mendezr@proton.me> |
| Architecture | source all |
| Distribution | unstable |
Changelog
golang-github-aquasecurity-jfather (0.0.8-1) unstable; urgency=medium . * Initial release (Closes: #1152527)
.dsc
| Priority | optional |
|---|---|
| Component | main |
| Package-List | golang-github-aquasecurity-jfather-dev deb golang optional arch=all |
| Section | golang |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/aquasecurity/jfather
Upstream-Name: jfather
Upstream-Contact: https://github.com/aquasecurity/jfather/issues
Files: *
Copyright: 2021-2022 Liam Galvin
2025 DmitriyLewen <https://github.com/DmitriyLewen>
License: Expat
Comment: LICENSE names "2022 Liam Galvin"; DmitriyLewen wrote later commits.
Files: debian/*
Copyright: 2026 Juan Manuel Méndez Rey <juan.mendezr@proton.me>
License: Expat
Comment: Debian packaging is licensed under the same terms as upstream
License: Expat
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
.
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 1 day ago.
Report
DFSG NEW review for golang-github-aquasecurity-jfather version 0.0.8-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
The whole tree is MIT/Expat. LICENSE is the only copyright/licence notice in the upstream files (Copyright (c) 2022 Liam Galvin); no source file carries a per-file notice, an SPDX tag or a different licence, there is no vendored or generated third-party code, and the files added for GitHub CI, the example program and the editor config carry no separate terms. debian/copyright is DEP-5 with the exact Format URL, a Files: * stanza naming both holders (Liam Galvin, DmitriyLewen), a debian/* stanza after it holding the maintainer, and a complete standalone License: Expat paragraph, so the short name, the text and the holders match what the tree shows; the prescan's holder check also found no unnamed holder. No Files-Excluded is needed: nothing was removed from the upstream tarball.
Packaging
A clean, conventional Go source package: one Architecture: all, Multi-Arch: foreign -dev package, debhelper compat 14 with dh $@ --buildsystem=golang --with=golang (dh-go ships the sequence addon but, unlike dh-golang, no dh-sequence-golang, so --with=golang is required and present), dpkg-build-api (= 1), and every Build-Depends resolvable in unstable (debhelper 14, dh-go 1.69, dpkg-build-api 1 via dpkg-dev 1.23.11, golang-any 1.27, testify 1.11.1 with <!nocheck>). Standards-Version 4.7.4 is current against the reviewing Policy 4.7.4.1, the changelog, upstream metadata and copyright for debian/* are consistent, there are no patches, and depends: ${misc:Depends} alone is correct at compat 14. The only thing that gave me pause is the non-default --builddirectory=debian/_build, which dh-go's dh_golang_autopkgtest does not account for; I could not confirm an effect without an autopkgtest run (Not confirmed).
Issues
None.
Verified ◂
- Covered the whole tree (36 upstream files plus
debian/): grepped every file outside.pc/forCopyright,(C),©,SPDX-License-Identifier,Licensed under,Permission is hereby granted, GPL/LGPL/Apache/MPL,public domainandAll rights reserved. The only hits areLICENSEanddebian/copyright; also grepped forCode generated/go:generate/DO NOT EDIT(no matches) and foradapted/copied/based on/derived from(none), so nothing in the tree claims another origin. - Prescan: it listed no file for review; its only result was that every holder found is named in
debian/copyright, which matches my own grep (LICENSE:Copyright (c) 2022 Liam Galvin). - Files the tree's own documentation or config could hide terms in are innocent:
README.md(usage and benchmark numbers, no licence text),.github/workflows/test.yml(upstream GitHub CI,actions/checkout@v2/setup-go@v2, no notice),_examples/basic/main.go(upstream example program, Expat code covered byFiles: *),.vimspector.json(editor debugger configuration, data),go.sum(dependency checksums only; no dependency source is shipped, so no third-party copyright belongs indebian/copyright). debian/copyrightin full: DEP-5,Format:the exact 1.0 URL,Source/Upstream-Name/Upstream-Contactpresent,Files: *with two holders andLicense: Expat,Files: debian/*last (so it overrides the catch-all), and a standaloneLicense: Expatparagraph containing the full MIT/Expat text, identical toLICENSE. Expat is DFSG-free, and nothing is combined with an incompatible licence. NoFiles-Excludedis declared, and no file has been removed from the upstream tarball.debian/read in full:changelog,control,copyright,gbp.conf,rules,salsa-ci.yml,source/format(3.0 quilt),upstream/metadata;debian/watchleft to the separate check. There is nodebian/patches/and.pc/applied-patchesis empty, so there are no patches that could lack DEP-3 headers or need forwarding.- Build-Depends checked against the archive lists:
debhelper-compat (= 14),dh-go1.69 (provides thegolangsequence addon and buildsystem;Conflicts: dh-golang, and it does not providedh-sequence-golang, hence--with=golang),dpkg-build-api (= 1)(provided by dpkg-dev 1.23.11),golang-any1:1.27,golang-github-stretchr-testify-dev1.11.1. testify is a test-only import and is marked<!nocheck>, which is right for a-devpackage with no runtime Go dependencies. dpkg-build-api (= 1)makesRules-Requires-Rootdefault tono(dpkg-build-api(7), API LEVELS v1), so its absence fromdebian/controlis not a fault.- Standards-Version 4.7.4 against the reviewing Policy 4.7.4.1: same first two components, so current enough and not an issue.
Package: golang-github-aquasecurity-jfather-dev,Architecture: all,Multi-Arch: foreignfor a source-only Go library package,XS-Go-Import-Pathmatching the module path ingo.mod,Depends: ${misc:Depends},alone at compat 14 (dh_gencontrol adds relationship substvars itself; dpkg-gencontrol deletes the field when it resolves empty).go.modrequires testify v1.7.0 while Debian has 1.11.1: not a problem, because dh-go's golang buildsystem setsGO111MODULE=offand build/test run in GOPATH mode, where the version requirement is not consulted.debian/gbp.conf:dist = DEP14is a genuine gbp setting, not a stray distribution name —/usr/lib/python3/dist-packages/gbp/scripts/buildpackage.pyget_pbuilder_dist()handles'DEP14'/'DEP-14'by deriving the dist from the DEP-14 branch name; the remaining options (debian-branch = debian/sid,pristine-tar,ignore-branch) are the Go team's template. Not an issue.debian/changelog: version0.0.8-1(upstream 0.0.8, Debian revision 1),unstable, initial release closing #1152527, maintainer matchingUploadersand thedebian/*copyright; dateFri, 30 Oct 2026is consistent with the stated year and with today's date.- uscan found the packaged version as the newest upstream release (upstream
0.0.8, packaged0.0.8).
Not confirmed ◂
debian/rulesbuilds indebian/_build, butdh_golang_autopkgtest(the script dh-go ships forTestsuite: autopkgtest-pkg-go;/usr/bin/dh_golang_autopkgtest, whoseadd_configure_override()appendsoverride_dh_auto_configure: mkdir -p "${APT_BDIR}" ...) computesAPT_BDIRfromload_buildsystem("golang")->get_builddir()with no options, i.e. the compat-14 default_build(golang.pmDEFAULT_BUILD_DIRECTORY), not the package'sdebian/_build. If autopkgtest dispatches pkg-go to that script and installs the built-devpackage, its override configures_buildand leavesdebian/_builduncreated, wheredh_auto_buildthen fails inget_targets(opendir debian/_build/src/github.com/aquasecurity/jfather); if the script is not what runs, the option is merely unnecessary. autopkgtest is not installed on the reviewing system, so I could not see the dispatch, and no build or test was run. An autopkgtest run would show which; dropping--builddirectory=debian/_build(compat 14 already defaults to_build) would settle it either way.- The Vcs-Git/Vcs-Browser URLs under
salsa.debian.org/go-team/packages/cannot be checked from here (no network access); they follow the Go team's layout, and the package is not yet in the archive lists.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader was emailed about the review 1 day ago.
Review Information
accepted — allocated to awm 1 day ago, started 1 day ago, completed 1 day ago.