DFSG NEW Queue

DFSG, Licensing & New Packages Team

Review: golang-github-bep-imagemeta 0.12.0+dfsg-1

Review Information

Packagegolang-github-bep-imagemeta — 0.12.0+dfsg-1
Reviewersiretart
Allocated5 days ago
Started5 days ago
Statusaccepted
Completed2 days ago

Final Comment

New Package Report

Notes

5 days ago ● public

So, I found a couple of additional copyright statements in what looks like exit data to (removed) test data, mostly photos:

I'm inclined to ACCEPT, but would appreciate a 2nd team opinion on this.

gen/testdata_exiftool/images/outofbounds-issue-34.jpg.json
152:    "ProfileCopyright": "Nikon Inc. & Nikon Corporation 2009",

gen/testdata_exiftool/images/sunrise.png.json
37:    "ExifCopyright": "Bjørn Erik Pedersen",
95:    "Icccopyright": "Copyright (c) 1998 Hewlett-Packard Company",
110:    "Copyright": "Bjørn Erik Pedersen",
177:    "CopyrightNotice": "Bjørn Erik Pedersen"

gen/testdata_exiftool/images/corrupt/infinite_loop_exif.jpg.json
47:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",

gen/testdata_exiftool/images/metadata_demo_iim_and_xmp_only.jpg.json
34:    "CopyrightFlag": 1,
64:    "CopyrightNotice": "© Copyright 2017 Carl Seibert  metadatamatters.blog (IIM)",
85:    "AOCopyrightNotice": "(c) 2017 Carl Seibert. 954-256-5834",
92:    "ArtworkCopyrightNotice": "Default",
95:    "ArtworkCopyrightOwnerID": "Default",
96:    "ArtworkCopyrightOwnerName": "Default",
134:    "Rights": "© Copyright 2017 Carl Seibert  metadatamatters.blog (XMP)",
161:    "CopyrightOwnerID": "Default",
162:    "CopyrightOwnerName": "Joe Photographer",
191:    "UsageTerms": "This is the Rights Usage Terms field. For real, this test image is licensed under Creative Commons 4.0",

gen/testdata_exiftool/images/sunrise.jpg.json
33:    "Copyright": "Bjørn Erik Pedersen",
91:    "CopyrightFlag": 1,
110:    "CopyrightNotice": "Bjørn Erik Pedersen"
129:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",

gen/testdata_exiftool/images/utf8-in-ztxt.png.json
45:    "ProfileCopyright": "Copyright 1999 Adobe Systems Incorporated",

gen/testdata_exiftool/images/smoke/hugo-issue-10738/sony_arw_fraction.jpg.json
106:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",
281:    "LookCopyright": "© 2018 Adobe Systems, Inc.",

gen/testdata_exiftool/images/metadata-extractor-images/jpg/issue614.png.json
43:    "Icccopyright": "Public Domain",
66:    "ProfileCopyright": "Public Domain",

gen/testdata_exiftool/images/smoke/hugo-issue-10738/leica_dng_fraction.jpg.json
103:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",
143:    "PreservedFileName": "L1010070.DNG",
277:    "LookCopyright": "© 2018 Adobe Systems, Inc.",

gen/testdata_exiftool/images/smoke/hugo-issue-10738/canon_cr2_integer.jpg.json
96:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",
268:    "LookCopyright": "© 2018 Adobe Systems, Inc.",

gen/testdata_exiftool/images/metadata-extractor/withXmp.jpg.json
50:    "CopyrightNotice": "CHRISTOF STACHE",

gen/testdata_exiftool/images/smoke/hugo-issue-10738/nikon_nef_integer.jpg.json
32:    "Copyright": "ediwi_jaya",
94:    "CopyrightNotice": "ediwi_jaya"
113:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",
286:    "LookCopyright": "© 2018 Adobe Systems, Inc.",

gen/testdata_exiftool/images/smoke/hugo-issue-10738/fuji_raf_integer.jpg.json
105:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",
277:    "LookCopyright": "© 2018 Adobe Systems, Inc.",

gen/testdata_exiftool/images/metadata-extractor/withIptcExifGps.jpg.json
42:    "Copyright": "ian Britton - FreeFoto.com",
96:    "CopyrightNotice": "ian Britton - FreeFoto.com"
109:    "CopyrightFlag": 1,
163:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",

gen/testdata_exiftool/images/smoke/hugo-issue-10738/lumix_rw2_fraction.jpg.json
108:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",
312:    "LookCopyright": "© 2018 Adobe Systems, Inc.",

gen/testdata_exiftool/images/metadata-extractor/withExifAndIptc.jpg.json
42:    "Copyright": "ian Britton - FreeFoto.com",
96:    "CopyrightNotice": "ian Britton - FreeFoto.com"
109:    "CopyrightFlag": 1,
163:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",

gen/testdata_exiftool/images/smoke/hugo-issue-10738/nikon_nef_d5600.jpg.json
110:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",
280:    "LookCopyright": "© 2018 Adobe Systems, Inc.",

gen/testdata_exiftool/images/goexif/FailedHash-NoDate-sep-remembory.jpg.json
39:    "ProfileCopyright": "(C) BROTHER INDUSTRIES,LTD. 2002   ",

gen/testdata_exiftool/images/smoke/hugo-issue-10738/canon_cr2_fraction.jpg.json
96:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",
269:    "LookCopyright": "© 2018 Adobe Systems, Inc.",

gen/testdata_exiftool/images/metadata-extractor/adobeJpeg1.jpg.json
36:    "Copyright": "1999 Lars Borg",
46:    "CopyrightNotice": "1999 Lars Borg"
59:    "CopyrightFlag": 1,
108:    "ProfileCopyright": "(c) 1999 Adobe Systems Inc.",

gen/testdata_exiftool/images/smoke/hugo-issue-10738/nikon_nef_fraction.jpg.json
111:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",
281:    "LookCopyright": "© 2018 Adobe Systems, Inc.",

gen/testdata_exiftool/images/smoke/upstream66.jpg.json
45:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",

gen/testdata_exiftool/images/smoke/hugo-issue-10738/dji_dng_fraction.jpg.json
103:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",
156:    "PreservedFileName": "shotkit-DJI-Mavic-Pro-Platinum-3.dng",

gen/testdata_exiftool/images/IPTC-PhotometadataRef-Std2021.1.jpg.json
31:    "Copyright": "Copyright (Notice) 2021.1 IPTC - www.iptc.org  (ref2021.1)",
58:    "CopyrightNotice": "Copyright (Notice) 2021.1 IPTC - www.iptc.org  (ref2021.1)",
90:    "ArtworkCopyrightNotice": "AO Copyright Notice 1 (ref2021.1)",
93:    "ArtworkCopyrightOwnerID": "AO Current Copyright Owner ID 1 (ref2021.1)",
94:    "ArtworkCopyrightOwnerName": "AO Current Copyright Owner Name 1 (ref2021.1)",
178:    "Rights": "Copyright (Notice) 2021.1 IPTC - www.iptc.org  (ref2021.1)",
192:    "CopyrightOwnerID": ["Copyright Owner Id 1 (ref2021.1)","Copyright Owner Id 2 (ref2021.1)"],
193:    "CopyrightOwnerName": ["Copyright Owner Name 1 (ref2021.1)","Copyright Owner Name 2 (ref2021.1)"],

gen/testdata_exiftool/images/metadata_demo_inc_exif_out_of_sync_Inc_adobe.jpg.json
25:    "ImageDescription": "(This caption in Exif) This is a metadata test file. It has values in most IPTC  fields, including many extended fields, in both the IIM and XMP data blocks. Also contains Exif data, inc. sample GPS data. NOTE that this file is out-of-sync. The Caption/description, Creator and Copyright fields have different values in the IIM, XMP, and Exif data blocks. This file also contains Photoshop log info, Lightroom Develop info, and both Exif and Photoshop thumbnails. The original file can be found at www.carlseibert.com/commons  Carl Seibert / Creative Commons 4.0",
34:    "Copyright": "© Copyright 2017 Carl Seibert  metadatamatters.blog (Exif)",
76:    "CopyrightFlag": 1,
101:    "Caption-Abstract": "(This caption in IIM) This is a metadata test file. It has values in most IPTC  fields, including many extended fields, in both the IIM and XMP data blocks. Also contains Exif data, inc. sample GPS data. NOTE that this file is out-of-sync. The Caption/description, Creator and Copyright fields have different values in the IIM, XMP, and Exif data blocks. This file also contains Photoshop log info, Lightroom Develop info, and both Exif and Photoshop thumbnails. The original file can be found at www.carlseibert.com/commons  Carl Seibert / Creative Commons 4.0",
106:    "CopyrightNotice": "© Copyright 2017 Carl Seibert  metadatamatters.blog (IIM)",
127:    "AOCopyrightNotice": "(c) 2017 Carl Seibert. 954-256-5834",
134:    "ArtworkCopyrightNotice": "Default",
137:    "ArtworkCopyrightOwnerID": "Default",
138:    "ArtworkCopyrightOwnerName": "Default",
174:    "Description": "(This caption in XMP) This is a metadata test file. It has values in most IPTC  fields, including many extended fields, in both the IIM and XMP data blocks. Also contains Exif data, inc. sample GPS data. NOTE that this file is out-of-sync. The Caption/description, Creator and Copyright fields have different values in the IIM, XMP, and Exif data blocks. This file also contains Photoshop log info, Lightroom Develop info, and both Exif and Photoshop thumbnails. The original file can be found at www.carlseibert.com/commons  Carl Seibert / Creative Commons 4.0",
176:    "Rights": "© Copyright 2017 Carl Seibert  metadatamatters.blog (XMP)",
203:    "CopyrightOwnerID": "Default",
204:    "CopyrightOwnerName": "Joe Photographer",
233:    "UsageTerms": "This is the Rights Usage Terms field. For real, this test image is licensed under Creative Commons 4.0",

gen/testdata_exiftool/images/smoke/hugo-issue-10738/fuji_raf_fraction.jpg.json
100:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",
268:    "LookCopyright": "© 2018 Adobe Systems, Inc.",

gen/testdata_exiftool/images/smoke/hugo-issue-10738/sony_arw_integer.jpg.json
106:    "ProfileCopyright": "Copyright (c) 1998 Hewlett-Packard Company",
283:    "LookCopyright": "© 2018 Adobe Systems, Inc.",
4 days ago ● public

Just reviewing that further, I see...

golang-github-bep-imagemeta (0.12.0+dfsg-1) unstable; urgency=medium

  * Team upload.
  * Exclude testdata images from the Debian package <<----
  * Add comment to d/copyright about image license  <<----
  * Disable testing of package

and also, in the debian/copyright it says:

Files-Excluded: testdata
Comment: The images in the testdata directory are only used
 for testing (obviously). They are not needed in the Debian package.
 The license and copyright status of those images is not clear,
 so they are removed from the Debian source and binary packages.

If you look in detail at the package there are actually no image files in there. Those are JSON files representing the exif data from images, but not the images themselves. I hereby revise my opinion and am totally OK to ACCEPT this package.

4 days ago ● public

thanks for double checking!

Back to Dashboard | View all reviews for this package