golang-github-brunoscheufler-aws-ecs-metadata-go 0.0~git20221221.67e37ae-1

Package Information

Description	Retrieve AWS ECS Task metadata (library) A minimal Go library to fetch Elastic Container Service (ECS) Task metadata from services running in containers provisioned by AWS Fargate. Based on the Fargate platform version, different versions of the Task Metadata Endpoint are available (v3 for Fargate 1.3.0+, v4 for 1.4.0+).
Maintainer	Debian Go Packaging Team <team+pkg-go@tracker.debian.org>
Changed By	Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Sponsor	ajqlee@debian.org
Distribution	unstable
Architecture	all
VCS	git: https://salsa.debian.org/go-team/packages/golang-github-brunoscheufler-aws-ecs-metadata-go.git (browse)
Closes	#1140162
Tracker	https://tracker.debian.org/pkg/golang-github-brunoscheufler-aws-ecs-metadata-go
Uploaded	7 hours ago

New Package Report

.changes◂

Source	golang-github-brunoscheufler-aws-ecs-metadata-go
Version	0.0~git20221221.67e37ae-1
Changed-By	Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Architecture	source all
Distribution	unstable
Date	Sat, 03 Oct 2026 13:12:37 +0200

Changelog◂

golang-github-brunoscheufler-aws-ecs-metadata-go (0.0~git20221221.67e37ae-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1140162)
   * Port to dh-go (module-aware builds)

.dsc◂

Component	main
Package-List	golang-github-brunoscheufler-aws-ecs-metadata-go-dev deb golang optional arch=all
Section	golang
Priority	optional

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/brunoscheufler/aws-ecs-metadata-go
Upstream-Name: aws-ecs-metadata-go
Upstream-Contact: Bruno Scheufler <git@brunoscheufler.com>

Files: *
Copyright: 2020 Bruno Scheufler
License: Expat

Files: debian/*
Copyright: 2026 Juan Manuel Méndez Rey <juan.mendezr@proton.me>
License: Expat
Comment: Debian packaging is licensed under the same terms as upstream

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 2 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 6 hours ago.

Report◂

DFSG NEW review for golang-github-brunoscheufler-aws-ecs-metadata-go version 0.0~git20221221.67e37ae-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: Yes
Issues: 0 blocker, 2 important, 0 minor
debian/watch: malformed version line
debian/copyright: machine-readable
Scan before the review: nothing found

Licensing

The whole upstream tree is MIT/Expat (LICENSE: "MIT License, Copyright (c) 2020 Bruno Scheufler"), the only holder in the tree, and debian/copyright is DEP-5 with a correct Files: * / Files: debian/* split and the full Expat text inline (Expat is not in /usr/share/common-licenses, so the inline text is required). No non-free terms, no third-party or vendored code, no built files. The prescan's author check found every holder already named.

Packaging

Small, conventional pkg-go library package: source 3.0 (quilt) with no patches, compat 13, dh $@ --with=golang, dpkg-build-api (= 1), correct XS-Go-Import-Path, autopkgtest-pkg-go, salsa-ci, gbp.conf and upstream/metadata all present. Build-Depends names dh-go, which exists in unstable (1.69, provides the golang addon; it Conflicts dh-golang, so --with=golang is required and supplied), testify only for the tests that need it, and golang-any. Standards-Version 4.7.4 matches the reviewing system's Policy series. No policy violation found.

Issues

important packaging 1. uscan reports an error for debian/watch ◂

Files: debian/watch
Basis: found by the review tooling's own checks

Evidence:

Malformed version line: version=5, only 'Version: X' is allowed when using version >= 5

Problem: uscan must run without errors or warnings and find the upstream releases.
Fix: Correct debian/watch so that uscan --report runs cleanly.

important packaging 2. uscan reports a warning for debian/watch ◂

Files: debian/watch
Basis: found by the review tooling's own checks

Evidence:

debian/watch version number is unrecognised

Problem: uscan must run without errors or warnings and find the upstream releases.
Fix: Correct debian/watch so that uscan --report runs cleanly.

Verified ◂

All 13 files outside debian/ and .pc/ were read: .gitignore, LICENSE, README.md, combined.go, fetch.go, go.mod, go.sum, v3.go, v4.go, v4_test.go, .github/workflows/go.yml, testdata/metadatav4-response-container.json, testdata/metadatav4-response-task.json. All carry the single upstream holder Bruno Scheufler (2020); only LICENSE has a notice, and the Expat text in debian/copyright matches it word for word.
testdata/*.json are sample ECS Task Metadata API responses (arn/ID strings, timestamps) copied from the AWS endpoint documentation that v3.go/v4.go cite; factual API output, no creative content and no separate licence needed. They are the test fixtures v4_test.go reads.
.github/workflows/go.yml and .gitignore are upstream's own GitHub CI/dotfile, covered by Files: * and by the single upstream holder; nothing to exclude.
The debian/* stanza follows Files: * and correctly overrides it for packaging files, whose holder (Juan Manuel Mendez Rey, 2026) and licence (Expat) are stated.
Copyright-format header (Format/Source/Upstream-Name/Upstream-Contact), Files patterns and the stand-alone Expat License paragraph are valid per copyright-format 1.0; Expat is absent from /usr/share/common-licenses, so the full text is correctly reproduced rather than referenced.
dh-go is a real archive package (1.69, Section golang, Provides nothing, Conflicts: dh-golang) whose description says it provides the debhelper addon named 'golang' -- so Build-Depends: dh-go plus dh $@ --with=golang is right, and debian/source/lintian-overrides only silences lintian's unknown-addon-dependency false positive.
dpkg-build-api (= 1) is the documented declaration form (dpkg-build-api(7), recommended level, dpkg >= 1.22.0); level 1 only changes default behaviour (Rules-Requires-Root=no, required rules targets) that dh provides.
golang-any (2:1.27~1) and golang-github-stretchr-testify-dev (1.11.1-2) exist in unstable; testify 1.11.1 satisfies the go.mod requirement of v1.8.0 and is only imported by v4_test.go, which dh's golang buildsystem test step runs (go test -vet=off), so having it in Build-Depends is correct.
No debian/patches, maintainer scripts, tests/control, *.maintscript or installed doc/links/dirs files exist; nothing to audit there. debian/changelog is well formed (unstable, 0.0~git20221221.67e37ae-1, ITP #1140162, correct Saturday date), gbp.conf and both CI yml files match pkg-go/salsa practice.
Upstream-only observation, not a packaging or licensing issue: GetTaskV3 and GetContainerV3 in v3.go ignore the error returned by fetch() and unmarshal a possibly nil body.
uscan found the packaged version as the newest upstream release (upstream 0.0~git20221221.67e37ae, packaged 0.0~git20221221.67e37ae).

Not confirmed ◂

None.

Proposed changes ◂

None.

Uploader's response to the LLM review

Confirmed. I mistake on my behalf.

debian/watch has the version 5 header with version 4 syntax, so uscan falls back to version 4 and still finds the packaged version.

I have prepared a fix is in https://salsa.debian.org/go-team/packages/golang-github-brunoscheufler-aws-ecs-metadata-go/-/merge_requests/1

It will be in the next upload.

Could this one be accepted as is?

— Juan Manuel Méndez Rey (mendezr), 6 hours ago

Back to Dashboard | View all reviews for this package