DFSG NEW Queue

DFSG, Licensing & New Packages Team

golang-github-containers-image 5.39.4-2

Package Information

DescriptionConfiguration files and manpages for github.com/containers repositories

This package contains documentation and configuration files for use by other container projects.

MaintainerDebian Go Packaging Team <team+pkg-go@tracker.debian.org>
Changed ByReinhard Tartler <siretart@tauware.de>
Sponsorsiretart@debian.org
Distributionunstable
Architectureall
VCSgit: https://salsa.debian.org/go-team/packages/golang-github-containers-image.git (browse)
Popcon Installs14522
Binary NEWYes (new binary packages of a source already in sid)
Trackerhttps://tracker.debian.org/pkg/golang-github-containers-image
Uploaded1 day ago

New Package Report

.changes◂
Distributionunstable
DateTue, 17 Nov 2026 20:05:29 -0500
Sourcegolang-github-containers-image
Version5.39.4-2
Changed-ByReinhard Tartler <siretart@tauware.de>
Architectureall source
Changelog◂
golang-github-containers-image (5.39.4-2) unstable; urgency=medium
 .
   * No-change reupload to fix botched upload
 .
 golang-github-containers-image (5.39.4-1) unstable; urgency=medium
 .
   * New upstream release:
     - Fix schema1 digest/signature bypass via JWS payload confusion
     - Prevent symbolic link escapes when consuming oci-archive: archives
     - Update containers/storage to 1.62.3 (fixing CVE-2026-79699)
     - Mask upper bits in socket deny rules for seccomp
       (upstream issue #1248)
   * debian/control:
     - Upgrade to debhelper compat 14.
     - Update XS-Go-Import-Path to include "v5" component and require
       dh-golang (>= 1.66~).
     - Rename library package to golang-github-containers-image-v5-dev.
     - Provide golang-github-containers-image-dev transitional package.
   * Prefix debhelper configuration files with package name for compat 14.
.dsc◂
Sectiongolang
Priorityoptional
Componentmain
Package-Listgolang-github-containers-image deb golang optional arch=all
golang-github-containers-image-dev deb oldlibs optional arch=all
golang-github-containers-image-v5-dev deb golang optional arch=all
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: image
Source: https://github.com/containers/container-libs
Comment: Repacked upstream sources to only contain the "image/" subdirectory

Files: *
Copyright: 2016-2019
           Antonio Murdaca <runcom@redhat.com>
           Brandon Philips <brandon.philips@coreos.com>
           Miloslav Trmac <mitr@redhat.com>
           Dan Walsh <dwalsh@redhat.com>
           Nalin Dahyabhai <nalin@redhat.com>
License: Apache-2.0

Files: debian/*
Copyright: 2019, Reinhard Tartler <siretart@tauware.de>
           2024, Simon Josefsson <simon@josefsson.org>
License: Apache-2.0
Comment: Debian packaging is licensed under the same terms as upstream

Files: docker/distribution_error.go
  docker/distribution_error_test.go
Copyright: 2022, github.com/distribution/distribution authors.
License: Apache-2.0

Files: internal/pkg/platform/platform_matcher.go
Copyright: The containerd Authors.
 2012-2017, Docker, Inc.
License: Apache-2.0

Files: signature/sigstore/copied.go
Copyright: 2021, The Sigstore Authors.
License: Apache-2.0

Files:
  signature/internal/sequoia/gosequoia.c
  signature/internal/sequoia/gosequoia.h
Copyright: GPG Sequoia authors
License: FSFAP

License: Apache-2.0
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 .
 http://www.apache.org/licenses/LICENSE-2.0
 .
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
 .
 On Debian systems, the complete text of the Apache version 2.0 license
 can be found in "/usr/share/common-licenses/Apache-2.0".

License: FSFAP
 Copying and distribution of this file, with or without modification,
 are permitted in any medium without royalty provided the copyright
 notice and this notice are preserved.  This file is offered as-is,
 without any warranty.

DFSG Assistant LLM REVIEW

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 1 day ago.

Report◂

DFSG NEW review for golang-github-containers-image version 5.39.4-2

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: Yes
  • Packaging is of good quality: Yes
  • Issues: 0 blocker, 0 important, 2 minor; 1 more from the model's own knowledge, under Not confirmed
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: 46 found

Licensing

debian/copyright is DEP-5 with the canonical Format line and stanzas for the catch-all, debian/*, and each file carrying its own notice. The tree is Apache-2.0 except signature/internal/sequoia/gosequoia.{c,h}, which are the FSF All Permissive License; both stand-alone License paragraphs are present, FSFAP is reproduced in full and Apache-2.0 points at /usr/share/common-licenses/Apache-2.0. Every holder found in the tree is named and every embedded copy (docker/distribution, containerd/Docker, Sigstore) is Apache-2.0, so all licences combined in the packages are compatible. No non-free term, no unlicensed file and no built file without its source was found; the binary and compressed files are test vectors.

Packaging

Packaging is current and careful: 3.0 (quilt), debhelper compat 14 via dh-golang, both binary packages Architecture: all, a proper transitional package for the rename, DEP-3 patches, Salsa CI and Standards-Version 4.7.4 against Policy 4.7.4.1. The defects are minor: debian/clean deletes an upstream test file (and its .gitignore glob is ineffective), the Build-Depends/Depends lists no longer match the code's imports, and patch 0004 leaves go.sum inconsistent with go.mod. None of these keeps the package from building or from being uploaded.

Issues

minor packaging 1. debian/clean deletes upstream test file docker/docker_transport_test.go ◂
  • Files: debian/clean:1-7, docker/docker_transport_test.go
  • Basis: checked, in the package or with a reference tool
  • Evidence: debian/clean: docker/docker_transport_test.go and */*/.gitignore under ## tests accessing network:
  • Problem: dh_clean reads debian/clean through Dh_Lib::filedoublearray (glob-expanded at compat 13+, comments ignored) and rm -f's each match, so debian/rules clean deletes a file that comes from the orig tarball and is created by no patch or build step. Policy 4.9 makes clean undo the effects of build/binary, not remove unpacked source. Consequences: the -dev package, whose contents are copied from the tree after clean, loses the whole file and the 13 offline tests in it (only TestReferenceNewImage, TestReferenceNewImageSource and TestReferenceNewImageDestination reach quay.io, docker/docker_transport_test.go:208-262); a rebuild from the cleaned tree differs from the uploaded source, and dpkg-source -b in that tree would fail on the missing file. The */*/.gitignore line matches only signature/fixtures/.gitignore (two components), not signature/simplesigning/testdata/.gitignore or signature/simplesequoia/testdata/.gitignore, which is why the lintian override package-contains-vcs-control-file is still needed.
  • Fix: Drop both entries from debian/clean. Disable the three network tests with a t.Skip patch in the style of debian/patches/0001 and 0003, and if the .gitignore files must not be shipped, remove them at install time or use a pattern that reaches all three.
minor packaging 2. Build-Depends lists five unused modules while modules imported by the shipped code are declared nowhere ◂
  • Files: debian/control:19-20, debian/control:31, debian/control:33, debian/control:46, debian/control:80-120
  • Basis: checked, in the package or with a reference tool
  • Evidence: Build-Depends has golang-github-fullsailor-pkcs7-dev, golang-github-ghodss-yaml-dev, golang-github-otiai10-copy-dev, golang-github-pquerna-ffjson-dev, golang-github-xeipuuv-gojsonschema-dev although no file imports fullsailor/pkcs7, ghodss/yaml, otiai10/copy, pquerna/ffjson or xeipuuv/gojsonschema. Conversely gopkg.in/yaml.v3 (docker/registries_d.go:20, openshift/openshift-copies.go:25, pkg/cli/sigstore/params/sigstore.go:8), github.com/klauspost/compress/zstd (pkg/compression/zstd.go:6), github.com/hashicorp/go-retryablehttp and go-cleanhttp (signature/sigstore/rekor/rekor.go:15-16, leveled_logger.go:6), golang.org/x/term (copy/copy.go:30, pkg/shortnames/shortnames.go:16) and golang.org/x/oauth2 (signature/sigstore/fulcio/fulcio.go:21) appear in neither Build-Depends nor the -dev package's Depends.
  • Problem: Policy 7.7 and 3.5 require the build and binary relationships to describe what the package needs; here they describe a mixture of old states of the code. The modules happen to arrive only through other packages' Depends (x/term via golang-golang-x-crypto-dev, x/oauth2 via golang-github-sigstore-sigstore-dev, the hashicorp modules via golang-github-sigstore-rekor-dev, klauspost/compress via golang-github-containers-storage-dev), which is accidental; for yaml.v3 I found no declared dependency that pulls golang-gopkg-yaml.v3-dev in, so a consumer installing only the -dev package may not be able to compile go.podman.io/image/v5/docker.
  • Fix: Remove the five unused Build-Depends entries and add golang-gopkg-yaml.v3-dev, golang-github-klauspost-compress-dev, golang-github-hashicorp-go-retryablehttp-dev, golang-github-hashicorp-go-cleanhttp-dev, golang-golang-x-term-dev and golang-golang-x-oauth2-dev to both Build-Depends and the -dev package's Depends.
Verified ◂
  • Read all of debian/ (control, rules, changelog, copyright, clean, gbp.conf, gitlab-ci.yml, license-reconcile.yml, repack, install/docs/examples files, lintian overrides, source/format, source/lintian-overrides, upstream/metadata, all five patches and series). .pc/ was ignored as instructed.
  • Read debian/copyright in full: DEP-5, canonical Format URL, stanzas for *, debian/*, docker/distribution_error.go(+test), internal/pkg/platform/platform_matcher.go, signature/sigstore/copied.go and the two Sequoia C files, plus both stand-alone License paragraphs. Every holder found by the scan (distribution authors, containerd/Docker, Sigstore, GPG Sequoia) has a stanza; the names in Files: * match MAINTAINERS, and the year range is only stale, not a different holder.
  • Licence sweep over the tree: LICENSE and README.md are Apache-2.0; the only per-file notices are docker/distribution_error.go, docker/distribution_error_test.go, internal/pkg/platform/platform_matcher.go, signature/sigstore/copied.go, signature/internal/sequoia/gosequoia.c, signature/internal/sequoia/gosequoia.h (FSFAP) and SPDX tags in signature/internal/sequoia/sequoia.h and signature/internal/sequoia/gosequoiafuncs.h (Apache-2.0, covered by Files: *); no non-free wording anywhere.
  • Embedded copies are all Apache-2.0 and compatible with the package licence, with no separate notice to preserve: docker/reference/ (README: copy of github.com/docker/distribution/reference), docker/wwwauthenticate.go, internal/tarfile/types.go, internal/image/docker_schema1.go and openshift/openshift-copies.go.
  • The compressed and archive files the scan lists are upstream test inputs, not built artifacts: pkg/compression/fixtures/Hello.gz, pkg/compression/fixtures/Hello.bz2, pkg/compression/fixtures/Hello.xz and pkg/compression/fixtures/Hello.zst are read by pkg/compression/compression_test.go:17-20; copy/fixtures/Hello.zst by copy/single_test.go:138; copy/fixtures/Hello.std by no test; docker/archive/fixtures/almostempty.tar by docker/archive/transport_test.go:19. They are testdata shipped by DH_GOLANG_INSTALL_EXTRA and need no generator.
  • All unknown binary files are test vectors for the test suite, not compiled objects: internal/manifest/testdata/non-json.manifest.json (internal/manifest/manifest_test.go:33 and manifest/manifest_test.go:31); signature/fixtures/corrupt.signature and signature/fixtures/corrupt.signature-v3 (malformed armored signatures); signature/fixtures/expired.signature, signature/fixtures/image.signature, signature/fixtures/invalid-blob.signature, signature/fixtures/invalid-blob.signature-v3, signature/fixtures/invalid-reference.signature, signature/fixtures/no-optional-fields.signature, signature/fixtures/subkey.signature, signature/fixtures/subkey.signature-v3, signature/fixtures/subkey-revoked.signature, signature/fixtures/subkey-revoked.signature-v3, signature/fixtures/unknown-key.signature, signature/fixtures/unknown-key.signature-v3, signature/fixtures/unknown-cosign-key.signature, signature/fixtures/unsigned-encrypted.signature and signature/fixtures/unsigned-literal.signature (signature verification cases); the GnuPG material signature/fixtures/public-key-1.gpg, signature/fixtures/public-key-2.gpg, signature/fixtures/pubring.gpg, signature/fixtures/secring.gpg and signature/fixtures/trustdb.gpg (signature/mechanism_test.go:174, signature/policy_eval_signedby_test.go:68-116); the cosign directory fixtures signature/fixtures/dir-img-cosign-fulcio-rekor-valid/signature-1, signature/fixtures/dir-img-cosign-key-rekor-valid/signature-1, signature/fixtures/dir-img-cosign-other-attachment/signature-1, signature/fixtures/dir-img-cosign-pki-valid/signature-1, signature/fixtures/dir-img-cosign-valid/signature-1, signature/fixtures/dir-img-cosign-valid-2/signature-2, signature/fixtures/dir-img-cosign-valid-with-tag/signature-1, signature/fixtures/dir-img-valid/signature-1 and signature/fixtures/dir-img-valid-2/signature-2; and the simplesequoia keystore signature/simplesequoia/testdata/data/keystore/softkeys/1F5825285B785E1DB13BF36D2D11A19ABA41C6AE.pgp, signature/simplesequoia/testdata/data/keystore/softkeys/50DDE898DF4E48755C8C2B7AF6F908B6FA48A229.pgp, signature/simplesequoia/testdata/data/pgp.cert.d/1f/5825285b785e1db13bf36d2d11a19aba41c6ae, signature/simplesequoia/testdata/data/pgp.cert.d/4d/8bcd544b7573eefaad18c278473e5f255d10b8, signature/simplesequoia/testdata/data/pgp.cert.d/50/dde898df4e48755c8c2b7af6f908b6fa48a229, signature/simplesequoia/testdata/data/pgp.cert.d/68/de230c4a009f5ee5fbb27984642d0130b86046 and signature/simplesequoia/testdata/data/pgp.cert.d/trust-root (read by the simplesequoia signer tests). Test data under Apache-2.0, no generator needed.
  • Checked the debian/clean behaviour against debhelper 14.5: Dh_Lib::filedoublearray (Dh_Lib.pm:1826) skips # lines and globs entries, dh_clean rm -f's them; only signature/fixtures/.gitignore matches */*/.gitignore, the other two .gitignore files are three levels deep and remain installed.
  • Checked that DH_GOLANG_EXCLUDES="pkg/docker" is set only on the dh_auto_test invocation (debian/rules:20-22), so pkg/docker/config is still built and installed; docker/docker_client.go:32 imports go.podman.io/image/v5/pkg/docker/config, so that matters. At compat 14 dh skips override_dh_auto_test under nocheck (debhelper tool, dh_auto_test), so there is no <!nocheck> problem.
  • Standards-Version 4.7.4 against Policy 4.7.4.1: current. Patch headers are DEP-3 with Forwarded fields; 0004 is Debian-specific and justified.
  • Every Build-Depends name checked exists in the archive at a satisfying version (gowebpki/jcs 1.0.1-3, containers-storage 1.64.0-1, moby-sys 0.0~git20260904, rekor 1.5.3-2, sigstore 1.10.9-2, jsonschema 6.0.2-4, securesystemslib 0.11.1-1, docker.io 28.5.2, dh-golang 1.67). No Build-Depends exists nowhere.
  • The scan's holder check (611 files, all holders named) agrees with my own sweep; .pc/ and debian/cargo-checksum.json (absent) were excluded.
  • uscan found upstream releases with debian/watch; a newer upstream version is available (upstream 5.42.1, packaged 5.39.4), which is not a fault of the package.
  • Every pointer of debian/copyright to /usr/share/common-licenses names a file that is there (Apache-2.0).
Not confirmed ◂
  • I did not compute the full Depends closure of golang-github-containers-image-v5-dev; x/term, x/oauth2, the hashicorp modules and klauspost/compress are covered by other declared dependencies, but I found no package in the closure that pulls golang-gopkg-yaml.v3-dev, so the docker and openshift packages may be uncompilable from the -dev package alone.
  • I did not build or run the tests; whether the build-tag comment without a blank line in signature/simple_test.go and signature/simplesigning/signer_test.go (patch 0002) is accepted silently by Go was not checked against a Go installation.
  • Whether this is a fault: Patch 0004 changes go.mod but leaves go.sum without the gowebpki/jcs checksums. The model reported it as a minor packaging issue from its own knowledge of something outside the package, which it did not check with a tool, so it is not counted among the issues. Files: debian/patches/0004-use-gowebpki-jcs.patch, go.mod:19, go.sum:46-47.
    Evidence: The patch replaces github.com/cyberphone/json-canonicalization with github.com/gowebpki/jcs v1.0.1 in go.mod; go.sum still contains only the two github.com/cyberphone/json-canonicalization v0.0.0-20241213102144-19d51d7fe467 lines and no gowebpki/jcs line.
    Problem: The patched module metadata is internally inconsistent: a module-aware build of the tree stops because go.sum has no entry for gowebpki/jcs, which defeats the patch's stated purpose (needed to support module-aware builds). Debian's own build is unaffected because dh-golang builds with GO111MODULE=off.
    Fix: Add the go.sum hashes for github.com/gowebpki/jcs v1.0.1 in the patch and drop the cyberphone lines, or remove the module-mode claim.
  • debian/watch looks at github.com/containers/container-libs, but Repository in debian/upstream/metadata names github.com/containers/image. Whether these are the same upstream was not checked.
Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader was emailed about the review 1 day ago.

Back to Dashboard | View all reviews for this package