Review: golang-github-foxcpp-go-mockdns 1.2.0-1

Package Information

Description	mock DNS server and resolver for Go tests Boilerplate for testing code that performs DNS lookups. Provides a mock resolver and helpers to redirect net.Lookup* calls during tests.
Maintainer	Debian Go Packaging Team <team+pkg-go@tracker.debian.org>
Changed By	Hermes Rodríguez <hrodrig@usb.ve>
Sponsor	maytham@debian.org
Distribution	unstable
Architecture	all
VCS	git: https://salsa.debian.org/go-team/packages/golang-github-foxcpp-go-mockdns.git (browse)
Closes	#1148104
Blocked Bugs	#910799 (wishlist)
Tracker	https://tracker.debian.org/pkg/golang-github-foxcpp-go-mockdns
Uploaded	2 hours ago

New Package Report

.changes◂

Architecture	source all
Distribution	unstable
Date	Thu, 12 Nov 2026 15:27:30 +0800
Source	golang-github-foxcpp-go-mockdns
Version	1.2.0-1
Changed-By	Hermes Rodríguez <hrodrig@usb.ve>

Changelog◂

golang-github-foxcpp-go-mockdns (1.2.0-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1148104)
   * Skip flaky TestServer_FollowCNAMEs (CNAME assertion race).
 .
   [ Damian Szuberski ]
   * Bump Standards-Version to 4.7.4
   * Remove Priority: optional
   * Update debhelper version to 14
   * Migrate debian/watch to format version 5 using the GitHub template
   * Remove --builddirectory from debian/rules

.dsc◂

Section	golang
Priority	optional
Component	main
Package-List	golang-github-foxcpp-go-mockdns-dev deb golang optional arch=all

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: go-mockdns
Upstream-Contact: Max Mazurov <fox.cpp@disroot.org>
Source: https://github.com/foxcpp/go-mockdns

Files: *
Copyright: 2019 Max Mazurov <fox.cpp@disroot.org>
License: Expat

Files: debian/*
Copyright: 2026 Hermes Rodríguez <hrodrig@usb.ve>
License: Expat

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 1 hour ago.

Report◂

DFSG NEW review for golang-github-foxcpp-go-mockdns version 1.2.0-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: Yes
Issues: 0 blocker, 0 important, 0 minor
debian/watch: version 5
debian/copyright: machine-readable
Scan before the review: nothing found

Licensing

The whole tree is MIT/Expat under a single holder, and debian/copyright is DEP-5, matches the files, and reproduces the licence text verbatim. The only copyright notice in the tree is LICENSE (Copyright © 2019 Max Mazurov <fox.cpp@disroot.org>); the Go sources carry no notices and no third-party code, so the Files: * stanza is accurate, and Files: debian/* covers the packaging files. Nothing in the package is non-free, and no file lacks a licence.

Packaging

Small, ordinary team-maintained Go library using the standard dh-golang packaging: source format 3.0 (quilt) with no patches, compat 14 with dh-sequence-golang, dpkg-build-api 1, correct Build-Depends on golang-any and the one imported library, arch:all -dev package with the right Depends, Testsuite: autopkgtest-pkg-go, complete upstream metadata and current Standards-Version. The one test that does not pass deterministically is skipped in debian/rules with an explanatory comment, which is a reasonable workaround. No policy violations or bugs worth reporting.

Issues

None.

Verified ◂

Read every file in the tree: all 15 upstream files (LICENSE, README.md, go.mod, go.sum, .gitignore, and the nine .go files) and every file under debian/; the tree matches golang-github-foxcpp-go-mockdns_1.2.0.orig.tar.gz and the .debian.tar.xz exactly (no extra or missing files, no debian/patches, no debian/tests, no binaries).
LICENSE is MIT (Expat) with Copyright © 2019 Max Mazurov <fox.cpp@disroot.org>; debian/copyright Files: * names the same holder and reproduces the same Expat text, so no licence text is missing (DEP-5, common-licenses not needed).
A grep for Copyright, (C), ©, SPDX-License-Identifier, Permission is hereby granted, GNU/Apache/MPL wording and All rights reserved over the whole tree (including hidden files, gitignore: false) matched only LICENSE and debian/copyright; a grep for non-commercial/no-modification/field-of-use wording matched nothing.
The .go files contain no copyright headers, no Code generated/go:generate markers and no embedded third-party code; the only external import is github.com/miekg/dns (stdlib otherwise), and go.sum holds hashes only, so nothing raises an attribution or embedded-copy question beyond the Files: * stanza.
beian/copyright is machine-readable DEP-5 with a correct Format: URL, Upstream-Name, Upstream-Contact, Source, two Files stanzas (upstream, then debian/* overriding it) and a stand-alone Expat paragraph; no Files-Excluded needed. The prescan's author check (14 files scanned) found no unnamed holder.
The prescan listed no built files, minified code, PDFs or other files to account for; there are none in the tree either (the only non-source files are go.mod, go.sum and an 11-byte .gitignore containing coverage.*).
debian/control: debhelper-compat (= 14), dh-sequence-golang, dpkg-build-api (= 1), golang-any, golang-github-miekg-dns-dev — the last exists in the archive as 1.1.73-1 (>= the go.mod requirement of 1.1.57) and is Multi-Arch: foreign; golang-any is 2:1.27~1. Binary is arch:all with Multi-Arch: foreign, Depends: golang-github-miekg-dns-dev, ${misc:Depends} (naming substvars is harmless at compat 14), Standards-Version 4.7.4 against Policy 4.7.4.1, and a correct Description.
debian/rules: dh $@ --buildsystem=golang plus override_dh_auto_test: dh_auto_test -- -skip=TestServer_FollowCNAMEs. The -- parameters reach the build system (dh_auto_test(1) and sub test in /usr/share/perl5/Debian/Debhelper/Buildsystem/golang.pm), which runs go test -vet=off -v -p N -skip=... targets; -skip exists in the golang-any 2:1.27~1 toolchain, so the skip works and dh-golang's GOPATH mode (GO111MODULE=off) needs no module dependencies such as golang.org/x/tools. At compat 14 dh itself skips this override under nocheck, so no such check is needed in the rules file.
Changelog: 1.2.0-1, unstable, urgency=medium, date Thu, 12 Nov 2026 is a valid Thursday, upstream version matches the tarball, Closes: #1148104; debian/source/format is 3.0 (quilt); debian/upstream/metadata, debian/gbp.conf (dist = DEP14, accepted by gbp) and the salsa-ci/gitlab-ci pair are complete and consistent.
uscan found upstream releases with debian/watch; a newer upstream version is available (upstream 1.3.0, packaged 1.2.0), which is not a fault of the package.

Not confirmed ◂

The excluded test TestServer_FollowCNAMEs is skipped only in override_dh_auto_test; if the Testsuite: autopkgtest-pkg-go runner invokes go test on the installed source without the -skip argument, that flaky test would still run in autopkgtest. The runner is not installed on the reviewing system (no /usr/share/autopkgtest), so this could not be checked; any such test failure would be at most minor and is not a licensing or packaging fault.
Whether bug #1148104 is indeed the ITP for this source package could not be checked (no network access to the BTS).

Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader was emailed about the review 1 hour ago.

Review Information

accepted — allocated to mechtilde 1 hour ago, started 1 hour ago, completed 1 hour ago.

Final Comment

Back to Dashboard | View all reviews for this package