Review: golang-github-go-gorp-gorp 3.1.0-1
Package Information
| Description | Go Relational Persistence, an ORM-ish library for Go Given some Go structs and a database, gorp should remove a fair amount of boilerplate busy-work from your code. It binds struct fields to table columns and supports embedded structs. |
|---|---|
| Maintainer | Debian Go Packaging Team <team+pkg-go@tracker.debian.org> |
| Changed By | Juan Manuel Méndez Rey <juan.mendezr@proton.me> |
| Sponsor | tsimonq2@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/go-team/packages/golang-github-go-gorp-gorp.git (browse) |
| Closes | #1152907 |
| Tracker | https://tracker.debian.org/pkg/golang-github-go-gorp-gorp |
| Uploaded | 2 days ago |
New Package Report
.changes
| Source | golang-github-go-gorp-gorp |
|---|---|
| Version | 3.1.0-1 |
| Changed-By | Juan Manuel Méndez Rey <juan.mendezr@proton.me> |
| Architecture | source all |
| Distribution | unstable |
| Date | Fri, 30 Oct 2026 16:30:36 +0100 |
Changelog
golang-github-go-gorp-gorp (3.1.0-1) unstable; urgency=medium . * Initial release (Closes: #1152907)
.dsc
| Section | golang |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | golang-github-go-gorp-gorp-v3-dev deb golang optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Source: https://github.com/go-gorp/gorp Upstream-Name: gorp Upstream-Contact: https://github.com/go-gorp/gorp/issues Files: * Copyright: 2012 James Cooper <james@bitmechanic.com> License: Expat Files: debian/* Copyright: 2026 Juan Manuel Méndez Rey <juan.mendezr@proton.me> License: Expat Comment: Debian packaging is licensed under the same terms as upstream License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the 'Software'), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 1 day ago.
Report
DFSG NEW review for golang-github-go-gorp-gorp version 3.1.0-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
debian/copyright is DEP-5 and covers the whole tree: Files: * holds Copyright: 2012 James Cooper <james@bitmechanic.com> under License: Expat, and a later Files: debian/* stanza holds Juan Manuel Méndez Rey for the packaging. Every one of the .go files (including the four integration-tagged test files) begins with // Copyright 2012 James Cooper. All rights reserved. and an MIT-style notice pointing at LICENSE, whose text is the Expat licence reproduced in full in debian/copyright. No other holder, no other licence wording, no vendored third-party code, no binary or generated files, and the orig tarball is pristine, so nothing is missing from the inventory or needs Files-Excluded.
Packaging
Recognisably the Debian Go team's current template: debhelper compat 14, the team's module-aware dh-go add-on with --with=golang, dpkg-build-api (= 1), Testsuite: autopkgtest-pkg-go, Standards-Version 4.7.4 (current against Policy 4.7.4.1), correct Vcs-* and XS-Go-Import-Path: github.com/go-gorp/gorp/v3 for the /v3 module, and a single arch:all -dev package. Every Build-Depends resolves in the archive (dh-go 1.69, golang-any, and the four golang-*-dev packages) and the <!nocheck> set matches exactly the imports of the files compiled by the integration-tagged test run. No patches, a plain initial-release changelog, and tests are actually run (sqlite dialect). The only loose end is the non-default build directory, which I could not confirm interacts correctly with the Go autopkgtest runner.
Issues
None.
Verified ◂
- Prescan: it lists no files (
Result: every holder found is named in debian/copyright). I still grepped the whole tree withgitignore: falsefor Copyright, (c), ©, SPDX-License-Identifier, "licensed under", "permission is hereby granted", GNU/Apache/Mozilla/public domain/"All rights reserved"/non-commercial: the only notices anywhere are the per-file.goheaders, LICENSE, and debian/copyright. - Inventory covered: all 36 upstream files reported by the scan plus
.github/workflows/go.yml(listing from glob withgitignore: false, and from the orig tarball). Contents are .go, .md, go.mod/go.sum, LICENSE, .gitignore, .travis.yml, test_all.sh and one YAML workflow: no binaries, images, fonts, minified code, PDFs or generated sources, and novendor/directory..pc/was left out as instructed; there is nodebian/cargo-checksum.json. - Licence mapping:
Files: *is the catch-all and matches dotfiles and any depth, so.github/workflows/go.yml,.travis.yml,test_all.sh,go.sumand the rest are covered;Files: debian/*comes later and so overrides it for the packaging.Expatis the right short name for the MIT text, the paragraph quoted in debian/copyright is the complete LICENSE text, and both stanzas' copyright years (2012 upstream, 2026 Debian packaging, matching the changelog date) match the notices. - The orig tarball is the unmodified upstream tree (no +ds revision, every upstream path present), so no
Files-Excludedor repacking note belongs in debian/copyright. debian/watch was not reviewed. - Reference-tool checks: Policy on this system is 4.7.4.1, so Standards-Version 4.7.4 is current (first two components match); debhelper 14.5 is installed and compat 14 is the recommended level;
dpkg-build-apiis a virtual package provided as version 1 by dpkg-dev 1.23.11, and dpkg-build-api(7) saysdpkg-buildpackagethen defaultsRules-Requires-Roottono, so its absence from debian/control is correct (dh-golang's own example dropped the field in 1.66 for the same reason). - apt-cache confirmed
dh-go1.69 (a debhelper sequence addon named golang,Conflicts: dh-golang, nodh-sequence-golangProvides, hence--with=golangis needed and present),golang-any,golang-github-go-sql-driver-mysql-dev1.10.1,golang-github-lib-pq-dev1.10.9,golang-github-mattn-go-sqlite3-dev1.14.52,golang-github-stretchr-testify-dev1.11.1;golang-github-go-gorp-gorp-v3-devis this upload's own binary, and nogolang-github-go-gorp-gorp-devexists in the archive or NEW, so the initial release is not a takeover. - Test dependency set checked against the code: with
-tags integrationthe compiled files are gorp_test.go, db_test.go, transaction_test.go and context_test.go; their third-party imports are testify/assert plus the blank imports of the mysql, pq and sqlite3 drivers, all four present as <!nocheck> Build-Depends.debian/rulesremoves dialect_{mysql,postgres,snowflake}_test.go from the build tree; those are//go:build !integrationand import onpar (Debian has 0.3.3, upstream wants v1.1.2), and because the test run passes-tags integrationthey are never compiled — the removal only keeps the decompilable-onpar tests out of the installed source, so it is not a build issue (no onpar Build-Depends is needed). Uploaders: Juan Manuel Méndez Rey <...>,andDepends: ${misc:Depends},end in a comma: dpkg's dependency parser splits on commas and drops the trailing empty item (the generated .dsc already showsUploaderswithout it), and an emptied Depends field is dropped by dpkg-gencontrol, so this is cosmetic only. The arch:all package'sMulti-Arch: foreignmatches current Go team practice (same field on testify, lib/pq and the mysql driver)..travis.ymlcarries an encrypted CI variable (secure: ...); it is not licence material and raises no DFSG question.- uscan found the packaged version as the newest upstream release (upstream
3.1.0, packaged3.1.0).
Not confirmed ◂
- Autopkgtest and the non-default build directory:
debian/rulespasses--builddirectory=debian/_build, whereas the Go autopkgtest runner installed here (/usr/bin/dh_golang_autopkgtest from dh-golang 1.67) computes its APT_BDIR from the golang buildsystem with no options, i.e. the compat-14 default_build(Buildsystem/golang.pmDEFAULT_BUILD_DIRECTORY+prefer_out_of_source_building), and injects anoverride_dh_auto_configurethat populates only that directory before runningdebian/rules build. That build then usesdebian/_build, which the override never creates, sodh_auto_buildwould fail inget_targets()(opendirofdebian/_build/src/github.com/go-gorp/gorp/v3/...) or indoit_in_builddir's chdir. I could not confirm this against the runner actually used by the archive: the testbed would install dh-go 1.69 (the package's Build-Depends; it declaresCommands: dh_golang_autopkgtest), which is not installed here, so its version of the helper may handle a custom build directory. An autopkgtest run would settle it; if it fails as described, the fix is to use the documented--builddirectory=_build(or rely on the compat-14 default_build) so that rules and the runner agree, adjusting theGORP_TEST_DSNpath to match.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader was emailed about the review 1 day ago.
Review Information
accepted — allocated to awm 1 day ago, started 1 day ago, completed 1 day ago.