Review: golang-github-intevation-gval 1.3.0+ds-1
Package Information
| Description | expression evaluation library for Go (library) Gval (Go eVALuate) evaluates arbitrary expressions, in particular Go-like ones, with parameters and arithmetic, logical and string operations. Parameters can be maps, slices or structs, whose fields and methods are reachable through dot and bracket selectors. Every constant, function and operator can be defined separately, so existing expression languages can be combined and extended with custom functions and operators. Expressions can be parsed once and evaluated many times. This is Intevation's fork of github.com/PaesslerAG/gval, published under its own module path. |
|---|---|
| Maintainer | Debian Go Packaging Team <team+pkg-go@tracker.debian.org> |
| Changed By | Juan Manuel Méndez Rey <juan.mendezr@proton.me> |
| Sponsor | tsimonq2@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/go-team/packages/golang-github-intevation-gval.git (browse) |
| Closes | #1148986 |
| Tracker | https://tracker.debian.org/pkg/golang-github-intevation-gval |
| Uploaded | 7 hours ago |
New Package Report
.changes
| Version | 1.3.0+ds-1 |
|---|---|
| Changed-By | Juan Manuel Méndez Rey <juan.mendezr@proton.me> |
| Architecture | source all |
| Distribution | unstable |
| Date | Fri, 25 Sep 2026 23:45:00 +0200 |
| Source | golang-github-intevation-gval |
Changelog
golang-github-intevation-gval (1.3.0+ds-1) unstable; urgency=medium . * Initial release (Closes: #1148986)
.dsc
| Package-List | golang-github-intevation-gval-dev deb golang optional arch=all |
|---|---|
| Section | golang |
| Priority | optional |
| Component | main |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: gval Upstream-Contact: Sascha L. Teichmann <sascha.teichmann@intevation.de> Source: https://github.com/Intevation/gval Files-Excluded: prtg-batmin-gopher.png Comment: The excluded image is a gopher mascot shown only in README.md. It is derived from Renée French's Go gopher and carries no licence statement of its own; nothing in the build uses it. Files: * Copyright: 2017 Paessler AG <support@paessler.com> License: BSD-3-clause Comment: The holder and year are those of LICENSE, the only copyright notice in the tree; this repository is Intevation's fork of PaesslerAG/gval. The fork's own changes (2023) add no copyright notice. Files: debian/* Copyright: 2026 Juan Manuel Méndez Rey <juan.mendezr@proton.me> License: BSD-3-clause Comment: Debian packaging is licensed under the same terms as upstream License: BSD-3-clause Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: . 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. . 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. . 3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. . THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 4 hours ago.
Report
DFSG NEW review for golang-github-intevation-gval version 1.3.0+ds-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
The tree is a small Go library whose only licence notice is LICENSE: BSD-3-clause, copyright 2017 Paessler AG. debian/copyright is DEP-5, its Files: * stanza carries that holder and licence, debian/* is claimed by the packager under the same terms, and the full BSD-3-clause text is reproduced (BSD-3-clause is not in /usr/share/common-licenses, so it must be). The one upstream file with unclear provenance, the Renée French-derived gopher image prtg-batmin-gopher.png, is excluded by Files-Excluded and is absent from the tree and from the .orig.tar.xz. No other holder, licence or non-free term is present anywhere in the source.
Packaging
Packaging is idiomatic and clean: debhelper compat 14, dh-go with the golang buildsystem, source format 3.0 (quilt) with one DEP-3 patch forwarded upstream, an autopkgtest-pkg-go testsuite, Vcs-* and upstream metadata, and a salsa-ci template. Every build-dependency resolves in the archive (dh-go 1.69, dpkg-build-api (= 1) provided by dpkg-dev 1.23.11, golang-any, golang-github-shopspring-decimal-dev 1.3.1-1). Standards-Version 4.7.4 matches the current Policy 4.7.4.1 in its first two components. The one lintian override is explained by dh-go's renaming the golang addon away from dh-golang.
Issues
None.
Verified
- Read the whole of debian/ (changelog, control, copyright, gbp.conf, rules, salsa-ci.yml, watch, patches/0001-test-fix-int-overflow-on-32-bit.patch, patches/series, source/format, source/lintian-overrides, upstream/metadata) and every file of the upstream tree (26 files: Go sources and tests, README.md, LICENSE, go.mod, go.sum, .travis.yml, .gitignore).
- debian/copyright is machine-readable (Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/), with two Files stanzas and one stand-alone BSD-3-clause License stanza; Comment: is a permitted Files-stanza field (copyright-format 5.2) and the Files patterns cover the whole tree (Files: * for everything, debian/* overriding for packaging).
- The only copyright notice in the tree is LICENSE:
Copyright (c) 2017, Paessler AG <support@paessler.com>, BSD-3-clause; Files: * names exactly that holder and licence, and the License paragraph reproduces the three-clause text verbatim, including clause 3 and the disclaimer. - The pre-review scan's author check found every holder named in debian/copyright; the only other names in the tree are Upstream-Contact Sascha L. Teichmann (debian/copyright), README.md's credit line
Credits to Reene French for the gophers, and the packager's own address, none of which is a licence notice. - The fork's later changes carry no copyright notice of their own, as the Files: * Comment states; no file notice names any holder other than Paessler AG, so nothing further is attributable from the package itself.
- prtg-batmin-gopher.png (named in Files-Excluded) is not present anywhere in the unpacked tree nor in golang-github-intevation-gval_1.3.0+ds.orig.tar.xz; README.md references it in an image link only and is itself covered by Files: *.
- All 26 upstream files are hand-written Go source, Markdown, the licence, Go module files, a Travis config and a .gitignore: no compiled objects, archives, bytecode, minified code, fonts, images or generated code, and no vendored third-party source; the only third-party import is github.com/shopspring/decimal, which Debian ships as golang-github-shopspring-decimal-dev 1.3.1-1, matching go.mod's v1.3.1.
- debian/patches/0001-test-fix-int-overflow-on-32-bit.patch has full DEP-3 headers (Description, Author, Forwarded to an upstream PR, Last-Update) and fixes an untyped int constant that overflows on 32-bit; it is the only patch and is listed in patches/series.
- debian/control build-dependencies checked with apt-cache: dh-go (1.69) provides the golang addon and conflicts with dh-golang, dpkg-build-api (= 1) is provided by dpkg-dev 1.23.11, golang-any and golang-github-shopspring-decimal-dev exist; the Depends of the -dev package on golang-github-shopspring-decimal-dev matches the library's public use of that package.
- Standards-Version 4.7.4 against the reviewing system's Policy 4.7.4.1: first two components 4.7 match, so it is current; debhelper compat is 14 (recommended), with debian/copyright present, no debian/compat file, and dh used throughout debian/rules.
- debian/source/lintian-overrides justifies the one override: the golang dh addon now comes from dh-go, which no longer Provides dh-sequence-golang, so lintian's dh-addon table still pointing at dh-golang is a false positive.
- uscan found the packaged version as the newest upstream release (upstream
1.3.0, packaged1.3.0+ds).
Not confirmed
- The .pc/ quilt directory was ignored as instructed; nothing else in debian/ or the upstream tree was left unread.
- I did not run the build or the test suite, and did not build the package; no build or test failure is asserted.
Proposed changes
None.
Uploader's response to the LLM review
The uploader was emailed about the review 4 hours ago.
Review Information
accepted — allocated to awm 3 hours ago, started 3 hours ago, completed 3 hours ago.