golang-github-masahiro331-go-disk 0.1.2+git20260423.f7a470e-1

Package Information

Description	simple disk parser, supported Master Boot Record and GUID Partition Table This Go library reads the partition table of a disk image: a Master Boot Record, a GUID Partition Table, or a disk that holds a filesystem with no table. It returns each partition as an io.SectionReader with its name, size and bootable flag, ready for a filesystem parser.
Maintainer	Debian Go Packaging Team <team+pkg-go@tracker.debian.org>
Changed By	Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Sponsor	tsimonq2@debian.org
Distribution	unstable
Architecture	all
VCS	git: https://salsa.debian.org/go-team/packages/golang-github-masahiro331-go-disk.git (browse)
Closes	#1152501
Tracker	https://tracker.debian.org/pkg/golang-github-masahiro331-go-disk
Uploaded	3 hours ago

New Package Report

.changes◂

Distribution	unstable
Date	Fri, 30 Oct 2026 03:47:57 +0100
Source	golang-github-masahiro331-go-disk
Version	0.1.2+git20260423.f7a470e-1
Changed-By	Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Architecture	source all

Changelog◂

golang-github-masahiro331-go-disk (0.1.2+git20260423.f7a470e-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1152501)

.dsc◂

Section	golang
Priority	optional
Component	main
Package-List	golang-github-masahiro331-go-disk-dev deb golang optional arch=all

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/masahiro331/go-disk
Upstream-Name: go-disk
Upstream-Contact: https://github.com/masahiro331/go-disk/issues

Files: *
Copyright: 2022 Masahiro Fujimura (masahiro331) <m_fujimura@r.recruit.co.jp>
           2024-2026 yusuke-koyoshi
           2026 Bryce Boe <bbzbryce@gmail.com>
           2026 Lukas Hoehl <lukas.hoehl.316@gmail.com>
License: Expat
Comment: LICENSE names "2022 Masahiro331"; the other holders are the authors of
 later commits. testdata/fs.bin is an empty XFS image and
 mbr/testdata/mbr.bin a partition table on an empty disk.

Files: debian/*
Copyright: 2026 Juan Manuel Méndez Rey <juan.mendezr@proton.me>
License: Expat
Comment: Debian packaging is licensed under the same terms as upstream

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 1 hour ago.

Report◂

DFSG NEW review for golang-github-masahiro331-go-disk version 0.1.2+git20260423.f7a470e-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: Yes
Issues: 0 blocker, 0 important, 0 minor
debian/watch: version 5
debian/copyright: machine-readable
Scan before the review: 2 found

Licensing

LICENSE is the only file in the tree that carries a licence, and it is MIT/Expat (MIT License, Copyright (c) 2022 Masahiro331); every other file has no notice of its own, so debian/copyright's single Files: * stanza with License: Expat and the later Files: debian/* stanza correctly describe the tree, with the full Expat text in the stand-alone paragraph. The holder the prescan reports as unnamed, Masahiro331 (LICENSE:3), is named in that stanza as 2022 Masahiro Fujimura (masahiro331). Both scan-listed binaries are disk-image test data used by the tests, not built programs: testdata/fs.bin is the XFS image disk_test.go checks with xfs.Check, and mbr/testdata/mbr.bin is a zero-padded image whose MBR mbr_test.go parses. There are no non-free terms, no files without a licence, no vendored third-party code (the only dependencies are declared in go.mod and packaged separately) and no images, fonts or data of unclear provenance.

Packaging

The packaging is small and conventional: compat 14 with dpkg-build-api (= 1), dh-go's golang buildsystem, cmd/ excluded from both build and install, a single -dev package with Multi-Arch: foreign, complete and correct dependencies, Testsuite: autopkgtest-pkg-go (which runs dh_golang_autopkgtest against the installed sources, so the installed testdata and the xfs dependency are needed), Standards-Version 4.7.4 against Policy 4.7.4.1, a correct changelog, Vcs-* and upstream metadata. The only unverified point is that golang-github-masahiro331-go-xfs-filesystem-dev, which both Build-Depends and Depends name, is not yet in the archive or the NEW queue, so it must land together with this package.

Issues

None.

Verified ◂

Read all of debian/ (changelog, control, copyright, gbp.conf, rules, salsa-ci.yml, source/format, upstream/metadata) and all 15 upstream text files; both scan-listed binaries are covered below.
Licensing: a case-insensitive grep of the whole tree for copyright/licence/MIT/BSD/GPL/Apache/warranty finds them only in LICENSE (MIT/Expat, Copyright (c) 2022 Masahiro331) and debian/copyright, so the Files: * + Files: debian/* stanzas cover every file with the right holder and licence.
The prescan holder Masahiro331 (LICENSE:3) is the same person debian/copyright names as 2022 Masahiro Fujimura (masahiro331) <m_fujimura@r.recruit.co.jp>; the stanza also covers LICENSE itself, so no holder is missing.
testdata/fs.bin (40 MB): XFS filesystem image opened by disk_test.go (inputFile: "testdata/fs.bin", with xfs.Check expected to succeed), generated by upstream's Makefile target fs.bin (mkfs.xfs on a 40 MB image, partition extracted with cmd/main.go); it is an essentially zero-filled image (all sources plus both 56 MB of images fit in the 20,616-byte orig tarball), so it holds no third-party content. Test data, not a built program, so there is no missing source file.
mbr/testdata/mbr.bin (16 MB): raw disk image whose first sector mbr_test.go parses (partition types 0xAB/0xAF, the Apple types its table expects); its provenance is upstream's Makefile target mbr.bin (dd of a 32768-sector image, then fdisk) and the test comment // built by "make mbr.bin" from m1 mac. Zero-padded test data with no copyrightable content or licence notice, so no licensing issue.
Build dependencies are satisfiable: debhelper 14.5 provides debhelper-compat (= 14), dpkg-dev 1.23.11 provides dpkg-build-api (= 1), dh-go 1.69 provides both the golang sequence addon (--with=golang) and the golang buildsystem, and golang-golang-x-xerrors-dev (0.0~git20240903.7835f81-1) exists.
DH_GOLANG_EXCLUDES := cmd in debian/rules does what its comment says: dh-go's get_targets filters github.com/masahiro331/go-disk/cmd out of the build targets, and since DH_GOLANG_EXCLUDES_ALL defaults to true from compat 12 the install step also skips cmd/, so the example program is neither built nor shipped.
Testsuite: autopkgtest-pkg-go is functional: /usr/bin/dh_golang_autopkgtest (shipped by dh-go) copies the installed /usr/share/gocode/src tree into the build directory and runs debian/rules build, i.e. go test on the installed sources; this is why the -dev package needs and gets both testdata images (dh-go installs testdata/ by default) and its Depends on the xfs package (imported by disk_test.go).
Standards-Version 4.7.4 matches the reviewing system's Policy 4.7.4.1; the changelog (unstable, 0.1.2+git20260423.f7a470e-1, Closes: #1152501) matches the directory name, the .dsc and the Vcs-* fields; there are no maintainer scripts and no patches.
Shipped tarballs match: the orig tarball lists the same upstream files and no debian/ directory, and the debian tarball contains only debian/ (changelog, control, copyright, gbp.conf, rules, salsa-ci.yml, watch, source/, upstream/) with no patches/.
debian/gbp.conf's dist = DEP14 is valid, not a typo: gbp buildpackage accepts both DEP-14 and DEP14 (gbp/scripts/buildpackage.py:212), so it needs no change.
uscan found upstream releases with debian/watch; a newer upstream version is available (upstream 0.1.2+git20261019.1afeb92, packaged 0.1.2+git20260423.f7a470e), which is not a fault of the package.

Not confirmed ◂

golang-github-masahiro331-go-xfs-filesystem-dev, named in both debian/control's Build-Depends and the -dev package's Depends, is in neither the archive lists nor the NEW queue as of 2026-11-07T02:21Z; the build and installation need it, so it presumably is a companion upload, but its absence means I could not verify that it exists with a suitable version (the lists can also lag).
The three extra holders in Files: * (2024-2026 yusuke-koyoshi, 2026 Bryce Boe, 2026 Lukas Hoehl) appear in no file in the package; they can only come from upstream's git history, which is not shipped, so I could not verify them. Their absence of in-file notices is not itself a fault, since LICENSE covers the project as a whole.

Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader was emailed about the review 0 hours ago.

Back to Dashboard | View all reviews for this package