Review: golang-github-masahiro331-go-ebs-file 0.1.1+git20260422.9d24e29-1

Package Information

Description	Abstracting AWS Elastic block store with io.ReadSeeker (library) Abstracting AWS Elastic block store with io.ReadSeeker
Maintainer	Debian Go Packaging Team <team+pkg-go@tracker.debian.org>
Changed By	Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Sponsor	tsimonq2@debian.org
Distribution	unstable
Architecture	all
VCS	git: https://salsa.debian.org/go-team/packages/golang-github-masahiro331-go-ebs-file.git (browse)
Closes	#1152502
Tracker	https://tracker.debian.org/pkg/golang-github-masahiro331-go-ebs-file
Uploaded	2 days ago

New Package Report

.changes◂

Changed-By	Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Architecture	source all
Distribution	unstable
Date	Fri, 30 Oct 2026 05:04:28 +0100
Source	golang-github-masahiro331-go-ebs-file
Version	0.1.1+git20260422.9d24e29-1

Changelog◂

golang-github-masahiro331-go-ebs-file (0.1.1+git20260422.9d24e29-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1152502)

.dsc◂

Component	main
Package-List	golang-github-masahiro331-go-ebs-file-dev deb golang optional arch=all
Section	golang
Priority	optional

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/masahiro331/go-ebs-file
Upstream-Name: go-ebs-file
Upstream-Contact: https://github.com/masahiro331/go-ebs-file/issues

Files: *
Copyright: 2022-2023 Masahiro Fujimura (masahiro331) <m_fujimura@r.recruit.co.jp>
           2024 Nikita Pivkin <nikita.pivkin@smartforce.io>
           2026 yusuke-koyoshi
License: Expat
Comment: LICENSE names "2022 Masahiro331"; the other holders are the authors of
 later commits.

Files: debian/*
Copyright: 2026 Juan Manuel Méndez Rey <juan.mendezr@proton.me>
License: Expat
Comment: Debian packaging is licensed under the same terms as upstream

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 1 day ago.

Report◂

DFSG NEW review for golang-github-masahiro331-go-ebs-file version 0.1.1+git20260422.9d24e29-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: Yes
Issues: 0 blocker, 0 important, 0 minor
debian/watch: version 5
debian/copyright: machine-readable
Scan before the review: nothing found

Licensing

The whole upstream tree (9 files, no vendor/, no generated or binary files) is MIT/Expat, the only copyright notice being LICENSE ('Copyright (c) 2022 Masahiro331'), and the DFSG accepts it. debian/copyright is DEP-5 with the correct Format: URL; a Files: * stanza covers every upstream file and a later debian/* stanza the packaging, both under Expat, and the stand-alone Expat paragraph reproduces the same MIT text as LICENSE (copyright line omitted, as the format requires). The holders named in debian/copyright include the one in LICENSE (as 'Masahiro Fujimura (masahiro331)'), and no Files-Excluded or licence for excluded files is needed.

Packaging

Standard Debian Go Team packaging: debhelper compat 14 with dh-go's golang buildsystem and addon, the source installed as a Go library with the upstream demo main package excluded, Architecture: all/Multi-Arch: foreign, a Depends on the only Debian package providing the imported AWS SDK modules, Testsuite: autopkgtest-pkg-go, current Standards-Version: 4.7.4, correct Homepage/Vcs/XS-Go-Import-Path and a sane initial changelog entry. No patches, maintainer scripts or other packaging machinery is needed, and nothing found violates Policy or would break upgrade or user experience.

Issues

None.

Verified ◂

Prescan item LICENSE:3 ('Copyright (c) 2022 Masahiro331'): the holder is named in debian/copyright (Files: *, 2022-2023 Masahiro Fujimura (masahiro331) <m_fujimura@r.recruit.co.jp>), and the stanza's Comment: quotes the LICENSE line and explains the other two holders; no separate Files: LICENSE stanza is needed, so the author check's 'missing holder' is a false positive.
Read the complete upstream tree: .gitignore, LICENSE, README.md, cache.go, ebsfile.go, ebsfile_test.go, go.mod, go.sum, cmd/main.go. A grep for Copyright, (C), ©, SPDX-License-Identifier, Licensed under, Permission is hereby granted, GNU General Public, GNU Lesser, Apache License, Mozilla Public, public domain and All rights reserved (gitignore disabled) matched only LICENSE; no per-file notices exist and no other licence file is present.
debian/copyright is machine-readable DEP-5 with the exact Format: URL; the Files: * pattern matches every file at any depth (copyright-format 6.9) and the later debian/* stanza overrides it for the packaging; both use Expat, whose full text is given once as a stand-alone License paragraph and matches LICENSE.
No built, minified, generated or binary files; no vendor/ directory, no embedded copy of a library Debian already ships, no fonts, images or sound data. Prescan listed no built files.
Standards-Version: 4.7.4 against the reviewing system's Policy 4.7.4.1 — current enough (first two components match); dpkg-build-api (= 1) is the level documented in dpkg-build-api(7) and is provided by dpkg-dev 1.23.11.
Build-Depends all exist in unstable: dh-go 1.69 (provides the golang sequence addon, buildsystem and dh_golang/dh_golang_autopkgtest), debhelper 14.5 (provides debhelper-compat (= 14)), golang-any 2:1.27~1, and golang-github-aws-aws-sdk-go-v2-dev 1.41.7-2, the only aws-sdk-go-v2 binary in the archive.
debian/rules uses --buildsystem=golang --with=golang; dh-golang sets GO111MODULE=off and GOPROXY=off by default, so the build resolves imports from the installed /usr/share/gocode and go.mod's older requirements (aws-sdk-go-v2 1.25.0, config 1.26.3, service/ebs 1.22.1) are not fetched; --builddirectory=debian/_build is cleaned by the buildsystem's clean stage.
export DH_GOLANG_EXCLUDES := cmd keeps upstream's demo main package (placeholder credentials in cmd/main.go) out of both the build and the installed source, so the -dev package ships only the library source; that is the intended shape for a library-only package.
No debian/patches, maintainer scripts, *.maintscript or debian/tests/control; the Go test suite runs at build time through dh_auto_test, and Testsuite: autopkgtest-pkg-go uses the implicit Go test (/usr/bin/dh_golang_autopkgtest, which needs exactly the XS-Go-Import-Path the package has).
The trailing commas in Uploaders: and Build-Depends: are harmless: Perl's split drops trailing empty fields, so Dpkg::Deps::deps_parse never sees an empty relation (and the generated .dsc shows the fields normalised).
dist = DEP14 in debian/gbp.conf is valid: gbp-buildpackage treats both DEP-14 and DEP14 as the special 'derive from branch name' value (checked in /usr/lib/python3/dist-packages/gbp/scripts/buildpackage.py:212), and options under [DEFAULT] that a given command does not define are ignored when that command reads its configuration.
Binary package: Architecture: all with Multi-Arch: foreign, matching golang-github-aws-aws-sdk-go-v2-dev and the other Go library packages; Depends: golang-github-aws-aws-sdk-go-v2-dev covers the direct imports (aws, config, service/ebs, service/ebs/types), with smithy-go pulled in transitively; ${misc:Depends} is harmless at compat 14.
debian/upstream/metadata, debian/salsa-ci.yml, debian/source/format (3.0 quilt) and the changelog (version 0.1.1+git20260422.9d24e29-1, unstable, ITP closure, correct date) are sound; Homepage and both Vcs fields point at the right places.
uscan found upstream releases with debian/watch; a newer upstream version is available (upstream 0.1.1+git20261019.23e7724, packaged 0.1.1+git20260422.9d24e29), which is not a fault of the package.

Not confirmed ◂

I could not inspect the file list of golang-github-aws-aws-sdk-go-v2-dev to confirm that its config/ and service/ebs/ module directories are included; it is the archive's only aws-sdk-go-v2 binary (491984 KiB installed), so this is an inference, not a check.
I could not build or run the tests (read-only review); that the code compiles against the packaged AWS SDK 1.41.7 rather than the versions named in go.mod is assumed, and they are within the same major versions.
The 2024 (Nikita Pivkin) and 2026 (yusuke-koyoshi) holders are not evidenced by any notice in the tree; they are taken from upstream history, as the Comment: in debian/copyright states.

Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader was emailed about the review 1 day ago.

Review Information

accepted — allocated to awm 1 day ago, started 1 day ago, completed 1 day ago.

Final Comment

Back to Dashboard | View all reviews for this package