Review: golang-github-masahiro331-go-ext4-filesystem 0.1.3+git20260423.fe51f5b-1
Package Information
| Description | ext4 filesystem stream parser (library) go-ext4-filesystem is ext4 filesystem stream parser. This library implement io/fs interface. |
|---|---|
| Maintainer | Debian Go Packaging Team <team+pkg-go@tracker.debian.org> |
| Changed By | Juan Manuel Méndez Rey <juan.mendezr@proton.me> |
| Sponsor | tsimonq2@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/go-team/packages/golang-github-masahiro331-go-ext4-filesystem.git (browse) |
| Closes | #1152503 |
| Tracker | https://tracker.debian.org/pkg/golang-github-masahiro331-go-ext4-filesystem |
| Uploaded | 2 days ago |
New Package Report
.changes
| Version | 0.1.3+git20260423.fe51f5b-1 |
|---|---|
| Changed-By | Juan Manuel Méndez Rey <juan.mendezr@proton.me> |
| Architecture | source all |
| Distribution | unstable |
| Date | Fri, 30 Oct 2026 04:46:03 +0100 |
| Source | golang-github-masahiro331-go-ext4-filesystem |
Changelog
golang-github-masahiro331-go-ext4-filesystem (0.1.3+git20260423.fe51f5b-1) unstable; urgency=medium . * Initial release (Closes: #1152503)
.dsc
| Component | main |
|---|---|
| Package-List | golang-github-masahiro331-go-ext4-filesystem-dev deb golang optional arch=all |
| Section | golang |
| Priority | optional |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/masahiro331/go-ext4-filesystem
Upstream-Name: go-ext4-filesystem
Upstream-Contact: https://github.com/masahiro331/go-ext4-filesystem/issues
Files: *
Copyright: 2021-2023 Masahiro Fujimura (masahiro331) <m_fujimura@r.recruit.co.jp>
2023 Tomais Williamson <williamson.tomais@gmail.com>
2023 Pierre Guilleminot <pierre.guilleminot@datadoghq.com>
2023 Shachar Menashe
2024 Sebastian <sebastian@sebastians-site.de>
2024 Andras Elso <ea333@freemail.hu>
2024 Aruneko <aruneko99@gmail.com>
2026 yusuke-koyoshi
2026 tuxxi <aidan.sojourner@gmail.com>
License: Apache-2.0
Comment: Upstream has no copyright notice (LICENSE carries the unfilled
Apache-2.0 appendix and no file has a header). The holders are the authors
of the commits in the upstream history.
Files: debian/*
Copyright: 2026 Juan Manuel Méndez Rey <juan.mendezr@proton.me>
License: Apache-2.0
Comment: Debian packaging is licensed under the same terms as upstream
License: Apache-2.0
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
.
https://www.apache.org/licenses/LICENSE-2.0
.
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
Comment:
On Debian systems, the complete text of the Apache version 2.0 license
can be found in "/usr/share/common-licenses/Apache-2.0".
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 1 day ago.
Report
DFSG NEW review for golang-github-masahiro331-go-ext4-filesystem version 0.1.3+git20260423.fe51f5b-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
Every upstream file is Apache-2.0: LICENSE is the stock Apache-2.0 text and no source file carries a copyright or licence header of its own, so the single Files: * Apache-2.0 stanza plus the later Files: debian/* stanza covers all 27 files in the tree (18 upstream, 9 packaging). The file is valid DEP-5, uses the right short name, points to /usr/share/common-licenses/Apache-2.0 as Policy 12.5 recommends for Apache-2.0, and there is no DFSG problem: no non-free wording anywhere, no unlicensed file, no generated or binary-only file, no vendored third-party code. The only thing I could not check is the completeness of the nine named holders, which the file itself says come from the upstream commit history (no VCS metadata in the source).
Packaging
This is the Debian Go team template applied cleanly: debhelper compat 14 with dh-go (--buildsystem=golang --with=golang), a single Architecture: all Multi-Arch: foreign -dev package, Depends matching the non-test imports, Testsuite: autopkgtest-pkg-go, salsa-ci and gbp.conf, upstream/metadata, and Standards-Version 4.7.4 against Policy 4.7.4.1. Every build and runtime dependency exists in the archive and the helper files dh-go needs are installed on the reviewing system; there are no patches, no maintainer scripts, and nothing a sponsor would require changing.
Issues
None.
Verified ◂
- Prescan:
dfsg-author-checkfound no holder missing fromdebian/copyright, and the scan listed no built files, minified code, PDFs, fonts or images. The tree has no such files — the whole upstream part is 18 text files:LICENSE,README.md,go.mod,go.sum, 13.gofiles underext4/,log/log.go. LICENSEis the canonical Apache-2.0 text with the appendix left as the placeholderCopyright {yyyy} {name of copyright owner}, and contains no additional or restricting clause.- No upstream file carries a header: grep over the whole tree for
Copyright,(C),©,SPDX-License-Identifier,Licensed under,Permission is hereby granted,GNU,Apache,All rights reserved,public domainmatched onlyLICENSEanddebian/copyright. TheFiles: */License: Apache-2.0statement therefore matches the evidence in the files. - Stanza matching:
Files: *reaches every path including belowext4/andlog/(copyright-format 6.9,*spans/), and the laterFiles: debian/*overrides it for all nine packaging files (changelog,control,copyright,gbp.conf,rules,salsa-ci.yml,watch,source/format,upstream/metadata), which are attributed to the maintainer. Commentis allowed both in a Files stanza and in a stand-alone License stanza (copyright-format 5.2 and 5.3, read with thepolicytool), so the file's use of it is conformant.- The stand-alone
License: Apache-2.0paragraph gives the notice and refers to/usr/share/common-licenses/Apache-2.0; Policy 12.5 (read with thepolicytool) says Apache-2.0 packages should refer to that file rather than quote the licence. - No vendored code: imports in the tree are only
github.com/lunixbochs/struc,go.uber.org/zapandgolang.org/x/xerrors, each packaged separately in Debian. - No generated code or missing generator input: no
// Code generated,go:generate,go:embedorunsafemarker in the tree, anddebian/patchesdoes not exist, so nothing was patched or repacked. - Packaging files read in full:
debian/changelog,control,copyright,rules,gbp.conf,salsa-ci.yml,source/format,upstream/metadata(pluswatchfor context only, not reviewed). - Build dependencies resolve in the archive:
dh-go1.69 (installs/usr/share/perl5/Debian/Debhelper/Buildsystem/golang.pmandSequence/golang.pm, so the--buildsystem=golang/--with=golangindebian/ruleshave their files, and it Conflicts: dh-golang),dpkg-build-apiprovided bydpkg-dev1.23.11,golang-any2:1.27~1,golang-github-lunixbochs-struc-dev,golang-go.uber-zap-dev1.27.0-2,golang-golang-x-xerrors-dev. - The -dev package's three Depends are exactly the three third-party imports; the
_test.gofiles import onlybytes,encoding/binary,io,stringsandtesting, so no test dependency is missing and no build test dependency is needed. Standards-Version: 4.7.4versus the reviewing system's Policy 4.7.4.1: same first two components, so current; not an issue at any severity.- Architecture split and fields are the Go team's:
Architecture: all,Multi-Arch: foreign,Section: golang,XS-Go-Import-Path: github.com/masahiro331/go-ext4-filesystemmatching the module path ingo.mod; other Go -dev packages in the archive (golang-github-lunixbochs-struc-dev,golang-go.uber-zap-dev,golang-golang-x-xerrors-dev) use the same Multi-Arch value. debian/rulesis the documented form for this build system (its own POD: configure creates the workspace at the build directory, build runsgo install, test runsgo test -v, install copies into/usr/share/gocode/src, clean removes the build directory), withdebian/_buildas an explicit build directory instead of the compat-14 default_build.- Changelog is well formed: version
0.1.3+git20260423.fe51f5b-1,unstable, urgency medium, trailer with the uploader and a plausible date, andCloses: #1152503. The trailing comma on theUploadersline ofdebian/controlis normalised away by dpkg — the generated.dscshows the single uploader with no empty entry — so it has no effect. - uscan found upstream releases with
debian/watch; a newer upstream version is available (upstream0.1.3+git20261019.81cc551, packaged0.1.3+git20260423.fe51f5b), which is not a fault of the package. - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (Apache-2.0).
Not confirmed ◂
- The nine upstream copyright holders in the
Files: *stanza are stated to be the authors of the upstream commits; the source package carries no VCS metadata and no file has a notice, so I could not verify that the list is complete or that the names and years are exact. - autopkgtest is not installed on the reviewing system (no
/usr/share/autopkgtest, no/usr/share/doc/autopkgtest), so I could not read the implementation of theautopkgtest-pkg-gospecial test suite named indebian/control; the declaration is the one the Debian Go team's other packages use, anddh_golang_autopkgtest(which the package does not use) is only an alternative test command.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader was emailed about the review 1 day ago.
Review Information
accepted — allocated to awm 1 day ago, started 1 day ago, completed 1 day ago.