golang-github-masterminds-squirrel 1.5.4-1

Package Information

Description	fluent SQL generator for Go Squirrel helps build SQL queries from composable parts without being an ORM. It supports placeholders for multiple databases (including PostgreSQL dollar placeholders) and can run queries via database/sql.
Maintainer	Debian Go Packaging Team <team+pkg-go@tracker.debian.org>
Changed By	Hermes Rodríguez <hrodrig@usb.ve>
Sponsor	maytham@debian.org
Distribution	unstable
Architecture	all
VCS	git: https://salsa.debian.org/go-team/packages/golang-github-masterminds-squirrel.git (browse)
Closes	#1147755
Blocked Bugs	#910799 (wishlist)
Tracker	https://tracker.debian.org/pkg/golang-github-masterminds-squirrel
Uploaded	3 hours ago

New Package Report

.changes◂

Source	golang-github-masterminds-squirrel
Version	1.5.4-1
Changed-By	Hermes Rodríguez <hrodrig@usb.ve>
Architecture	source all
Distribution	unstable
Date	Mon, 09 Nov 2026 11:04:17 +0800

Changelog◂

golang-github-masterminds-squirrel (1.5.4-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1147755)

.dsc◂

Section	golang
Priority	optional
Component	main
Package-List	golang-github-masterminds-squirrel-dev deb golang optional arch=all

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: squirrel
Upstream-Contact: https://github.com/Masterminds/squirrel/issues
Source: https://github.com/Masterminds/squirrel

Files: *
Copyright: 2014-2015 Lann Martin
           2015-2016 Google
           2015 Matt Farina and Matt Butcher
License: Expat

Files: debian/*
Copyright: 2026 Hermes Rodríguez <hrodrig@usb.ve>
License: Expat

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 2 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 2 hours ago.

Proposes a replacement debian/watch: debian/watch in version 5 format

Report◂

DFSG NEW review for golang-github-masterminds-squirrel version 1.5.4-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: Yes
Issues: 0 blocker, 0 important, 2 minor
debian/watch: old format (version 4)
debian/copyright: machine-readable
Scan before the review: nothing found

Licensing

Upstream ships one MIT/Expat LICENSE that names Lann Martin, Google, and Matt Farina and Matt Butcher; debian/copyright is DEP-5 with the correct Format line, a Files: * stanza naming all of those holders and a debian/* stanza, and the full Expat text. No other licence file, per-file copyright notice or SPDX tag exists anywhere in the tree (the integration/ module is under the same licence), and nothing in it restricts modification, commercial use or distribution, so the licensing is DFSG-free and accurately described.

Packaging

Conventional, current Debian Go packaging: debhelper compat 13 with dh-sequence-golang, one Architecture: all / Multi-Arch: foreign -dev package, correct runtime Depends on golang-github-lann-builder-dev, Testsuite: autopkgtest-pkg-go served by autodep8, Vcs-* and upstream/metadata present, Standards-Version 4.7.4 against Policy 4.7.4.1. debian/rules uses the documented golang buildsystem invocation and excludes the separate integration/ test module from both build and install. The only defect is a stray trailing comma at the end of both relationship fields in debian/control.

Issues

minor packaging 1. Build-Depends and Depends in debian/control end with stray trailing commas ◂

Files: debian/control:10, debian/control:25
Basis: checked, in the package or with a reference tool
Evidence: golang-github-stretchr-testify-dev, is the last Build-Depends line before Testsuite: autopkgtest-pkg-go; the binary stanza has Depends: golang-github-lann-builder-dev, / ${misc:Depends},.
Problem: Policy 7.1 defines these fields as "a list of package names separated by commas"; a trailing comma adds an empty item, so the field as written in the source tree is malformed. Nothing fails in practice: Dpkg::Deps::deps_parse drops a trailing empty item (the shipped .dsc already shows the field normalised to ... golang-github-stretchr-testify-dev), and dpkg-gencontrol rebuilds the binary Depends from the parsed list. It is still a typo in a file a sponsor reads.
Fix: Drop the trailing commas: end Build-Depends on golang-github-stretchr-testify-dev and Depends on ${misc:Depends} with no following comma.

minor packaging 2. debian/watch is in the old version 4 format ◂

Files: debian/watch
Basis: found by the review tooling's own checks
Evidence: version=4
Problem: Version 5 is the current format of debian/watch.
Fix: Convert it to version 5; a mechanical conversion is under Proposed changes.

Verified ◂

Prescan: the two holders it flagged from LICENSE:4 (Copyright (c) 2014-2015, Lann Martin. Copyright (C) 2015-2016, Google. Copyright (C) 2015, Matt Farina and Matt Butcher.) are all named in the Files: * stanza of debian/copyright; debian/copyright's License: Expat matches the LICENSE text exactly, and the debian/* stanza covers the packaging under the same licence.
Grepping all 47 files for Copyright, (C), ©, SPDX-License-Identifier, Permission is hereby granted, GNU/Apache/Mozilla/public-domain wording found hits only in LICENSE, debian/copyright and README.md's link to the MIT licence; no Go file carries its own notice, so Files: * covers the whole upstream tree.
LICENSE is the only licence/copying file in the tree; integration/ has none of its own (same Expat terms), and its doc.go says only // This is a tests-only package.
integration/ is upstream's separate Go module (tests needing MySQL, PostgreSQL and SQLite drivers, replace github.com/Masterminds/squirrel => ../); it is excluded from build targets and, at compat >= 12, from installation by DH_GOLANG_EXCLUDES := integration, so the -dev package ships only the library.
The tree contains no built, minified or binary files: the only non-source artefacts are go.sum checksum files, .gitignore and .travis.yml, all upstream files covered by Files: *.
Every dependency name resolves: dpkg-build-api is provided by dpkg-dev (= 1), golang-github-stretchr-testify-dev (1.11.1-2) is in the archive, and golang-github-lann-builder-dev is waiting in NEW as golang-github-lann-builder 0.0~git20180802.47ae307-1, which is not a fault.
At compat 13 ${misc:Depends} is present in the binary stanza; Testsuite: autopkgtest-pkg-go is handled by autodep8's go template (grep-dctrl ... golang-(go|any), running dh_golang_autopkgtest with @builddeps@), so a hand-written debian/tests/control is not required.
dh-golang's golang buildsystem documents exactly the --builddirectory=<dir> --buildsystem=golang invocation used in debian/rules, and applies DH_GOLANG_EXCLUDES to go list targets and to dh_auto_install at this compat level; Build-Depends on testify is used because the golang test step runs go test on those targets.
gbp.conf's dist = DEP14 is valid: gbp buildpackage's dist option accepts DEP14 and derives the pbuilder distribution from the branch name (gbp/scripts/buildpackage.py).
Standards-Version 4.7.4 corresponds to Policy 4.7.4.1 (same first two components), so it is current.
Coverage: read all files of debian/ (watch excepted, as instructed), the .dsc and the .dsc-side tarball names; grepped the whole upstream tree for licence/copyright evidence rather than reading all 40 Go files in full.
uscan found the packaged version as the newest upstream release (upstream 1.5.4, packaged 1.5.4).

Not confirmed ◂

None.

Proposed: debian/watch in version 5 format ◂

debian/watch is in an old format. This is the conversion made by uscan --update-watchfile, which has not been run against the upstream site: some defaults differ in version 5, so test it with uscan --report before use.

Version: 5

Template: Github
Dist: https://github.com/Masterminds/squirrel
Uversionmangle: s/(\d)[_\.\-\+]?(RC|rc|pre|dev|beta|alpha)[.]?(\d*)$/$1~$2$3/

Uploader's response to the LLM review

The uploader was emailed about the review 2 hours ago.

Back to Dashboard | View all reviews for this package