Review: golang-github-pingcap-failpoint 0.0~git20240528.b51a646-1
Review Information
| Package | golang-github-pingcap-failpoint — 0.0~git20240528.b51a646-1 |
|---|---|
| Reviewer | awm |
| Allocated | 5 days ago |
| Started | 5 days ago |
| Status | accepted |
| Completed | 5 days ago |
Final Comment
LGTM
New Package Report
Notes
5 days ago
● public
duck - check URL redirections
Command: env PERL5OPT=-m-lib=. duck
Exit code: 0
I: debian/copyright:2: URL: https://github.com/pingcap/failpoint: INFORMATION (Certainty:wild-guess)
Curl:0 HTTP:200 No error
Website seems to be outdated, is probably a parked domain or for sale. Please update your links!
Matching regular expression(s):
m/\bunsupported\b/i
I: debian/upstream/metadata:URL: https://github.com/pingcap/failpoint.git: INFORMATION (Certainty:wild-guess)
Curl:0 HTTP:200 No error
Website seems to be outdated, is probably a parked domain or for sale. Please update your links!
Matching regular expression(s):
m/\bunsupported\b/i
I: debian/control: Homepage: https://github.com/pingcap/failpoint: INFORMATION (Certainty:wild-guess)
Curl:0 HTTP:200 No error
Website seems to be outdated, is probably a parked domain or for sale. Please update your links!
Matching regular expression(s):
m/\bunsupported\b/i
I: debian/upstream/metadata:URL: https://github.com/pingcap/failpoint: INFORMATION (Certainty:wild-guess)
Curl:0 HTTP:200 No error
Website seems to be outdated, is probably a parked domain or for sale. Please update your links!
Matching regular expression(s):
m/\bunsupported\b/i
5 days ago
● public
suspicious-source
Command: suspicious-source
Exit code: 0
(no output)
5 days ago
● public
vulture
Command: vulture .
Exit code: 0
(no output)
5 days ago
● public
debmake -cc
Command: debmake -cc
Exit code: 0
I: set parameters
I: scan source for copyright+license text and file extensions
I: 52 %, ext = go
I: 18 %, ext = md
I: 8 %, ext = yml
I: 5 %, ext = install
I: 2 %, ext = gitignore
I: 2 %, ext = sum
I: 2 %, ext = mod
I: 2 %, ext = conf
I: 2 %, ext = patch
I: 2 %, ext = gitkeep
I: 2 %, ext = media
I: check_all_licenses
I: ......................................W: analyze_copyright: skip name="", years=9999-0
.........W: Non-UTF-8 char found, using latin-1: media/rewrite-demo.png
W: ... 'utf-8' codec can't decode byte 0x89 in position 0: invalid start byte
W: analyze_copyright: skip name="", years=9999-0
I: check_all_licenses completed for 47 files.
I: bunch_all_licenses
I: format_all_licenses
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: package
Upstream-Contact: <preferred name and address to reach the upstream project>
Source: <url://example.com>
#
# Please double check copyright with the licensecheck(1) command.
Files: .codecov.yml
.github/ISSUE_TEMPLATE/bug-report.md
.github/ISSUE_TEMPLATE/feature-request.md
.github/ISSUE_TEMPLATE/question.md
.github/workflows/suite.yml
.gitignore
CONTRIBUTING.md
MAINTAINERS.md
Makefile
README.md
debian/control
debian/failpoint-tools.install
debian/gbp.conf
debian/gitlab-ci.yml
debian/golang-github-pingcap-failpoint-dev.install
debian/patches/fix-rewriter_test-output.patch
debian/patches/series
debian/rules
debian/source/format
debian/upstream/metadata
debian/watch
go.mod
go.sum
media/rewrite-demo.png
tools/.gitkeep
Copyright: __NO_COPYRIGHT_NOR_LICENSE__
License: __NO_COPYRIGHT_NOR_LICENSE__
Files: code/expr_rewriter.go
code/main_test.go
code/restorer.go
code/restorer_test.go
code/rewriter.go
code/rewriter_test.go
examples/injectcall/inject_call.go
examples/injectcall/inject_call_test.go
failpoint-ctl/main.go
failpoint-ctl/version/version.go
failpoint-toolexec/main.go
failpoint.go
failpoint_test.go
failpoints_test.go
http_test.go
main_test.go
marker.go
Copyright: 2019-2024 PingCAP, Inc.
License: Apache-2.0
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
.
http://www.apache.org/licenses/LICENSE-2.0
.
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
.
On Debian systems, the complete text of the Apache License Version 2.0
can be found in `/usr/share/common-licenses/Apache-2.0'.
Files: failpoints.go
http.go
terms.go
terms_test.go
Copyright: 2016 CoreOS, Inc.
2019 PingCAP, Inc.
License: Apache-2.0
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
.
http://www.apache.org/licenses/LICENSE-2.0
.
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
.
http://www.apache.org/licenses/LICENSE-2.0
.
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
.
On Debian systems, the complete text of the Apache License Version 2.0
can be found in `/usr/share/common-licenses/Apache-2.0'.
Files: LICENSES/GOFAIL_LICENSE
Copyright: [yyyy] [name of copyright owner]
license to reproduce, prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such Derivative Works in Source or Object form.
License: __UNKNOWN__
3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.
.
4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:
.
(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and
.
(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and
.
(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.
.
You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.
.
5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.
.
6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.
.
7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.
.
8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.
.
9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.
.
END OF TERMS AND CONDITIONS
.
APPENDIX: How to apply the Apache License to your work.
.
To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.
.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
.
http://www.apache.org/licenses/LICENSE-2.0
.
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
#----------------------------------------------------------------------------
# xml and html files (skipped):
# .github/pull_request_template.md
5 days ago
● public
Licenserecon
Command: lrc -l
Exit code: 0
en: Versions: licenserecon '11.0' licensecheck '3.3.9-1'
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
d/copyright | licensecheck
Apache-2.0 | Apache-2.0 code/expr_rewriter.go
Apache-2.0 | Apache-2.0 code/main_test.go
Apache-2.0 | Apache-2.0 code/restorer.go
Apache-2.0 | Apache-2.0 code/restorer_test.go
Apache-2.0 | Apache-2.0 code/rewriter.go
Apache-2.0 | Apache-2.0 code/rewriter_test.go
Apache-2.0 | Apache-2.0 examples/injectcall/inject_call.go
Apache-2.0 | Apache-2.0 examples/injectcall/inject_call_test.go
Apache-2.0 | Apache-2.0 failpoint-ctl/main.go
Apache-2.0 | Apache-2.0 failpoint-ctl/version/version.go
Apache-2.0 | Apache-2.0 failpoint.go
Apache-2.0 | Apache-2.0 failpoints.go
Apache-2.0 | Apache-2.0 failpoints_test.go
Apache-2.0 | Apache-2.0 failpoint_test.go
Apache-2.0 | Apache-2.0 failpoint-toolexec/main.go
Apache-2.0 | Apache-2.0 http.go
Apache-2.0 | Apache-2.0 http_test.go
Apache-2.0 | Apache-2.0 LICENSE
Apache-2.0 | Apache-2.0 LICENSES/GOFAIL_LICENSE
Apache-2.0 | Apache-2.0 main_test.go
Apache-2.0 | Apache-2.0 marker.go
Apache-2.0 | Apache-2.0 terms.go
Apache-2.0 | Apache-2.0 terms_test.go
No significant differences found
5 days ago
● public
copyright check
Command: cme check dpkg-copyright
Exit code: 0
(no output)