golang-github-redis-go-redis 9.17.2-2
Package Information
| Description | type-safe redis client for go (v9) This package contains go-redis which is the official Redis client library for the Go programming language. It offers a straightforward interface for interacting with Redis servers. |
|---|---|
| Maintainer | Debian Go Packaging Team <team+pkg-go@tracker.debian.org> |
| Changed By | Rafael Passos <rafael@rcpassos.me> |
| Sponsor | tsimonq2@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/go-team/packages/golang-github-redis-go-redis.git (browse) |
| Binary NEW | Yes (new binary packages of a source already in sid) |
| Tracker | https://tracker.debian.org/pkg/golang-github-redis-go-redis |
| Uploaded | 2 hours ago |
New Package Report
.changes
| Date | Fri, 13 Nov 2026 16:46:08 -0300 |
|---|---|
| Source | golang-github-redis-go-redis |
| Version | 9.17.2-2 |
| Changed-By | Rafael Passos <rafael@rcpassos.me> |
| Architecture | source all |
| Distribution | unstable |
Changelog
golang-github-redis-go-redis (9.17.2-2) unstable; urgency=medium . * Team Upload * d/control: update debhelper-compat to 14 * d/control: update standards to 4.7.4 * d/control: set go import path to /v9 * d/control: rename bin package to v9 * d/install: add explicit install helper * d/watch: set custom version to v9 * d/link: install time link for extras * d/rules: build time link for the extras * d/salsa-ci: move to salsa-ci * d/control: port to dh-go * d/control: add otel dependency
.dsc
| Priority | optional |
|---|---|
| Component | main |
| Package-List | golang-github-redis-go-redis-dev deb oldlibs optional arch=all golang-github-redis-go-redis-v9-dev deb golang optional arch=all |
| Section | oldlibs |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/redis/go-redis
Upstream-Name: go-redis
Upstream-Contact: https://github.com/redis/go-redis/issues
Files: *
Copyright: 2013 The github.com/redis/go-redis Authors.
License: BSD-2-clause
Files: internal/once.go
Copyright: 2014 The Camlistore Authors
License: Apache-2.0
Files: internal/hashtag/hashtag.go
Copyright: 2001-2010 Georges Menie (www.menie.org)
2013 The Go Authors. All rights reserved.
License: BSD-3-clause
Comment: See the license in the header of Appendix A: CRC16 reference implementation in ANSI C:
https://redis.io/docs/latest/operate/oss_and_stack/reference/cluster-spec/#appendix-a-crc16-reference-implementation-in-ansi-c
Files: debian/*
Copyright: 2026 Andrew Lee (李健秋) <ajqlee@debian.org>
License: BSD-2-clause
Comment: Debian packaging is licensed under the same terms as upstream
License: BSD-2-clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:
.
* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the following disclaimer
in the documentation and/or other materials provided with the
distribution.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
License: Apache-2.0
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
.
https://www.apache.org/licenses/LICENSE-2.0
.
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
.
On Debian systems, the complete text of the Apache version 2.0 license
can be found in "/usr/share/common-licenses/Apache-2.0".
License: BSD-3-clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
.
* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
* Neither the name of the University of California, Berkeley nor the
names of its contributors may be used to endorse or promote products
derived from this software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND ANY
EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE REGENTS AND CONTRIBUTORS BE LIABLE FOR ANY
DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
DFSG Assistant LLM REVIEW 1 blocker, 0 important, 3 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 1 hour ago.
Report
DFSG NEW review for golang-github-redis-go-redis version 9.17.2-2
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: No
- Issues: 1 blocker, 0 important, 3 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: 1 found
Licensing
The three licences present (BSD-2-clause for the project, Apache-2.0 for internal/once.go, BSD-3-clause for internal/hashtag/hashtag.go) are DFSG-free and compatible, and debian/copyright is DEP-5 with correct stanzas and full licence texts; the prescan found no unnamed holder. However the source package also contains example/throughput/throughput, a 7.9 MB Mach-O executable for which no source exists anywhere in the tree, so the source package does not ship everything in its preferred form for modification (DFSG 1 and 2). Deleting or repacking the tarball without that file is required before the package can be accepted.
Packaging
The packaging is mostly conventional (compat 14, dpkg-build-api 1, autopkgtest-pkg-go, correct transitional package and nested-module symlinks), but debian/rules compiles the extra/ modules while golang-opentelemetry-otel-dev is only in Depends, not Build-Depends, so a clean sbuild is expected to fail on go.opentelemetry.io/otel; the test override discards all test results with '|| true'; and golang-golang-x-tools-dev is depended on only for internal/customvet, which is excluded from both build and install.
Issues
blocker licensing 1. example/throughput/throughput is a prebuilt 7.9 MB Mach-O executable shipped with no source ◂
- Files:
example/throughput/throughput - Basis: checked, in the package or with a reference tool
- Evidence: Prescan:
example/throughput/throughput: Mach-O executable or library. The directory contains only this file, and there is no debian/patches, so it comes from the upstream tarball unchanged. - Problem: The source package distributes a compiled program without any corresponding source anywhere in the tree (no throughput example source, no generator, no patch). DFSG 1 and 2 require the preferred form for modification and the source code to accompany the program; a sourceless binary cannot be reviewed, rebuilt or modified, and its exact contents cannot be verified against any free source. debian/copyright merely assumes it is covered by the
Files: *BSD-2 stanza. - Fix: Repack the upstream tarball without example/throughput/throughput (add
Files-Excluded: example/throughput/throughputto debian/copyright and exclude it in the watch/repack setup), or ask upstream to remove the binary; verify the orig tarball no longer contains it.
minor packaging 2. Build-Depends omits golang-opentelemetry-otel-dev although extra/redisotel is a build target ◂
- Files:
debian/control:10-16,debian/control:36-42,debian/rules:4,debian/rules:27-36,extra/redisotel/config.go:6-10 - Basis: inferred from what was read, not seen directly
- Evidence:
export DH_GOLANG_EXCLUDES := example doctests internal/customvetdoes not excludeextra; the dh golang build system's default target is${DH_GOPKG}/...and builds in GOPATH mode withgo install, and rules itself says the extra/ symlinks makerediscensus -> extra/rediscmd/v9resolve "during dh_auto_build".extra/redisotel/config.goimportsgo.opentelemetry.io/otel, butgolang-opentelemetry-otel-devappears only in the binary package's Depends, not in Build-Depends. - Problem: In a clean sbuild chroot, which has only Build-Depends installed,
go install github.com/redis/go-redis/v9/...reaches extra/redisotel and fails withcannot find package "go.opentelemetry.io/otel", so the package cannot build. The dependencies of the other extras (opencensus, prometheus) are present in Build-Depends, which makes the otel omission look accidental. - Fix: Add golang-opentelemetry-otel-dev to Build-Depends (keep it in Depends as well), or exclude extra/redisotel from the build and install if it is not meant to be shipped.
minor
packaging
3. override_dh_auto_test swallows every test failure with || true
◂
-
Files:
debian/rules:10-13 -
Basis: checked, in the package or with a reference tool
-
Evidence:
override_dh_auto_test: # Bypass tests due to missing build-deps on github.com/bsm/ginkgo/v2 and github.com/bsm/gomega. dh_auto_test -- -v -short || true -
Problem: The upstream test suite is compiled and run, but any failure (and even a compile failure) is discarded, so the build cannot detect a broken library. Because there is no
autopkgtesttarget in debian/rules, the testsuite generated byTestsuite: autopkgtest-pkg-goonly runsdebian/rules buildand therefore also never executes them (dh_golang_autopkgtest only calls theautopkgtesttarget if one exists). The tests are effectively never enforced anywhere, while the package advertises an autopkgtest suite. -
Fix: Remove
|| trueand either package github.com/bsm/ginkgo/v2 and github.com/bsm/gomega as Build-Depends (or use Debian's golang-github-onsi-ginkgo-v2-dev/gomega if the imports can be adjusted), or replace the target with a documented no-op and add a debian/tests/control that runs the suite with its dependencies.
minor packaging 4. golang-golang-x-tools-dev is depended on only for internal/customvet, which is excluded from build and install ◂
- Files:
debian/control:10-16,debian/control:36-42,debian/rules:4 - Basis: inferred from what was read, not seen directly
- Evidence: The only imports of
golang.org/x/toolsin the tree are internal/customvet/main.go and internal/customvet/checks/setval; rules hasexport DH_GOLANG_EXCLUDES := example doctests internal/customvet, and at compat 14 dh-golang's DH_GOLANG_EXCLUDES_ALL defaults to true, so that directory is also left out of the installed source. - Problem: Neither the build nor the installed library uses golang.org/x/tools, so the Build-Depends makes every build install it for nothing and the Depends makes every consumer of the -dev package install it for nothing. That is dependency bloat, not a policy violation.
- Fix: Drop golang-golang-x-tools-dev from both Build-Depends and Depends, unless internal/customvet is to be shipped (then add it to Depends only and say why it is installed).
Verified ◂
- Read all of debian/ (control, rules, changelog, copyright, install, links, gbp.conf, salsa-ci.yml, source/format, upstream/metadata); there are no debian/patches and no debian/tests.
- LICENSE is BSD-2-clause and the
Files: *stanza reproduces it; internal/once.go carries the Apache-2.0 header matching its stanza; internal/hashtag/hashtag.go carries the Georges Menie 2001-2010 and Go Authors 2013 headers matching its BSD-3-clause stanza. Apache-2.0 with BSD-2/BSD-3 is compatible in one binary. - A tree-wide grep for Copyright/(C)/©/SPDX/Licensed under/GNU/Apache/MPL/public domain/All rights reserved found no other licence notice or holder than those three files plus LICENSE, and the prescan author check agrees that every holder is named.
- example/throughput/throughput was accounted for above; example/otel/image/metrics.png and example/otel/image/redis-trace.png are Grafana/dashboard screenshots referenced by example/otel/README.md:71 and :98, covered by
Files: *, and were not opened (binary images). - No file in the tree carries a 'Code generated'/'DO NOT EDIT' marker or a go:generate without its input, so no generated code lacks its generator.
- example/* and doctests/ are separate Go modules; they are excluded by DH_GOLANG_EXCLUDES and are not installed in any binary package.
- The four lines of debian/golang-github-redis-go-redis-v9-dev.links follow dh_link(1)'s source-then-link-name order and create github.com/redis/go-redis/extra//v9 pointing at the installed .../go-redis/v9/extra/ trees, so the nested-module import paths resolve.
- Standards-Version 4.7.4 is current against Policy 4.7.4.1 (first two components), and compat 14 with dpkg-build-api 1 means the test/strip overrides are skipped under nocheck/nostrip and no relationship substvars need to be named in control.
- No debian/copyright Format replacement is needed: the file is DEP-5 with the exact copyright-format/1.0 URL.
- Sampled the Go sources rather than reading all 341 files: headers, imports of the extra/ modules, go.mod/go.sum files, and all packaging files were read; the rest of the library code was only grepped.
- uscan found upstream releases with
debian/watch; a newer upstream version is available (upstream9.23.0, packaged9.17.2), which is not a fault of the package. - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (Apache-2.0).
Not confirmed ◂
- The reference system has dh-golang 1.67 installed, not the dh-go 1.71 the package Build-Depends on; the otel Build-Depends finding assumes dh-go 1.71 keeps dh-golang's GOPATH-mode
${DH_GOPKG}/...build targets, which the rules comment about building the extras implies. - The Mach-O binary was not inspected (binary file), so its build origin and upstream commit cannot be identified; it is referenced by no README, Makefile or test in the tree.
- Whether the throughput binary is an accidental upstream commit or was added by the packager cannot be told from the package: there are no patches, so it is in the orig tarball as unpacked.
- Why the model asked for what a review has no use for. During this review it asked once for something outside the package and the reviewing system (another file of the sandbox, or a URL), or was given part of the review tooling's own configuration, and that was refused or withheld. A model does this when something it has read tells it to, so look in the package for text addressed to a reviewing program, and treat this report with suspicion. Refused:
read: "xd://read/sources" is not a file of the package or of the reviewing system.
Proposed changes ◂
None.
Uploader's response to the LLM review
Waiting for the uploader's response until , because the review found serious issues.
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 9.17.2-1 | 4dcff098… | 2026-02-23 04:40 | 2026-02-23 04:41 | awm | accepted | VIEW |