DFSG NEW review for golang-github-wagoodman-go-presenter version 0.0~git20211015.f9c01af-1

Summary

• Licensing is DFSG-compliant and debian/copyright is accurate: Yes
• Packaging is of good quality: Yes
• Issues: 0 blocker, 0 important, 0 minor
• debian/watch: version 5
• debian/copyright: machine-readable
• Scan before the review: nothing found

Licensing

The whole tree is a single 2021 Go module by Alex Goodman, licensed Apache-2.0; LICENSE is verbatim Apache License 2.0 and every other file (.gitignore, README.md, go.mod, presenter.go) is covered by the Files: * stanza. debian/copyright is DEP-5, names the right holders (upstream Alex Goodman; packaging by the uploader), matches the Apache-2.0 short name to the actual text, and points at /usr/share/common-licenses/Apache-2.0. No non-free terms, no built artefacts, no third-party embedded code.

Packaging

A clean, small team-style Go library package: debhelper compat 14 with dh-go's golang buildsystem, XS-Go-Import-Path matching the go.mod module path, autopkgtest-pkg-go, salsa-ci.yml, gbp.conf, upstream/metadata, Vcs-* and a sane Standards-Version (4.7.4, current Policy 4.7.4.1). The architecture-independent package installs only Go source, uses ${misc:Depends} (auto-added at compat 14), and the one lintian override of missing-build-dependency-for-dh-addon golang is correct because dh-go 1.69 supplies the golang addon/buildsystem and conflicts with dh-golang.

Issues

None.

Verified

• Tree inventoried in full (gitignore: false): upstream is only .gitignore, LICENSE, README.md, go.mod, presenter.go; debian/ holds changelog, control, copyright, gbp.conf, rules, salsa-ci.yml, watch, source/format, source/lintian-overrides, upstream/metadata. No patches/ and no other files.
• Prescan reported no problem files: it scanned 4 files and found that every copyright holder it detected is named in debian/copyright. A grep of the whole tree for Copyright, (C), ©, SPDX-License-Identifier, Licensed under, GNU General Public/Lesser, Apache License, Mozilla Public, public domain, All rights reserved, non-commercial, no modification found text only in LICENSE and debian/copyright; no DFSG-unfree wording anywhere.
• LICENSE is the unmodified Apache License 2.0 text (appendix still has the Copyright [yyyy] [name of copyright owner] placeholder), as debian/copyright's Comment states; it is the source of the Apache-2.0 licence for all upstream files, so no file lacks a licence and the Files: * stanza's holder/year (inferred from the two upstream commits, documented in the Comment) is the only possible one.
• debian/copyright is DEP-5 (Format: first line, correct URL), uses Files: * plus debian/* (the latter overrides for the packaging), gives a stand-alone License: Apache-2.0 paragraph with the notice and the pointer to /usr/share/common-licenses/Apache-2.0; Comment: is a permitted optional Files-stanza field (copyright-format 5.2).
• Build-Depends are satisfiable: dh-go 1.69 exists and, per its apt-cache control, provides the golang debhelper sequence addon, a golang buildsystem module and dh_golang/dh_golang_autopkgtest, and it Conflicts with dh-golang; so --with=golang --buildsystem=golang with dh-go (not dh-golang) is right, and the debian/source/lintian-overrides entry for missing-build-dependency-for-dh-addon golang is a legitimate override, not a masked fault (dh-go has no Provides: dh-sequence-golang, so the explicit --with=golang is needed).
• dpkg-build-api (= 1) is the documented form for declaring the build API level (man dpkg-build-api: Build-Depends: dpkg-build-api (= 1),; provided by dpkg-dev 1.23.11), and at level 1 Rules-Requires-Root defaults to no, so its absence from debian/control is not a fault.
• Testsuite: autopkgtest-pkg-go is consistent with the tree: autodep8's go test template (/usr/share/autodep8/support/go/) detects golang-any in Build-Depends and runs /usr/bin/dh_golang_autopkgtest with Depends: @, @builddeps@, both provided by dh-go; no debian/tests/control is needed.
• Standards-Version 4.7.4 matches current Policy 4.7.4.1 in its first two components; changelog version 0.0~git20211015.f9c01af-1 (matches the watch Git-Pretty scheme 0.0~git%cd.%h), distribution unstable, date a valid Friday, one bug closure.
• XS-Go-Import-Path github.com/wagoodman/go-presenter matches the module path in go.mod; the arch-independent -dev package uses ${misc:Depends} only (substvar auto-added by dh_gencontrol at compat 14).
• uscan found the packaged version as the newest upstream release (upstream 0.0~git20211015.f9c01af, packaged 0.0~git20211015.f9c01af).
• Every pointer of debian/copyright to /usr/share/common-licenses names a file that is there (Apache-2.0).

Not confirmed

• Whether upstream has any copyright holder besides Alex Goodman could not be checked (the tarball carries no git history); debian/copyright documents that both commits are his and that he is the only contributor.

Proposed changes

None.