Review: gweather-locations 2026.2-1

Package Information

Description	location data for libgweather The GWeather locations database contains a list of locations used by GNOME components through libgweather.
Maintainer	Debian Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
Changed By	Matthias Geiger <werdahias@debian.org>
Sponsor	werdahias@debian.org
Distribution	unstable
Architecture	any
VCS	git: https://salsa.debian.org/gnome-team/gweather-locations.git (browse)
Closes	#1138236
Tracker	https://tracker.debian.org/pkg/gweather-locations
Uploaded	25 days ago

New Package Report

.changes◂

Date	Tue, 13 Oct 2026 19:06:01 +0200
Source	gweather-locations
Version	2026.2-1
Changed-By	Matthias Geiger <werdahias@debian.org>
Architecture	source amd64
Distribution	unstable

Changelog◂

gweather-locations (2026.2-1) unstable; urgency=medium
 .
   [ Matthias Geiger ]
   * Initial release. (Closes: #1138236)
   * d/control: Fully switch to DH 14
 .
   [ Danial Behzadi ]
   * d/watch: Update to Version 5
   * d/control: Fix Homepage address
   * d/copyright: Fix copyrigh attributions

.dsc◂

Package-List	gweather-locations deb gnome optional arch=any
Section	gnome
Priority	optional
Component	main

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: gweather-locations
Upstream-Contact: Emanualle Bassi <ebassi@gnome.org>
Source: https://gitlab.gnome.org/GNOME/gweather-locations

Files: *
Copyright:
  1999-2026 The GNOME Project
License: GPL-2+
Comment:
 The GNOME Project is the copyright holder of these projects:
 * libgweather
 * gnome-applets
 * gnome-applets.locations
 * gweather-locations

Files:
 po/ca.po
 po/ca@valencia.po
 po/crh.po
 po/cy.po
 po/da.po
 po/eo.po
 po/et.po
 po/fa.po
 po/fi.po
 po/fr.po
 po/ga.po
 po/gl.po
 po/hu.po
 po/it.po
 po/ja.po
 po/ky.po
 po/lt.po
 po/ms.po
 po/nb.po
 po/ro.po
 po/ru.po
 po/rw.po
 po/sk.po
 po/sl.po
 po/sq.po
 po/sv.po
 po/th.po
 po/zh_CN.po
 po/zh_HK.po
 po/zh_TW.po
Copyright:
  2000-2025 Free Software Foundation, Inc.
License: GPL-2+

Files:
 po/bg.po
Copyright:
  2004-2017 Free Software Foundation, Inc.
  2010-2014 Krasimir Chonov <mk2616@abv.bg>
  2022-2026 Alexander Shopov
  2022 twlvnn kraftwerk
License: GPL-2+

Files:
 po/cs.po
Copyright:
  2004-2006 Miloslav Trmac <mitr@volny.cz>
  2008 Pavel Šefránek <ps@pjoul.cz>
License: GPL-2+

Files:
 po/el.po
Copyright:
  2004 Free Software Foundation, Inc.
  2004 Kostas Papadimas
  2004 Simos Xenitellis
License: GPL-2+

Files:
 po/en_CA.po
Copyright:
  2004-2005 Adam Weinberger
License: GPL-2+

Files:
 po/gd.po
Copyright:
  2012 Rosetta Contributors and Canonical Ltd.
License: GPL-2+

Files:
 po/lv.po
Copyright:
  2011-2024 Rudolfs <rudolfs.mazurs@gmail.com>
License: GPL-2+

Files: po/nn.po
Copyright:
  2004-2006 Free Software Foundation, Inc.
  2005 Yahoo! Inc.
License: GPL-2+

Files:
 po/te.po
Copyright:
  2005 Rajesh Ranjan <rranjan@redhat.com>
  2005 Sunil Mohan Adapa <sunil@atc.tcs.co.in>
  2011-2012 Swecha Telugu Localisation Team <localization@swecha.net>
License: GPL-2+

Files: debian/*
Copyright:
    2026 Matthias Geiger <werdahias@debian.org>
    2026 Danial Behzadi <dani.behzi@ubuntu.com>
License: GPL-2+

License: GPL-2+
 This package is free software; you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
 the Free Software Foundation; either version 2 of the License, or
 (at your option) any later version.
 .
 This package is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU General Public License for more details.
 .
 You should have received a copy of the GNU General Public License
 along with this program. If not, see <https://www.gnu.org/licenses/>
 .
 On Debian systems, the complete text of the GNU General
 Public License version 2 can be found in "/usr/share/common-licenses/GPL-2".

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 6 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 24 days ago.

Report◂

DFSG NEW review for gweather-locations version 2026.2-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: Yes
Issues: 0 blocker, 0 important, 6 minor
debian/watch: version 5
debian/copyright: machine-readable

Licensing

Licensing is DFSG-free throughout: every file is GPL-2+ (with the usual 'or any later version'), the only COPYING is GPL-2, meson.build declares GPL-2.0-or-later, and every .po header states distribution under the license of its (GPL-licensed) host package. There are no binaries, fonts, images, minified files, or generated artifacts without preferred-form source; the sole generated object, data/Locations.bin, is produced at build time from the shipped Locations.xml. debian/copyright is machine-readable DEP-5 with the exact 1.0 Format URL and a full standalone GPL-2+ License paragraph; the per-file .po stanzas accurately name the holders found in the corresponding headers. Only two cosmetic attribution nits (Upstream-Contact typo, one SPDX-tagged translator holder in he.po) do not affect the DFSG verdict.

Packaging

Packaging is good: debhelper compat 14 with a plain dh $@ rules, meson build, Architecture: any is correct because Locations.bin is endianness-dependent, and the applied patch keeps the gweather-locations.pc in the per-arch pkgconfig directory so consumers resolve the right Locations.bin. Build dependences are adequate (msgfmt arrives via debhelper -> po-debconf -> gettext, python3-gi brings the GLib typelib for the generator). Only minor cleanups remain: a 'Debian Debian' typo in Maintainer, missing Rules-Requires-Root: no, Standards-Version 4.7.4 instead of current 4.7.4.1, and the single patch lacking DEP-3 headers plus not being forwarded upstream.

Issues

minor licensing 1. Upstream-Contact misspells upstream maintainer's name ◂

Files: debian/copyright:3
Evidence: Upstream-Contact: Emanualle Bassi (the .doap file spells the name 'Emmanuele Bassi')
Problem: Misspelled contact name without an address; upstream contact should be an RFC 5322 address per copyright-format 6.3.
Fix: Write Upstream-Contact: Emmanuele Bassi <ebassi@gnome.org>.

minor licensing 2. po/he.po carries an explicit individual copyright not reflected in debian/copyright ◂

Files: debian/copyright (Files: * stanza), po/he.po:6
Evidence: # SPDX-FileCopyrightText: 2024 Yaron Shahrabani <sh.yaron@gmail.com>
Problem: he.po is matched only by the catch-all stanza attributing everything to 'The GNOME Project'; this SPDX-tagged holder (a real person, not the GNOME Project) is thus not represented, unlike the .po files with dedicated stanzas.
Fix: Add a Files: po/he.po stanza naming Yaron Shahrabani (and, for consistency, the other named translators could be swept under the existing catch-all).

minor packaging 3. Maintainer field contains duplicated word 'Debian Debian' ◂

Files: debian/control:3
Evidence: Maintainer: Debian Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
Problem: The team's name is duplicated; wrong maintainer string appears in the binary/source control data.
Fix: Change to Maintainer: Debian GNOME Maintainers <...>.

minor packaging 4. Patch lacks DEP-3 headers and is not forwarded; Debian-specific meson option is never set ◂

Files: debian/patches/use-correct-pkgconfig-patch.patch
Evidence: Patch carries only From:/Date:/Subject:; it adds option('host_arch', type: 'string') (empty default) and uses install_dir: get_option('libdir') / get_option('host_arch') / 'pkgconfig'.
Problem: No Description, Forwarded, Origin or Last-Update DEP-3 headers, so the patch's purpose and provenance are unclear to future maintainers, and this genuine upstream bug (a .pc file installed under datadir/pkgconfig) is not reported upstream. Debian never passes -Dhost_arch, so the install path is only correct because join_paths collapses the empty component into $(libdir)/pkgconfig.
Fix: Add DEP-3 headers and forward upstream; upstream would prefer the simpler get_option('libdir') / 'pkgconfig' without the RHEL-oriented host_arch indirection.

minor packaging 5. Rules-Requires-Root: no not declared ◂

Files: debian/control
Evidence: No Rules-Requires-Root field; the package installs only under /usr/share and /usr/lib with default ownership.
Problem: Policy 4.9.3 asks that Rules-Requires-Root: no be set when the package does not need root to build; omitting it disables rootless builds and nicer CI handling.
Fix: Add Rules-Requires-Root: no to the source stanza.

minor packaging 6. Standards-Version is slightly out of date ◂

Files: debian/control:5
Evidence: Standards-Version: 4.7.4; Debian Policy on the reviewing system is version 4.7.4.1 (2026-03-31).
Problem: Initial 2026 upload should state the current Standards-Version.
Fix: Bump Standards-Version to 4.7.4.1.

Verified ◂

Read debian/copyright, control, rules, changelog, source/format, watch, gbp.conf, salsa-ci.yml, upstream/metadata, patches/series and the patch, in full.
Inventoried the entire unpacked source tree (excluding .pc/): meson.build/meson_options.txt, build-aux/gen_locations_variant.py, data/, docs/, po/ (all ~90 .po plus LINGUAS/POTFILES/regen.sh/extract.xsl/README.translators), COPYING, NEWS, README.md, gweather-locations.doap, .gitlab-ci.yml.
Collected licence evidence across the tree: only GPL/«same license as the GPL host package» notices; no Apache/MIT/CC/JSON-clause non-free terms, no public-domain claims needing text, no embedded third-party code.
Cross-checked every .po header Copyright line against the debian/copyright stanzas: the FSF stanza (30 files), bg, cs, el, en_CA, gd, lv, nn, te, and catch-all all match the named holders; no FSF-copyrighted .po is left out.
Confirmed no DFSG-preferred-form gaps: only generated artifact is data/Locations.bin, produced at build time from the shipped data/Locations.xml; no minified JS/CSS, no .jar/.class/.so/.pyc, no fonts/images of unclear provenance.
Checked build dependencies against the archive: debhelper 14.5 -> po-debconf -> gettext provides msgfmt; python3-gi Depends on gir1.2-glib-2.0 (GLib typelib needed by gen_locations_variant.py); dh-sequence-single-binary and meson are present.
Verified the patch's install path resolves to the Debian multiarch pkgconfig dir: meson's libdir / '' / 'pkgconfig' collapses to $(libdir)/pkgconfig = /usr/lib//pkgconfig, where pkg-config (pkgconf) finds it.
uscan found the packaged version as the newest upstream release (upstream 2026.2, packaged 2026.2).

Not confirmed ◂

Could not run an actual build (review environment is read-only; no files may be created), so end-to-end build success and the installed .pc/.bin layout are reasoned from the meson files rather than observed.
lintian and licensecheck were already run separately and were not replicated.

Proposed changes ◂

None.

Review Information

accepted — allocated to mechtilde 23 days ago, started 23 days ago, completed 23 days ago.

Final Comment

Other Reviews of this Package

Version	Hash	Allocated	Completed	Reviewer	Status	Details
2026.2-1	c3acede0…	2026-05-31 18:35	2026-05-31 18:39	mechtilde	rejected	VIEW

Public Notes

23 days ago ● public

Missed Author Check

Command: dnq author-check
Exit code: 0

Using active review (from current.json): gweather-locations
Author check: gweather-locations 2026.2-1

Scanned 115 files.
Authors declared in debian/copyright: 16

NOT IN debian/copyright (4):

  Gnome Foundation
    po/es.po:4

  GNOME I18N Project for Vietnamese. Nguyễn Thái Ngọc Duy <pclouds@gmail.org>, 2004,2011
    po/vi.po:2

  libgweather
    po/pt.po:2

  Yaron Shahrabani <sh.yaron@gmail.com>
    po/he.po:6

Result: ATTENTION REQUIRED — 4 authors not in debian/copyright

Back to Dashboard | View all reviews for this package