Review: iperf 2.2.2+dfsg-2
Package Information
| Description | Internet Protocol bandwidth measuring tool (transitional package) Package to ease upgrading from older iperf package to the new iperf-client package. This package can be purged at anytime once the iperf-client package has been installed. |
|---|---|
| Maintainer | Daniel Baumann <daniel@debian.org> |
| Changed By | Daniel Baumann <daniel@debian.org> |
| Sponsor | mail@daniel-baumann.ch |
| Distribution | sid |
| Architecture | any all |
| VCS | git: https://forgejo.debian.net/linux/iperf (browse) |
| Popcon Installs | 9358 |
| Binary NEW | Yes (new binary packages of a source already in sid) |
| Tracker | https://tracker.debian.org/pkg/iperf |
| Uploaded | 9 hours ago |
New Package Report
.changes
| Date | Fri, 13 Nov 2026 09:58:45 +0100 |
|---|---|
| Source | iperf |
| Version | 2.2.2+dfsg-2 |
| Changed-By | Daniel Baumann <daniel@debian.org> |
| Architecture | source amd64 all |
| Distribution | sid |
Changelog
iperf (2.2.2+dfsg-2) sid; urgency=medium
.
* Moving systemd integration to run an iperf server into new iperf-
server package to highly lower complexity and improve admin
experience.
* Runing iperf server using a dynamic user rather than a static system
user.
* Removing old lintian overrides..dsc
| Section | oldlibs |
|---|---|
| Priority | extra |
| Component | main |
| Package-List | iperf deb oldlibs extra arch=all iperf-client deb net optional arch=any iperf-server deb net optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: iperf
Upstream-Contact: FIXME
Source: https://sourceforge.net/projects/iperf2
Files-Excluded:
include/service.h
src/service.c
Files: *
Copyright:
1999-2007 The Board of Trustees of the University of Illinois
2014-2025 Broadcom Corporation
2014-2026 Robert J. McMahon
License: NCSA
Files: NEWS.md
Copyright:
2014-2025 Broadcom Corporation
2014-2026 Robert J. McMahon
License: GPL-3+
Files: aclocal.m4
Copyright: 1996-2025 Free Software Foundation, Inc.
License: FSFULLR
Files: configure
Copyright: 1992-2023 Free Software Foundation, Inc.
License: FSFUL
Files:
compat/inet_ntop.c
compat/inet_pton.c
Copyright: 1996-2001 Internet Software Consortium
License: ISC
Files:
flows/discover_rig.py
flows/ssh_nodes.py
Copyright: 2025 Umber Networks
License: BSD-3-clause
Files: include/gnu_getopt.h
Copyright: 1989-1997 Free Software Foundation, Inc.
License: LGPL-2+
Files: install-sh
Copyright: 1994 X Consortium
License: X11
Files: m4/ax_pthread.m4
Copyright:
2008 Steven G. Johnson <stevenj@alum.mit.edu>
2011 Daniel Richard G. <skunk@iSKUNK.ORG>
License: GPL-3+ with Autoconf-2.0~Archive exception
Files: src/dscp.c
Copyright:
2000 Markus Friedl
2005,2006 Damien Miller
2022 Robert McMahon
License: BSD-2-clause
Files:
src/gnu_getopt.c
src/gnu_getopt_long.c
Copyright: 1987-1997 Free Software Foundation, Inc.
License: LGPL-2+
Files: debian/*
Copyright:
1998-2014 Roberto Lumbreras <rover@debian.org>
2026 Daniel Baumann <daniel@debian.org>
License: GPL-2+
License: BSD-2-clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
.
THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
License: BSD-3-clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
.
1. Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.
.
2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.
.
3. Neither the name of the copyright holder nor the names of its
contributors may be used to endorse or promote products derived from
this software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
License: FSFUL
This configure script is free software; the Free Software Foundation
gives unlimited permission to copy, distribute and modify it.
License: FSFULLR
This file is free software; the Free Software Foundation
gives unlimited permission to copy and/or distribute it,
with or without modifications, as long as this notice is preserved.
.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY, to the extent permitted by law; without
even the implied warranty of MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
License: GPL-2+
The full text of the GNU General Public License 2
can be found in the file /usr/share/common-licenses/GPL-2
License: GPL-3+
The full text of the GNU General Public License 3
can be found in the file /usr/share/common-licenses/GPL-3
License: GPL-3+ with Autoconf-2.0~Archive exception
The full text of the GNU General Public License 3
can be found in the file /usr/share/common-licenses/GPL-3
.
As a special exception, the respective Autoconf Macro's copyright owner
gives unlimited permission to copy, distribute and modify the configure
scripts that are the output of Autoconf when processing the Macro. You
need not follow the terms of the GNU General Public License when using
or distributing such scripts, even though portions of the text of the
Macro appear in them. The GNU General Public License (GPL) does govern
all other use of the material that constitutes the Autoconf Macro.
.
This special exception to the GPL applies to versions of the Autoconf
Macro released by the Autoconf Archive. When you make and distribute a
modified version of the Autoconf Macro, you may extend this special
exception to the GPL to apply to your modified version as well.
License: ISC
Permission to use, copy, modify, and distribute this software for any
purpose with or without fee is hereby granted, provided that the above
copyright notice and this permission notice appear in all copies.
.
THE SOFTWARE IS PROVIDED "AS IS" AND INTERNET SOFTWARE CONSORTIUM
DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL
INTERNET SOFTWARE CONSORTIUM BE LIABLE FOR ANY SPECIAL, DIRECT,
INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING
FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT,
NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION
WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
License: LGPL-2+
The full text of the GNU Lesser General Public License 2
can be found in the file /usr/share/common-licenses/LGPL-2
License: NCSA
Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal with
the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
of the Software, and to permit persons to whom the Software is furnished to
do so, subject to the following conditions:
* Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimers.
* Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimers in the documentation
and/or other materials provided with the distribution.
* Neither the names of the University of Illinois, NCSA,
Broadcom Corporation, Robert J. McMahon,
nor the names of its contributors may be used to endorse or promote products
derived from this Software without specific prior written permission.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
CONTRIBUTORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS WITH THE
SOFTWARE.
License: X11
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to
deal in the Software without restriction, including without limitation the
rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
sell copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
.
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
X CONSORTIUM BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN
AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNEC-
TION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
.
Except as contained in this notice, the name of the X Consortium shall not
be used in advertising or otherwise to promote the sale, use or other deal-
ings in this Software without prior written authorization from the X Consor-
tium.
DFSG Assistant LLM REVIEW 2 blocker, 3 important, 5 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 8 hours ago.
Report
DFSG NEW review for iperf version 2.2.2+dfsg-2
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: No
- Issues: 2 blocker, 3 important, 5 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
Every licence actually present in the tree is DFSG-free (NCSA, BSD-2/3-clause, ISC, X11, LGPL-2+, GPL-2+/GPL-3+, FSFUL/FSFULLR, Apache-2.0) and they are mutually compatible, so there is no non-free content. debian/copyright, however, is materially inaccurate and incomplete: the vendored L4STeam Prague code and all of contrib/udp_prague/ are Apache-2.0 but are covered by the Files: * NCSA stanza with no Apache text or holder; flows/test_rig.py carries a literal # ... [License Header] ... placeholder and no licence grant; The Regents of the University of California (LBNL) is named in LICENSE but not in the file; and the autotools-generated files (Makefile.in, config.guess, config.sub, compile, depcomp, missing, test-driver) are described as NCSA instead of their FSF licences.
Packaging
The package has no working upgrade path: the new transitional iperf package has no Depends on iperf-client and iperf-client has no Breaks/Replaces on the old iperf, contrary to the split pattern in Policy 7.6.1, so upgrading removes /usr/bin/iperf or collides over it. In addition src/Makefile.in still lists the deliberately removed src/service.c, which the shipped configure/build setup cannot regenerate, so the package cannot build; the installed man page advertises ---eportstyle instead of --reportstyle; iperf-server is Architecture: any although it ships only a systemd unit; and the transitional package uses the deprecated Priority: extra.
Issues
blocker licensing 1. Vendored Apache-2.0 L4STeam Prague code is described as NCSA and has no Apache or holder entry ◂
- Files:
debian/copyright:9-14,src/prague_cc.cpp,include/prague_cc.h,src/prague_cc.LICENSE,src/prague_cc.UPSTREAM,contrib/udp_prague/LICENSE,contrib/udp_prague/UPSTREAM,Makefile.am:6 - Basis: checked, in the package or with a reference tool
- Evidence: debian/copyright has
Files: *...License: NCSAand no other stanza matches these paths;src/prague_cc.LICENSE:1isApache License / Version 2.0; Makefile.am calls include/prague_cc.h and src/prague_cc.cpp 'vendored unmodified from L4STeam/udp_prague', and contrib/udp_prague/LICENSE is the same Apache-2.0 text. - Problem: The only stanza matching src/prague_cc.cpp, include/prague_cc.h, src/prague_cc.LICENSE and everything under contrib/udp_prague/ claims NCSA. The code is Apache-2.0, the Apache licence text is not referenced or reproduced in debian/copyright, and no holder of that code is named anywhere in the Debian copyright file (src/prague_cc.cpp itself has no header). Apache-2.0 is DFSG-free and compatible with the rest, but debian/copyright does not describe the licensing of these files, which is a DEP-5 accuracy failure. (The code is not compiled by the Debian build: configure.ac enables UDP_L4S only with --enable-professional, which debian/rules does not pass, but it is part of the source package.)
- Fix: Add a Files stanza for src/prague_cc.cpp, include/prague_cc.h, src/prague_cc.LICENSE and contrib/udp_prague/* naming the L4STeam/udp_prague authors as Copyright and
License: Apache-2.0, with the stand-alone Apache-2.0 paragraph pointing to /usr/share/common-licenses/Apache-2.0.
blocker licensing 2. flows/test_rig.py ships a literal license placeholder and no licence grant ◂
- Files:
flows/test_rig.py:1-6,debian/copyright:36-40 - Basis: checked, in the package or with a reference tool
- Evidence: flows/test_rig.py head:
# * Copyright (c) 2025,# * Umber Networks,# * All Rights Reserved., then# ... [License Header] ...and no grant; debian/copyright's Umber stanza names only flows/discover_rig.py and flows/ssh_nodes.py, so this file falls underFiles: *, which names UIUC, Broadcom and Robert J. McMahon, not Umber Networks. - Problem: The file claims 'All Rights Reserved' and then leaves the licence text as a placeholder, so it grants nothing. It is neither covered by the Umber BSD-3-clause stanza nor by a holder named in
Files: *. A file with no licence grant cannot be distributed, and the copyright file does not accurately describe it. - Fix: Have upstream replace the placeholder with the BSD-3-Clause header used by flows/discover_rig.py and flows/ssh_nodes.py, and add flows/test_rig.py to the Umber Networks stanza; if the file is instead under the project's NCSA licence, say so in a stanza that names Umber Networks.
important licensing 3. Files: * does not name The Regents of the University of California (LBNL), named in LICENSE:84 ◂
- Files:
LICENSE:84,debian/copyright:9-13 - Basis: checked, in the package or with a reference tool
- Evidence: LICENSE:84:
"iperf, Copyright (c) 2014-2021, The Regents of the University of California, through Lawrence Berkeley National Laboratory ... All rights reserved."; the Files: * Copyright list has only UIUC, Broadcom and Robert J. McMahon. - Problem: A copyright holder stated in the source tree is not represented in debian/copyright. The pre-review scan flagged exactly this line.
- Fix: Add
2014-2021 The Regents of the University of California, through Lawrence Berkeley National Laboratoryto the Files: * Copyright list, or give LICENSE its own stanza naming it.
important licensing 4. Autotools-generated files are described as NCSA instead of their FSF licences ◂
- Files:
debian/copyright:9-14,Makefile.in:4,src/Makefile.in:4,compat/Makefile.in:4,include/Makefile.in:4,doc/Makefile.in:4,flows/Makefile.in:4,man/Makefile.in:4,config.guess:4,config.sub:4,compile:7,depcomp:7,missing:6,test-driver:5 - Basis: checked, in the package or with a reference tool
- Evidence: Makefile.in:
Copyright (C) 1994-2025 Free Software Foundation, Inc.andThis Makefile.in is free software; the Free Software Foundation gives unlimited permission to copy and/or distribute it, with or without modifications, as long as this notice is preserved.; config.guess/config.sub:GNU General Public License ... either version 3 ... or any later versionplus the Autoconf exception; compile, depcomp, missing and test-driver: GPL-2+ with the same Autoconf exception. - Problem: All of these match only
Files: *, which says NCSA. Only aclocal.m4 (FSFULLR), configure (FSFUL) and install-sh (X11) have stanzas. The licence of the generated build infrastructure is therefore misdescribed in the copyright file. - Fix: Add stanzas:
Files: Makefile.in */Makefile.inwithLicense: FSFULLR;Files: config.guess config.subwithLicense: GPL-3+ with Autoconf exception;Files: compile depcomp missing test-driverwithLicense: GPL-2+ with Autoconf exception, plus the stand-alone paragraph for the GPL-2+ Autoconf exception (the existing 'GPL-3+ with Autoconf-2.0~Archive exception' text is a different exception).
important packaging 5. The iperf to iperf-client split lacks Depends and Breaks/Replaces, so upgrades lose /usr/bin/iperf or hit a file conflict ◂
- Files:
debian/control:13-21,debian/control:24-36,debian/iperf-client.install:1 - Basis: checked, in the package or with a reference tool
- Evidence:
Package: iperf/Architecture: allwith no Depends field, although its Description says it eases upgrading to iperf-client;Package: iperf-clienthas noBreaks/Replaces, yet it shipsusr/bin/*andusr/share/man/man1/*, which the old iperf package shipped. - Problem: Policy 7.6.1 gives the exact pattern for a package split: the new package Replaces and Breaks the old one (<< new version), and the old package Depends on the new one. Here an upgrade of iperf installs an empty package and removes the iperf binary and man page, and if iperf-client is unpacked while the old iperf is still installed dpkg must refuse the file overwrite.
- Fix: Add
Depends: iperf-client (>= 2.2.2+dfsg-2~)to the iperf stanza, andBreaks: iperf (<< 2.2.2+dfsg-2~)andReplaces: iperf (<< 2.2.2+dfsg-2~)to iperf-client.
minor licensing 6. debian/copyright has Upstream-Contact: FIXME ◂
- Files:
debian/copyright:3 - Basis: checked, in the package or with a reference tool
- Evidence:
Upstream-Contact: FIXME - Problem: The field is a placeholder rather than the upstream contact, leaving the DEP-5 header unfinished.
- Fix: Put the iperf2 upstream maintainer/contact (or the project mailing list) in Upstream-Contact.
minor packaging 7. The transitional iperf package uses the deprecated Priority: extra ◂
- Files:
debian/control:15 - Basis: checked, in the package or with a reference tool
- Evidence:
Priority: extra - Problem: Policy 2.5 says 'extra' is deprecated and should be treated as 'optional'; it should be 'optional' now.
- Fix: Change
Priority: extratoPriority: optional.
minor packaging 8. iperf-server is Architecture: any although it ships only architecture-independent files ◂
- Files:
debian/control:38-41,debian/iperf-server.service - Basis: checked, in the package or with a reference tool
- Evidence:
Package: iperf-server/Architecture: any; there is no debian/iperf-server.install, and the package's only content is the systemd unit installed by dh_installsystemd plus the shared changelog/copyright. - Problem: The package contains no compiled or otherwise architecture-dependent files, so declaring it 'any' produces an identical copy for every architecture and needlessly blocks it where iperf-client is not built.
- Fix: Change iperf-server to
Architecture: all.
minor packaging 9. The installed man page advertises a nonexistent option '---eportstyle' ◂
- Files:
man/iperf.1:130,debian/patches/debian/0001-fix-hyphen-used-as-minus-sign.patch - Basis: checked, in the package or with a reference tool
- Evidence: man/iperf.1:130
.BR \-y ", " \-\-\-eportstyle " C|c"; src/Locale.c:234 and src/Settings.cpp:212 give the real option as-y, --reportstyle. - Problem: The hyphen-escaping patch mangled
--reportstyleinto---eportstyle, so the installed man page documents an option that does not exist. - Fix: Correct the line (and the patch) to
\-\-reportstyle.
minor packaging 10. src/Makefile.in still lists service.c, which is not in the tarball, so the build cannot produce iperf ◂
- Files:
src/Makefile.in:389-393,src/Makefile.in:152-164,debian/patches/debian/0003-delete-service.patch,configure.ac:13,debian/control:5-7 - Basis: inferred from what was read, not seen directly
- Evidence: src/Makefile.in:
iperf_SOURCES = ... main.cpp service.c ...andam_iperf_OBJECTS = ... main.$(OBJEXT) service.$(OBJEXT) ...; service.c is absent from iperf_2.2.2+dfsg.orig.tar.xz (Files-Excluded); 0003 patches only src/Makefile.am; configure.ac:13 hasAM_MAINTAINER_MODE([disable]), so configure substitutes MAINTAINER_MODE_TRUE='#' and the$(srcdir)/Makefile.in:rebuild rule has no prerequisites; autoconf/automake are not in Build-Depends. - Problem: With maintainer mode disabled there is no automake run to regenerate Makefile.in, so make compiles from the shipped src/Makefile, which requires service.o from the removed src/service.c. The build fails with no rule to make service.c. The 0003 patch was refreshed but never covered Makefile.in.
- Fix: Extend 0003 to also drop service.c/service.o from src/Makefile.in (and service.h from include/Makefile.in's EXTRA_DIST), or regenerate Makefile.in from the patched Makefile.am and ship that, removing the patch.
Verified ◂
- Read debian/copyright in full; it is DEP-5 format with the correct Format URL. Files-Excluded names include/service.h and src/service.c, and both are absent from the unpacked tree and from iperf_2.2.2+dfsg.orig.tar.xz, so the Microsoft 'All Rights Reserved' files are genuinely removed.
- Grepped the whole tree (passing over .pc/) for copyright/licence/SPDX wording and read every LICENSE, COPYING and NOTICE-like file; covered src/, include/, compat/, flows/, contrib/, doc/, man/, m4/, t/, tools/ and the top level.
- Licence evidence matched to the tree: NCSA (UIUC/Broadcom/Robert J. McMahon) in src/, include/, compat/, doc/ and the top-level README/LICENSE/COPYING; Umber Networks BSD-3-clause in flows/discover_rig.py and flows/ssh_nodes.py; ISC in compat/inet_ntop.c and inet_pton.c; X11 in install-sh; LGPL-2+ in src/gnu_getopt.c, src/gnu_getopt_long.c and include/gnu_getopt.h; BSD-2-clause in src/dscp.c; FSFUL in configure; FSFULLR in aclocal.m4; GPL-3+ with Autoconf exception in m4/ax_pthread.m4; GPL-3+ in NEWS.md; Apache-2.0 in src/prague_cc.LICENSE and contrib/udp_prague/LICENSE.
- The Prague congestion-control code under src/prague_cc.cpp/h is not compiled by the Debian build: configure.ac gates UDP_L4S on --enable-professional and debian/rules passes only --enable-fastsampling. It still ships in the source package.
- Document figures doc/tcp_.png, doc/udp_l4s_.png, doc/bounceback_*.png and doc/dast.gif are images referenced by doc/index.html and doc/ui_license.html and carry no extra licence; man/iperf-manpage.html is generated from man/iperf.1, which is present. No compiled binaries, object files, minified code, archives or PDFs are in the tree.
- Read every file under debian/ (control, rules, changelog, copyright, iperf-client.install, iperf-server.service, lrc.config, ufw/iperf, source/format, all four patches and series) and sampled the 1250-line hyphen patch, whose result in man/iperf.1 was checked directly.
- The t/ directory is upstream's own 49-script test suite; debian/rules disables it with
override_dh_auto_testand there is no debian/tests/control. Not reported as an issue, only noted. - debian/lrc.config is a license-reconcile ignore list; no binary package installs it and it has no effect on the build.
- dh-sequence-installsysusers is provided by debhelper 14.5 (apt-cache); dh_installsystemd is in the default dh sequence at compat 14 and installs debian/iperf-server.service into iperf-server. The trailing commas in Build-Depends and iperf-server's Depends are accepted by Dpkg::Deps::deps_parse, so they are not reported.
- The install destinations in debian/iperf-client.install are directories without a trailing slash, which dh_install(1) accepts, so the ufw profile and HTML docs are installed inside the named directories.
- uscan found the packaged version as the newest upstream release (upstream
2.2.2, packaged2.2.2+dfsg). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (GPL-2,GPL-3,LGPL-2).
Not confirmed ◂
- No build was run (none is possible in this review); the failure over src/service.c follows from the shipped files but was not exercised.
- The provenance of the binary documentation images (doc/*.png, doc/dast.gif) beyond the project documentation could not be inspected without opening them.
- README names an android/ directory that is not present in the tarball; no licensing consequence for the shipped source, but the build instructions for the Android client point nowhere.
- Whether iperf normally exits with status 1 (debian/iperf-server.service sets SuccessExitStatus=1) was not verified.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader rejected this upload in response to the review.
Review Information
rejected — allocated to dfsg-uploader 8 hours ago, started 8 hours ago, completed 8 hours ago.
Final Comment
The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.