Review: jaraco.logging 3.4.0-1
Package Information
| Description | routines to integrate argparse with logging jaraco.logging is a library of routines to integrate the ‘argparse’ module with ‘logging’. |
|---|---|
| Maintainer | Ben Finney <bignose@debian.org> |
| Changed By | Ben Finney <bignose@debian.org> |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/bignose/pkg-jaraco.logging.git (browse) |
| Closes | #1010782 |
| Blocked Bugs | #783396 (normal) |
| Tracker | https://tracker.debian.org/pkg/jaraco.logging |
| Uploaded | 25 days ago |
New Package Report
.changes
| Changed-By | Ben Finney <bignose@debian.org> |
|---|---|
| Architecture | source all |
| Distribution | unstable |
| Date | Tue, 13 Oct 2026 20:43:33 +1100 |
| Source | jaraco.logging |
| Version | 3.4.0-1 |
Changelog
jaraco.logging (3.4.0-1) unstable; urgency=medium
.
* Initial Debian release.
Closes: bug#1010782..dsc
| Section | python |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | python3-jaraco.logging deb python optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: jaraco.logging
Upstream-Contact: Jason R. Coombs <jaraco@jaraco.com>
Source: https://github.com/jaraco/jaraco.logging/
Files: *
Copyright:
© 2009–2024 Jason R. Coombs <jaraco@jaraco.com>
License: Expat
Files: debian/*
Copyright:
© 2010–2024 Ben Finney <bignose@debian.org>
License: GPL-3+
License-Grant:
This is free software: you may copy, modify, and/or distribute this work
under the terms of the GNU General Public License as published by the
Free Software Foundation; version 3 of that license or any later version.
No warranty expressed or implied.
License: Expat
Permission is hereby granted, free of charge, to any person obtaining a
copy of this software and associated documentation files (the "Software"),
to deal in the Software without restriction, including without limitation
the rights to use, copy, modify, merge, publish, distribute, sublicense,
and/or sell copies of the Software, and to permit persons to whom the
Software is furnished to do so, subject to the following conditions:
.
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
DEALINGS IN THE SOFTWARE.
License: GPL-3+
On Debian systems, the complete text of the GNU General Public License
version 3 can be found in the file ‘/usr/share/common-licenses/GPL-3’.
# Local variables:
# coding: utf-8
# mode: debian-copyright
# fill-column: 78
# End:
# vim: fileencoding=utf-8 textwidth=78 :
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 3 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 25 days ago.
Proposes a replacement debian/watch:
debian/watch in version 5 format
Report
DFSG NEW review for jaraco.logging version 3.4.0-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 3 minor
- debian/watch: old format (version 4)
- debian/copyright: machine-readable
Licensing
All upstream files are MIT/Expat, accurately covered by the Files: * stanza attributing Jason R. Coombs; Debian packaging files are GPL-3+ for Ben Finney. The complete Expat text is reproduced in debian/copyright and GPL-3+ references /usr/share/common-licenses/GPL-3. The only licence-bearing files in the tree are LICENSE and the PKG-INFO/egg-info metadata, all MIT. No vendored code, no prefab binary/minified artifacts, no non-free clauses (no NC/ND, no field-of-use restrictions), and the two licences are compatible.
Packaging
Clean pybuild/pyproject build using debhelper compat 14, correct Build-Depends for the declared PEP 517 backend tools (setuptools>=77, setuptools-scm, coherent.licensed), a sensible python3-jaraco.logging binary (Arch: all) whose sole runtime dependency tempora is pulled in via ${python3:Depends}, a functioning autopkgtest that runs the upstream doctests against the installed module, and sane VCS/changelog/Standards-Version fields. Only minor, cosmetic leftovers; nothing a sponsor would require fixing.
Issues
minor
licensing
1. Shipped LICENSE file has an unfilled Copyright ... <copyright holders> placeholder
◂
- Files:
LICENSE - Evidence:
Copyright (c) 2025 <copyright holders> - Problem: The upstream MIT licence file in the tarball names no actual holder, so the licence notice Debian must reproduce is only accurate because
debian/copyrightindependently attributes© 2009–2024 Jason R. Coombs. This is the jaraco skeleton template —coherent.licensed(listed in[build-system] requires) rewrites it with the real holder at wheel-build time — so it is not a DFSG problem and the installed wheel is expected to carry the fixed notice. - Fix: No Debian change strictly required; optionally confirm the built wheel's
LICENSEnames Jason R. Coombs and otherwise keep the accuratedebian/copyrightattribution as-is.
minor
packaging
2. PYBUILD_INSTALL_ARGS with --install-option is dead configuration for the pyproject build system
◂
- Files:
debian/rules:12-13 - Evidence:
export PYBUILD_INSTALL_ARGS ?= --install-option="--install-layout=deb" - Problem: With
PYBUILD_SYSTEM := pyproject, pybuild's pyproject plugin installs the built wheel with the PEP 517installerand never reads install args (only the distutils plugin did), so this variable is ignored; the--install-optionform was also removed from modern setuptools/pip. It suggests--install-layoutthat no longer applies and misleads future maintainers. - Fix: Delete the two lines (and the surrounding comment noise) from
debian/rules;dh-pythonalready installs to the Debian layout.
minor packaging 3. debian/watch is in the old version 4 format ◂
- Files:
debian/watch - Evidence:
version = 4 - Problem: Version 5 is the current format of
debian/watch. - Fix: Convert it to version 5; a mechanical conversion is under Proposed changes.
Verified ◂
- Read
debian/copyrightin full: DEP-5 1.0 format, two Files stanzas (*→ Expat,debian/*→ GPL-3+), complete Expat text, GPL-3+ referring to /usr/share/common-licenses/GPL-3. - Inventory each upstream file (top-level,
jaraco/,docs/,jaraco.logging.egg-info/, dot-config files,.github/) against the .orig tarball listing; every file is MIT/Expat and covered by theFiles: *stanza. - Grep of the whole tree for licence markers (Copyright, ©, SPDX, GPL/LGPL/Apache/MPL, public domain, All rights reserved, sublicense, non-commercial, etc.): only LICENSE, PKG-INFO and egg-info metadata carry licence text, all MIT.
- Read LICENSE, PKG-INFO,
jaraco/logging.py, pyproject.toml, setup.cfg, pytest.ini, docs/conf.py, NEWS.rst, README.rst. - Checked for compiled/binary artifacts (.jar/.class/.so/.pyc/minified JS/CSS/fonts/images): none present; no embedded copies of third-party code.
- Read every debian/ file: control, rules, changelog, source/format, clean, gbp.conf, salsa-ci.yaml, upstream/metadata, tests/control, tests/upstream-testsuite, tests/pkg-python/import-name, source/options, source/lintian-overrides, README.source.
- Confirmed all Build-Depends names exist in the archive at satisfying versions via apt-cache (pybuild-plugin-pyproject, python3-setuptools 84>=77, python3-setuptools-scm, python3-coherent.licensed, python3-tempora, python3-pytest, python3-ruff, dh-python, debhelper-compat 14).
- Verified via installed dh-python source (pybuild pyproject plugin) that the PEP 517 install step uses
installerand ignoresPYBUILD_INSTALL_ARGS. - Checked changelog (initial upload, Closes bug#1010782, distribution unstable) and that Policy's current version is 4.7.4.1 against the declared Standards-Version 4.7.4.
- uscan found the packaged version as the newest upstream release (upstream
3.4.0, packaged3.4.0).
Not confirmed ◂
- No build was run (read-only review), so the binary build/install/autopkgtest steps were reasoned about rather than observed.
- The wheel's generated LICENSE content (what
coherent.licensedinjects at build time) was not inspected. debian/watchis reviewed separately by the harness and was not assessed here.
Proposed: debian/watch in version 5 format ◂
debian/watch is in an old format. This is the conversion made by uscan --update-watchfile, which has not been run against the upstream site: some defaults differ in version 5, so test it with uscan --report before use.
Version: 5
# debian/watch
# Debian UScan configuration for this package.
# Manual page: ‘uscan(1)’.
# Version of the UScan configuration format for this file.
# Public releases at Debian redirector for Python Package Index.
Source: https://pypi.debian.net/@PACKAGE@/
Matching-Pattern: @PACKAGE@-@ANY_VERSION@@ARCHIVE_EXT@
Pgpmode: none
Update-Script: uupdate
Uversionmangle: s/(\d)-?((?:rc|a|b|c)\d*)$/$1~$2/
Review Information
accepted — allocated to awm 24 days ago, started 24 days ago, completed 24 days ago.