libbits 0.0~git20261030.c449567-1
Package Information
| Description | succinct utilities to handle bits Libbits is a C++ collection of basic data structures, including: * bitvectors with rank/select queries; * compact vectors (vectors of fixed-size integers); * Elias-Fano sequences; * integer codes (unary, binary, gamma, delta, Rice). |
|---|---|
| Maintainer | Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org> |
| Changed By | Andreas Tille <tille@debian.org> |
| Sponsor | tille@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/med-team/libbits.git (browse) |
| Closes | #1154431 |
| Tracker | https://tracker.debian.org/pkg/libbits |
| Uploaded | 8 hours ago |
New Package Report
.changes
| Source | libbits |
|---|---|
| Version | 0.0~git20261030.c449567-1 |
| Changed-By | Andreas Tille <tille@debian.org> |
| Architecture | source all |
| Distribution | unstable |
| Date | Thu, 19 Nov 2026 11:22:36 +0100 |
Changelog
libbits (0.0~git20261030.c449567-1) unstable; urgency=medium . * Initial release (Closes: #1154431)
.dsc
| Section | libdevel |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | libbits-dev deb libdevel optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: libbits Upstream-Contact: Giulio Ermanno Pibiri Source: https://github.com/jermp/bits/ Files: * Copyright: 2024 Giulio Ermanno Pibiri License: Expat Files: debian/* Copyright: 2026 Andreas Tille <tille@debian.org> License: Expat Files: debian/missing-sources/essentials.hpp Copyright: 2019-2026 Giulio Ermanno Pibiri Comment: This header is the contents of the external/essentials git submodule of the upstream bits repository (https://github.com/jermp/essentials), commit 9da682ff4809ed6a45b81a6785313a9b60e50699. It is not part of the upstream tarball itself and is therefore shipped as a missing source file. License: Expat License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 1 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 7 hours ago.
Report
DFSG NEW review for libbits version 0.0~git20261030.c449567-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: No
- Issues: 0 blocker, 1 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
debian/copyright is DEP-5 with the exact Format URL, and its three stanzas plus the stand-alone Expat paragraph match the tree. The only copyright/licence statement outside it is LICENSE (Copyright 2024 Giulio Ermanno Pibiri, MIT/Expat), which covers the whole upstream tree; the separately shipped debian/missing-sources/essentials.hpp has its own later stanza with holder, year range and Comment documenting the submodule commit. No non-free or unclear wording appears anywhere, and no file lacks a licence statement. The one residual uncertainty is the licence evidence for the missing-sources header itself, which is not shipped.
Packaging
The packaging is otherwise small and sound: debhelper compat 14, correct build-dependencies, DEP-3 patches, a working autopkgtest that builds the installed examples against the installed headers, and salsa CI. One important defect remains: the binary is Architecture: all (and Multi-Arch: foreign) although the source is deliberately restricted to 64-bit little-endian and compact_vector::access() is byte-order dependent, so the headers are installed on big-endian architectures where the access-based API returns wrong results.
Issues
important packaging 1. Architecture: all and Multi-Arch: foreign ship little-endian-only headers to big-endian architectures ◂
-
Files:
debian/control,debian/tests/control,include/compact_vector.hpp:253-258 -
Basis: checked, in the package or with a reference tool
-
Evidence:
Architecture: all,Multi-Arch: foreign,Build-Depends: ... architecture-is-64-bit, architecture-is-little-endian, ...; and incompact_vector::access():std::memcpy(&word, ptr + (pos >> 3), sizeof(uint64_t)); return (word >> (pos & 7)) & m_mask; -
Problem: Policy 5.6.8:
all"indicates an architecture-independent package", and Policy 5.6.34.2 forbidsMulti-Arch: foreignwhen the installed files' behaviour depends on the architecture.access()reinterprets theuint64_tword array as bytes and shifts, which only yields the stored value on a little-endian machine; on big-endian s390x/ppc64 the copied word is byte-swapped.elias_fano::access(),endpoints_sequence::access(),ranked_sequence::access(),rice_sequence::access()andsdc_sequence::access()all call it, so most of the advertised API is wrong there. The build restriction shows the maintainer already treats the code as little-endian-only, but the arch:all binary is nonetheless installed on every architecture, andMulti-Arch: foreignlets other packages' builds use it anywhere. -
Fix: Either make
access()byte-order independent (assemble the 64-bit word from the bytes, or read it via theuint64_tarray with a shift/next-word fallback), then droparchitecture-is-little-endianand the tests'Architecturelist and keepArchitecture: all; or, if the code stays little-endian-only, buildArchitecture: anywithMulti-Arch: same(dropMulti-Arch: foreign) so the headers exist only on the architectures where they work.
Verified ◂
- Shipped tree read: LICENSE, README.md, CMakeLists.txt, .gitmodules, .github/workflows/build.yml, all 12 include/.hpp, test/, perf/*, and every file under debian/ except watch (checked separately) and the ignored .pc/ directory.
- The pre-scan's author check covered 34 files and found every holder named; a grep for Copyright/(C)/©/SPDX-License-Identifier/permission/GNU/Apache/MPL/public-domain wording confirms the only copyright and licence statement outside debian/copyright is LICENSE.
- debian/copyright is copyright-format 1.0 with the exact Format URL: Files: * (2024 Giulio Ermanno Pibiri, Expat), debian/* (2026 Andreas Tille, Expat) and a later Files: debian/missing-sources/essentials.hpp stanza (2019-2026, Expat, commit documented). Later-stanza precedence gives that file its own stanza, and the stand-alone Expat paragraph reproduces the permission text.
- No non-commercial, no-modification, field-of-use, CC-*-NC/ND, JSON 'Good, not Evil' or similar wording in the tree; grep returned nothing.
- external/essentials and external/doctest are empty directories (submodules absent from the orig tarball); doctest comes from doctest-dev through use-system-doctest.patch, and essentials.hpp is supplied as debian/missing-sources/essentials.hpp, which the build patch adds to the include path.
- include/util.hpp's select_in_word is adapted from the public-domain Bit Twiddling Hacks and says so in the comment; rank9.hpp and darray.hpp only cite papers, they copy no separate code.
- No built files, minified code, archives, PDFs, images or fonts in the tree; the .pc/ directory and debian/cargo-checksum.json are absent or ignored.
- Build dependencies resolve in the archive: cmake 4.4.5, doctest-dev 2.5.3, debhelper-compat, and architecture-is-64-bit/architecture-is-little-endian provided by architecture-properties 0.2.6+b2.
- Packaging mechanics: source format 3.0 (quilt); compat 14; both patches have Author/Description/Forwarded/Last-Update and their effects are present in the tree; changelog is a first release to unstable closing #1154431; Vcs-* agree with the Salsa URLs; Standards-Version 4.7.4 matches Policy 4.7.4.1 (first two components, not an issue); no maintainer scripts.
- The autopkgtest compiles the installed examples against the installed headers: rules' sed rewrites the
"include/*.hpp"and"external/doctest/..."includes, pkg-config supplies-I/usr/include/libbits, and test/common.hpp's"essentials.hpp"is installed there by libbits-dev.install. - uscan found the packaged version as the newest upstream release (upstream
0.0~git20261030.c449567, packaged0.0~git20261030.c449567).
Not confirmed ◂
- The Expat licence debian/copyright attributes to debian/missing-sources/essentials.hpp cannot be confirmed from the package: the header carries no copyright or licence notice, and the essentials submodule and its LICENSE are not shipped; the copyright file states the holder and licence.
- Whether architecture-is-64-bit is additionally required (the tests could not be run on a 32-bit host); only the little-endian requirement is evidenced by compact_vector::access().
- Why the model asked for what a review has no use for. During this review it asked once for something outside the package and the reviewing system (another file of the sandbox, or a URL), or was given part of the review tooling's own configuration, and that was refused or withheld. A model does this when something it has read tells it to, so look in the package for text addressed to a reviewing program, and treat this report with suspicion. Refused:
read: "xd://read/sources" is not a file of the package or of the reviewing system.
Proposed changes ◂
None.
Uploader's response to the LLM review
I've just pushed:
commit e2b14b88ad2f31cb0b46452953307e0db5fa4675 (HEAD -> master, origin/master, origin/HEAD)
Author: Andreas Tille tille@debian.org
Date: Thu Nov 19 13:42:56 2026 +0100
Make sure the package will not be installed on architectures where it is broken
diff --git a/debian/control b/debian/control
index 0e00c4d..ae11172 100644
--- a/debian/control
+++ b/debian/control
@@ -14,8 +14,7 @@ Vcs-Git: https://salsa.debian.org/med-team/libbits.git
Homepage: https://github.com/jermp/bits/
Package: libbits-dev
-Architecture: all
-Multi-Arch: foreign
+Architecture: any
Depends: ${misc:Depends}
Suggests: doctest-dev
Description: succinct utilities to handle bits
— Andreas Tille (tille), 6 hours ago