libfossil 0.6.1+ds-1
Package Information
| Description | shared library for working with Fossil SCM repositories The libfossil library provides functions for accessing and manipulating Fossil repository databases, checkouts, artifacts, manifests, and other data. This package contains the shared library necessary to run programs compiled with libfossil. |
|---|---|
| Maintainer | Harsha Bhattacharyya <harshabhattacharyya@disroot.org> |
| Changed By | Harsha Bhattacharyya <harshabhattacharyya@disroot.org> |
| Distribution | unstable |
| Architecture | any all |
| VCS | git: https://salsa.debian.org/debian/libfossil.git (browse) |
| Closes | #1153222 |
| Tracker | https://tracker.debian.org/pkg/libfossil |
| Uploaded | 2 hours ago |
New Package Report
.changes
| Source | libfossil |
|---|---|
| Version | 0.6.1+ds-1 |
| Changed-By | Harsha Bhattacharyya <harshabhattacharyya@disroot.org> |
| Architecture | source amd64 all |
| Distribution | unstable |
| Date | Mon, 09 Nov 2026 09:53:53 +0000 |
Changelog
libfossil (0.6.1+ds-1) unstable; urgency=medium . * Initial release. (Closes: #1153222)
.dsc
| Component | main |
|---|---|
| Package-List | libfossil-dev deb libdevel optional arch=any libfossil-doc deb doc optional arch=all libfossil0 deb libs optional arch=any |
| Section | libdevel |
| Priority | optional |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://fossil.wanderinghorse.net/r/libfossil
Upstream-Name: libfossil
Upstream-Contact: Stephan Beal <stephan@wanderinghorse.net>
Comment: The excluded files are DFSG-free but are not needed to build the
library: an embedded copy of jimsh, bundled third-party sources (extsrc/),
client applications, language bindings, and Fossil checkout metadata.
Files-Excluded: autosetup/jimsh0.c
bindings/*
client/*
doc/*.md
extsrc/*
f-apps/*
include/libfossil.hpp
resources/*
sql/q-*.sql
sql/snippets.txt
manifest*
sanity-check.sh
LICENSES/README.md
LICENSES/Simplified-BSD.txt
LICENSES/SPDX-header-for-*.txt
tools/c-struct.sh
tools/pull-patches-from-ram-drive.sh
tools/mkccode.tcl
tools/schema-info-views.sql
tools/transport-command
autosetup/pkg-config.tcl
autosetup/teaish/*
autosetup/local.tcl
autosetup/README.autosetup
Files: *
Copyright: 2013-2021 The Libfossil Authors
License: BSD-2-clause
Copyright 2013-2021 Stephan Beal, the Libfossil authors and contributors.
.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
.
1. Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.
.
2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
Comment:
The documentation is only CC-BY-SA-4.0 when built (doc/libfossil-API-html)
and installed (/usr/share/doc/libfossil/html/).
Files:
debian/*
Copyright: 2026 Harsha Bhattacharyya <harshabhattacharyya@disroot.org>
License: Unlicense
This is free and unencumbered software released into the public domain.
.
Anyone is free to copy, modify, publish, use, compile, sell, or
distribute this software, either in source code form or as a compiled
binary, for any purpose, commercial or non-commercial, and by any
means.
.
In jurisdictions that recognize copyright laws, the author or authors
of this software dedicate any and all copyright interest in the
software to the public domain. We make this dedication for the benefit
of the public at large and to the detriment of our heirs and
successors. We intend this dedication to be an overt act of
relinquishment in perpetuity of all present and future rights to this
software under copyright law.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR
OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
OTHER DEALINGS IN THE SOFTWARE.
.
For more information, please refer to <https://unlicense.org/>
Files: src/sha1.c
Copyright: 2017 Marc Stevens <marc@marc-stevens.nl>
2017 Dan Shumow <danshu@microsoft.com>
License: Expat
MIT License
.
Copyright (c) 2017:
Marc Stevens
Cryptology Group
Centrum Wiskunde & Informatica
P.O. Box 94079, 1090 GB Amsterdam, Netherlands
marc@marc-stevens.nl
.
Dan Shumow
Microsoft Research
danshu@microsoft.com
.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
.
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
Files: src/popen.c src/zip.c src/utf8.c src/sha3.c
Copyright: 2010, 2017 D. Richard Hipp
License: BSD-2-clause
Copyright 2007 D. Richard Hipp. All rights reserved.
.
Redistribution and use in source and binary forms, with or
without modification, are permitted provided that the
following conditions are met:
.
1. Redistributions of source code must retain the above
copyright notice, this list of conditions and the
following disclaimer.
.
2. Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the
following disclaimer in the documentation and/or other
materials provided with the distribution.
.
THIS SOFTWARE IS PROVIDED BY THE AUTHORS ``AS IS'' AND ANY EXPRESS
OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHORS OR CONTRIBUTORS BE
LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
.
The views and conclusions contained in the software and documentation
are those of the authors and contributors and should not be interpreted
as representing official policies, either expressed or implied, of anybody
else.
Files: src/md5.c
Copyright: none
Comment: Written by Colin Plumb in 1993.
License: public-domain
This code was written by Colin Plumb in 1993, no copyright is claimed. This code is in the public domain; do with it what you wish.
Files: src/xdirent.h
Copyright: 2006-2012 Toni Ronkko
License: Expat
Copyright (C) 2006-2012 Toni Ronkko
.
Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
``Software''), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:
.
The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED ``AS IS'', WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL TONI RONKKO BE LIABLE FOR ANY CLAIM, DAMAGES OR
OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
OTHER DEALINGS IN THE SOFTWARE.
Files: src/strftime.c
Copyright: none
Comment: Written by Arnold Robbins.
License: public-domain
Public-domain relatively quick-and-dirty implemenation of
ANSI library routine for System V Unix systems.
Files: autosetup/*
Copyright: 2006-2012, 2016 WorkWare Systems
License: BSD-2-clause
Copyright (c) 2010-2011, WorkWare Systems <http://workware.net.au/>
.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
.
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the following
disclaimer in the documentation and/or other materials
provided with the distribution.
.
THIS SOFTWARE IS PROVIDED BY THE WORKWARE SYSTEMS ``AS IS'' AND ANY
EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL WORKWARE
SYSTEMS OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
.
The views and conclusions contained in the software and documentation
are those of the authors and should not be interpreted as representing
official policies, either expressed or implied, of WorkWare Systems.
Files: src/ext_regexp.c autosetup/proj.tcl autosetup/wh-common.tcl
Copyright: none
License: public-domain
The author disclaims copyright to this source code. In place of
a legal notice, here is a blessing:
.
May you do good and not evil.
May you find forgiveness for yourself and forgive others.
May you share freely, never taking more than you give.
Files: autosetup/autosetup-config.guess autosetup/autosetup-config.sub
Copyright: 1992-2024 Free Software Foundation
License: GPL-3+ with Autoconf exception
This file is part of Autoconf. This program is free
software; you can redistribute it and/or modify it under the
terms of the GNU General Public License as published by the
Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
.
Under Section 7 of GPL version 3, you are granted additional
permissions described in the Autoconf Configure Script Exception,
version 3.0, as published by the Free Software Foundation.
.
You should have received a copy of the GNU General Public License
and a copy of the Autoconf Configure Script Exception along with
this program; see the files COPYINGv3 and COPYING.EXCEPTION
respectively. If not, see <http://www.gnu.org/licenses/>.
.
The GNU General Public License version 3 may be found on Debian systems
in /usr/share/common-licenses/GPL-3.
.
The Autoconf Configure Script Exception version 3 is below:
.
AUTOCONF CONFIGURE SCRIPT EXCEPTION
Version 3.0, 18 August 2009
.
Copyright (C) 2009 Free Software Foundation, Inc. <http://fsf.org/>
Everyone is permitted to copy and distribute verbatim copies
of this license document, but changing it is not allowed.
.
This Exception is an additional permission under section 7 of the GNU
General Public License, version 3 ("GPLv3"). It applies to a given
file that bears a notice placed by the copyright holder of the file
stating that the file is governed by GPLv3 along with this Exception.
.
The purpose of this Exception is to allow distribution of Autoconf's
typical output under terms of the recipient's choice (including
proprietary).
.
0. Definitions
.
"Covered Code" is the source or object code of a version of Autoconf
that is a covered work under this License.
.
"Normally Copied Code" for a version of Autoconf means all parts of
its Covered Code which that version can copy from its code (i.e., not
from its input file) into its minimally verbose, non-debugging and
non-tracing output.
.
"Ineligible Code" is Covered Code that is not Normally Copied Code.
.
1. Grant of Additional Permission.
.
You have permission to propagate output of Autoconf, even if such
propagation would otherwise violate the terms of GPLv3. However, if
by modifying Autoconf you cause any Ineligible Code of the version you
received to become Normally Copied Code of your modified version, then
you void this Exception for the resulting covered work. If you convey
that resulting covered work, you must remove this Exception in accordance
with the second paragraph of Section 7 of GPLv3.
.
2. No Weakening of Autoconf Copyleft.
.
The availability of this Exception does not imply any general presumption
that third-party software is unaffected by the copyleft requirements of
the license of Autoconf.
DFSG Assistant LLM REVIEW 1 blocker, 2 important, 4 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 1 hour ago.
Report
DFSG NEW review for libfossil version 0.6.1+ds-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: Yes
- Issues: 1 blocker, 2 important, 4 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: 2 found
Licensing
The code is DFSG-compliant: BSD-2-clause throughout src/, include/ and autosetup/, MIT for src/sha1.c's hardened code and src/xdirent.h, public domain for src/md5.c, src/strftime.c and src/ext_regexp.c, and GPL-3+ with the Autoconf exception for the two autosetup-config.* build scripts only; all are compatible in one binary, and the full texts are in debian/copyright. debian/copyright is nonetheless inaccurate for several files: the declared CC-BY-SA-4.0 of the generated HTML has no Files stanza and no licence text at all, src/schema.c's holder Stephan Beal is not in the Copyright field, and src/sha1.c, src/ext_regexp.h and src/difftk.tcl are described under holders and licences that do not match their contents.
Packaging
The packaging is competent and ordinary: debhelper compat 14 with dh, a three-way libs/libdevel/doc split with correct Multi-Arch, a symbols file with @Base 0.6.1 and Build-Depends-Package, five small well-attributed patches that only undo the repack (Build-Depends on jimsh/libsqlite3-dev/zlib1g-dev and Build-Depends-Indep on the doc tools are right), Standards-Version 4.7.4, and a doc-base entry that matches the installed path. The one defect is that debian/rules clean does not remove the doxygen output tree, contrary to Policy 4.9.
Issues
blocker licensing 1. The documentation declared CC-BY-SA-4.0 has no Files stanza and its licence text is not shipped ◂
- Files:
debian/copyright:58-60,LICENSES/CC-by-SA-4.0.txt:1-3 - Basis: checked, in the package or with a reference tool
- Evidence:
Comment:/The documentation is only CC-BY-SA-4.0 when built (doc/libfossil-API-html)/and installed (/usr/share/doc/libfossil/html/).and the only CC file in the tree:This is a human-readable summary of (and not a substitute for) the Creative Commons CC-by-SA license. A plain text version is available at https://creativecommons.org/licenses/by-nc-sa/4.0/legalcode.txt . - Problem: libfossil-doc ships the doxygen HTML, so its licence has to be stated in a Files stanza and its text included verbatim: Policy 12.5 requires a verbatim copy of every distribution licence in /usr/share/doc//copyright, and CC-BY-SA-4.0 is not one of the licences that may be referred to /usr/share/common-licenses. debian/copyright records it only in a Comment, with no Copyright holder and no licence text; the only CC text shipped is a human-readable summary (not the licence), and its link is to the by-nc-sa legalcode, i.e. to a non-free licence the documentation is not under. The Comment also names the wrong install path (libfossil, not libfossil-doc).
- Fix: Either state in a Files stanza that the generated HTML is BSD-2-clause like the headers it is generated from and drop the CC-BY-SA claim, or add
Files: doc/libfossil-API-html/*with the holder and the complete CC-BY-SA-4.0 text (and ship the full legalcode in LICENSES/), and correct the /usr/share/doc path in the Comment.
important
licensing
2. Files: * does not name Stephan Beal, the holder stated in src/schema.c
◂
- Files:
debian/copyright:34,src/schema.c:4 - Basis: checked, in the package or with a reference tool
- Evidence: debian/copyright
Copyright: 2013-2021 The Libfossil Authors; src/schema.cCopyright 2013-2021 Stephan Beal (https://wanderinghorse.net). - Problem: The Copyright field of the catch-all stanza names no holder matching src/schema.c, which is the only file in the tree carrying the old per-author header; Stephan Beal appears only inside the licence body text of the same stanza, which is not the holder field. The holder of that file is therefore not recorded in the copyright file.
- Fix: Add
Files: src/schema.cwithCopyright: 2013-2021 Stephan BealandLicense: BSD-2-clause, or add Stephan Beal to the Copyright field ofFiles: *.
important packaging 3. uscan reports a warning for debian/watch ◂
-
Files:
debian/watch -
Basis: found by the review tooling's own checks
-
Evidence:
Untrackable project: Upstream serves source only via manual fossil and doesn't publish release tarballs; track releases manually via https://fossil.wanderinghorse.net/r/libfossil/taglist -
Problem: uscan must run without errors or warnings and find the upstream releases.
-
Fix: Correct
debian/watchso thatuscan --reportruns cleanly.
minor
licensing
4. Files: src/sha1.c declares the whole file MIT though it also contains Steve Reid's public-domain SHA-1
◂
- Files:
debian/copyright:91-94,src/sha1.c:1444-1453 - Basis: checked, in the package or with a reference tool
- Evidence: stanza:
Files: src/sha1.c/Copyright: 2017 Marc Stevens <marc@marc-stevens.nl>/2017 Dan Shumow <danshu@microsoft.com>/License: Expat; src/sha1.c in the#elsebranch:SHA-1 in C / By Steve Reid <steve@edmweb.com> / 100% Public Domain(taken via NetBSD/OpenBSD). - Problem: Because this stanza overrides
Files: *for the whole file, the Steve Reid/public-domain implementation and the libfossil glue around both implementations are declared as MIT code of Stevens and Shumow only. Both licences are free, so the binary stays DFSG-compliant, but the copyright statement is wrong for a large part of the file. - Fix: Describe the whole file: add the public-domain SHA-1 (Steve Reid, via NetBSD/OpenBSD) and the Libfossil Authors' BSD-2-clause wrapper code to the stanza, using a combined
License:line such asExpat and BSD-2-clause and public-domain.
minor
licensing
5. Files: * misdescribes src/ext_regexp.h (public domain) and src/difftk.tcl (verbatim Fossil code)
◂
- Files:
debian/copyright:33-35,debian/copyright:231-233,src/ext_regexp.h:5-10,src/difftk.tcl:1-3 - Basis: checked, in the package or with a reference tool
- Evidence: src/ext_regexp.h carries the same
The author disclaims copyright to this source code. In place of a legal notice, here is a blessing:text as src/ext_regexp.c, but the public-domain stanza names onlyFiles: src/ext_regexp.c autosetup/proj.tcl autosetup/wh-common.tcl; src/difftk.tcl begins# This script was taken verbatim from the Fossil SCM project.and has no copyright or licence notice, so it falls underFiles: *(Copyright: 2013-2021 The Libfossil Authors,License: BSD-2-clause). - Problem: src/ext_regexp.h is public domain, not BSD-2-clause code of the Libfossil Authors, and src/difftk.tcl is third-party code from Fossil whose holder is not the libfossil authors. Neither is a DFSG problem (both are free), but the copyright file does not describe these files' provenance correctly, and difftk.tcl is compiled into the library as fsl_difftk_cstr.
- Fix: Add src/ext_regexp.h to the
public-domainstanza, and give src/difftk.tcl its own stanza naming the Fossil SCM project (D. Richard Hipp) as the source, with the licence Fossil distributes that script under.
minor
packaging
6. debian/rules clean leaves the generated doc/libfossil-API-html tree in the source
◂
- Files:
debian/rules:11-12,debian/clean:1,Makefile.in:430-437 - Basis: checked, in the package or with a reference tool
- Evidence:
execute_after_dh_auto_build-indep:runs$(MAKE) -C doc doc, whose doxygen output isHTML_OUTPUT = libfossil-API-html(doc/Doxyfile.in:1276), i.e. doc/libfossil-API-html/. The top-leveldistcleanonly doesrm -f doc/Doxyfile .clangd, and debian/clean contains onlysrc/difftk_cstr.c; nothing calls doc/GNUmakefile'sclean-doxy. - Problem: Policy 4.9 requires the clean target to undo the effects of build and binary. After a full build the source tree keeps the whole doxygen HTML tree, so the tree is no longer as unpacked and a later
dpkg-source -borgbp buildpackagefrom it fails to represent the new files. - Fix: Add
doc/libfossil-API-html/(ordoc/libfossil-API-*) to debian/clean, or add anoverride_dh_auto_cleanthat runs$(MAKE) -C doc clean-doxyafterdh_auto_clean.
minor packaging 7. Files-Excluded is set but debian/watch sets no repack suffix ◂
- Files:
debian/copyright,debian/watch - Basis: found by the review tooling's own checks
- Evidence:
0.6.1+ds-1 - Problem:
debian/copyrighthasFiles-Excluded, so uscan repacks the upstream tarball, butdebian/watchneither names the suffix the repacked version gets nor mangles the version. - Fix: Set
Repacksuffixindebian/watchto the suffix the version carries.
Verified ◂
- Read every file under debian/ in full (control, rules, changelog, copyright, the three .install files, doc-base, clean, gbp.conf, salsa-ci.yml, source/format, source/lintian-overrides, upstream/metadata, all five patches and series, and the head of libfossil0.symbols); .pc/ and debian/cargo-checksum.json were left unread.
- Inventoried the whole upstream tree (109 files across auto.def, Makefile.in, configure, autosetup/, doc/, include/, LICENSES/, sql/, src/, tools/) and grepped all of it for copyright, SPDX, licence and public-domain wording.
- Licence evidence matches the stanzas: BSD-2-clause headers (
SPDX-License-Identifier: BSD-2-Clause-FreeBSD) in all src/.c and include/fossil-scm/.h; MIT for src/sha1.c (Stevens/Shumow) and src/xdirent.h (Ronkko); public domain for src/md5.c (Colin Plumb), src/strftime.c (Arnold Robbins/Elm), src/ext_regexp.c and src/ext_regexp.h (SQLite blessing); the same blessing for autosetup/proj.tcl and autosetup/wh-common.tcl; D. Richard Hipp 2010/2017 for src/popen.c, src/zip.c, src/utf8.c and src/sha3.c; WorkWare Systems BSD-2 for the rest of autosetup/ (autosetup, cc*.tcl, tmake*, system.tcl, default.auto, autosetup-find-tclsh, LICENSE); GPL-3+ with the Autoconf exception in autosetup/autosetup-config.guess and -config.sub, which are build-time scripts only and never linked into the library. BSD-2, MIT and public domain combine without conflict. - src/schema__cstr.c and src/difftk_cstr.c are generated C arrays, not compiled objects: the former are checked in and their inputs (sql/.sql) ship; difftk_cstr.c is generated at build from src/difftk.tcl (auto.def
lFile2C) and removed by debian/clean. No binaries, minified files, PDFs, images or fonts are in the tree. - Every path in Files-Excluded is absent from the tree (autosetup/jimsh0.c, bindings/, client/, doc/.md, extsrc/, f-apps/, resources/, include/libfossil.hpp, sql/q-.sql, manifest*, LICENSES/README.md, tools/mkccode.tcl, autosetup/pkg-config.tcl, ...), and nothing that remains uses them; --disable-ncurses turns off the fnc build that would need client/.
- The
commercial or non-commercialline the scan pointed at (debian/copyright:70) is the Unlicense's permission grant (for any purpose, commercial or non-commercial, and by any means), not a use restriction; the Unlicense is DFSG-free and the debian/* stanza is correct. - The 'The Libfossil Authors SPDX-FileType: Code' strings the scan flagged (src/foci.c, the include/fossil-scm/*.h headers) name the same holder as the
Files: *stanza, so no holder is missing for them. - Build inputs: Build-Depends all exist (jimsh 0.84; dh-sequence-doxygen is provided by doxygen 1.17.0) and are right (jimsh runs autosetup, include/fossil-scm/db.h includes sqlite3.h so -dev needs libsqlite3-dev, -dev's zlib1g-dev covers the static library's -lz). dh_auto_configure's autoconf path supplies --prefix=/usr and --libdir=${prefix}/lib/, which is why the ${DEB_HOST_MULTIARCH} paths in the .install files match (substitution is supported, dh_install(1) EXAMPLE).
- compat 14, so ${misc:Depends}/${shlibs:Depends} need not be written in control; libfossil0.symbols starts
libfossil.so.0 libfossil0 #MINVER#with* Build-Depends-Package: libfossil-devand@Base 0.6.1, and debian/rules sets hardening=+all. Patch 0005 puts $(CPPFLAGS)/$(CFLAGS) on the compile line, and LDFLAGS reaches the link through @LDFLAGS@ (autosetup's cc-init takes LDFLAGS from the environment), so the dpkg-buildflags flags are used. - Standards-Version 4.7.4 matches the reviewing system's Policy 4.7.4.1 (first two components). Patches carry From/Date/Subject/Forwarded, their purposes are the repack itself, and none is obsolete. changelog is an initial release on unstable closing #1153222 with a valid version/tarball pair (0.6.1+ds / libfossil_0.6.1+ds.orig.tar.gz, 3.0 (quilt)).
- Doc build: configure generates doc/Doxyfile from doc/Doxyfile.in (auto.def
proj-dot-ins-append doc/Doxyfile.in doc/Doxyfile),make -C doc docruns doxygen into doc/libfossil-API-html, the .install path and doc-base Index (index.html) match, and graphviz is present for HAVE_DOT. - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (GPL-3).
Not confirmed ◂
- The doxygen debhelper addon pulled in by dh-sequence-doxygen is not installed on the reviewing system (its Sequence module is absent), so I could not check what dh_doxygen does with this package; the docs are built by hand in execute_after_dh_auto_build-indep, so the addon looks unnecessary but harmless.
- I could not compile a client against the installed amalgamation header to confirm it is usable: the -dev package gets only the generated libfossil.h and libfossil-config.h under /usr/include/fossil-scm/ (upstream's install-headers does not install include/fossil-scm/*.h), and make-amalgamation.bash deletes local
#include "*.h"lines so it should be self-contained.
Proposed changes ◂
None.
Uploader's response to the LLM review
The CC-BY-SA-4.0 cannot be accurately shown in d/copyright via Files: * as such, a comment is provided.
— Harsha Bhattacharyya (harsha-bhattacharyya), 0 hours ago