Review: libgweather 4.6.0-3

Package Information

Description	GWeather shared library libgweather is a library to access weather information from online services for numerous locations. This package contains shared libraries.
Maintainer	Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
Changed By	Jeremy Bícha <jbicha@ubuntu.com>
Sponsor	jbicha@debian.org
Distribution	experimental
Architecture	any all
VCS	git: https://salsa.debian.org/gnome-team/libgweather.git (browse)
Popcon Installs	8002
Tracker	https://tracker.debian.org/pkg/libgweather
Uploaded	2 hours ago

Takes Over Existing Binary Packages

This upload builds binary packages that a different source package currently builds in unstable. Check that the takeover is intended and explained, for example in the changelog.

Binary	Currently built by
`gir1.2-gweather-4.0`	libgweather4
`libgweather-4-0t64`	libgweather4
`libgweather-4-common`	libgweather4
`libgweather-4-dev`	libgweather4

New Package Report

.changes◂

Distribution	experimental
Date	Wed, 21 Oct 2026 09:19:40 +0200
Source	libgweather
Version	4.6.0-3
Changed-By	Jeremy Bícha <jbicha@ubuntu.com>
Architecture	source amd64

Changelog◂

libgweather (4.6.0-3) experimental; urgency=medium
 .
   * Remove version number from source package name and -dev package name
   * Update Homepage

.dsc◂

Section	introspection
Priority	optional
Component	main
Package-List	gir1.2-gweather-4.0 deb introspection optional arch=any libgweather-4-0t64 deb libs optional arch=any libgweather-4-common deb libs optional arch=all libgweather-4-dev deb oldlibs optional arch=all libgweather-dev deb libdevel optional arch=any

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://download.gnome.org/sources/libgweather/
Upstream-Name: libgweather
Comment: We use the distro version of gi-docgen

Files: *
Copyright:
2004 Gareth Owen
2005 Papadimitriou Spiros
2014 Javier Jardón
2011-2015 Giovanni Campagna
2015-2026 The GWeather authors
License: GPL-2+

Files: debian/*
Copyright:
2008 Sebastien Bacher <seb128@canonical.com>
2026 Danial Behzadi <dani.behzi@ubuntu.com>
License: GPL-2+

Files:
libgweather/gweather.h
libgweather/gweather-location.c
Copyright: 2008, Red Hat, Inc.
License: LGPL-2.1+

Files: libgweather/gweather-version.h.in
Copyright:
2014 Javier Jardón
2014 Emmanuele Bassi
License: LGPL-2+

Files: libgweather/tests/*
Copyright: 2021 Emmanuele Bassi
License: LGPL-2.1+

Files:
libgweather/tests/duplicates.c
libgweather/tests/timezones.c
Copyright:
2017 Bastien Nocera
2021 Emmanuele Bassi
License: LGPL-2+

Files: libgweather/tests/test_libgweather.c
Copyright: 2017 Bastien Nocera
License: LGPL-2+

Files: libgweather/tools/test_sun_moon.c
Copyright: 2009, Frank Solensky
2011-2012, 2015, Giovanni Campagna
License: GPL-2+

Files: libgweather/third-party/kdtree.*
Copyright: 2007-2011, John Tsiombikas <nuclear@member.fsf.org>
License: BSD-3-clause

Files: po/*
Copyright: 1999-2000 01, 02, 03, 04, 05, 06, 07 Free Software Foundation, Inc. GNOME 1.x
2004-2009, 2012-2014, 2017, 2021, 2024 A S Alam <aalam@users.sf.net> Amanpreet Singh Alam <aalam@users.sf.net>
2004-2006 Adam Weinberger and the GNOME Foundation
2002, 2004-2005, 2007-2008, 2022 Alexander Shopov. Alexander Shopov <ash@kambanaria.org>
2005 Canonical Ltd
1998-2022 Free Software Foundation
2005 Free Software Foundation, Andhra Pradesh
2000-2008 Free Software Foundation, Inc. Gediminas Paulauskas <menesis@chatsubo.lt>
1999-2009 Free Software Foundation, Inc. Half of translation by Spiros, Simos/Sarantis other half
2001-2003 Free Software Foundation, Inc. Hasbullah Bin Pit (sebol) <sebol@ikhlas.com>
1998-2021 Free Software Foundation, Inc. Kjartan Maraas <kmaraas@gnome.org>
2003-2004 Free Software Foundation, Inc. Largely Chris and Dafydd H
1998-2021 Free Software Foundation, Inc. Martin Wahlen <mva@sbbs.se>
1999-2000, 2002 Free Software Foundation, Inc. Pablo Saratxaga <srtxg@chanae.alphanet.ch>
1998-2010, 2013 Free Software Foundation, Inc. Reşat SABIQ <tilde.birlik@gmail.com>
1999-2000 Free Software Foundation, Inc. Robert Brady <robert@susu.org.uk>
2000-2001, 2003-2004 Free Software Foundation, Inc. Vasif Ismailoglu <azerb_linux@hotmail.com>
1998-2009, 2012, 2019-2020, 2022 Free Software Foundation, Inc. Yukihiro Nakai <Nakai@abricot.co.jp>
2000 Free Software Foundation, Inc. Yuri Syrota <rasta@renome.rovno.ua>
2009 GNOME i18n Project for Vietnamese
1999-2002 Jesús Bravo Álvarez Proxecto Trasno - Adaptación do software libre á lingua galega: Se desexas
2001-2021 libgweather
2003-2006 Miloslav Trmac <mitr@volny.cz>
2008 Pavel Šefránek <ps@pjoul.cz>
2013 Rosetta Contributors and Canonical Ltd
2001 Roy-Magne Mo
2012 Swecha Telugu Localisation Team <localization@swecha.net>
License: GPL-2+

License: BSD-3-clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
.
1. Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.
3. The name of the author may not be used to endorse or promote products
derived from this software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO
EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
OF SUCH DAMAGE.

License: GPL-2+
This package is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
.
This package is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
.
You should have received a copy of the GNU General Public License
along with this program. If not, see <https://www.gnu.org/licenses/>
.
On Debian systems, the complete text of the GNU General Public
License version 2 can be found in "/usr/share/common-licenses/GPL-2".

License: LGPL-2+
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
.
On Debian systems, the complete text of the GNU Library General Public
License version 2 can be found in "/usr/share/common-licenses/LGPL-2".

License: LGPL-2.1+
This package is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
.
This package is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
.
You should have received a copy of the GNU Lesser General Public License
along with this program. If not, see <https://www.gnu.org/licenses/>.
.
On Debian systems, the complete text of the GNU Lesser General
Public License can be found in "/usr/share/common-licenses/LGPL-2.1".

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 0 hours ago.

Report◂

DFSG NEW review for libgweather version 4.6.0-3

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: Yes
Issues: 0 blocker, 0 important, 0 minor
debian/watch: version 5
debian/copyright: machine-readable
Scan before the review: 1 found

Licensing

debian/copyright is machine-readable (copyright-format 1.0) with a Files: * catch-all under GPL-2+ and specific stanzas for the LGPL and BSD files. The SPDX headers in the C sources (GPL-2.0-or-later, LGPL-2.1-or-later, LGPL-2.0-or-later) and the BSD-3-clause text in libgweather/third-party/kdtree.* all match the corresponding Files stanzas and short names, which override the GPL-2+ catch-all correctly. Copyright holders named in file headers (Red Hat, John Tsiombikas, Emmanuele Bassi, Bastien Nocera, Javier Jardón, the po/* translators) appear in the matching stanzas. The full text of BSD-3-clause is included and the GPL/LGPL short names point at /usr/share/common-licenses. All licences (GPL-2+, LGPL-2.1+, BSD-3-clause) are compatible for the combined binary. No non-free terms, no files lacking a licence, no built-only or minified code, no files of unclear provenance were found.

Packaging

debhelper-compat 14 with a plain dh $@ rules file, hardening=+all and DPKG_GENSYMBOLS_CHECK_LEVEL=4. Binary split (libgweather-4-0t64 any/M-A same, libgweather-dev, libgweather-4-common, gir1.2-gweather-4.0, and a libgweather-4-dev transitional package) is sound; the t64 rename is reflected in Breaks/Replaces and the .symbols file. The only patch is a clearly-motivated Debian-local patch disabling the Internet-dependent metar test, and the ca-certificates <!nocheck> build-dependency plus the dh_auto_test override are consistent with compat 13+ nocheck handling. Standards-Version 4.7.4 matches current Policy (4.7.x). Autopkgtests are not shipped (none present) and none are required. Packaging does its job and follows established GNOME-team practice.

Issues

None.

Verified

Prescan 'rare licence wording' CONTRIBUTING.md:261 is a contributor guideline stating that if a weather data provider restricts non-commercial usage, that fact must be documented in the GWeather API docs; it is not a licence term applying to the distributed code. libgweather source is GPL-2+/LGPL throughout. Not an issue.
Prescan holder scan (177 files) flagged po/it.po (Free Software Foundation) and po/et.po (The GNOME Project); both are covered by the Files: po/* stanza, which lists Free Software Foundation, Free Software Foundation, Inc. and related transliterations.
libgweather third-party kdtree.h/kdtree.c carry BSD-3-clause text matching the libgweather/third-party/kdtree.* stanza and the standalone BSD-3-clause License paragraph.
SPDX headers checked in libgweather/*.c, .h and tests/ match the copyright stanzas (gweather.h/gweather-location.c LGPL-2.1+; gweather-version.h.in LGPL-2+; tests gweather-test-utils/metar LGPL-2.1+ via libgweather/tests/*; duplicates.c/timezones.c/test_libgweather.c LGPL-2+ via their specific stanzas).
Compatibility: GPL-2+ (core), LGPL-2.1+/LGPL-2+ (a few files) and BSD-3 (kdtree) are combined in one library; all are compatible.
libgweather-4-0t64 Depends on gweather-locations and libgweather-4-common; gweather-locations is also a Build-Depends and is produced at build time (referenced in the sources); binary Built-Using/Depends substvars are handled automatically by debhelper 14.
Patch disable-tests-that-require-Internet.patch (added in 3.91.0-1, 2022) cleanly disables only the metar test in libgweather/tests/meson.build; no regression risk. It lacks a FORWARDED field but is intentionally Debian-local, so this is acceptable.
The scan reported no binary, minified, generated-without-source, or ambiguously-licensed files in the tree.
uscan found the packaged version as the newest upstream release (upstream 4.6.0, packaged 4.6.0).
Every pointer of debian/copyright to /usr/share/common-licenses names a file that is there (GPL-2, LGPL-2, LGPL-2.1).

Not confirmed

None.

Proposed changes

None.

Uploader's response to the LLM review

The uploader was emailed about the review 0 hours ago.

Review Information

accepted — allocated to awm 0 hours ago, started 0 hours ago, completed 0 hours ago.

Final Comment

Back to Dashboard | View all reviews for this package