Review: libsidplayfp 3.0.0-1
New Package Report
.changes
| Version | 3.0.0-1 |
|---|---|
| Changed-By | Laszlo Boszormenyi (GCS) |
| Architecture | source amd64 all |
| Distribution | experimental |
| Date | Sat, 02 May 2026 14:19:46 +0200 |
| Source | libsidplayfp |
Changelog
libsidplayfp (3.0.0-1) experimental; urgency=medium . * New upstream release. * Transition to libsidplayfp7. * Update copyright file.
.dsc
| Component | main |
|---|---|
| Package-List | libsidplayfp-dev deb libdevel optional arch=any libsidplayfp-doc deb doc optional arch=all libsidplayfp7 deb libs optional arch=any libstilview-dev deb libdevel optional arch=any libstilview0 deb libs optional arch=any |
| Section | libdevel |
| Priority | optional |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: libsidplayfp Source: https://sourceforge.net/projects/sidplay-residfp/files/libsidplayfp/ Files: * Copyright: Copyright (C) 2000 Simon White, Copyright (C) 2007-2010 Antti Lankila, Copyright (C) 2010-2012 Leandro Nini <drfiemost@users.sourceforge.net> License: GPL-2+ Files: build-aux/install-sh Copyright: 1994 X Consortium License: X11 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE X CONSORTIUM BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. . Except as contained in this notice, the name of the X Consortium shall not be used in advertising or otherwise to promote the sale, use or other dealings in this Software without prior written authorization from the X Consortium. Files: build-aux/ltmain.sh Copyright: 1996-2019, 2021-2022 Free Software Foundation, Inc. License: GPL-2+ with Libtool exception GNU Libtool is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. . As a special exception to the GNU General Public License, if you distribute this file as part of a program or library that is built using GNU Libtool, you may include this file under the same distribution terms that you use for the rest of that program. . GNU Libtool is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. . You should have received a copy of the GNU General Public License version 2 along with this program. If not, see <http://www.gnu.org/licenses/>. Files: m4/ax_append_compile_flags.m4 m4/ax_append_flag.m4 m4/ax_check_compile_flag.m4 m4/ax_cxx_compile_stdcxx.m4 m4/ax_require_defined.m4 Copyright: 2008 Benjamin Kosnik <bkoz@redhat.com>, 2011 Maarten Bosmans <mkbosmans@gmail.com>, 2012 Zack Weinberg <zackw@panix.com>, 2013 Roy Stogner <roystgnr@ices.utexas.edu>, 2014 Mike Frysinger <vapier@gentoo.org>, 2014, 2015 Google Inc.; contributed by Alexey Sokolov <sokolov@google.com>, 2015 Paul Norman <penorman@mac.com>, 2015 Moritz Klammler <moritz@klammler.eu>, 2016, 2018 Krzesimir Nowak <qdlacz@gmail.com>, 2019 Enji Cooper <yaneurabeya@gmail.com>, 2020 Jason Merrill <jason@redhat.com>, 2021, 2024 Jörn Heusipp <osmanx@problemloesungsmaschine.de>, 2015, 2022, 2023, 2024 Olly Betts License: FSFAP This file is free software; the Free Software Foundation gives unlimited permission to copy and/or distribute it, with or without modifications, as long as this notice is preserved. . This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY, to the extent permitted by law; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Files: m4/libtool.m4 Copyright: 1996-2001, 2003-2019, 2021-2022 Free Software Foundation, Inc. License: FSFULLR and/or GPL-2+ with Libtool exception GNU Libtool is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. . As a special exception to the GNU General Public License, if you distribute this file as part of a program or library that is built using GNU Libtool, you may include this file under the same distribution terms that you use for the rest of that program. . GNU Libtool is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. . You should have received a copy of the GNU General Public License version 2 along with this program. If not, see <http://www.gnu.org/licenses/>. Files: m4/lt~obsolete.m4 m4/ltoptions.m4 m4/ltsugar.m4 m4/ltversion.m4 Copyright: 2004, 2011-2019, 2021-2022 Free Software Foundation, Inc. License: FSFULLR This file is free software; the Free Software Foundation gives unlimited permission to copy and/or distribute it, with or without modifications, as long as this notice is preserved. . This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY, to the extent permitted by law; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Files: configure Copyright: 1992-1996, 1998-2017, 2020-2021 Free Software Foundation License: FSFUL This configure script is free software; the Free Software Foundation gives unlimited permission to copy, distribute and modify it. Files: src/builders/exsid-builder/* Copyright: 2015-2017,2021 Thibaut VARENE License: GPL-2 Files: src/builders/usbsid-builder/driver/src/* Copyright: 2024-2025 LouD License: GPL-2 Files: src/libs/hashlib/* Copyright: 2025 Cra3z License: Expat Files: tests/utpp/* Copyright: 2017-2024 Mircea Neacsu License: Expat Files: debian/* Copyright: 2012- Laszlo Boszormenyi (GCS) <gcs@debian.org> License: GPL-2+ License: GPL-2 This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; under version 2 of the License. . This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. . You should have received a copy of the GNU General Public License version 2 along with this program. If not, see <https://www.gnu.org/licenses/> . On Debian systems, the full text of the GNU General Public License version 2 can be found in the file `/usr/share/common-licenses/GPL-2'. License: GPL-2+ This package is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. . This package is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. . You should have received a copy of the GNU General Public License version 2 along with this program. If not, see <https://www.gnu.org/licenses/> . On Debian systems, the full text of the GNU General Public License version 2 can be found in the file `/usr/share/common-licenses/GPL-2'. License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Review Information
rejected — allocated to mechtilde 20 hours ago, started 20 hours ago, completed 20 hours ago.
Final Comment
Hi
There are missed 12 authors in d/copyright.
Additionally you can fix the lintian warnings you can see in the public notes
Thanks
Public Notes
20 hours ago
● public
Missed Author Check
Command: dnq author-check
Exit code: 0
Using active review (from current.json): libsidplayfp
Author check: libsidplayfp 3.0.0-1
Scanned 202 files.
Authors declared in debian/copyright: 26
NOT IN debian/copyright (12):
André Fachat (a.fachat@physik.tu-chemnitz.de)
src/reloc65.cpp:6
src/reloc65.h:6
Bootstrap Authors
build-aux/ltmain.sh:1527
build-aux/ltmain.sh:75
COMPUTE!
src/sidtune/sidplayer1.a65:4
src/sidtune/sidplayer2.a65:4
Dag Lem
src/psiddrv.a65:6
src/reloc65.cpp:5
src/reloc65.h:5
Dan Nicholson <dbn.lists@gmail.com>
aclocal.m4:27
Daniel Richard G. <skunk@iSKUNK.ORG>
m4/ax_pthread.m4:61
src/builders/exsid-builder/driver/m4/ax_pthread.m4:61
Guido U. Draheim <guidod@gmx.de>
m4/ax_append_flag.m4:23
m4/ax_check_compile_flag.m4:29
LaLa<br/>
docs/mainpage.dox:24
src/utils/STILview/stil.cpp:114
src/utils/STILview/stil.cpp:27
src/utils/STILview/stil.cpp:4
src/utils/STILview/stil.h:37
... and 2 more files
Marc Stevens <marc.stevens@cwi.nl>
m4/ax_pthread.m4:62
src/builders/exsid-builder/driver/m4/ax_pthread.m4:62
Scott James Remnant <scott@netsplit.com>
aclocal.m4:26
Steven G. Johnson <stevenj@alum.mit.edu>
m4/ax_pthread.m4:60
src/builders/exsid-builder/driver/m4/ax_pthread.m4:60
VICE Project
src/c64/Banks/ZeroRAMBank.h:5
src/c64/CIA/SerialPort.cpp:5
src/c64/CIA/SerialPort.h:5
src/c64/CIA/mos652x.cpp:118
src/c64/CIA/mos652x.cpp:5
... and 8 more files
Result: ATTENTION REQUIRED — 12 authors not in debian/copyright
20 hours ago
● public
Lintian
Command: lintian -c -E -I -i -L '>=warning' --show-overrides --color=never ../$(basename $PWD)_*.changes
Exit code: 0
N:
W: libsidplayfp-doc: privacy-breach-generic [<img src="https://img.shields.io/badge/language-c%2b%2b11-blue.svg" alt="language" style="pointer-events: none;" class="inline"/>] (https://img.shields.io/badge/language-c%2b%2b11-blue.svg) [usr/share/doc/libsidplayfp-dev/html/dir_ce675e6c36c1b0754e68fe5ef6e6da18.html]
N:
N: This package creates a potential privacy breach by fetching data from an
N: external website at runtime. Please remove these scripts or external HTML
N: resources.
N:
N: Please replace any scripts, images, or other remote resources with
N: non-remote resources. It is preferable to replace them with text and links
N: but local copies of the remote resources are also acceptable as long as
N: they don't also make calls to remote services. Please ensure that the
N: remote resources are suitable for Debian main before making local copies
N: of them.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: files/privacy-breach
N:
N:
W: libsidplayfp-doc: privacy-breach-generic [<img src="https://img.shields.io/badge/license-mit-green.svg" alt="license" style="pointer-events: none;" class="inline"/>] (https://img.shields.io/badge/license-mit-green.svg) [usr/share/doc/libsidplayfp-dev/html/dir_ce675e6c36c1b0754e68fe5ef6e6da18.html]