Review: libvgio 0.0~git20261016.54490c2-1
Package Information
| Description | library for reading and writing vg file formats libvgio implements reading and writing of the file formats used by the vg toolkit for sequence variation graphs and read alignments, including protobuf-encoded and BGZF-compressed streams. This package contains the shared library. |
|---|---|
| Maintainer | Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org> |
| Changed By | Andreas Tille <tille@debian.org> |
| Sponsor | tille@debian.org |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/med-team/libvgio.git (browse) |
| Closes | #1152536 |
| Tracker | https://tracker.debian.org/pkg/libvgio |
| Uploaded | 5 days ago |
New Package Report
.changes
| Date | Fri, 30 Oct 2026 12:09:18 +0100 |
|---|---|
| Source | libvgio |
| Version | 0.0~git20261016.54490c2-1 |
| Changed-By | Andreas Tille <tille@debian.org> |
| Architecture | source amd64 |
| Distribution | unstable |
Changelog
libvgio (0.0~git20261016.54490c2-1) unstable; urgency=medium . * Initial release (Closes: #1152536).
.dsc
| Section | libdevel |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | libvgio-dev deb libdevel optional arch=any libvgio0 deb libs optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: libvgio
Source: https://github.com/vgteam/libvgio
Files: *
Copyright: 2014 Erik Garrison
vg contributors
License: LGPL-3
Files: src/json2pb.cpp
src/bin2ascii.h
include/vg/io/json2pb.h
Copyright: 2013 Pavel Shramov <shramov@mexmat.net>
2009-2014 Petri Lehtinen <petri@digip.org>
License: MIT
Files: include/vg/io/fdstream.hpp
Copyright: 2001 Nicolai M. Josuttis
License: NTP
Permission to copy, use, modify, sell and distribute this software
is granted provided this copyright notice appears in all copies.
This software is provided "as is" without express or implied
warranty, and with no claim as to its suitability for any purpose.
Files: debian/*
Copyright: 2026 Andreas Tille <tille@debian.org>
License: LGPL-3
License: LGPL-3
This program is free software: you can redistribute it and/or modify it
under the terms of the GNU Lesser General Public License as published by
the Free Software Foundation, either version 3 of the License.
.
On Debian systems, the complete text of the GNU Lesser General Public
License version 3 can be found in "/usr/share/common-licenses/LGPL-3".
License: MIT
Permission is hereby granted, free of charge, to any person obtaining a
copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:
.
The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 5 days ago.
Report
DFSG NEW review for libvgio version 0.0~git20261016.54490c2-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
debian/copyright is DEP-5 and matches the tree. The licence files present are LGPL-3 for the project (LICENSE, first line "libvgio is licensed to you under the GNU LGPL version 3"), with three files carrying their own permissive licences: src/json2pb.cpp, src/bin2ascii.h and include/vg/io/json2pb.h (MIT, Pavel Shramov and the Petri Lehtinen macro) and include/vg/io/fdstream.hpp (Josuttis/NTP). Each has its own Files stanza with the full licence text where the licence is not in common-licenses, and the stanzas are ordered so the specific ones override Files: *. MIT and NTP are compatible with LGPL-3 and all notices are reproduced. No file lacks a licence, no non-free terms occur, and there are no built files, vendored library copies or generated code without their inputs; the only third-party tree referenced, deps/libhandlegraph, is an empty submodule directory and is not built or shipped.
Packaging
The packaging is conventional and correct: debhelper-compat 14 with dh and the cmake buildsystem, hardening=+all, Rules-Requires-Root: no, Standards-Version 4.7.4 (current against Policy 4.7.4.1), a well-formed initial changelog closing the ITP, a d-shlibs based library/dev split with a SONAME (libvgio0/libvgio-dev), correct ${binary:Version} dependency, Multi-Arch: same, a DEP-3 headed patch that removes the hardcoded -O3 -g and adds the SONAME and CMake dependency lookup, an autopkgtest that compiles and runs the upstream test against the installed library, and valid debian/upstream/metadata. Build-Depends and the -dev Depends match what CMake and the exported CMake config need (libhandlegraph-dev, libhts-dev, libjansson-dev, libprotobuf-dev, pkgconf). No policy violation found.
Issues
None.
Verified ◂
- Prescan:
src/json2pb.cpp:13Petri Lehtinen is covered by theFiles: src/json2pb.cpp src/bin2ascii.h include/vg/io/json2pb.hstanza, whoseCopyright:line already names2009-2014 Petri Lehtinen <petri@digip.org>; his MIT-licensedjson_booleanmacro is inside that file. No other holder from the scan is missing. - Only four files carry their own notices:
src/json2pb.cpp,src/bin2ascii.h,include/vg/io/json2pb.h(MIT, Pavel Shramov) andinclude/vg/io/fdstream.hpp(NTP, Nicolai M. Josuttis, including its permission text). Every other upstream file (src/.cpp, include/vg/io/.hpp, deps/vg.proto, CMakeLists.txt, README.md, install.sh, build/*.sh, test.cpp) has no notice and is covered by the project-wide LGPL-3 statement inLICENSE. LICENSElines 1-6 state the project is LGPL-3 and that it includes components from vg under MIT and fdstream.hpp under its own licence;debian/copyrightputs vg contributors in theFiles: *Copyright line and the LGPL-3 stanza quotes "either version 3 of the License" without "or any later", matching the upstream statement (LGPL-3 only).debian/copyrightis DEP-5 (Format:URL exactly the 1.0 one), uses*patterns that legally reach subdirectories, and puts the specific stanzas afterFiles: *, so they override it.- No built files, minified code, PDFs or archives in the tree; the prescan reported none.
build/contains only.gitignore,build.shandclean.sh;deps/libhandlegraph/is an empty submodule directory and.gitmodulesonly names it, and the build passes-DUSE_INSTALLED_LIBHANDLEGRAPH_ONLY=ON, so nothing vendored is compiled. debian/patches/install-paths-and-soname.patchapplies to the shipped CMakeLists.txt (the minus lines are absent, the addedset_target_properties(... SOVERSION 0)andfind_dependencylines are present), has DEP-3 Description/Author/Last-Update, and only changes build flags, SONAME and the CMake package config.$(DEB_HOST_GNU_TYPE)and$(DEB_HOST_MULTIARCH)used in debian/rules without including /usr/share/dpkg/architecture.mk do work: dpkg-buildpackage puts the wholedpkg-architecture -foutput into the build environment (lines 785-790 of /usr/bin/dpkg-buildpackage), so./obj-$(DEB_HOST_GNU_TYPE)/test_libvgioandusr/lib/$(DEB_HOST_MULTIARCH)expand correctly; debhelper's default cmake build directory is indeedobj-+ DEB_HOST_GNU_TYPE (/usr/share/perl5/Debian/Debhelper/Buildsystem.pm line 49).override_dh_auto_testneeds nonocheckguard at compat 13+: dh skips overrides of dh_auto_test undernocheck(debhelper tool, v13 change).- autopkgtest
Depends: @, build-essentialinstalls both binaries of the source (autopkgtest spec,@), so g++ from build-essential, the headers from libvgio-dev and libprotobuf-dev (via libvgio-dev's Depends) are all present for compiling test.cpp;Restrictions: allow-stderris right because test.cpp logs to stderr. - All names in Build-Depends and -dev Depends exist: d-shlibs 0.111, libhandlegraph-dev 20261019.3d8c3c9-1 (ships headers, static library and CMake config), libhtscodecs-dev 1.6.7-1, libjansson-dev 2.15.1-1 (apt-cache).
include/vg/io/loader.hppis a zero-byte upstream header, not a packaging artefact; it is installed as-is.- uscan found the packaged version as the newest upstream release (upstream
0.0~git20261016.54490c2, packaged0.0~git20261016.54490c2). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (LGPL-3).
Not confirmed ◂
- d-shlibs is not installed on the reviewing system, so I could not read d-shlibmove. CMake installs both the shared and the static library (
install(TARGETS vgio vgio_static ...)), while debian/rules passes onlydebian/tmp/usr/lib/*/*.soto d-shlibmove; if d-shlibmove does not also movelibvgio.ainto libvgio-dev (whose Description promises the static library), dh_missing --fail-missing, the default at compat 14, would abort the build. A clean sbuild of the package would show it immediately.
Proposed changes ◂
None.
Uploader's response to the LLM review
Please accept this last library that is missing to upgrade vg. Thanks a lot for all your fast processing which made this migration possible at all!
— Andreas Tille (tille), 4 days ago
Review Information
accepted — allocated to awm 4 days ago, started 4 days ago, completed 4 days ago.
Final Comment
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 0.0~git20261016.54490c2-1 | df4b9dd0… | 2026-11-02 19:01 | 2026-11-02 19:01 | dfsg-uploader | rejected | VIEW |