Review: libvpx 1.16.0-1
Package Information
| Maintainer | Debian Multimedia Maintainers <debian-multimedia@lists.debian.org> |
|---|---|
| Changed By | Sebastian Ramacher <sramacher@debian.org> |
| Sponsor | sebastian@ramacher.at |
| Distribution | experimental |
| Architecture | any all |
| VCS | git: https://salsa.debian.org/multimedia-team/libvpx.git (browse) |
| Popcon Installs | 76609 |
| Tracker | https://tracker.debian.org/pkg/libvpx |
| Uploaded | 20 days ago |
Review Information
accepted — allocated to awm 12 days ago, started 12 days ago, completed 12 days ago.
Final Comment
Some minor warnings about debian/control but otherwise fine.
Public Notes
12 days ago
● public
duck - check URL redirections
Command: duck
Exit code: 0
I: debian/copyright:3: URL: http://www.webmproject.org/: INFORMATION (Certainty:possible)
URL schema changed from HTTP to HTTPS during redirect(s): http://www.webmproject.org -> https://www.webmproject.org
Please investigate and update the URL eventually, to avoid unnecessary redirects!
12 days ago
● public
vulture
Command: vulture .
Exit code: 3
/usr/src/dfsg/libvpx_1.16.0-1/tools/cpplint.py:192: SyntaxWarning: invalid escape sequence '\.'
exclude_files=.*\.cc
/usr/src/dfsg/libvpx_1.16.0-1/tools/cpplint.py:1117: SyntaxWarning: invalid escape sequence '\D'
"C:\Documents and Settings\..." or "/home/username/..." in them and thus
tools/cpplint.py:5400: expected an indented block after 'for' statement on line 5398 at "# type::max()."
tools/non_greedy_mv/non_greedy_mv.py:188: Missing parentheses in call to 'print'. Did you mean print(...)? at "print rf_idx, frame_idx, ref_frame_idx, gf_frame_offset, ref_gf_frame_offset, len(mv_ls)"
test/android/scrape_gtest_log.py:25: Missing parentheses in call to 'print'. Did you mean print(...)? at "print "Expects a file to write json to!""
test/android/get_files.py:19: unused import 'time' (90% confidence)
test/android/get_files.py:20: unused import 'itertools' (90% confidence)
test/android/get_files.py:114: unused variable 'retry' (60% confidence)
tools/3D-Reconstruction/MotionEST/HornSchunck.py:66: unused variable 'sz' (60% confidence)
tools/3D-Reconstruction/MotionEST/HornSchunck.py:147: unused method 'motion_field_estimation_mat' (60% confidence)
tools/3D-Reconstruction/MotionEST/MotionEST.py:73: unused method 'distortion' (60% confidence)
tools/3D-Reconstruction/MotionEST/MotionEST.py:86: unused method 'motion_field_evaluation' (60% confidence)
tools/3D-Reconstruction/MotionEST/SearchSmooth.py:106: unused method 'block_matching' (60% confidence)
tools/3D-Reconstruction/MotionEST/SearchSmooth.py:209: unused method 'block_matching' (60% confidence)
tools/3D-Reconstruction/MotionEST/Util.py:14: unused import 'filters' (90% confidence)
12 days ago
● public
Licenserecon
Command: lrc -l
Exit code: 0
en: Versions: licenserecon '11.0' licensecheck '3.3.9-1'
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
d/copyright | licensecheck
BSD-3-Clause | BSD-3-clause LICENSE
public-domain | public-domain md5_utils.c
public-domain | public-domain md5_utils.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/gtest-assertion-result.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/gtest-death-test.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/gtest.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/gtest-matchers.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/gtest-message.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/gtest-param-test.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/gtest_pred_impl.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/gtest-printers.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/gtest_prod.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/gtest-spi.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/gtest-test-part.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/gtest-typed-test.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/internal/custom/gtest.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/internal/custom/gtest-port.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/internal/custom/gtest-printers.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/internal/gtest-death-test-internal.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/internal/gtest-filepath.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/internal/gtest-internal.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/internal/gtest-param-util.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/internal/gtest-port-arch.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/internal/gtest-port.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/internal/gtest-string.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/include/gtest/internal/gtest-type-util.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/LICENSE
BSD-3-Clause | BSD-3-clause third_party/googletest/src/src/gtest-all.cc
BSD-3-Clause | BSD-3-clause third_party/googletest/src/src/gtest-assertion-result.cc
BSD-3-Clause | BSD-3-clause third_party/googletest/src/src/gtest.cc
BSD-3-Clause | BSD-3-clause third_party/googletest/src/src/gtest-death-test.cc
BSD-3-Clause | BSD-3-clause third_party/googletest/src/src/gtest-filepath.cc
BSD-3-Clause | BSD-3-clause third_party/googletest/src/src/gtest-internal-inl.h
BSD-3-Clause | BSD-3-clause third_party/googletest/src/src/gtest_main.cc
BSD-3-Clause | BSD-3-clause third_party/googletest/src/src/gtest-matchers.cc
BSD-3-Clause | BSD-3-clause third_party/googletest/src/src/gtest-port.cc
BSD-3-Clause | BSD-3-clause third_party/googletest/src/src/gtest-printers.cc
BSD-3-Clause | BSD-3-clause third_party/googletest/src/src/gtest-test-part.cc
BSD-3-Clause | BSD-3-clause third_party/googletest/src/src/gtest-typed-test.cc
BSD-3-Clause | BSD-3-clause third_party/libwebm/LICENSE.TXT
BSD-3-Clause | BSD-3-clause third_party/libyuv/LICENSE
Expat | Expat third_party/nalloc/LICENSE
Expat | Expat third_party/nalloc/nalloc.h
ISC | ISC third_party/x86inc/LICENSE
ISC | ISC third_party/x86inc/x86inc.asm
BSD-3-Clause | BSD-3-clause tools/cpplint.py
No significant differences found
12 days ago
● public
CME fix
Command: cme fix --verbose dpkg
Exit code: 0
Reading package lists... 0%
Reading package lists... 100%
Reading package lists... Done
Building dependency tree... 0%
Building dependency tree... 0%
Building dependency tree... 50%
Building dependency tree... 50%
Building dependency tree... Done
Reading state information... 0%
Reading state information... 0%
Reading state information... Done
cme: running fix on dpkg configuration...
Connecting to api.ftp-master.debian.org to check 3 package versions. Please wait...
Got info from api.ftp-master.debian.org for 3 packages.
Warning in 'install:"libvpx-dev" content:0': path should not begin with '/'
Offending value: '#! /usr/bin/dh-exec --with-scripts=subst-multiarch'
Warning in 'install:"libvpx-dev" content:1': path should not begin with '/'
Offending value: 'builddir/vpx-vp8-*/lib/libvpx.so /usr/lib/${DEB_HOST_MULTIARCH}/'
Warning in 'install:"libvpx-dev" content:2': path should not begin with '/'
Offending value: 'builddir/vpx-vp8-*/lib/libvpx.a /usr/lib/${DEB_HOST_MULTIARCH}/'
Warning in 'install:libvpx12 content:0': path should not begin with '/'
Offending value: '#! /usr/bin/dh-exec --with-scripts=subst-multiarch'
Warning in 'install:libvpx12 content:1': path should not begin with '/'
Offending value: 'builddir/vpx-vp8-*/lib/libvpx.so.* /usr/lib/${DEB_HOST_MULTIARCH}/'
Warning in 'install:libvpx12 content:2': path should not begin with '/'
Offending value: 'builddir-neon/vpx-vp8-*/lib/libvpx.so.* /usr/lib/${DEB_HOST_MULTIARCH}/vfp/neon [armhf]'
Changes applied to dpkg configuration:
- install:"libvpx-dev" content:0: '#! /usr/bin/dh-exec --with-scripts=subst-multiarch' -> '#! usr/bin/dh-exec --with-scripts=subst-multiarch' # applied fix for :path should not begin with '/'
- install:"libvpx-dev" content:1: 'builddir/vpx-vp8-*/lib/libvpx.so /usr/lib/${DEB_HOST_MULTIAR[...]' -> 'builddir/vpx-vp8-*/lib/libvpx.so usr/lib/${DEB_HOST_MULTIARC[...]' # applied fix for :path should not begin with '/'
- install:"libvpx-dev" content:2: 'builddir/vpx-vp8-*/lib/libvpx.a /usr/lib/${DEB_HOST_MULTIARC[...]' -> 'builddir/vpx-vp8-*/lib/libvpx.a usr/lib/${DEB_HOST_MULTIARCH[...]' # applied fix for :path should not begin with '/'
- install:libvpx12 content:0: '#! /usr/bin/dh-exec --with-scripts=subst-multiarch' -> '#! usr/bin/dh-exec --with-scripts=subst-multiarch' # applied fix for :path should not begin with '/'
- install:libvpx12 content:1: 'builddir/vpx-vp8-*/lib/libvpx.so.* /usr/lib/${DEB_HOST_MULTI[...]' -> 'builddir/vpx-vp8-*/lib/libvpx.so.* usr/lib/${DEB_HOST_MULTIA[...]' # applied fix for :path should not begin with '/'
- install:libvpx12 content:2: 'builddir-neon/vpx-vp8-*/lib/libvpx.so.* /usr/lib/${DEB_HOST_[...]' -> 'builddir-neon/vpx-vp8-*/lib/libvpx.so.* usr/lib/${DEB_HOST_M[...]' # applied fix for :path should not begin with '/'