lomiri-keeper 0.2.0~20261113-1
Package Information
| Description | Backup Tool for Lomiri Lomiri Operating Environment is a convergent work shell designed for use cases on phone, tablet or desktop devices. Lomiri Keeper is a backup/restore utility. This package contains the services. |
|---|---|
| Maintainer | Debian UBports Team <team+ubports@tracker.debian.org> |
| Changed By | Jeremy Bícha <jbicha@ubuntu.com> |
| Sponsor | jbicha@debian.org |
| Distribution | experimental |
| Architecture | any |
| VCS | git: https://salsa.debian.org/ubports-team/lomiri-keeper.git (browse) |
| Tracker | https://tracker.debian.org/pkg/lomiri-keeper |
| Uploaded | 2 hours ago |
New Package Report
.changes
| Source | lomiri-keeper |
|---|---|
| Version | 0.2.0~20261113-1 |
| Changed-By | Jeremy Bícha <jbicha@ubuntu.com> |
| Architecture | source amd64 |
| Distribution | experimental |
| Date | Thu, 19 Nov 2026 18:25:50 +0100 |
Changelog
lomiri-keeper (0.2.0~20261113-1) experimental; urgency=medium . * Initial release
.dsc
| Package-List | liblomiri-keeper-client0 deb libs optional arch=any lomiri-keeper deb misc optional arch=any lomiri-keeper-cli deb misc optional arch=any lomiri-keeper-client-dev deb libdevel optional arch=any qml-module-lomiri-keeper deb misc optional arch=any |
|---|---|
| Section | libs |
| Priority | optional |
| Component | main |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Source: https://gitlab.com/ubports/development/core/lomiri-keeper Upstream-Name: lomiri-keeper Files: * Copyright: 2016 Canonical License: GPL-3 Files: src/helper/helper.cpp Copyright: 2016 Canonical 2008-2014 Mnemosyne LLC License: GPL-3 Comment: Includes code from transmission's libtransmission/bandwidth.c which is originally available under GPL-2 or GPL-3 or "any future license endorsed by Mnemosyne LLC" Files: debian/* Copyright: 2016 Charles Kerr <charles.kerr@canonical.com> License: GPL-3 License: GPL-3 This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License version 3, as published by the Free Software Foundation. . This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranties of MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. . You should have received a copy of the GNU General Public License along with this program. If not, see <http://www.gnu.org/licenses/>. . On Debian systems, the complete text of the GNU General Public License version 3 can be found in "/usr/share/common-licenses/GPL-3".
DFSG Assistant LLM REVIEW 1 blocker, 2 important, 5 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 1 hour ago.
Proposes a replacement debian/watch:
debian/watch in version 5 format
Report
DFSG NEW review for lomiri-keeper version 0.2.0~20261113-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: No
- Issues: 1 blocker, 2 important, 5 minor
- debian/watch: old format (version 4)
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
The tree is DFSG-free: GPL-3 for almost everything, LGPL-3/LGPL-3+ for nine files, and a GPL-2-or-3 Transmission snippet that is compatible with GPL-3; no non-free terms, no repacking needed, no opaque or generated files. But debian/copyright describes the whole tree as GPL-3 (Files: *) while nine files say LGPL-3 or LGPL-3+ in their own headers, and the top-level COPYING is the LGPL-3 text while README.md calls the project GPL v3.0. The licence text for LGPL-3 is not in the file, so the copyright file is inaccurate and must be fixed.
Packaging
The packaging itself is conventional: 3.0 (quilt), debhelper compat 13, hardening=+all, Vcs-* set, Standards-Version 4.7.4 (current against Policy 4.7.4.1), every installed path covered by an .install file, no maintainer scripts or patches. The -dev package, however, is broken: its pkg-config file links -lkeeper-client although the library is liblomiri-keeper-client, its installed headers cannot be included, and it does not depend on qtbase5-dev. The CLI package installs no command in $PATH and does not depend on the service package it talks to. There is also no debian/tests/control, so the upstream CTest suite is not exercised beyond the build.
Issues
blocker
licensing
1. Files: * calls nine files GPL-3 whose own notices are LGPL-3 or LGPL-3+
◂
- Files:
debian/copyright:5-7,src/client/qml-plugin/plugin.cpp:5,src/client/qml-plugin/plugin.h:5,src/qdbus-stubs/backend-utils.h:5,src/qdbus-stubs/CMakeLists.txt:4,tests/qdbus-stubs/CMakeLists.txt:4,tests/com_lomiri_keeper.py:18-19,26,tests/surface/copyright/check_copyright.sh:7,tests/surface/whitespace/check_whitespace.py:7,tests/utils/main.cpp:5,COPYING:1 - Basis: checked, in the package or with a reference tool
- Evidence:
debian/copyrighthas onlyFiles: */Copyright: 2016 Canonical/License: GPL-3(lines 5-7), then overrides onlysrc/helper/helper.cppanddebian/*. The nine files above sayunder the terms of the GNU Lesser General Public License version 3(plugin.cpp/h, backend-utils.h, both qdbus-stubs CMakeLists.txt, check_copyright.sh, check_whitespace.py, tests/utils/main.cpp);tests/com_lomiri_keeper.py:19addseither version 3 of the License, or (at your option) any later versionand line 26 has__license__ = 'LGPL 3+'.COPYING:1is<spaces>GNU LESSER GENERAL PUBLIC LICENSE, whileREADME.mdsaysGPL v3.0. - Problem: Later stanzas override earlier ones, and nothing matches these files, so the catch-all declares GPL-3 for LGPL-3/LGPL-3+ work.
src/client/qml-plugin/plugin.cppis compiled into the shipped QML plugin andsrc/qdbus-stubs/backend-utils.hinto the static qdbus-stubs library linked into keeper-service, keeper-tar and keeper-untar, so even the minimum of Policy 2.3 (notices for files compiled into binaries) is recorded under the wrong licence. The LGPL-3 licence text is absent from the file as well. LGPL-3 itself permits conveying the combined work under GPL-3, so this is not a DFSG problem and the package may be distributed, but copyright-format 7.1 requires the short names to match the licences actually granted, and a recipient is not told of the LGPL-3 permissions. - Fix: Add
Files:stanzas withLicense: LGPL-3for the eight LGPL-3 files andLicense: LGPL-3+fortests/com_lomiri_keeper.py, plus stand-aloneLicense: LGPL-3/LGPL-3+paragraphs pointing to/usr/share/common-licenses/LGPL-3(also present asCOPYING). Note in the header that COPYING is the LGPL-3 text while README.md says GPL-3; ask upstream to reconcile COPYING, README.md and the file headers.
important
packaging
2. lomiri-keeper-client.pc links -lkeeper-client, but the installed library is liblomiri-keeper-client
◂
- Files:
src/client/lomiri-keeper-client.pc.in:9,src/client/CMakeLists.txt:29,debian/lomiri-keeper-client0.install:1,debian/lomiri-keeper-client-dev.install:2 - Basis: checked, in the package or with a reference tool
- Evidence:
Libs: -L${libdir} -lkeeper-client; the only library built and shipped isliblomiri-keeper-client.so.0.2.0(add_library(lomiri-keeper-client SHARED ...)), with the.sosymlink in the -dev package. - Problem: Any consumer doing
pkg-config --libs lomiri-keeper-clientis told to link-lkeeper-client, and nolibkeeper-client.soexists, so linking fails. The -dev package exists to be built against and is unusable this way. - Fix: Change the line to
Libs: -L${libdir} -llomiri-keeper-client, and make theName:field consistent with thelomiri-keeper-client.pcfile name; send the fix upstream, or carry it as a patch.
important
packaging
3. Installed headers cannot be used: keeper-items.h includes client/keeper-errors.h, which the flat /usr/include/keeper install does not provide
◂
- Files:
include/client/keeper-items.h:23,include/client/client.h:23-24,src/client/CMakeLists.txt:51-54,debian/lomiri-keeper-client-dev.install:1 - Basis: checked, in the package or with a reference tool
- Evidence:
#include "client/keeper-errors.h"inkeeper-items.h; the three public headers are installed flat:install(FILES ${CLIENT_HEADERS} DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/keeper), so/usr/include/keeper/client/keeper-errors.hdoes not exist.client.hincludes"keeper-errors.h"and"keeper-items.h", i.e. the flat layout. - Problem: A consumer including either public header fails: the quoted include is looked for first next to the header (
/usr/include/keeper/client/keeper-errors.h), then through the.pc-I/usr/include/keeper, and neither exists. The -dev package therefore ships headers that cannot be compiled against. - Fix: Make the installed layout agree with the includes: patch
keeper-items.hto#include "keeper-errors.h"(send upstream) and keep the flat install, or install the headers preservinginclude/client/and adjustclient.hand the.pcCflags; check by compiling a small consumer against the installed headers.
minor
packaging
4. lomiri-keeper-client-dev lacks a dependency on qtbase5-dev although its headers and .pc require Qt5
◂
- Files:
debian/control:95-101,include/client/client.h:25-29,include/client/keeper-items.h:23,src/client/lomiri-keeper-client.pc.in:7 - Basis: checked, in the package or with a reference tool
- Evidence:
lomiri-keeper-client-devDepends onliblomiri-keeper-client0 (= ${binary:Version})and${misc:Depends}only; its headers include<QObject>,<QScopedPointer>,<QStringList>,<QVariant>and<QJsonObject>, and the .pc hasRequires.private: Qt5Core Qt5DBus. - Problem: Policy 8.4 requires the development package to install all development files necessary for compiling against the library. Without
qtbase5-dev, the Qt5 headers are missing andpkg-configcannot resolve theQt5Core/Qt5DBusmodules named in the .pc, so a consumer installing only the -dev package cannot compile. - Fix: Add
qtbase5-devtolomiri-keeper-client-dev'sDepends.
minor
packaging
5. Development package is named lomiri-keeper-client-dev instead of liblomiri-keeper-client-dev
◂
- Files:
debian/control:95,debian/lomiri-keeper-client-dev.install - Basis: checked, in the package or with a reference tool
- Evidence: The runtime package is
liblomiri-keeper-client0forliblomiri-keeper-client.so.0; Policy 8.4:the source package needs to generate a binary development package named libraryname-dev. - Problem: Policy 8.4 names the development package after the library, so
liblomiri-keeper-client-devis required; the current name breaks the convention the package's own runtime package follows and would be much harder to change after the first upload. - Fix: Rename the binary package and its
.installfile toliblomiri-keeper-client-devbefore the first upload.
minor
packaging
6. lomiri-keeper-cli installs keeper only in /usr/lib/<triplet>/lomiri-keeper, so it provides no command in $PATH
◂
- Files:
src/cli/CMakeLists.txt:30-33,debian/lomiri-keeper-cli.install:1 - Basis: checked, in the package or with a reference tool
- Evidence:
install(TARGETS ${CLI_EXEC} RUNTIME DESTINATION ${CMAKE_INSTALL_FULL_PKGLIBEXECDIR}); the .install file contains onlyusr/lib/*/lomiri-keeper/keeper.src/cli/command-line.cpppresents itself asKeeper command line clientwith list/backup/restore commands. - Problem: The package is described as the command line backup tool and this binary is its only file, but a program in the multiarch libdir is not reachable as a command; installing the package gives the user no usable CLI.
- Fix: Install the executable to
/usr/bin(fix upstream), or ship a/usr/bin/keepersymlink or wrapper and a man page; if it is meant only as an internal helper, drop the separate package and say so.
minor
packaging
7. lomiri-keeper-cli does not depend on lomiri-keeper, whose D-Bus service it needs
◂
- Files:
debian/control:51-56,src/cli/command-line-client.cpp:34,src/client/client.cpp:35-43,data/com.lomiri.keeper.service.in:2 - Basis: checked, in the package or with a reference tool
- Evidence: The CLI drives
KeeperClient, which connects toDBusTypes::KEEPER_SERVICE(com.lomiri.keeper,src/qdbus-stubs/dbus-types.h:49) on the session bus; that name is supplied only by theusr/share/dbus-1/services/com.lomiri.keeper.servicefile, which is in thelomiri-keeperpackage (debian/lomiri-keeper.install:7).lomiri-keeper-cliDepends onxz-utils,${misc:Depends}and${shlibs:Depends}only. - Problem: Policy 7.2: Depends should be used when the depended-on package is required for a significant amount of the package's functionality. With only
lomiri-keeper-cliinstalled, D-Bus activation ofcom.lomiri.keeperfails and the tool cannot list, back up or restore anything. - Fix: Add
Depends: lomiri-keepertolomiri-keeper-cli(a versioned dependency such aslomiri-keeper (= ${binary:Version})is also fine).
minor packaging 8. debian/watch is in the old version 4 format ◂
- Files:
debian/watch - Basis: found by the review tooling's own checks
- Evidence:
version=4 - Problem: Version 5 is the current format of
debian/watch. - Fix: Convert it to version 5; a mechanical conversion is under Proposed changes.
Verified ◂
- Read
debian/copyrightin full: DEP-5 with the exact 1.0Format:URL,Source/Upstream-Name, stanzasFiles: *(GPL-3),Files: src/helper/helper.cpp(GPL-3 with the Mnemosyne comment),Files: debian/*; noFiles-Excludedand no patches, so the tree is upstream's. - Prescan item
src/helper/helper.cpp:40(Mnemosyne LLC) is accounted for:Files: src/helper/helper.cppnames2008-2014 Mnemosyne LLC; theRateHistoryclass is Transmission'slibtransmission/bandwidth.ccode, offered under GPL-2 or GPL-3 and so compatible with the GPL-3 of the surrounding work. - Grepped all 174 files for
Copyright,(C),©,SPDX-License-Identifier,GNU General Public,GNU Lesser,Apache License,Mozilla Public,public domain,All rights reservedand permission wording: the only holders are Canonical Ltd. (2013-2016) and Mnemosyne LLC, all covered by the three stanzas; the only licence families are GPL-3, LGPL-3 and LGPL-3+. - Top-level
COPYINGis the verbatim LGPL-3 text (FSF, 2007) with the FSF's verbatim-copy notice; it is licence text, not compiled into a binary, and its own notice is intact, so Policy 2.3 does not require its holder to be copied into debian/copyright. - No binary blobs, fonts, images, PDFs, built or minified code in the tree; the test fixtures are shell, Python, XML and C++ sources, and
tests/surfaceonly checks headers and whitespace. - Read every file of
debian/: nocompat, no patches, no maintainer scripts, nolinks/docs/dirs, notests/, noupstream/metadata, nogbp.conf;debian/Jenkinsfileanddebian/salsa-ci.ymlare CI boilerplate. - Compared every CMake
install()destination with the.installfiles: library, headers, .pc, QML plugin, scripts, helper registry, D-Bus service file and executables are all packaged exactly once. Standards-Version4.7.4 against Policy 4.7.4.1 (same first two components),debhelper-compat (= 13),3.0 (quilt),hardening=+all,Vcs-Git/Vcs-Browserpresent, changelog distributionexperimentalwith a valid date.xz-utilsis justified bysrc/tar/untar.cpp:37(uncompress_.start("xz", ...)); thejson-glib-1.0module required byCMakeLists.txt:21is provided throughlibclick-dev's own Depends onlibjson-glib-dev.- uscan found the packaged version as the newest upstream release (upstream
0.2.0~20261113, packaged0.2.0~20261113). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (GPL-3).
Not confirmed ◂
- Whether Charles Kerr is the right sole holder for all of
debian/*: the stanza says2016 Charles Kerr, butdebian/changelog,controlandsalsa-ci.ymlare 2026 work signed by Jeremy Bícha.debian/is not shipped in any binary package, so Policy 2.3 does not require this and it would be minor at most; authorship of packaging files cannot be verified from the package. - Build and test results: this was a read-only review; per the brief, a clean build and the CTest suite are assumed to pass.
Proposed: debian/watch in version 5 format ◂
debian/watch is in an old format. This is the conversion made by uscan --update-watchfile, which has not been run against the upstream site: some defaults differ in version 5, so test it with uscan --report before use.
Version: 5
Source: https://gitlab.com/ubports/development/core/@PACKAGE@
Matching-Pattern: HEAD
Mode: git
Git-Pretty: 0.2.0~%cd
Uploader's response to the LLM review
Waiting for the uploader's response until , because the review found serious issues.