DFSG NEW Queue

DFSG, Licensing & New Packages Team

lomiri-system-settings-keeper 0~20230410-1

Package Information

DescriptionSecurity and privacy settings plugin for Lomiri system settings

This plugin provides the security and privacy settings plugin to lomiri-system-settings.

MaintainerDebian UBports Team <team+ubports@tracker.debian.org>
Changed ByJeremy Bícha <jbicha@ubuntu.com>
Sponsorjbicha@debian.org
Distributionexperimental
Architectureany
VCSgit: https://salsa.debian.org/ubports-team/lomiri-system-settings-keeper.git (browse)
Trackerhttps://tracker.debian.org/pkg/lomiri-system-settings-keeper
Uploaded2 hours ago

New Package Report

.changes◂
Version0~20230410-1
Changed-ByJeremy Bícha <jbicha@ubuntu.com>
Architecturesource amd64
Distributionexperimental
DateSat, 21 Nov 2026 21:02:51 +0100
Sourcelomiri-system-settings-keeper
Changelog◂
lomiri-system-settings-keeper (0~20230410-1) experimental; urgency=medium
 .
   * Initial release
.dsc◂
Package-Listlomiri-system-settings-keeper deb misc optional arch=any
Sectionmisc
Priorityoptional
Componentmain
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://gitlab.com/ubports/development/core/lomiri-system-settings-keeper
Upstream-Name: lomiri-system-settings-keeper

Files: *
Copyright: 2012-2016 Canonical Ltd.
           2021 UBports Foundation
License: GPL-3
 On Debian systems, the complete text of the GNU General
 Public License version 3 can be found in `/usr/share/common-licenses/GPL-3'.

DFSG Assistant LLM REVIEW 1 blocker, 1 important, 2 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 1 hour ago.

Proposes a replacement debian/watch: debian/watch in version 5 format

Report◂

DFSG NEW review for lomiri-system-settings-keeper version 0~20230410-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: No
  • Packaging is of good quality: No
  • Issues: 1 blocker, 1 important, 2 minor
  • debian/watch: old format (version 4)
  • debian/copyright: machine-readable
  • Scan before the review: nothing found

Licensing

Every upstream file is free software: PageComponent.qml and po/extractsettingsinfo are GPL-3 (version 3 only), the rest is GPL-3 under the catch-all, and COPYING holds the GPL-3 text, so there is no DFSG problem. debian/copyright is DEP-5 and its stanzas and short name match the notices, but it names only Canonical Ltd. and the UBports Foundation: the po/ translation headers also credit Rosetta Contributors and, in po/is.po, 'Icelandic translators of FOSS software', and those files are compiled with msgfmt into .mo catalogues that the binary package installs. Policy 2.3 requires those notices in debian/copyright.

Packaging

Base packaging is sound: compat 13, dh with all hardening flags, Hardware/DEP-14 Vcs fields, correct upstream metadata, current Standards-Version 4.7.4, and every build dependency resolvable (gettext arrives through debhelper -> po-debconf). Two real defects remain. The binary package's synopsis and long description say it is the security/privacy plugin, while the plugin is Backup & Restore. More seriously, the po/ directory holds the lomiri-system-settings accessibility plugin's translations, not this plugin's, and po/CMakeLists.txt installs them renamed to lomiri-system-settings-accessibility.mo: the keeper UI strings therefore have no translations, and the package ships ~80 catalogues under a text domain belonging to another plugin/package name.

Issues

blocker licensing 1. Files: * does not name the po/ translation copyright holders Rosetta Contributors and the Icelandic translators of FOSS software ◂
  • Files: debian/copyright:5-8, po/is.po:3, po/ar.po:2, po/CMakeLists.txt:70-72
  • Basis: checked, in the package or with a reference tool
  • Evidence: po/is.po:3 # Copyright (c) 2014 Icelandic translators of FOSS software; po/ar.po:2 # Copyright (c) 2013 Rosetta Contributors and Canonical Ltd 2013; debian/copyright has only Copyright: 2012-2016 Canonical Ltd. and 2021 UBports Foundation for Files: *.
  • Problem: The .po files are compiled by msgfmt into the .mo catalogues installed into /usr/share/locale/*/LC_MESSAGES (po/CMakeLists.txt:63-72), so they are shipped in compiled form, their GPL notice is not present in the .mo, and the GPL requires the copyright notices to be kept. Policy 2.3 therefore requires these holders in debian/copyright; the Canonical Ltd. part of the headers is covered, but Rosetta Contributors and the Icelandic translators are not. The same files' licence reference ('distributed under the same license as the lomiri-system-settings-accessibility package') resolves to GPL-3, which the catch-all states correctly.
  • Fix: Add a translation stanza, e.g. Files: po/* with Copyright: 2013-2015 Rosetta Contributors, 2013-2015 Canonical Ltd., 2014 Icelandic translators of FOSS software and License: GPL-3.
important packaging 2. po/*.po contain the accessibility plugin's strings and are installed as lomiri-system-settings-accessibility.mo, so the keeper UI is untranslated and the catalogues are dead ◂
  • Files: po/CMakeLists.txt:70-72, plugins/keeper/keeper.settings:4, po/is.po:26-38
  • Basis: checked, in the package or with a reference tool
  • Evidence: po/is.po (and the other 80 files) contain only msgid "Accessibility", msgid "accessibility", msgid "a11y"; po/CMakeLists.txt:72 RENAME lomiri-system-settings-accessibility.mo; plugins/keeper/keeper.settings:4 "translations": "lomiri-system-settings".
  • Problem: The installed catalogues are the lomiri-system-settings accessibility plugin's translations, saved under a filename that names that other plugin/package, while the keeper plugin's own i18n.tr strings in PageComponent.qml (and its manifest) use the lomiri-system-settings domain. The keeper UI therefore gets no translations at all, and the package installs ~80 .mo files under a text-domain filename that nothing in this package loads and that another source may want; if lomiri-system-settings ships the same path, installing both packages will fail with a file conflict.
  • Fix: Drop po/ from the build and install (patch po/CMakeLists.txt away or remove add_subdirectory(po)), or regenerate po/ from this project's own pot file and install it under the domain keeper.settings names, coordinating the filename with lomiri-system-settings.
minor packaging 3. Synopsis and long description call the keeper plugin a security and privacy plugin ◂
  • Files: debian/control:34-36, plugins/keeper/keeper.settings:3
  • Basis: checked, in the package or with a reference tool
  • Evidence: Description: Security and privacy settings plugin for Lomiri system settings / This plugin provides the security and privacy settings plugin to lomiri-system-settings.; keeper.settings:3 "name": "Backup & Restore"; README.md This plugin provides the backup/restore settings plugin.
  • Problem: The package installs the Backup & Restore (keeper) plugin, not a security/privacy plugin, so apt search and the package description mislead users about what is installed.
  • Fix: Change the synopsis and long description to say the package provides the backup and restore plugin for lomiri-system-settings.
minor packaging 4. debian/watch is in the old version 4 format ◂
  • Files: debian/watch
  • Basis: found by the review tooling's own checks
  • Evidence: version=4
  • Problem: Version 5 is the current format of debian/watch.
  • Fix: Convert it to version 5; a mechanical conversion is under Proposed changes.
Verified ◂
  • Upstream tree covered in full: CMakeLists.txt, cmake/QmlTest.cmake, COPYING, README.md, .gitignore, plugins/keeper/* and po/* (83 .po files plus CMakeLists.txt and extractsettingsinfo); the only binary file is plugins/keeper/settings-keeper.svg.
  • plugins/keeper/PageComponent.qml:1-20 has GNU General Public License version 3 (not or-later), matching the GPL-3 short name in debian/copyright; its 2023 date against 2021 UBports Foundation is only year drift with the holder named.
  • po/extractsettingsinfo is Copyright (C) 2013 Canonical Ltd. under GPL-3, covered by the catch-all holder and licence.
  • The many po headers reading Rosetta Contributors and Canonical Ltd ... are named as far as Canonical Ltd. goes; the unfilled Copyright (C) YEAR Canonical Ltd. headers (bn_BD, en_US, fr, fr_CA, hy, sc, sk) name Canonical.
  • COPYING is the GPL-3 text; the reference to /usr/share/common-licenses/GPL-3 is correct and the full text need not be repeated.
  • Copying the scan's four 'possibly named' groups: they reduce to Canonical Ltd., which is named, except the Rosetta Contributors part reported above; the scan's single 'not named' holder is po/is.po, reported above.
  • No non-free wording, field-of-use clause, no-modification or non-commercial term anywhere in the tree; no Files-Excluded in debian/copyright and none needed.
  • debian/patches/0001_rename.patch is DEP-3 (From, Date, Subject, Origin with the upstream MR) and only switches the QML import to Lomiri.Keeper 0.2; no third-party file is introduced.
  • Build-Depends resolve in the archive: cmake, cmake-extras, liblomirisystemsettings-dev, liblomirisystemsettingsprivate-dev, pkgconf, python3, qtbase5-dev, qtdeclarative5-dev; qml-module-lomiri-keeper is not in the archive yet but is built by lomiri-keeper, waiting in NEW for experimental, so the runtime dependency is satisfiable.
  • gettext is not in Build-Depends, but xgettext/msgfmt needed by po/CMakeLists.txt at configure time come transitively: debhelper depends on po-debconf, which depends on gettext; a clean sbuild chroot gets them.
  • There are no tests (no add_qml_test call and no tst_*.qml), so the <!nocheck> build dependencies (lomiri-system-settings, qml-module-lomiri-components, qml-module-qtquick2, qtbase5-private-dev, xvfb) are simply unused; nothing outside a test uses them and no nocheck build failure follows.
  • debian/control declares compat 13 with ${misc:Depends} present; no maintainer scripts, install/links/docs files, tests/control or gbp.conf exist to review; changelog is well formed and Vcs-*/Homepage are correct; Standards-Version 4.7.4 matches the reviewing system's Policy 4.7.4.1.
  • uscan found the packaged version as the newest upstream release (upstream 0~20230410, packaged 0~20230410).
  • Every pointer of debian/copyright to /usr/share/common-licenses names a file that is there (GPL-3).
Not confirmed ◂
  • Whether lomiri-system-settings (or any other package) also installs /usr/share/locale/*/LC_MESSAGES/lomiri-system-settings-accessibility.mo; binary file lists are not available here, so a dpkg file conflict with the renamed catalogues could not be verified, only the wrong text domain itself.
  • Whether LomiriSystemSettings.pc's plugin_manifest_dir is under an architecture-specific libdir; the Lomiri development packages are not installed on the reviewing system, so whether Architecture: any (rather than all) is required for this QML-only package could not be checked.
  • plugins/keeper/settings-keeper.svg was not opened (image file); its provenance is judged only from its place in the tree and it is covered by Files: *.
Proposed: debian/watch in version 5 format ◂

debian/watch is in an old format. This is the conversion made by uscan --update-watchfile, which has not been run against the upstream site: some defaults differ in version 5, so test it with uscan --report before use.

Version: 5

Source: https://gitlab.com/ubports/development/core/@PACKAGE@
Matching-Pattern: HEAD
Mode: git
Git-Pretty: 0~%cd

Uploader's response to the LLM review

Waiting for the uploader's response until , because the review found serious issues.

Back to Dashboard | View all reviews for this package