Review: lpac 2.3.0-1
New Package Report
.changes
| Distribution | unstable |
|---|---|
| Date | Fri, 03 Apr 2026 10:56:59 +0000 |
| Source | lpac |
| Version | 2.3.0-1 |
| Changed-By | Yifei Zhan |
| Architecture | amd64 arm64 armhf source |
Changelog
lpac (2.3.0-1) unstable; urgency=medium . [ erebion ] * Initial lpac 2.3.0 release. (Closes: #1080482)
.dsc
| Package-List | lpac deb utils optional arch=amd64,armhf,arm64 |
|---|---|
| Section | utils |
| Priority | optional |
| Component | main |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: lpac Source: https://github.com/estkme-group/lpac Files: debian/* Copyright: 2025 erebion <erebion@erebion.eu> License: MIT Files: src/* driver/* utils/* Copyright: 2023-2025 ESTKME TECHNOLOGY LIMITED, Hong Kong License: AGPL-v3.0-only Files: euicc/* Copyright: 2023-2025 ESTKME TECHNOLOGY LIMITED, Hong Kong License: LGPL-v2.1-only Files: cjson/* dlfcn-win32/* docs/* .github/* cmake/* CMakeLists.txt README.md .editorconfig .clang-format .git-blame-ignore-revs .gitignore Copyright: 2023-2025 ESTKME TECHNOLOGY LIMITED, Hong Kong License: MIT License: AGPL-v3.0-only This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. . This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for more details. . You should have received a copy of the GNU Affero General Public License along with this program. If not, see <https://www.gnu.org/licenses/>. License: LGPL-v2.1-only This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. . This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. . You should have received a copy of the GNU Lesser General Public License along with this library; if not, see <https://www.gnu.org/licenses/>. License: MIT The MIT License (MIT) . Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Review Information
rejected — allocated to awm 11 days ago, started 11 days ago, completed 11 days ago.
Final Comment
In REUSE.toml a variety of additional copyright holders are identified who should
also be mentioned in debian/copyright.
Another one is in driver/apdu/mbim.c
The Lintian message about various files not having copyright information is because
there is no "Files: *" stanza to handle the fallback case of who are the authors -
if you added this stanza Lintian would then skip these files (though they are still
regularly misidentified as being licensed under the terms of the license they
descibe, which can be ignored, unless they're in a subdirectory on their own with
some included source).
The lintian message about possibly unindented list is that the package description
needs a two-space indent for items in a list.
Thanks!
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 2.3.0-1 | e220f859… | 2026-04-04 03:21 | 2026-04-04 03:35 | awm | accepted | VIEW |
Public Notes
11 days ago
● public
Lintian
Command: lintian -Iiv -L '>=warning' --show-overrides --color=never ../$(basename $PWD)_*.changes
Exit code: 0
N:
W: lpac source: file-without-copyright-information LICENSES/AGPL-3.0-only.txt [debian/copyright]
N:
N: The source tree contains a file which was not matched by any of the Files
N: paragraphs in debian/copyright. Either adjust existing wildcards to match
N: that file or add a new Files paragraph.
N:
N: Please refer to
N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N: details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/copyright/dep5
N:
N:
W: lpac source: file-without-copyright-information LICENSES/CC0-1.0.txt [debian/copyright]
N:
W: lpac source: file-without-copyright-information LICENSES/LGPL-2.1-only.txt [debian/copyright]
N:
W: lpac source: file-without-copyright-information LICENSES/LicenseRef-ESTKME-Commercial.txt [debian/copyright]
N:
W: lpac source: file-without-copyright-information LICENSES/MIT.txt [debian/copyright]
N:
W: lpac source: file-without-copyright-information REUSE.toml [debian/copyright]
N:
W: lpac source: newer-standards-version 4.7.4 (current is 4.7.3)
N:
N: The source package refers to a Standards-Version which is newer than the
N: highest one Lintian is programmed to check.
N:
N: If the source package is correct, please upgrade Lintian to the newest
N: version.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: fields/standards-version
N:
N:
W: lpac: possible-unindented-list-in-extended-description line 5
N:
N: The package "Description:" contains an unindented line which starts with a
N: dash (-) or asterisk (*). If this was meant to be a list of items these
N: lines need to be indented (dselect would word-wrap these lines otherwise).
N:
N: Please refer to Description (Section 5.6.13) in the Debian Policy Manual
N: for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: fields/description
N:
N:
W: lpac: possible-unindented-list-in-extended-description line 5
N:
W: lpac: possible-unindented-list-in-extended-description line 5
11 days ago
● public
Licenserecon
Command: lrc -s
Exit code: 3
en: Versions: licenserecon '14.0' licensecheck '3.3.9-1'
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
d/copyright | licensecheck
AGPL-v3.0-only | Expat driver/apdu/mbim.c
AGPL-v3.0-only | AGPL-3 driver/LICENSE
LGPL-v2.1-only | LGPL-2.1 euicc/LICENSE
MIT | CC0-1.0 .github/workflows/reuse-lint.yaml
| AGPL-3 LICENSES/AGPL-3.0-only.txt
| CC0-1.0 LICENSES/CC0-1.0.txt
| LGPL-2.1 LICENSES/LGPL-2.1-only.txt
| Expat LICENSES/MIT.txt
AGPL-v3.0-only | AGPL-3 src/LICENSE
Short option in use. Not all differences shown
11 days ago
● public
CME fix
Command: cme fix --verbose dpkg
Exit code: 0
cme: running fix on dpkg configuration...
Connecting to api.ftp-master.debian.org to check 8 package versions. Please wait...
Got info from api.ftp-master.debian.org for 8 packages.
Warning in 'control source Standards-Version': Current standards version '4.7.4' is newer than lintian version (4.7.3). Please check your system
(this cannot be fixed with 'cme fix' command)
Offending value: '4.7.4'
Warning in 'control binary:lpac Description': lintian like possible-unindented-list-in-extended-description. i.e. "-" or "*" without leading white space
Offending value:
+++++
lpac is a cross-platform local profile agent program, its features include:
- Supports Activation Code and Confirmation Code
- Supports Custom IMEI sent to server
- Supports Profile Discovery (SM-DS)
- Profile management: list, enable, disable, delete and nickname
- Notification management: list, send and delete
- Lookup eUICC chip info
+++++
Warning in 'copyright Files:"debian/*" License short_name': value is "MIT". There are many versions of the MIT license. Please use Expat instead, when it matches. See L<Debian copyright format|https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-specification> and L<wikipedia|https://en.wikipedia.org/wiki/MIT_License#Various_versions>for details.
Offending value: 'MIT'
Warning in 'copyright Files:"cjson/* dlfcn-win32/* docs/* .github/* cmake/* CMakeLists.txt[...]" License short_name': value is "MIT". There are many versions of the MIT license. Please use Expat instead, when it matches. See L<Debian copyright format|https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-specification> and L<wikipedia|https://en.wikipedia.org/wiki/MIT_License#Various_versions>for details.
Offending value: 'MIT'
License Expat is not used in Files: section
License Expat is not used in Files: section
License Expat is not used in Files: section
Changes applied to dpkg configuration:
- control source Build-Depends:0: removed redundant initial value
- control source debhelper-version: removed redundant initial value
- control binary:lpac Description: 'lpac is a cross-platform local profile agent program, its fe[...]' -> 'lpac is a cross-platform local profile agent program, its fe[...]' # applied fix for :lintian like possible-unindented-list-in-extended-description. i.e. "-" or "*" without leading white space
- copyright License:Expat text: 'The MIT License Permission is hereby granted, free of charg[...]' -> 'The MIT License (MIT) Permission is hereby granted, free of[...]'
- copyright License: rename key from 'MIT' to 'Expat'
- copyright Files:"debian/*" License short_name: 'MIT' -> 'Expat' # applied fix for :value is "MIT". There are many versions of the MIT license. Please use Expat instead, when it matches. See L<Debian copyright format|https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-specification> and L<wikipedia|https://en.wikipedia.org/wiki/MIT_License#Various_versions>for details.
- copyright Files:"cjson/* dlfcn-win32/* docs/* .github/* cmake/* CMakeLists.txt
README.md .editorconfig .clang-format .git-blame-ignore-revs .gitignore" License short_name: 'MIT' -> 'Expat' # applied fix for :value is "MIT". There are many versions of the MIT license. Please use Expat instead, when it matches. See L<Debian copyright format|https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-specification> and L<wikipedia|https://en.wikipedia.org/wiki/MIT_License#Various_versions>for details.
11 days ago
● public
Search for SPDX license declarations
Command: grep -r -B1 'SPDX-'
Exit code: 0
driver/apdu/mbim.c:// SPDX-License-Identifier: MIT
--
driver/apdu/mbim.h:// SPDX-License-Identifier: MIT
--
driver/apdu/qmi.c:// SPDX-License-Identifier: MIT
--
driver/apdu/qmi.h:// SPDX-License-Identifier: MIT
--
driver/apdu/qmi_qrtr.c:// SPDX-License-Identifier: MIT
--
driver/apdu/qmi_common.h:// SPDX-License-Identifier: MIT
--
driver/apdu/mbim_helpers.c:// SPDX-License-Identifier: MIT
--
driver/apdu/mbim_helpers.h:// SPDX-License-Identifier: MIT
--
driver/apdu/qmi_common.c:// SPDX-License-Identifier: MIT
--
driver/apdu/qmi_helpers.c:// SPDX-License-Identifier: MIT
--
driver/apdu/qmi_helpers.h:// SPDX-License-Identifier: MIT
--
driver/apdu/qmi_qrtr.h:// SPDX-License-Identifier: MIT
--
.github/workflows/reuse-lint.yaml:# SPDX-FileCopyrightText: 2022 Free Software Foundation Europe e.V. <https://fsfe.org>
.github/workflows/reuse-lint.yaml-#
.github/workflows/reuse-lint.yaml:# SPDX-License-Identifier: CC0-1.0
--
REUSE.toml-]
REUSE.toml:SPDX-FileCopyrightText = "2023-2025 ESTKME TECHNOLOGY LIMITED, Hong Kong"
REUSE.toml:SPDX-License-Identifier = "AGPL-3.0-only"
--
REUSE.toml-path = ["euicc/**"]
REUSE.toml:SPDX-FileCopyrightText = "2023-2025 ESTKME TECHNOLOGY LIMITED, Hong Kong"
REUSE.toml:SPDX-License-Identifier = "LGPL-2.1-only OR LicenseRef-ESTKME-Commercial"
--
REUSE.toml-]
REUSE.toml:SPDX-FileCopyrightText = "2023-2025 ESTKME TECHNOLOGY LIMITED, Hong Kong"
REUSE.toml:SPDX-License-Identifier = "MIT"
--
REUSE.toml-path = ["cjson/**"]
REUSE.toml:SPDX-FileCopyrightText = "2009-2017 Dave Gamble and cJSON contributors"
REUSE.toml:SPDX-FileContributor = [
--
REUSE.toml-]
REUSE.toml:SPDX-License-Identifier = "MIT"
--
REUSE.toml-path = ["dlfcn-win32/**"]
REUSE.toml:SPDX-FileCopyrightText = "2007 Ramiro Polla"
REUSE.toml:SPDX-FileContributor = [
--
REUSE.toml-]
REUSE.toml:SPDX-License-Identifier = "MIT"