Review: matrix-eno-bot 0.0~git20240903-1
New Package Report
.changes
| Changed-By | Russell Coker |
|---|---|
| Architecture | source amd64 |
| Distribution | unstable |
| Date | Sun, 05 Apr 2026 15:04:54 +1000 |
| Source | matrix-eno-bot |
| Version | 0.0~git20240903-1 |
Changelog
matrix-eno-bot (0.0~git20240903-1) unstable; urgency=medium . * Initial release. (Closes: #1116693)
.dsc
| Section | net |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | matrix-eno-bot deb net optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Source: https://github.com/8go/matrix-eno-bot Upstream-Name: matrix-eno-bot Upstream-Contact: Files: * Copyright: 2025 8go License: Apache License 2.0 Files: debian/* Copyright: 2025 Russell Coker <russell@coker.com.au> License: GPL-2+ This package is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. . This package is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. . You should have received a copy of the GNU General Public License along with this package. If not, see <https://www.gnu.org/licenses/>. Comment: On Debian systems, the complete text of the GNU General Public License version 2 can be found in "/usr/share/common-licenses/GPL-2".
Review Information
accepted — allocated to mechtilde 1 day ago, started 1 day ago, completed 1 day ago.
Final Comment
hi,
before the next upload, please fix lintian warnings.
In d/control remove template entries and update to recent standrd version, please.
Public Notes
1 day ago
● public
Lintian
Command: lintian -c -E -I -i -L '>=warning' --show-overrides --color=never ../$(basename $PWD)_*.changes
Exit code: 2
N:
E: matrix-eno-bot source: debian-rules-is-dh_make-template [debian/rules:25]
N:
N: The debian/rules file appears to be an unmodified or insufficiently
N: modified copy of the dh_make template.
N:
N: Please double-check the rules file.
N:
N: Visibility: error
N: Show-Always: no
N: Check: debian/rules
N:
N:
E: matrix-eno-bot: python-package-missing-depends-on-python
N:
N: The specified Python package ships Python modules under /usr/lib but does
N: not specify any dependency on Python.
N:
N: This is likely an omission, the result of a typo in debian/control or the
N: file should not be installed.
N:
N: Visibility: error
N: Show-Always: no
N: Check: languages/python
N:
N:
E: matrix-eno-bot: python3-script-but-no-python3-dep python3 (does not satisfy python3:any | python3-minimal:any) [usr/sbin/matrix-eno-bot]
N:
N: Packages with Python3 scripts should depend on the package python3. Those
N: with scripts that specify a specific version of Python3 must depend,
N: recommend or suggest on that version of Python3 (exactly).
N:
N: For example, if a script in the package uses #!/usr/bin/python3, the
N: package needs a dependency on python3. If a script uses
N: #!/usr/bin/python3.8, the package needs a dependency on python3.8. A
N: dependency on python (>= 3.8) is not correct, since later versions of
N: Python may not provide the /usr/bin/python3.8 binary.
N:
N: If you are using debhelper, adding ${python3:Depends} to the Depends field
N: and ensuring dh_python3 is run during the build should take care of adding
N: the correct dependency.
N:
N: In some cases a weaker relationship, such as Suggests or Recommends, will
N: be more appropriate.
N:
N: Visibility: error
N: Show-Always: no
N: Check: scripts
N:
N:
W: matrix-eno-bot source: bad-homepage <insert the upstream URL, if relevant>
N:
N: The "Homepage:" field in this package's control file does not contain a
N: valid absolute URL. Most probably you forgot to specify the scheme (e.g.
N: http).
N:
N: This tag is also triggered if the scheme is not known by Lintian.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: fields/homepage
N:
N:
W: matrix-eno-bot: bad-homepage <insert the upstream URL, if relevant>
N:
W: matrix-eno-bot source: dh-make-template-in-source [debian/README.Debian.ex]
N:
N: The named file looks like a dh_make template.
N:
N: Source files like debian/*.ex or debian/ex.* were usually installed by
N: dh_make. They are meant to be renamed after they were adapted by the
N: maintainer.
N:
N: Unused templates should be removed.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: dh-make/template
N:
N:
W: matrix-eno-bot source: dh-make-template-in-source [debian/upstream.ex/]
N:
W: matrix-eno-bot source: maintainer-script-lacks-debhelper-token [debian/postrm]
N:
N: This package is built using debhelper commands that may modify maintainer
N: scripts, but the maintainer scripts do not contain the "#DEBHELPER#" token
N: debhelper uses to modify them.
N:
N: Adding the token to the scripts is recommended.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debhelper
N:
N:
W: matrix-eno-bot: maintainer-script-needs-depends-on-adduser adduser (does not satisfy adduser) [postinst:9]
N:
N: This script calls adduser, but the package does not depend or pre-depend
N: on the adduser package.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: scripts
N:
N:
W: matrix-eno-bot source: missing-license-paragraph-in-dep5-copyright apache license 2.0 [debian/copyright:10]
N:
N: The Files paragraph in the machine readable copyright file references a
N: license for which no stand-alone License paragraph exists.
N:
N: Sometimes this tag appears because of incorrect ordering. Stand-alone
N: License paragraphs must appear *after* all Files paragraphs.
N:
N: Please refer to
N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ and
N: Bug#959067 for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/copyright/dep5
N:
N:
W: matrix-eno-bot: no-manual-page [usr/sbin/matrix-eno-bot]
N:
N: Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have
N: a manual page
N:
N: Note that though the man program has the capability to check for several
N: program names in the NAMES section, each of these programs should have its
N: own manual page (a symbolic link to the appropriate manual page is
N: sufficient) because other manual page viewers such as xman or tkman don't
N: support this.
N:
N: If the name of the manual page differs from the binary by case, man may be
N: able to find it anyway; however, it is still best practice to match the
N: exact capitalization of the executable in the manual page.
N:
N: If the manual pages are provided by another package on which this package
N: depends, Lintian may not be able to determine that manual pages are
N: available. In this case, after confirming that all binaries do have manual
N: pages after this package and its dependencies are installed, please add a
N: Lintian override.
N:
N: Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
N: for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: binary-without-manpage
N:
N:
W: matrix-eno-bot: recursive-privilege-change "chown -R" [postinst:10]
N:
N: The named maintainer script appears to call chmod or chown with a
N: --recursive/-R argument, or it uses find(1) with similar intent.
N:
N: All such uses are vulnerable to hardlink attacks on mainline (i.e.
N: non-Debian) kernels that do not set fs.protected_hardlinks=1.
N:
N: The security risk arises when a non-privileged user set links to files
N: they do not own, such as such as /etc/shadow or files in /var/lib/dpkg/. A
N: superuser's recursive call to chown or chmod on behalf of a role user
N: account would then modify the non-owned files in ways that allow the
N: non-privileged user to manipulate them later.
N:
N: There are several ways to mitigate the issue in maintainer scripts:
N:
N: - For a static role user, please call chown at build time
N: and not during the installation.
N: - If that is too complicated, use runuser(1) in the
N: relevant build parts to create files with correct ownership.
N: - Given a static list of files to change, use non-recursive calls
N: for each file. (Please do not generate the list with find.)
N:
N: Please refer to Bug#895597, Bug#889060, Bug#889488, and the runuser(1)
N: manual page for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: scripts
N: Renamed from: maintainer-script-should-not-use-recursive-chown-or-chmod
N:
N:
W: matrix-eno-bot source: space-in-std-shortname-in-dep5-copyright apache license 2.0 [debian/copyright:10]
N:
N: The “License” field contains a short name with a space, which does not
N: conform to the specification.
N:
N: Please refer to
N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N: details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/copyright/dep5
N:
N:
W: matrix-eno-bot source: superfluous-clutter-in-homepage <insert the upstream URL, if relevant>
N:
N: The "Homepage:" field in this package's control file contains superfluous
N: markup around the URL, like enclosing < and >. This is unnecessary and
N: needlessly complicates using this information.
N:
N: Please refer to Homepage (Section 5.6.23) in the Debian Policy Manual for
N: details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: fields/homepage
N:
N:
W: matrix-eno-bot: superfluous-clutter-in-homepage <insert the upstream URL, if relevant>