Review: mtfmapper 0.7.41-1
New Package Report
.changes
| Version | 0.7.41-1 |
|---|---|
| Changed-By | Dima Kogan |
| Architecture | source amd64 |
| Distribution | unstable |
| Date | Tue, 05 May 2026 21:04:45 -0700 |
| Source | mtfmapper |
Changelog
mtfmapper (0.7.41-1) unstable; urgency=medium . * Initial release into Debian (Closes: #1135219)
.dsc
| Section | devel |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | mtfmapper deb devel optional arch=any |
debian/copyright
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://sourceforge.net/p/mtfmapper/
Upstream-Contact: Frans van den Bergh <fvdbergh@gmail.com>
Upstream-Name: mtfmapper
Files: *
Copyright: 2011-2021 Frans van den Bergh <fvdbergh@gmail.com>
License: BSD-2
Files: debian/*
Copyright: 2026 Dima Kogan <dkogan@debian.org>
License: BSD-2
Files: cmake_helpers/FindEigen3.cmake
Copyright: 2006, 2007 Montel Laurent <montel@kde.org>
2008, 2009 Gael Guennebaud <g.gael@free.fr>
2009 Benoit Jacob <jacob.benoit.1@gmail.com>
License: BSD-2
Files: cmake_helpers/UseLATEX.cmake
Copyright: 2004 Sandia Corporation
License: uselatex
Files: include/fastexp.h
Copyright: 2011 Paul Mineiro <paul@mineiro.com>
License: BSD-3
Files: include/find_polynomial_roots_jenkins_traub.h
src/find_polynomial_roots_jenkins_traub.cc
Copyright: 2015 The Regents of the University of California (Regents)
License: BSD-3
Files: include/five_point_focal_length_radial_distortion.h
src/five_point_focal_length_radial_distortion.cc
Copyright: 2014 The Regents of the University of California (Regents)
License: BSD-3
License: BSD-2
Redistribution and use in source and binary forms, with or without modification, are
permitted provided that the following conditions are met:
.
1. Redistributions of source code must retain the above copyright notice, this list of
conditions and the following disclaimer.
.
2. Redistributions in binary form must reproduce the above copyright notice, this list
of conditions and the following disclaimer in the documentation and/or other materials
provided with the distribution.
.
THIS SOFTWARE IS PROVIDED BY Frans van den Bergh ''AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL Frans van den Bergh OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
License: uselatex
Redistribution and use in source and binary forms, with
or without modification, are permitted provided that this Notice and any
statement of authorship are reproduced on all copies.
License: BSD-3
Redistribution and use in source and binary forms, with
or without modification, are permitted provided that the
following conditions are met:
.
* Redistributions of source code must retain the
above copyright notice, this list of conditions and
the following disclaimer.
.
* Redistributions in binary form must reproduce the
above copyright notice, this list of conditions and
the following disclaimer in the documentation and/or
other materials provided with the distribution.
.
* Neither the name of Paul Mineiro nor the names
of other contributors may be used to endorse or promote
products derived from this software without specific
prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER
OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE
GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
POSSIBILITY OF SUCH DAMAGE.
Review Information
rejected — allocated to awm 1 day ago, started 1 day ago, completed 1 day ago.
Final Comment
Hi,
There is some credit and license correction needed in debian/copyright
because the include/threadpool.h appears to be licensed with Zlib license
and needs authors recognized (see full notes for names).
There is also some copyright/author apparently in the manual that is
also missed.
While you're fixing that, consider reviewing the full notes, with a
lintian warning and the output from 'cme' which fixes some license
naming problems also ('BSD-2' -> 'BSD-2-Clause' etc to apply standard
names).
All pretty minor stuff, but the copyright changes are necessary, I think.
Thanks!
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 0.7.41-1 | 993374e2… | 2026-05-07 06:24 | 2026-05-07 06:28 | awm | accepted | VIEW |
Public Notes
Missed Author Check
Command: dnq author-check -prepare
Exit code: 0
Author check: scanned 384 files.
NOT IN debian/copyright (3):
Jakob Progsch, Va'clav Zeman
include/threadpool.h:2
Lu Wang <coolwanglu@gmail.com>
doc/html/mtf_mapper_user_guide.html:11
doc/html/mtf_mapper_user_guide.html:17
doc/html/mtf_mapper_user_guide.html:4930
Mozilla Foundation
doc/html/mtf_mapper_user_guide.html:4929
Result: ATTENTION REQUIRED — 3 authors not in debian/copyright
Lintian
Command: lintian -Iiv -L '>=warning' --show-overrides --color=never ../$(basename $PWD)_*.changes
Exit code: 0
N:
W: mtfmapper source: uses-debhelper-compat-file [debian/compat]
N:
N: This package declares its debhelper compatibility level with the
N: debian/compat file.
N:
N: The recommended way to do so is to use the virtual package
N: debhelper-compat instead.
N:
N: From debhelper 14 onward, using debian/compat will not work anymore.
N:
N: As such, unless you need an experimental or beta compatibility level,
N: please remove the debian/compat file and add the debhelper-compat virtual
N: package to your Build-Depends, for example:
N:
N: Build-Depends: debhelper-compat (= 13)
N:
N: Please refer to the debhelper(7) manual page for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debhelper
N:
Licenserecon
Command: lrc -s
Exit code: 3
en: Versions: licenserecon '14.0' licensecheck '3.3.9-1'
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
d/copyright | licensecheck
BSD-2-clause | BSD-2-Clause-Views include/afft.h
BSD-2-clause | Zlib include/threadpool.h
BSD-2-clause | BSD-2-Clause-Views include/thresholding.h
Short option in use. Not all differences shown
CME fix
Command: cme fix --verbose dpkg
Exit code: 0
cme: running fix on dpkg configuration...
Warning in 'control source Standards-Version': Current standards version is '4.7.4'. Please read https://www.debian.org/doc/debian-policy/upgrading-checklist.html for the changes that may be needed on your package
to upgrade it from standard version '4.6.0' to '4.7.4'.
Offending value: '4.6.0'
Warning in 'control source Build-Depends:0': compat parameter is deprecated. Please use debhelper-compat dependency. See debhelper(7) for details.
Offending value: 'debhelper-compat (= 13)'
Warning in 'control source Build-Depends:0': compat parameter is deprecated. Please use debhelper-compat dependency. See debhelper(7) for details.
Offending value: 'debhelper (>= 13)'
Warning in 'control source Build-Depends:0': debhelper dependency is deprecated. It should be a dependency for debhelper-compat package
Offending value: 'debhelper (>= 13)'
Warning in 'copyright Format': Format uses insecure http protocol instead of https
Offending value: 'http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/'
Warning in 'copyright Files:"*" License short_name': Please use BSD-x-clause name, like BSD-3-clause
Offending value: 'BSD-2'
Warning in 'copyright Files:"debian/*" License short_name': Please use BSD-x-clause name, like BSD-3-clause
Offending value: 'BSD-2'
Warning in 'copyright Files:"cmake_helpers/FindEigen3.cmake" License short_name': Please use BSD-x-clause name, like BSD-3-clause
Offending value: 'BSD-2'
Warning in 'copyright Files:"include/fastexp.h" License short_name': Please use BSD-x-clause name, like BSD-3-clause
Offending value: 'BSD-3'
Warning in 'copyright Files:"include/find_polynomial_roots_jenkins_traub.h[...]" License short_name': Please use BSD-x-clause name, like BSD-3-clause
Offending value: 'BSD-3'
Warning in 'copyright Files:"include/five_point_focal_length_radial_distortion.h[...]" License short_name': Please use BSD-x-clause name, like BSD-3-clause
Offending value: 'BSD-3'
License BSD-2-clause is not used in Files: section
License BSD-2-clause is not used in Files: section
License BSD-2-clause is not used in Files: section
License BSD-3-clause is not used in Files: section
License BSD-3-clause is not used in Files: section
License BSD-3-clause is not used in Files: section
Changes applied to dpkg configuration:
- control source Build-Depends:0: 'debhelper-compat (= 13)' -> 'debhelper (>= 13)' # conflicting initial values
- control source Standards-Version: '4.6.0' -> '4.7.4' # applied fix for :Current standards version is '4.7.4'. Please read https://www.debian.org/doc/debian-policy/upgrading-checklist.html for the changes that may be needed on your package
to upgrade it from standard version '4.6.0' to '4.7.4'.
- compat deleted value: '13'
- control source Build-Depends:0: 'debhelper (>= 13)' -> 'debhelper-compat (= 13)' # applied fix for :Cleared deprecated compat value; changed debhelper dependency to debhelper dependency
- copyright Format: 'http://www.debian.org/doc/packaging-manuals/copyright-format[...]' -> 'https://www.debian.org/doc/packaging-manuals/copyright-forma[...]' # applied fix for :Format uses insecure http protocol instead of https
- copyright License:"BSD-2-clause" text has new value: 'Redistribution and use in source and binary forms, with or w[...]'
- copyright License: rename key from 'BSD-2' to 'BSD-2-clause'
- copyright Files:"*" License short_name: 'BSD-2' -> 'BSD-2-clause' # applied fix for :Please use BSD-x-clause name, like BSD-3-clause
- copyright Files:"debian/*" License short_name: 'BSD-2' -> 'BSD-2-clause' # applied fix for :Please use BSD-x-clause name, like BSD-3-clause
- copyright Files:"cmake_helpers/FindEigen3.cmake" License short_name: 'BSD-2' -> 'BSD-2-clause' # applied fix for :Please use BSD-x-clause name, like BSD-3-clause
- copyright License:"BSD-3-clause" text: 'The BSD License Redistribution and use in source and binary[...]' -> 'Redistribution and use in source and binary forms, with or w[...]'
- copyright License: rename key from 'BSD-3' to 'BSD-3-clause'
- copyright Files:"include/fastexp.h" License short_name: 'BSD-3' -> 'BSD-3-clause' # applied fix for :Please use BSD-x-clause name, like BSD-3-clause
- copyright Files:"include/find_polynomial_roots_jenkins_traub.h
src/find_polynomial_roots_jenkins_traub.cc" License short_name: 'BSD-3' -> 'BSD-3-clause' # applied fix for :Please use BSD-x-clause name, like BSD-3-clause
- copyright Files:"include/five_point_focal_length_radial_distortion.h
src/five_point_focal_length_radial_distortion.cc" License short_name: 'BSD-3' -> 'BSD-3-clause' # applied fix for :Please use BSD-x-clause name, like BSD-3-clause
- patches:"730-force-sequential-build-of-man-pages.patch" Synopsis has new value: 'force sequential build of man pages' # applied fix for :Empty synopsis
- patches:"cmake-3.5.patch" Synopsis has new value: 'Cmake 3.5' # applied fix for :Empty synopsis
deleting debian/compat
Config::Model::Backend::DpkgSyntax::parse_dpkg_lines No section found in file debian/patches/cmake-3.5.patch (line 146)
License Check
Command: dnq license-check -prepare
Exit code: 0
License check [main]:
Found 3 unique license identifier(s) in debian/copyright:
COMPATIBLE (2):
BSD-2-clause
BSD-3-clause
UNKNOWN (not in DFSG license database):
uselatex (manually verify DFSG compatibility)
Result: ATTENTION REQUIRED
- 1 unrecognized license(s) require manual review