DFSG NEW Queue

DFSG, Licensing & New Packages Team

Review: munit 1.3.6+ds-1

Package Information

DescriptionScala testing library with actionable errors (Scala 2.13)

MUnit is a testing library for Scala. Tests are written as functions in a test suite class and run as JUnit tests. Failed assertions show the source location and a diff of the obtained and expected values.

This package provides org.scalameta:munit_2.13 and org.scalameta:munit-diff_2.13, built for Scala 2.13.

MaintainerDebian Java Maintainers <pkg-java-maintainers@lists.alioth.debian.org>
Changed ByJuan Manuel Méndez Rey <juan.mendezr@proton.me>
Sponsortsimonq2@debian.org
Distributionunstable
Architectureall
VCSgit: https://salsa.debian.org/java-team/munit.git (browse)
Closes#1152797
Trackerhttps://tracker.debian.org/pkg/munit
Uploaded2 hours ago

New Package Report

.changes◂
Version1.3.6+ds-1
Changed-ByJuan Manuel Méndez Rey <juan.mendezr@proton.me>
Architecturesource all
Distributionunstable
DateThu, 05 Nov 2026 01:17:24 +0100
Sourcemunit
Changelog◂
munit (1.3.6+ds-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1152797).
.dsc◂
Priorityoptional
Componentmain
Package-Listlibmunit-junit-interface-java deb java optional arch=all
libmunit-scala2.13-java deb java optional arch=all
libmunit-scala3-java deb java optional arch=all
Sectionjava
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: munit
Upstream-Contact: https://github.com/scalameta/munit/issues
Source: https://github.com/scalameta/munit
Files-Excluded:
 bin/scalafmt
 munit/js
 munit/js-native
 munit/native
 package-lock.json
 package.json
 tests/js
 tests/native
 website
 yarn.lock
Comment: bin/scalafmt is a launcher with a prebuilt zip appended. The
 website and its npm files are not built. The Scala.js and Scala Native
 trees are not built and hold the Scala.js and JUnit 4 translations that
 NOTICE.md describes.

Files: *
Copyright: 2020-2026 Ólafur Páll Geirsson
 2020-2026 Tomasz Godzik
 2020-2026 Gabriele Petronella
 2020-2026 Andrew Valencik
 2020-2026 Albert Meltzer
 2020-2026 other MUnit contributors
License: Apache-2.0
Comment: No file carries a copyright notice; holders from upstream's git
 history.

Files: junit-interface/src/main/java/munit/internal/junitinterface/AbstractAnnotatedFingerprint.java
 junit-interface/src/main/java/munit/internal/junitinterface/AbstractEvent.java
 junit-interface/src/main/java/munit/internal/junitinterface/Ansi.java
 junit-interface/src/main/java/munit/internal/junitinterface/EmptyRunner.java
 junit-interface/src/main/java/munit/internal/junitinterface/EventDispatcher.java
 junit-interface/src/main/java/munit/internal/junitinterface/GlobFilter.java
 junit-interface/src/main/java/munit/internal/junitinterface/JUnit3Fingerprint.java
 junit-interface/src/main/java/munit/internal/junitinterface/JUnitFingerprint.java
 junit-interface/src/main/java/munit/internal/junitinterface/JUnitFramework.java
 junit-interface/src/main/java/munit/internal/junitinterface/JUnitRunner.java
 junit-interface/src/main/java/munit/internal/junitinterface/JUnitTask.java
 junit-interface/src/main/java/munit/internal/junitinterface/RichLogger.java
 junit-interface/src/main/java/munit/internal/junitinterface/RunSettings.java
 junit-interface/src/main/java/munit/internal/junitinterface/RunStatistics.java
 junit-interface/src/main/java/munit/internal/junitinterface/RunWithFingerprint.java
 junit-interface/src/main/java/munit/internal/junitinterface/SilentFilterRequest.java
 junit-interface/src/main/java/munit/internal/junitinterface/TestFilter.java
Copyright: 2009-2012 Stefan Zeiger
 2020-2026 Ólafur Páll Geirsson
 2020-2026 other MUnit contributors
License: BSD-2-clause and Apache-2.0
Comment: From sbt's junit-interface (com.novocode.junit), moved into MUnit in
 2020. TestFilter.java says it is mostly copied from a 2009 Stack Overflow
 answer (questions/1230706); it shares with it only the JUnit Filter method
 signatures, a delimiter constant and one substring call.

Files: munit-diff/shared/src/main/scala/munit/diff/DifferentiationFailedException.scala
 munit-diff/shared/src/main/scala/munit/diff/MyersDiff.scala
 munit-diff/shared/src/main/scala/munit/diff/PathNode.scala
Copyright: 1999-2003 The Apache Software Foundation
 2020-2026 MUnit contributors
License: Apache-1.1 and Apache-2.0
Comment: Scala translation of difflib.myers from java-diff-utils, written by
 Juanco Anez for the Apache Jakarta Commons.

Files: munit-diff/shared/src/main/scala/munit/diff/Chunk.scala
 munit-diff/shared/src/main/scala/munit/diff/Delta.scala
 munit-diff/shared/src/main/scala/munit/diff/DiffAlgorithm.scala
 munit-diff/shared/src/main/scala/munit/diff/DiffUtils.scala
 munit-diff/shared/src/main/scala/munit/diff/Equalizer.scala
 munit-diff/shared/src/main/scala/munit/diff/Patch.scala
Copyright: 2010 Dmitry Naumenko <dm.naumenko@gmail.com>
 2020-2026 MUnit contributors
License: Apache-2.0
Comment: Scala translation of java-diff-utils.

Files: munit-diff/shared/src/main/scala/munit/diff/Diff.scala
 munit-diff/shared/src/main/scala/munit/diff/Diffs.scala
 munit/shared/src/main/scala/munit/Diffs.scala
Copyright: 2014-2018 EPFL
 2016-2018 Twitter, Inc.
 2020-2026 Ólafur Páll Geirsson
 2020-2026 other MUnit contributors
License: BSD-3-clause and Apache-2.0
Comment: Derived from scala.meta.testkit.DiffAssertions in Scalameta.

Files: munit/shared/src/main/scala/munit/internal/console/Printers.scala
 munit/shared/src/main/scala/munit/internal/console/StackTraces.scala
Copyright: 2019 Li Haoyi
 2020-2026 MUnit contributors
License: Expat and Apache-2.0
Comment: Adapted from PPrint (Printers.scala) and uTest (StackTraces.scala).

Files: debian/*
Copyright: 2026 Juan Manuel Méndez Rey <juan.mendezr@proton.me>
License: Apache-2.0

License: Apache-1.1
 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions
 are met:
 .
 1. Redistributions of source code must retain the above copyright
    notice, this list of conditions and the following disclaimer.
 .
 2. Redistributions in binary form must reproduce the above copyright
    notice, this list of conditions and the following disclaimer in
    the documentation and/or other materials provided with the
    distribution.
 .
 3. The end-user documentation included with the redistribution, if
    any, must include the following acknowledgement:
       "This product includes software developed by the
        Apache Software Foundation (http://www.apache.org/)."
    Alternately, this acknowledgement may appear in the software itself,
    if and wherever such third-party acknowledgements normally appear.
 .
 4. The names "The Jakarta Project", "Commons", and "Apache Software
    Foundation" must not be used to endorse or promote products derived
    from this software without prior written permission. For written
    permission, please contact apache@apache.org.
 .
 5. Products derived from this software may not be called "Apache"
    nor may "Apache" appear in their names without prior written
    permission of the Apache Software Foundation.
 .
 THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
 WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
 OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
 ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
 USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
 ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
 OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
 OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 SUCH DAMAGE.
 .
 This software consists of voluntary contributions made by many
 individuals on behalf of the Apache Software Foundation.  For more
 information on the Apache Software Foundation, please see
 <http://www.apache.org/>.

License: Apache-2.0
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 .
 http://www.apache.org/licenses/LICENSE-2.0
 .
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
 .
 On Debian systems, the complete text of the license can be found in
 "/usr/share/common-licenses/Apache-2.0".

License: BSD-2-clause
 All rights reserved.
 .
 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions are met:
 .
     * Redistributions of source code must retain the above copyright notice,
       this list of conditions and the following disclaimer.
 .
     * Redistributions in binary form must reproduce the above copyright
       notice, this list of conditions and the following disclaimer in the
       documentation and/or other materials provided with the distribution.
 .
 THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
 AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
 ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
 LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
 CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
 SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
 INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
 CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
 ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 POSSIBILITY OF SUCH DAMAGE.

License: BSD-3-clause
 All rights reserved.
 .
 Redistribution and use in source and binary forms, with or without modification,
 are permitted provided that the following conditions are met:
 .
   * Redistributions of source code must retain the above copyright notice,
     this list of conditions and the following disclaimer.
   * Redistributions in binary form must reproduce the above copyright notice,
     this list of conditions and the following disclaimer in the documentation
     and/or other materials provided with the distribution.
   * Neither the name of the EPFL nor the names of its contributors
     may be used to endorse or promote products derived from this software
     without specific prior written permission.
 .
 THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
 CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
 EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
 PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
 PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
 LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
 NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
 SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

DFSG Assistant LLM REVIEW 1 blocker, 0 important, 2 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 0 hours ago.

Report◂

DFSG NEW review for munit version 1.3.6+ds-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: No
  • Packaging is of good quality: Yes
  • Issues: 1 blocker, 0 important, 2 minor
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: nothing found

Licensing

debian/copyright is DEP-5 and is accurate for almost the tree: Apache-2.0 with correctly reproduced Apache-1.1, BSD-2-clause, BSD-3-clause and Expat texts, and the excluded Scala.js/Scala Native trees explain the EPL-1.0 and Hamcrest notices in NOTICE.md. It is nevertheless incomplete: the two PPrint-derived files under munit-diff/shared/src/main/scala/munit/diff/console are compiled into both munit jars but are not in the Li Haoyi/Expat stanza. A leftover sbt junit-interface metadata file is also misdescribed. No DFSG-non-free terms were found.

Packaging

The packaging is solid: debhelper compat 14, dh-sequence-scala with --buildsystem=scala, three Architecture: all library packages, DEP-3 patches, autopkgtests, salsa CI, a sane initial changelog and Standards-Version 4.7.4. One minor Maven metadata problem remains: the Scala 3 POMs name scala3-library 3.3.8 although the package is built and tested with Debian's 3.9.0.

Issues

blocker licensing 1. debian/copyright omits Li Haoyi and the Expat licence for the PPrint-derived munit-diff console sources ◂
  • Files: munit-diff/shared/src/main/scala/munit/diff/console/Printers.scala, munit-diff/shared/src/main/scala/munit/diff/console/AnsiColors.scala, debian/copyright:88-93, debian/scala-build:11-12, debian/scala-build:21-22
  • Basis: inferred from what was read, not seen directly
  • Evidence: debian/copyright lists only munit/shared/src/main/scala/munit/internal/console/Printers.scala and .../StackTraces.scala under Copyright: 2019 Li Haoyi, License: Expat and Apache-2.0, with the comment Adapted from PPrint (Printers.scala) and uTest (StackTraces.scala). The unlisted munit-diff/.../console/AnsiColors.scala contains PPrint's exact API (val LightRed = "\u001b[91m", val Reversed, val Faint, def c(...), def filterAnsi), and munit-diff/.../console/Printers.scala is the printString/printChar implementation those adaptations use; munit/shared/.../console/Printers.scala:1 calls itself an Adaptation of .../pprint/... and imports munit.diff.console.{Printers => DiffPrinters}.
  • Problem: Both files are compiled into libmunit-scala2.13-java and libmunit-scala3-java (debian/scala-build lists munit-diff/shared/src/main/scala as the munit-diff source root), yet they are not matched by any specific stanza and fall to Files: *, i.e. Apache-2.0 with only the MUnit contributors. The files derive from Li Haoyi's PPrint, which is Expat/MIT: its copyright and permission notice must be retained in binary distributions, and Policy 2.3 and 12.5 require the copyright information to be in debian/copyright. A missing holder for compiled-in code is a blocker; the licence name is wrong as well.
  • Fix: Add both paths to the existing Li Haoyi stanza (or add a separate Expat stanza with Copyright: 2019 Li Haoyi and 2020-2026 MUnit contributors).
minor licensing 2. debian/copyright calls junit-interface/src/main/ls/0.8.json Apache-2.0 though it declares BSD ◂
  • Files: junit-interface/src/main/ls/0.8.json:8-11, debian/copyright:21-31, debian/copyright:41-55
  • Basis: checked, in the package or with a reference tool
  • Evidence: The file is sbt metadata from "site":"https://github.com/szeiger/junit-interface", "version":"0.8", with "licenses": [{"name": "BSD", "url": ".../szeiger/junit-interface/blob/635f723.../LICENSE.txt"}]. The junit-interface stanza of debian/copyright names only the .java files, so this file falls to Files: * / Apache-2.0 / MUnit contributors.
  • Problem: This is a leftover of sbt's junit-interface 0.8, i.e. Stefan Zeiger's BSD-2-clause project, and the file itself declares that licence; debian/copyright instead attributes it to MUnit contributors under Apache-2.0. It is not in any scala-build Sources (only junit-interface/src/main/java is compiled), so Policy 2.3 does not require its holder in a binary package, but debian/copyright should still describe it correctly.
  • Fix: Add junit-interface/src/main/ls/0.8.json to the junit-interface BSD-2-clause stanza, or give it a small BSD-2-clause stanza with Stefan Zeiger as holder.
minor packaging 3. munit_3 and munit-diff_3 POMs require scala3-library_3 3.3.8, but Debian ships 3.9.0 ◂
  • Files: debian/poms/munit_3.pom.xml:46-50, debian/poms/munit-diff_3.pom.xml:36-39, debian/control:12, debian/build-info:9-12
  • Basis: inferred from what was read, not seen directly
  • Evidence: Both POMs contain <artifactId>scala3-library_3</artifactId> followed by <version>3.3.8</version>. debian/control builds with scala3, which apt-cache shows as version 3.9.0+ds2-3; debian/build-info derives BuildInfo.scalaVersion from the installed scala3 package. There is no debian/maven.rules to rewrite the version.
  • Problem: The jars are compiled against Debian's Scala 3 3.9.0, but the POMs installed into /usr/share/maven-repo by the helper ask for 3.3.8. A Maven consumer resolving org.scalameta:munit_3 or munit-diff_3 from the Debian repository therefore asks for a scala3-library_3 version that the archive does not provide. The 2.13 POMs use the matching Debian version (2.13.18), so this is an oversight rather than an upstream convention.
  • Fix: Change both <version> elements to the Scala 3 version Debian provides (3.9.0, or the version of the scala3 build dependency), or add a debian/maven.rules entry that maps it.
Verified ◂
  • Read every file under debian/: control, rules, changelog, copyright, source/format, scala-build, build-info, clean, run-upstream-tests, gbp.conf, salsa-ci.yml, lrc.config, all patches and series, all POMs, and tests/control and tests/upstream-tests.
  • debian/copyright is DEP-5 with the exact copyright-format 1.0 Format URL; it contains stand-alone texts for Apache-1.1, Apache-2.0, BSD-2-clause, BSD-3-clause and Expat, and refers to /usr/share/common-licenses/Apache-2.0.
  • Grepped all 203 files of the unpacked tree (including hidden files) for Copyright, (C), ©, SPDX-License-Identifier, Licensed under, Permission is hereby granted, GNU GPL/LGPL, Apache License, Mozilla Public, public domain and All rights reserved: only LICENSE and NOTICE.md carry notices, and both NOTICE.md holders (EPFL, Stefan Zeiger) are named in debian/copyright.
  • LICENSE is the Apache-2.0 text. NOTICE.md's EPL-1.0 and Hamcrest-BSD notices concern the JUnit 4.12 and Hamcrest 1.3 translations in munit/js, which Files-Excluded removes; munit/js, munit/js-native, munit/native, tests/js, tests/native, website, bin/scalafmt, package.json, package-lock.json and yarn.lock are all absent from the unpacked tree.
  • The junit-interface stanza covers the files that still come from sbt's junit-interface and gives them BSD-2-clause and Apache-2.0; the Apache-1.1 stanza reproduces the Apache-1.1 text and names the ASF for the java-diff-utils Myers translation; the EPFL/Twitter BSD-3 stanza covers the Scalameta-derived Diff/Diffs files.
  • All three patches have DEP-3 headers (Description, Author, Forwarded or Applied-Upstream, Last-Update) and alter existing files only; none creates a file from /dev/null.
  • No built files, class files, archives, minified JavaScript, generated documentation or PDFs are present; docs contain only remote image links, and there are no fonts or local images.
  • Packaging mechanics: debhelper-compat 14, dh-sequence-scala with --buildsystem=scala, three Architecture: all packages, a series/3.0 (quilt) source format, initial unstable changelog closing #1152797, autopkgtests with sensible binary/compiler test dependencies, and Standards-Version 4.7.4 (Policy 4.7.4.1, so current).
  • uscan found the packaged version as the newest upstream release (upstream 1.3.6, packaged 1.3.6+ds).
  • Every pointer of debian/copyright to /usr/share/common-licenses names a file that is there (Apache-2.0).
Not confirmed ◂
  • Whether ${scala:Depends} makes the binary packages depend on junit4 and libsbt-test-interface-java: the jars reference org.junit and sbt.testing, the POMs declare those dependencies, and debian/tests/upstream-tests uses /usr/share/java/junit4.jar and /usr/share/java/sbt-test-interface.jar, but the binary Depends fields name only ${misc:Depends} and ${scala:Depends}. scala-debian-helper is not installed on the reviewing system, so I could not read its substvar logic; if it adds only the Scala library, both the packages and the autopkgtest need those dependencies added.
  • Whether scala-debian-helper 0.1 installs the /usr/share/scala-debian-helper/smoke-test command used by the first autopkgtest; the helper is not installed here to check.
Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader rejected this upload in response to the review.

Review Information

rejected — allocated to dfsg-uploader 0 hours ago, started 0 hours ago, completed 0 hours ago.

Final Comment

The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.

The uploader said:

Blocker confirmed: munit-diff/shared/src/main/scala/munit/diff/console/Printers.scala was split upstream from the PPrint-derived Printers.scala (commit f0a004c).

Now declared under Li Haoyi, Expat.

Minor 1 confirmed: junit-interface/src/main/ls/0.8.json is now in the BSD-2-clause stanza.

Fix: https://salsa.debian.org/java-team/munit/-/commit/4f13100f059f64b29bba011a740b6080834dba41 .

Minor 2 does not apply to the binary package: the installed POMs depend on scala3-library_3 version 3.x, which scala3-library 3.9.0+ds2-3 ships.

Please reject; the same version will be uploaded again with the fix.

Back to Dashboard | View all reviews for this package