Review: node-amaro 1.1.11+ds-1
Package Information
| Description | Wrapper around SWC WebAssembly TypeScript parser for Node.js Amaro provides a stable API around the SWC TypeScript parser and type stripper, compiled to WebAssembly, together with the loaders used by Node.js for type stripping and type transformation. |
|---|---|
| Maintainer | Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org> |
| Changed By | Jérémy Lal <kapouer@melix.org> |
| Sponsor | kapouer@melix.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/js-team/node-amaro.git (browse) |
| Closes | #1136744 |
| Tracker | https://tracker.debian.org/pkg/node-amaro |
| Uploaded | 2 hours ago |
New Package Report
.changes
| Architecture | source all |
|---|---|
| Distribution | unstable |
| Date | Fri, 20 Nov 2026 02:14:00 +0100 |
| Source | node-amaro |
| Version | 1.1.11+ds-1 |
| Changed-By | Jérémy Lal <kapouer@melix.org> |
Changelog
node-amaro (1.1.11+ds-1) unstable; urgency=medium . * Initial release. (Closes: #1136744)
.dsc
| Section | javascript |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | node-amaro deb javascript optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: amaro Upstream-Contact: https://github.com/nodejs/amaro/issues Source: https://github.com/nodejs/amaro/tags Files-Excluded: deps/swc/Cargo.lock deps/swc/Cargo.toml deps/swc/bindings/README.md deps/swc/bindings/binding_core_node deps/swc/bindings/binding_core_wasm deps/swc/bindings/binding_es_ast_viewer deps/swc/bindings/binding_html_node deps/swc/bindings/binding_html_wasm deps/swc/bindings/binding_minifier_node deps/swc/bindings/binding_minifier_wasm deps/swc/bindings/binding_react_compiler_node deps/swc/bindings/swc_cli deps/swc/crates deps/swc/rust-toolchain deps/swc/tools deps/swc/xtask lib Files: * Copyright: 2024-2026 Marco Ippolito and Amaro contributors License: Expat Files: deps/swc/.cargo/config.toml deps/swc/bindings/binding_typescript_wasm/* deps/swc/bindings/binding_typescript_wasm/.cargo/config.toml Copyright: 2017-2026 SWC contributors License: Apache-2.0 Files: debian/* Copyright: 2024-2026 Jérémy Lal <kapouer@melix.org> License: Expat License: Apache-2.0 On Debian systems, the complete text of the Apache License 2.0 can be found in /usr/share/common-licenses/Apache-2.0. License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 1 blocker, 0 important, 1 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 1 hour ago.
Report
DFSG NEW review for node-amaro version 1.1.11+ds-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: Yes
- Issues: 1 blocker, 0 important, 1 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
Both licences in the tree are free and compatible (MIT/Expat for Amaro, Apache-2.0 for the vendored SWC binding), the full Expat text is present, and Apache-2.0 is correctly referred to /usr/share/common-licenses. debian/copyright is DEP-5 and otherwise complete, but one stanza is wrong: Files: * attributes deps/swc/LICENSE to Marco Ippolito/Amaro contributors under Expat, while that file is the SWC Apache-2.0 licence text (Copyright 2024 SWC contributors). No other stanza matches it, so the file's holder and licence are misstated.
Packaging
Careful packaging: debhelper compat 14 with the nodejs and single-binary addons, a clean build hook that builds the wasm from Debian's rust crates and bundles with the system esbuild, DEP-3 patches, a complete clean target, a correct changelog, Vcs fields and a current Standards-Version. The one real quality issue is the test suite: only test/index.test.js is ever run (both at build time and in autopkgtest), with a comment admitting the transform-mode and loader tests do not pass. The build-dependency names for the SWC crates could not be confirmed in the archive.
Issues
blocker licensing 1. Files: * describes SWC's Apache-2.0 deps/swc/LICENSE as Expat by Marco Ippolito/Amaro contributors ◂
- Files:
debian/copyright:24-26,deps/swc/LICENSE:189 - Basis: checked, in the package or with a reference tool
- Evidence:
Files: */Copyright: 2024-2026 Marco Ippolito and Amaro contributors/License: Expat, but deps/swc/LICENSE is the Apache License 2.0 text and endsCopyright 2024 SWC contributors.; the only later stanza isFiles: deps/swc/.cargo/config.toml deps/swc/bindings/binding_typescript_wasm/* .../Copyright: 2017-2026 SWC contributors/License: Apache-2.0, which does not match deps/swc/LICENSE. - Problem: DEP-5 patterns are matched literally against the whole tree and the last matching stanza wins (copyright-format 6.9), so no stanza names the correct holder and licence for this file; Policy 12.5/12.5.1 require debian/copyright to state the package's copyright and distribution licences accurately. Apache-2.0 is free, so this is an accuracy error in debian/copyright, not a DFSG problem.
- Fix: Cover deps/swc/LICENSE with the SWC stanza: widen it to
Files: deps/swc/*(which then also covers.cargo/config.tomlandbindings/) or adddeps/swc/LICENSEto its pattern list, keepingCopyright: 2017-2026 SWC contributorsandLicense: Apache-2.0.
minor packaging 2. Only test/index.test.js is ever run; transform-mode and loader tests are knowingly skipped ◂
- Files:
debian/tests/pkg-js/test:1-2,debian/tests/control:1 - Basis: checked, in the package or with a reference tool
- Evidence: debian/tests/pkg-js/test contains
# only those tests should pass for nowandnode --test test/index.test.js, while test/transform.test.js (usesmode: "transform") and test/loader.test.js (tests--import=./dist/register-strip.mjsandregister-transform.mjs) exist and are not referenced anywhere. - Problem: dh-nodejs runs debian/tests/pkg-js/test both in dh_auto_test during the build (Debian::Debhelper::Buildsystem::nodejs
sub test) and in autopkgtest, so two of the three upstream test files are never executed anywhere. The comment admits they do not pass, which leaves the documentedamaro/transformexport and both--importloaders unverified and hides whatever difference in the Debian-built wasm causes the failures. - Fix: Run the full suite (
node --test test/*.test.js) or fix and document the two failing files. If a file genuinely cannot run at build time, exclude it explicitly with a comment naming the failing test and the reason, rather than the current blanket narrowing.
Verified ◂
- Prescan: the author check listed no files and reported every holder found as named in debian/copyright; there is therefore no candidate file from the scan left unaccounted for.
- debian/copyright read in full: starts with the exact
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/, has Upstream-Name/Contact/Source, Files-Excluded, three Files stanzas and stand-alone Expat and Apache-2.0 License paragraphs; the full Expat text is included and Apache-2.0 is referred to /usr/share/common-licenses. - All 17 paths in Files-Excluded (deps/swc/Cargo.toml, Cargo.lock, bindings/README.md, the other bindings, crates, rust-toolchain, tools, xtask, lib) are absent from the unpacked tree; deps/swc/bindings/binding_typescript_wasm is deliberately kept and covered by the Apache stanza.
- Amaro's own tree (src/, test/ with fixtures and snapshots, tools/, .github/, README.md, CHANGELOG.md, package.json, configs) carries no separate copyright/licence notice; LICENSE.md names
Marco Ippolito and Amaro contributors, which the Files: * stanza matches. CODE_OF_CONDUCT.md only links to the Node.js CoC; no third-party holder was found. - SWC files under deps/swc/bindings/binding_typescript_wasm (Cargo.toml, LICENSE, src/lib.rs, src/error_reporter.rs, src/wasm-node.js, scripts/, .cargo/config.toml) are Apache-2.0 with
Copyright 2024 SWC contributors; the patched Cargo.toml sayslicense = "Apache-2.0"; both are covered by the Apache stanza and the holder is named in debian/copyright. - No non-free or field-of-use wording anywhere: the only hits for MPL/BSD are deny.toml's cargo-deny
allowlist of acceptable dependency licences, not a licence of any file. - No built artifacts in the source: lib/ and dist/ do not exist (lib is in Files-Excluded and both are removed by execute_after_dh_auto_clean); the wasm and dist/ are produced by debian/nodejs/build from the Rust sources and src/.
- debian/nodejs/build builds the binding with wasm-pack against /usr/share/cargo/registry, then bundles with the system esbuild; package.json#files ships dist/, lib/**/.d.ts and LICENSE.md. dist/index.js is an esbuild bundle of src/index.ts and ../lib/wasm.js, dist/strip-loader.js and dist/transform-loader.js require ./index.js and ./errors.js, dist/register-.mjs require the loaders, and lib/wasm.d.ts is installed for the emitted declarations, so the installed module is self-contained.
- dh sequence: debhelper-compat 14; dh-sequence-nodejs (dh-nodejs 0.17.14) and dh-sequence-single-binary (provided by debhelper 14.5). single_binary.pm adds
--destdir=debian/<pkg>/to dh_auto_install, so the nodejs buildsystem installs straight into the binary package rather than leaving files in debian/tmp. - Patches: series applies 0001-0003 and rust-no-nightly; all carry DEP-3 headers (Description or Subject, Author/From, Forwarded, Last-Update) and state what and why; no maintainer scripts, maintscripts or install files are needed or present.
- Changelog is well-formed (unstable, 1.1.11+ds-1, closes #1136744, date consistent); Vcs-Git/Vcs-Browser and Homepage are present; Standards-Version 4.7.4 matches the reviewing system's Policy 4.7.4.1 (first two components equal, so current).
- autopkgtest exists: debian/tests/control uses the pkg-js runner with
Depends: @, nodejs, pkg-js-autopkgtest; no override or hook target of dh_auto_test/dh_dwz/dh_strip is used, so compat 14's nocheck skipping applies without extra care. - Build dependencies checked with apt-cache: wasm-pack 0.15.1, wasm-bindgen 0.2.108, esbuild 0.28.2, node-typescript 6.0.3, libstd-rust-dev-wasm32, rust-llvm, dh-nodejs/dh-sequence-nodejs and pkg-js-autopkgtest exist; librust-swc-core-dev 77.1.2 Provides librust-swc-common-26-dev (= 26.0.0); miette 7.6.0, serde-wasm-bindgen 0.6.5, owo-colors 4.4.0, unicode-width 0.2.2 and the serde/wasm-bindgen feature packages satisfy the patched version requirements; Debian's nodejs is 24, so the esbuild
--target=node24is consistent with the runtime. - uscan found upstream releases with
debian/watch; a newer upstream version is available (upstream1.3.0, packaged1.1.11+ds), which is not a fault of the package. - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (Apache-2.0).
Not confirmed ◂
- The wasm build needs the crates swc_ts_fast_strip 58.0.0 and swc_error_reporters 28.0.0 (deps/swc/bindings/binding_typescript_wasm/Cargo.toml; lib.rs imports convert_span/to_pretty_source_code from swc_error_reporters). apt-cache found no binary package named librust-swc-ts-fast-strip-58+wasm-bindgen-dev (the name in Build-Depends) nor any package providing swc_ts_fast_strip or swc_error_reporters, in unstable/experimental or in the NEW queue as of 2026-11-20T13:11:55Z (librust-swc-core-dev's Provides list does not include either crate). If they are not part of an upload the NEW snapshot missed, the build cannot resolve its dependency graph; a build would show it.
- The tests were not run: whether test/transform.test.js and test/loader.test.js actually fail in this build (the stated reason for narrowing debian/tests/pkg-js/test) cannot be confirmed here.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader rejected this upload in response to the review.
Review Information
rejected — allocated to dfsg-uploader 1 hour ago, started 1 hour ago, completed 1 hour ago.
Final Comment
The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.