DFSG NEW Queue

DFSG, Licensing & New Packages Team

Review: node-angular 21.1.4+ds-1

Package Information

Descriptionweb application framework for TypeScript and JavaScript

Angular is a development platform and application-design framework for building single-page client applications in HTML and TypeScript.

It implements core and optional functionality as a set of TypeScript libraries that you import into your applications, including component templates, dependency injection, reactive signals, forms, HTTP client, routing, animations, and the Angular Ahead-of-Time (AOT) compiler.

This package provides the core Angular packages (@angular/core, @angular/common, @angular/compiler, @angular/compiler-cli, @angular/animations, @angular/forms, @angular/platform-browser, @angular/platform-browser-dynamic, @angular/router) and zone.js for Node.js.

MaintainerYing-Chun Liu (PaulLiu) <paulliu@debian.org>
Changed ByYing-Chun Liu (PaulLiu) <paulliu@debian.org>
Sponsorpaulliu@debian.org
Distributionunstable
Architectureall
VCSgit: https://salsa.debian.org/js-team/node-angular.git (browse)
Closes#1153526
Trackerhttps://tracker.debian.org/pkg/node-angular
Uploaded3 hours ago

New Package Report

.changes◂
Sourcenode-angular
Version21.1.4+ds-1
Changed-ByYing-Chun Liu (PaulLiu) <paulliu@debian.org>
Architecturesource all
Distributionunstable
DateThu, 19 Nov 2026 15:55:59 +0000
Changelog◂
node-angular (21.1.4+ds-1) unstable; urgency=low
 .
   * Initial release. (Closes: #1153526)
.dsc◂
Package-Listnode-angular deb javascript optional arch=all
Sectionjavascript
Priorityoptional
Componentmain
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: angular
Upstream-Contact: Angular Team <devrel@angular.io>
Source: https://github.com/angular/angular
Files-Excluded:
 .devcontainer
 .gemini
 .github
 .husky
 .ng-dev
 .vscode
 MODULE.bazel.lock
 pnpm-lock.yaml
 adev
 contributing-docs
 dev-app
 devtools
 goldens
 integration
 modules
 scripts
 third_party
 tools
 vscode-ng-language-service
 packages/benchpress
 packages/common/locales
 packages/common/test
 packages/common/upgrade
 packages/compiler-cli/test
 packages/core/schematics
 packages/core/test
 packages/docs
 packages/elements
 packages/examples
 packages/language-service
 packages/localize
 packages/misc
 packages/platform-server
 packages/private
 packages/router/upgrade
 packages/service-worker
 packages/ssr
 packages/upgrade
 packages/zone.js/doc
 packages/zone.js/example
 packages/zone.js/presentation.png
 packages/zone.js/test

Files: *
Copyright: 2010-2026 Google LLC
License: Expat

Files: debian/*
Copyright: 2026 Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
License: Expat

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in
 all copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.

DFSG Assistant LLM REVIEW 1 blocker, 0 important, 2 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 2 hours ago.

Report◂

DFSG NEW review for node-angular version 21.1.4+ds-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: No
  • Packaging is of good quality: Yes
  • Issues: 1 blocker, 0 important, 2 minor
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: nothing found

Licensing

The upstream tree itself is uniform and DFSG-free: every one of the 1,817 files with a copyright notice names Google LLC, the only licence file is the top-level MIT LICENSE, and there is no other licence text or non-free term anywhere in the tree; the +ds repack removed exactly what Files-Excluded says. But debian/copyright describes only upstream source and the packaging: debian/build.mjs makes esbuild inline the third-party MIT module magic-string into the shipped @angular/compiler-cli bundles, and its copyright and licence appear nowhere in the file. That is inaccurate for the binary package.

Packaging

Good-quality packaging: correct relationships, DEP-3 patches that only touch existing files, debhelper compat 13 with dh-sequence-nodejs, a genuine +ds repack, Vcs-*, Homepage and Rules-Requires-Root, and a test suite that actually runs at build time through dh's nodejs build system. Two minor gaps: the debian/tests/pkg-js tests are never collected by autopkgtest, and the shipped ngc/ng-xi18n are not on PATH.

Issues

blocker licensing 1. debian/copyright omits the magic-string code that is compiled into the shipped @angular/compiler-cli bundles ◂
  • Files: debian/copyright, debian/build.mjs, packages/compiler-cli/src/ngtsc/typecheck/src/context.ts:18
  • Basis: inferred from what was read, not seen directly
  • Evidence: import MagicString from 'magic-string'; (context.ts:18, used as a value at new MagicString(...) on line 492). The compiler-cli esbuild call in debian/build.mjs passes --bundle and externalises only '@angular/compiler', 'typescript', '@babel/core', 'reflect-metadata', 'chokidar', 'convert-source-map', 'semver', '@jridgewell/sourcemap-codec', 'tslib', 'yargs', 'yargs/helpers' — magic-string is not among them and is linked into node_modules by debian/nodejs/extlinks. debian/copyright has a single upstream stanza: Files: * / Copyright: 2010-2026 Google LLC / License: Expat, and names nothing else.
  • Problem: esbuild resolves magic-string from the node_modules link (node-magic-string is in Build-Depends) and inlines that third-party MIT code into the bundles installed under /usr/share/nodejs/@angular/compiler-cli/bundles/, i.e. into what the binary package ships. That copy is under the Expat licence with a copyright holder other than Google LLC, yet debian/copyright neither records the embedded code nor its copyright. Debian Policy 2.3 requires the copyright notices of files compiled into shipped object code to be copied into /usr/share/doc/*/copyright when the licence requires their retention, as MIT does. The same bundling is a convenience copy of a library the archive already has, which Policy 4.13 says binary packages should reference instead.
  • Fix: Preferably stop bundling it: add --external:magic-string to the compiler-cli esbuild invocation in debian/build.mjs and node-magic-string to the binary package's Depends (it is already a build dependency). If the bundle is kept, record the embedded copy, its holder and the full Expat text in debian/copyright.
minor packaging 2. the debian/tests/pkg-js suite is never run by autopkgtest (no Testsuite field and no debian/tests/control) ◂
  • Files: debian/control, debian/tests/pkg-js/test, debian/tests/test-suite.mjs
  • Basis: checked, in the package or with a reference tool
  • Evidence: The Package: node-angular stanza in debian/control has no Testsuite: field, and debian/tests/ contains only pkg-js/ and test-suite.mjs — no control. pkg-js-autopkgtest's description says it is used by setting Testsuite: autopkgtest-pkg-nodejs in debian/control; the autopkgtest specification provides implicit control files only for Ruby and Perl packages, not Node.js ones.
  • Problem: With neither a Testsuite: field nor debian/tests/control, adt-run finds no tests at all, so the test suite present in the package is never run by the archive for migration or reverse-dependency checks. It runs only inside dh_auto_test at build time, because dh's nodejs build system executes debian/tests/pkg-js/test during the build.
  • Fix: Add Testsuite: autopkgtest-pkg-nodejs to the Package: node-angular stanza so the pkg-js-autopkgtest framework picks up debian/tests/pkg-js/{test,files}; alternatively ship a debian/tests/control with Test-Command: node debian/tests/test-suite.mjs and Depends: @.
minor packaging 3. @angular/compiler-cli's ngc and ng-xi18n binaries are shipped but not linked into /usr/bin ◂
  • Files: packages/compiler-cli/package.json:5, debian/rules:6, debian/nodejs/packages/compiler-cli/install
  • Basis: checked, in the package or with a reference tool
  • Evidence: packages/compiler-cli/package.json declares "bin": {"ngc": "./bundles/src/bin/ngc.js", "ng-xi18n": "./bundles/src/bin/ng_xi18n.js"}; debian/rules only chmods those two files and no debian/nodejs/links, debian/node-angular.links or debian/nodejs/packages/compiler-cli/bins exists. dh's nodejs build system creates /usr/bin links only from the bin field of the main component (debian/nodejs/main = packages/zone.js, which has no bin field).
  • Problem: The two CLIs are installed under /usr/share/nodejs/@angular/compiler-cli/bundles/src/bin/ and are executable, but nothing puts them on PATH, so Debian users cannot invoke ngc/ng-xi18n by name even though upstream exposes them as the package's commands.
  • Fix: Add a debian/nodejs/links file, which dh's install step processes through add_link, with for example @angular/compiler-cli/bundles/src/bin/ngc.js /usr/bin/ngc and the same for ng-xi18n.
Verified ◂
  • Copyright holders: all 1,817 files with a copyright notice name Google LLC, either Copyright Google LLC All Rights Reserved. or (c) 2010-2026 Google LLC; no other holder appears. The scan's two files are the same holder: packages/license-banner.txt:3 is the Angular MIT banner ((c) 2010-2026 Google LLC. https://angular.dev/, License: MIT) and packages/zone.js/tools/base.mjs:13 is the same banner in the zone.js esbuild helper; both are covered by the Files: * Google LLC stanza and are licensed MIT, so neither is an issue.
  • Licence texts: the only LICENSE/COPYING/NOTICE/AUTHORS file in the tree is the top-level MIT LICENSE; the zone.js sub-package has no separate licence file. No GPL/LGPL/Apache/MPL/BSD/ISC/CC/SPDX/public-domain wording occurs anywhere in the tree.
  • No non-free terms: a search for non-commercial, no modification, No Derivative, Good, not Evil, research only and similar hit only code comments such as or the original content if no modification is needed and Original stack trace with no modifications.
  • debian/copyright is DEP-5 with the correct Format: URL, a complete Expat text, Upstream-Name/Source, and a debian/* stanza naming the packager.
  • The +ds repack matches Files-Excluded: none of the excluded root directories/files (.devcontainer, .github, adev, dev-app, devtools, goldens, integration, modules, scripts, third_party, tools, vscode-ng-language-service, MODULE.bazel.lock, pnpm-lock.yaml) nor the excluded package paths (packages/common/{locales,test,upgrade}, packages/compiler-cli/test, packages/core/{schematics,test}, packages/router/upgrade, packages/zone.js/{doc,example,test}, packages/zone.js/presentation.png) is present in the tree.
  • No images, fonts, PDFs, archives, .min.js or checked-in built JavaScript in the tree; packages/zone.js/bundles/ and fesm2015/ contain only their BUILD.bazel, so what build.mjs generates has its TypeScript sources in the package.
  • packages/core/primitives/event-dispatch/contract_binary.ts is hand-written TypeScript (compiled by build.mjs to contract_binary.js, then bundled), not a checked-in generated file; the zone.js bundle entry points in debian/build.mjs match packages/zone.js/bundles.bzl (including the curious upstream zone-patch-rxjs-fake-async -> zone-spec/rollup-proxy mapping).
  • Patches: both have DEP-3 headers (Description, Author, Forwarded, Last-Update); neither creates a file (--- /dev/null appears in neither), so no patch-introduced file needs its own stanza.
  • Build wiring: debian/nodejs/main = packages/zone.js, additional_components lists the nine @angular/* packages, every component has an install map into /usr/share/nodejs/@angular, root_modules = * installs them at the root, and the zone.js build hook runs debian/build.mjs from the build root before install; debian/clean removes dist/, .build-tmp/ and node_modules/.
  • Runtime relationships are sufficient: rxjs (a peer of core/common/forms/router) is available because node-inquirer Provides node-rxjs (= 7.5.7) and @jridgewell/sourcemap-codec because node-ampproject-remapping Provides it; both are hard Depends (apt-cache). tslib, @babel/core, reflect-metadata, chokidar, convert-source-map, semver, yargs, typescript are all declared directly.
  • Standards-Version: 4.7.2 against the reviewing system's Policy 4.7.4.1: the first two components match, so not an issue. Compat 13 with dh-sequence-nodejs; override_dh_nodejs_fixperms overrides a command the sequence really inserts; ${misc:Depends} and ${nodejs:Provides} are used.
  • debian/changelog: 21.1.4+ds-1, distribution unstable, weekday/date consistent (Thu, 19 Nov 2026), closes a bug.
  • uscan found upstream releases with debian/watch; a newer upstream version is available (upstream 22.3.0-next.4, packaged 21.1.4+ds), which is not a fault of the package.
Not confirmed ◂
  • No build was run, so that esbuild inlines magic-string into a concrete file under dist/@angular/compiler-cli/bundles/ is inferred from debian/build.mjs and the source import, not observed.
  • Whether esbuild's default legalComments setting keeps any magic-string copyright banner in the emitted bundle; node-magic-string is not installed here, so its licence file could not be read.
  • That bug #1153526 is the right one to close for this initial release.
Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader rejected this upload in response to the review.

Review Information

rejected — allocated to dfsg-uploader 1 hour ago, started 1 hour ago, completed 1 hour ago.

Final Comment

The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.

The uploader said:

I'll fix them all. Reject.

Back to Dashboard | View all reviews for this package