Review: node-codemirror-lang-jinja 6.0.0-1

Package Information

Description	Jinja language support for the CodeMirror code editor CodeMirror is a code editor component for the web. It can be used in websites to implement a text input field with support for many editing features, and has a rich programming interface to allow further extension. This package provides the Jinja language support.
Maintainer	Home Assistant Team <team+homeassistant@tracker.debian.org>
Changed By	Edward Betts <edward@4angle.com>
Sponsor	edward@debian.org
Distribution	unstable
Architecture	all
VCS	git: https://salsa.debian.org/homeassistant-team/js/node-codemirror-lang-jinja.git (browse)
Closes	#1152184
Tracker	https://tracker.debian.org/pkg/node-codemirror-lang-jinja
Uploaded	12 days ago

New Package Report

.changes◂

Changed-By	Edward Betts <edward@4angle.com>
Architecture	all source
Distribution	unstable
Date	Mon, 26 Oct 2026 16:15:25 +0000
Source	node-codemirror-lang-jinja
Version	6.0.0-1

Changelog◂

node-codemirror-lang-jinja (6.0.0-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #1152184)

.dsc◂

Section	javascript
Priority	optional
Component	main
Package-List	node-codemirror-lang-jinja deb javascript optional arch=all

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: @codemirror/lang-jinja
Upstream-Contact: Marijn Haverbeke <marijn@haverbeke.berlin>
Source: https://github.com/codemirror/lang-jinja

Files: *
Copyright: 2025 Marijn Haverbeke <marijn@haverbeke.berlin> and others
License: MIT

Files: debian/*
Copyright: 2026 Edward Betts <edward@4angle.com>
License: MIT

License: MIT
 Permission is hereby granted, free of charge, to any person obtaining a
 copy of this software and associated documentation files (the "Software"),
 to deal in the Software without restriction, including without limitation
 the rights to use, copy, modify, merge, publish, distribute, sublicense,
 and/or sell copies of the Software, and to permit persons to whom the
 Software is furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in
 all copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 DEALINGS IN THE SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 11 days ago.

Report◂

DFSG NEW review for node-codemirror-lang-jinja version 6.0.0-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: Yes
Issues: 0 blocker, 0 important, 0 minor
debian/watch: version 5
debian/copyright: machine-readable
Scan before the review: nothing found

Licensing

debian/copyright is DEP-5 and accurate. The whole upstream tree (15 files) is MIT: LICENSE carries 'Copyright (C) 2025 by Marijn Haverbeke marijn@haverbeke.berlin and others', and the copyright file repeats that holder under Files: *, with the packaging separately under Files: debian/* (Edward Betts, MIT). No other copyright or licence wording exists anywhere in the tree, and the scan's author check found no holder the file misses. The full MIT text is included, so no reference to /usr/share/common-licenses is needed, and nothing in the tree is a built or otherwise unmodifiable artifact.

Packaging

Packaging is sound: debhelper compat 14 with dh-nodejs (no-lerna and single-binary sequences), a small debian/build.cjs that bundles src/jinja.ts with rollup/esbuild and generates d.ts, and every tool it calls (lezer-generator, tsc, rollup and its three plugins, esbuild) is in Build-Depends. Runtime imports of the generated dist (@codemirror/language, lang-html, state, view, autocomplete, @lezer/common, @lezer/highlight, @lezer/lr) are all satisfied by Depends, directly or through node-lezer-common, which Provides the lezer modules. Standards-Version 4.7.4 matches current Policy 4.7.4.1, the changelog is a proper initial release closing the ITP, and the autopkgtest-pkg-nodejs test script is present with the needed packages in Build-Depends. The only patch is dgit's own single-delta patch, applied and consistent with .pc/applied-patches.

Issues

None.

Verified ◂

Read every file under debian/: control, rules, changelog, copyright, clean, build.cjs, tsconfig.json, nodejs/build, nodejs/files, nodejs/extlinks, patches/series and patches/dgit-changes, source/format, tests/pkg-js/test, tests/pkg-js/files, upstream/metadata and docs.
Prescan: the only file with copyright/licence wording is LICENSE (lines 3 and 5); its holder Marijn Haverbeke is named in debian/copyright's Files: *, and the scan's author check reported no unlisted holder. LICENSE is upstream's plain MIT text, so it is free and reproduced in the copyright file.
Upstream tree is 15 files (.gitignore, .npmignore, CHANGELOG.md, LICENSE, package.json, README.md, seven src/ files, three test/ files); all are MIT and there are no other notices, SPDX tags or third-party embedded copies, and no built artifacts in the orig tarball.
src/jinja.grammar.js and src/jinja.grammar.terms.js are generated at build time from src/jinja.grammar (debian/build.cjs calls lezer-generator; debian/clean removes them), so no generated code ships without its input.
debian/build.cjs' require() and execFileSync() calls map to Build-Depends: esbuild (Provides node-esbuild), rollup, node-rollup-plugin-json, node-rollup-plugin-node-resolve, node-rollup-plugin-dts, node-typescript (>= 5.6, needed for noCheck), node-lezer-generator.
Every module listed in debian/nodejs/extlinks (@codemirror/autocomplete, language, state, view, lang-html, @lezer/common, @lezer/highlight, @lezer/lr, @lezer/generator) is reachable from Build-Depends, so dh_nodejs' extlinks step will not fail; apt-cache shows @lezer/lr and @lezer/highlight provided by node-lezer-common, which is both Build-Depends and Depends.
Runtime imports of the bundled dist are covered by Depends: node-codemirror-language, lang-html, state, view, autocomplete and node-lezer-common; nothing the bundle imports is missing.
debian/patches/dgit-changes is dgit's generated single combined delta (the .dsc has a Dgit field); it is applied (.pc/applied-patches names it) and only changes src/jinja.ts imports and type exports needed to build the ESM sources with tsc/esbuild.
debian/rules' override_dh_auto_clean only adds removal of dist, debian/types and the test output after dh_auto_clean; debian/nodejs/build runs debian/build.cjs, debian/nodejs/files installs dist, and dh_nodejs always installs package.json.
debian/tests/pkg-js/test is exercised at build time by dh_auto_test (which dh skips under nocheck, matching mocha/node-ist being marked <!nocheck>) and by autodep8's nodejs template, whose second test depends on @builddeps@.
uscan found the packaged version as the newest upstream release (upstream 6.0.0, packaged 6.0.0).

Not confirmed ◂

The contents of the esbuild binary package were not available on the reviewing system (esbuild not installed); it Provides node-esbuild, which is what debian/build.cjs requires, so I did not treat it as a fault.
Compatibility of node-rollup-plugin-dts 6.5.1 and node-rollup-plugin-json 6.0.0 with rollup 3.30.0 would only be shown by a build; nothing in the package indicates a mismatch.

Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader was emailed about the review 11 days ago.

Review Information

accepted — allocated to babelouest 11 days ago, started 11 days ago, completed 11 days ago.

Final Comment

Back to Dashboard | View all reviews for this package