Review: node-tinyqueue 3.0.0-1
Package Information
| Description | binary heap priority queue This library maintains a priority queue using a binary heap. It supports adding and removing items, inspecting the highest priority item and supplying a custom comparison function. |
|---|---|
| Maintainer | Home Assistant Team <team+homeassistant@tracker.debian.org> |
| Changed By | Edward Betts <edward@4angle.com> |
| Sponsor | edward@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/homeassistant-team/js/node-tinyqueue.git (browse) |
| Closes | #1152183 |
| Tracker | https://tracker.debian.org/pkg/node-tinyqueue |
| Uploaded | 12 days ago |
New Package Report
.changes
| Source | node-tinyqueue |
|---|---|
| Version | 3.0.0-1 |
| Changed-By | Edward Betts <edward@4angle.com> |
| Architecture | all source |
| Distribution | unstable |
| Date | Mon, 26 Oct 2026 16:04:52 +0000 |
Changelog
node-tinyqueue (3.0.0-1) unstable; urgency=medium . * Initial release. (Closes: #1152183)
.dsc
| Section | javascript |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | node-tinyqueue deb javascript optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: tinyqueue Upstream-Contact: Vladimir Agafonkin <agafonkin@gmail.com> Source: https://github.com/mourner/tinyqueue Files: * Copyright: 2017 Vladimir Agafonkin License: ISC Files: debian/* Copyright: 2026 Edward Betts <edward@4angle.com> License: ISC License: ISC Permission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted, provided that the above copyright notice and this permission notice appear in all copies. . THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 11 days ago.
Report
DFSG NEW review for node-tinyqueue version 3.0.0-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
The whole upstream tree is under the ISC licence, with the sole copyright holder Vladimir Agafonkin (2017), as LICENSE states; debian/ is Edward Betts' work under the same licence. debian/copyright is DEP-5, matches the tree, and reproduces the complete ISC text (ISC is not in /usr/share/common-licenses, so the full notice is required and present). There are no non-free terms, no vendored third-party code, no binaries, minified files or other non-preferred forms for modification, and no generator inputs are missing. The npm lock file is metadata for dev-only dependencies and is not part of the binary package.
Packaging
Small, clean dh-nodejs package: compat 14 through debhelper-compat with the single-binary add-on explicitly declared (correct at 14, and what compat 15 will require), 3.0 (quilt) source with no patches, Standards-Version 4.7.4 against Policy 4.7.4.1, ITP closure in an initial changelog for unstable, upstream/metadata and autopkgtest hook present. The binary installs index.js, index.d.ts and package.json (dh-nodejs adds package.json itself) under /usr/share/nodejs/tinyqueue, with README.md as documentation; the tests/pkg-js test is also the build-time test dh-nodejs runs, and it only needs the built-in node:test module. All Build-Depends names exist in the archive.
Issues
None.
Verified ◂
- debian/copyright is DEP-5 with the correct Format URL,
Files: *(2017 Vladimir Agafonkin, ISC) andFiles: debian/*(2026 Edward Betts, ISC), plus one stand-alone ISC paragraph whose text matches LICENSE verbatim. - LICENSE is the ISC licence with
Copyright (c) 2017, Vladimir Agafonkin; it is the only copyright/licence notice in the tree, and grep for Copyright/(C)/©/SPDX/licence names found no other holder or licence. - index.js, index.d.ts, test.js, bench.js and eslint.config.js are hand-written upstream sources under that ISC grant; none is minified or generated, so no corresponding source is missing.
- package-lock.json is npm lock metadata listing dev-only dependencies (eslint and its tree); it is not installed by debian/nodejs/files and carries no code of its own, so it needs no separate stanza.
- .github/workflows/node.yml is upstream CI configuration, not shipped in the binary, covered by Files: *.
- No vendored third-party libraries, no binary/compressed/JAR/bytecode files anywhere in the tree; the prescan listed no file to account for.
- dh-sequence-single-binary is provided by debhelper 14.5 and dh-sequence-nodejs-no-lerna by dh-nodejs 0.17.14 (apt-cache); dh-nodejs depends on nodejs:any, so the build-time test has an interpreter.
- dh-nodejs's install step appends package.json to the files from debian/nodejs/files, so the installed module keeps
"type": "module",mainandtypes, and consumers still resolve it; no ESM/CJS breakage introduced by packaging. - debian/tests/pkg-js/test (
node --test test.js) is also what dh-nodejs's buildsystemsub testruns from the build tree, where test.js and index.js both exist; test.js uses only node:test and node:assert. - uscan found the packaged version as the newest upstream release (upstream
3.0.0, packaged3.0.0).
Not confirmed ◂
- Could not execute the pkg-js autopkgtest runner (pkg-js-autopkgtest is not installed on the reviewing system), so how it stages debian/tests/pkg-js/test and whether test.js is visible to it in that context was not verified; nothing in the package indicates a failure.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader was emailed about the review 11 days ago.
Review Information
accepted — allocated to babelouest 11 days ago, started 11 days ago, completed 11 days ago.