DFSG NEW Queue

DFSG, Licensing & New Packages Team

Review: node-vscode-loader 1.0.2+ds-1

Package Information

DescriptionAMD module loader used by VS Code and Monaco

vscode-loader resolves and fetches AMD (Asynchronous Module Definition) modules at run time.

Monaco ships only the copy of this loader that VS Code's own build generates, so assembling a readable AMD tree from source requires this package.

Node.js is an event-based server-side JavaScript engine.

MaintainerDebian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>
Changed ByEmfox Zhou <emfox@debian.org>
Sponsoremfox@debian.org
Distributionunstable
Architectureall
VCSgit: https://salsa.debian.org/js-team/node-vscode-loader.git (browse)
Closes#1152332
Trackerhttps://tracker.debian.org/pkg/node-vscode-loader
Uploaded10 days ago

New Package Report

.changes◂
Changed-ByEmfox Zhou <emfox@debian.org>
Architecturesource all
Distributionunstable
DateWed, 28 Oct 2026 15:20:00 +0800
Sourcenode-vscode-loader
Version1.0.2+ds-1
Changelog◂
node-vscode-loader (1.0.2+ds-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #1152332)
.dsc◂
Package-Listnode-vscode-loader deb javascript optional arch=all
Sectionjavascript
Priorityoptional
Componentmain
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: vscode-loader
Source: https://github.com/microsoft/vscode-loader
Files-Excluded:
 .gitattributes
 .gitmodules
 .vscode
 src/loader.js
 src/loader.d.ts
 src/css.js
 src/css.build.js
 src/nls.js
 src/nls.build.js
 tests/loader.test.js
 tests/css.test.js
 tests/amdjs-tests
 tests/ms-specific
 tests/qunit/qunit.js
 tests/qunit/qunit.css
 tests/run-tests.htm

Files: *
Copyright: Microsoft Corporation
License: Expat

Files: tests/qunit/qunit.d.ts
Copyright: 2014 Diullei Gomes
Comment: Type definitions from DefinitelyTyped, which tsconfig.json lists.
License: Expat

Files: debian/*
Copyright: 2026 Emfox Zhou
License: Expat

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 10 days ago.

Report◂

DFSG NEW review for node-vscode-loader version 1.0.2+ds-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: Yes
  • Packaging is of good quality: Yes
  • Issues: 0 blocker, 0 important, 0 minor
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: nothing found

Licensing

MIT/Expat throughout, with the one third-party file given its own stanza. debian/copyright is DEP-5, names Microsoft Corporation for the loader (its own License.txt is the Expat text, also reproduced in the copyright file) and Diullei Gomes for tests/qunit/qunit.d.ts; the jQuery Foundation/QUnit code the upstream ThirdPartyNotices.txt covers (tests/qunit/qunit.js, qunit.css) is excluded from the repack and absent from the tarball. The +ds repack removes only tsc output, all of which debian/rules regenerates from the shipped TypeScript, so nothing lacks its preferred form for modification.

Packaging

Small, conventional packaging: compat 14 with the plain dh sequence and a manual install of the six generated files plus package.json under /usr/share/nodejs/vscode-loader; the tsc flags in debian/rules are the ones node-typescript 6.0.3 (the version in unstable, which the Build-Depends requires) accepts. Standards-Version is current, Vcs-* and Homepage are right, the single patch is DEP-3-headed with a clear purpose, and two offline autopkgtests run the upstream node suite against the installed loader and smoke-test the four shipped plugin bundles.

Issues

None.

Verified ◂
  • The scan's dfsg-author-check reported 35 files scanned and every copyright holder found already named in debian/copyright; it listed no file for individual attention, so there is nothing left unmatched.
  • Read all of debian/ (control, rules, changelog, copyright, patches/series and the single patch, tests/control, tests/node, tests/tree, source/format, gbp.conf, salsa-ci.yml, README.source) and every upstream text file: all eight src/core/*.ts, src/css.ts, src/nls.ts, src/css.build.ts, src/nls.build.ts, tests/css.test.ts, tests/loader.test.ts, tests/run-tests.js, the six tests/node-specific/*/_test.js, License.txt, ThirdPartyNotices.txt, README.md, package.json, tsconfig.json, src/core/tsconfig.json.
  • Each src/** and tests/*.test.ts file carries Copyright (c) Microsoft Corporation. All rights reserved. and Licensed under the MIT License. See License.txt; License.txt is the unmodified Expat text; debian/copyright's stand-alone License: Expat paragraph reproduces it, so the MIT notice is carried in the binary package even though License.txt itself is not installed.
  • tests/qunit/qunit.d.ts is the only file with no licence text of its own: its header is // Definitions by: Diullei Gomes with a DefinitelyTyped link, and debian/copyright gives it a dedicated stanza (Copyright: 2014 Diullei Gomes, License: Expat, the DefinitelyTyped licence), so it is not left under Files: *.
  • ThirdPartyNotices.txt covers tests/qunit/** as Copyright 2013 jQuery Foundation and other contributors; that applies to tests/qunit/qunit.js and qunit.css, which Files-Excluded removes and which are absent from node-vscode-loader_1.0.2+ds.orig.tar.xz (listed: only License.txt, README.md, ThirdPartyNotices.txt, package.json, tsconfig.json, src/, tests/).
  • The orig tarball contains no generated or excluded path: no src/{loader,css,nls}*.js, no src/loader.d.ts, no tests/{loader,css}.test.js, no tests/run-tests.htm, no tests/amdjs-tests, no tests/ms-specific, no .gitattributes/.gitmodules/.vscode; README.source explains both groups of exclusions correctly.
  • The six files installed by debian/rules are exactly the outputs of the two tsc projects (src/core/tsconfig.json emits src/loader.js and src/loader.d.ts, the root project emits src/css.js, src/css.build.js, src/nls.js, src/nls.build.js), and override_dh_auto_clean deletes them again, so the built JavaScript never enters the source tarball or the diff.
  • --noCheck exists as an option and --ignoreDeprecations 6.0 silences exactly the deprecations debian/rules has to get past — checkDeprecations("6.0", "7.0", ...) covers target: ES5 and outFile — checked in /usr/share/nodejs/typescript/lib/_tsc.js (node-typescript 6.0.3, the version at which --ignoreDeprecations accepts 6.0).
  • node-typescript 6.0.3-2 is in unstable and satisfies node-typescript (>= 6.0.0); tsc runs under nodejs, which node-typescript depends on; node-typescript is Architecture: all, so the arch:all build works anywhere.
  • nodejs is Multi-Arch: allowed, so Depends: nodejs:any in the Architecture: all binary is satisfiable (Policy 5.6.34.4); ${misc:Depends} being listed at compat 14 is harmless.
  • debhelper 14.5 on the reviewing system lists v14 as the recommended mode, and debian/compat is not used, so debhelper-compat (= 14) is current; Standards-Version 4.7.4 matches Policy 4.7.4.1 in its first two components.
  • debian/tests/node copies tests/run-tests.js and tests/node-specific, replaces _loader.js with a require of the installed /usr/share/nodejs/vscode-loader/src/loader, and runs the suite with the patch that makes it exit non-zero on failure — so it exercises the shipped files, not the source tree. debian/tests/tree loads the installed loader and each of the four plugin bundles through a fake define, checking the registered ids and plugin methods; both tests are offline and declare their nodejs dependency.
  • The patch 1001-Make-the-test-runner-fail-on-errors.patch has Description, Origin and Forwarded headers and adds the missing exit status after the summary line; it is the only patch and the series lists only it.
  • uscan found the packaged version as the newest upstream release (upstream 1.0.2, packaged 1.0.2+ds).
Not confirmed ◂
  • The package was not built or tested here (read-only review); the tsc invocation was checked against the installed compiler's option definitions, not by running it.
  • I could not check that Debian bug #1152332, which debian/changelog closes, is this package's ITP; no BTS access.
Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader was emailed about the review 10 days ago.

Review Information

accepted — allocated to mechtilde 10 days ago, started 10 days ago, completed 10 days ago.

Final Comment

Other Reviews of this Package

VersionHashAllocatedCompletedReviewerStatusDetails
1.0.2+ds-1 29c1e4ae… 2026-10-28 13:01 2026-10-28 13:01 dfsg-uploader rejected VIEW

Back to Dashboard | View all reviews for this package