Review: ocaml-checkseum 0.5.4-1
Package Information
| Description | Adler-32, CRC32 and CRC32-C implementation in C and OCaml (dev) Checkseum is a library to provide implementation of Adler-32, CRC32 and CRC32-C in C and OCaml. This library use the linking trick to choose between the C implementation (checkseum.c) or the OCaml implementation (checkseum.ocaml). This library is on top of optint to get the best representation of an int32. This package contains development files. |
|---|---|
| Maintainer | Debian OCaml Maintainers <debian-ocaml-maint@lists.debian.org> |
| Changed By | Stéphane Glondu <glondu@debian.org> |
| Sponsor | glondu@debian.org |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/ocaml-team/ocaml-checkseum.git (browse) |
| Closes | #1150428 |
| Tracker | https://tracker.debian.org/pkg/ocaml-checkseum |
| Uploaded | 29 days ago |
New Package Report
.changes
| Distribution | unstable |
|---|---|
| Date | Fri, 09 Oct 2026 16:32:23 +0200 |
| Source | ocaml-checkseum |
| Version | 0.5.4-1 |
| Changed-By | Stéphane Glondu <glondu@debian.org> |
| Architecture | source amd64 |
Changelog
ocaml-checkseum (0.5.4-1) unstable; urgency=medium . * Initial release (Closes: #1150428)
.dsc
| Section | ocaml |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | libcheckseum-ocaml deb ocaml optional arch=any libcheckseum-ocaml-dev deb ocaml optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Files: *
Copyright: 2014, Romain Calascibetta
License: MIT
Files: src-c/native/{adler32,crc32}.c
Copyright: 1995-2016, Mark Adler
License: Zlib
Files: src-ocaml/gin_crc32.ml
Copyright: 2011, Jonathan Derque
2018, Romain Calascibetta
License: MIT
Files: src-ocaml/gin_crc32c.ml
Copyright: 2011, Jonathan Derque
2016, Gabriel de Perthuis
License: MIT
Files: debian/*
Copyright: 2026, Stéphane Glondu <glondu@debian.org>
License: MIT
License: MIT
Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
the Software, and to permit persons to whom the Software is furnished to do so,
subject to the following conditions:
.
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
License: Zlib
This software is provided 'as-is', without any express or implied
warranty. In no event will the authors be held liable for any damages
arising from the use of this software.
.
Permission is granted to anyone to use this software for any purpose,
including commercial applications, and to alter it and redistribute it
freely, subject to the following restrictions:
.
1. The origin of this software must not be misrepresented; you must not
claim that you wrote the original software. If you use this software
in a product, an acknowledgment in the product documentation would be
appreciated but is not required.
2. Altered source versions must be plainly marked as such, and must not be
misrepresented as being the original software.
3. This notice may not be removed or altered from any source distribution.
.
Jean-loup Gailly Mark Adler
jloup@gzip.org madler@alumni.caltech.edu
.
If you use the zlib library in a product, we would appreciate *not* receiving
lengthy legal documents to sign. The sources are provided for free but without
warranty of any kind. The library has been entirely written by Jean-loup
Gailly and Mark Adler; it does not include third-party code.
.
If you redistribute modified sources, we would appreciate that you include in
the file ChangeLog history information documenting your changes. Please read
the FAQ for more information on the distribution of modified source versions.
Review Information
accepted — allocated to awm 26 days ago, started 26 days ago, completed 26 days ago.
Final Comment
Hi,
One important issue you should please fix in your next upload, the other at your option...
- [important] [licensing]
Files:glob uses brace expansion, so the zlib stanza matches no file
- Files:
debian/copyright:7 - Evidence:
Files: src-c/native/{adler32,crc32}.c; the copyright-format 1.0 spec (§6.9) admits only*,?and the\escape as pattern syntax ([]are explicitly not recognized), so{}has no special meaning and the pattern is literal. - Problem: The pattern matches no path in the tree, so
adler32.candcrc32.c-- whose in-file headers sayCopyright (C) 1995-2016 Mark Adler/ zlib (for conditions of distribution and use, see copyright notice in zlib.h) -- are instead matched by the earlierFiles: *stanza and recorded underCopyright: 2014, Romain CalascibettaandLicense: MIT. debian/copyright therefore states the wrong holder and the wrong licence for the only zlib files. It is not a DFSG violation (the files remain under a free, compatible licence and the full zlib text is already reproduced), but the record is inaccurate and an automated per-file comparison (e.g. licensecheck) would flag the mismatch. - Fix: List the two files without braces, e.g.
Files: src-c/native/adler32.c src-c/native/crc32.c(or one stanza per file), so the Mark Adler / Zlib stanza actually applies.
- [minor] [packaging] -dev package installs the upstream debug CLI via a bare
usr/binline; no man page
- Files:
debian/libcheckseum-ocaml-dev.install - Evidence: The file is exactly
usr/bin;bin/dunehas(executable (name main) (public_name checkseum.checkseum)); CHANGES.md (v0.2.0) calls the tool "used only for debugging". - Problem: A single-item install line makes dh_install guess its destination, copying the whole
usr/bindirectory (the dune-builtcheckseumCLI) intolibcheckseum-ocaml-dev; a /usr/bin program in a library -dev package is an unusual placement and, per Policy 12.1, it should come with a man page, which is not shipped anywhere in the package. The line only resolves if dh-ocaml's dune install stagesbin/underdebian/tmp; a build should confirm the resulting binary name and path. - Fix: Confirm at build time that the binary is found and what it is named; if the CLI is kept, add a man page or relocate/ship it more appropriately -- or drop the line entirely since the tool is debug-only.