Review: ocaml-decompress 1.6.1+dfsg2-1

Package Information

Description	implementation of Zlib and GZip in OCaml (dev) Decompress is an implementation of Zlib and GZip in OCaml It provides a pure non-blocking interface to inflate and deflate data flow. This package contains development files.
Maintainer	Debian OCaml Maintainers <debian-ocaml-maint@lists.debian.org>
Changed By	Stéphane Glondu <glondu@debian.org>
Sponsor	glondu@debian.org
Distribution	unstable
Architecture	any
VCS	git: https://salsa.debian.org/ocaml-team/ocaml-decompress.git (browse)
Closes	#1150429
Tracker	https://tracker.debian.org/pkg/ocaml-decompress
Uploaded	17 days ago

New Package Report

.changes◂

Source	ocaml-decompress
Version	1.6.1+dfsg2-1
Changed-By	Stéphane Glondu <glondu@debian.org>
Architecture	source amd64
Distribution	unstable
Date	Wed, 21 Oct 2026 15:46:50 +0200

Changelog◂

ocaml-decompress (1.6.1+dfsg2-1) unstable; urgency=medium
 .
   * Remove Calgary corpus (unclear license)
   * Fix debian/copyright
   * Change patch to add support for SKIP_CORPUS_TESTS and set this
     environment variable in debian/rules
   * Install a manpage for decompress
   * Remove unused build-dependency libbytesrw-ocaml-dev
 .
 ocaml-decompress (1.6.1+dfsg1-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1150429)

.dsc◂

Package-List	libdecompress-ocaml deb ocaml optional arch=any libdecompress-ocaml-dev deb ocaml optional arch=any
Section	ocaml
Priority	optional
Component	main

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Files-Excluded: test/corpus

Files: *
Copyright: 2019, Romain Calascibetta
License: MIT

Files: test/bin/zpipe.c
Copyright: not copyrighted
License: public-domain

Files: test/minilzo-2.10/*
Copyright: 1996-2017, Markus F.X.J. Oberhumer
License: GPL-2+

Files: test/minilzo-2.10/minilzo.ml
       test/minilzo-2.10/stubs.c
       test/minilzo-2.10/dune
Copyright: 2019, Romain Calascibetta
License: MIT

Files: debian/*
Copyright: 2026, Stéphane Glondu <glondu@debian.org>
License: MIT

License: MIT
 Permission is hereby granted, free of charge, to any person obtaining a copy of
 this software and associated documentation files (the "Software"), to deal in
 the Software without restriction, including without limitation the rights to
 use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
 the Software, and to permit persons to whom the Software is furnished to do so,
 subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

License: GPL-2+
 The LZO library is free software; you can redistribute it and/or
 modify it under the terms of the GNU General Public License as
 published by the Free Software Foundation; either version 2 of
 the License, or (at your option) any later version.
 .
 The LZO library is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU General Public License for more details.
 .
 On Debian systems, the full text of the GNU General Public License
 version 2 is available in /usr/share/common-licenses/GPL-2.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 17 days ago.

Report◂

DFSG NEW review for ocaml-decompress version 1.6.1+dfsg2-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: Yes
Issues: 0 blocker, 0 important, 0 minor
debian/watch: version 5
debian/copyright: machine-readable
Scan before the review: nothing found

Licensing

The source is DFSG-free and debian/copyright is accurate and complete. Everything is MIT (Romain Calascibetta, matching LICENSE.md), GPL-2+ (the vendored miniLZO test code, correctly limited to test/minilzo-2.10), or public domain (test/bin/zpipe.c). The Calgary corpus, the only unclear-licence material, is excluded via Files-Excluded and absent from the tree; the tests that need it are gated by the SKIP_CORPUS_TESTS patch. No binary, minified, image, font, or other non-preferred-form files are present. The miniLZO holder named in the sources ("Markus Franz Xaver Johannes Oberhumer") is the same entity as the "Markus F.X.J. Oberhumer" in debian/copyright, which is also the spelling in the files' own footers and Makefile, so no holder is missing.

Packaging

Packaging is of good quality and follows current OCaml team practice. debhelper-compat 14, dh with the ocaml addon and ocaml_dune buildsystem; every Build-Depends exists in the archive (libzip-ocaml-dev is Debian's camlzip, so the test-time camlzip dependency is present; dh-ocaml 3.8 satisfies >= 3.8~). Test-only library Build-Depends are correctly marked <!nocheck> and compat 13+ dh skips dh_auto_test under nocheck. The dfSG repack, SKIP_CORPUS_TESTS patch, and rules export are coherent; a manpage is generated from the built binary, installed in the -dev package, and cleaned via debian/clean. Standards-Version 4.7.4 is current enough for Policy 4.7.4.1; Vcs-* fields and changelog are correct.

Issues

None.

Verified ◂

Read debian/copyright in full: DEP-5 with the exact Format URL, Files-Excluded: test/corpus, Files:* MIT, test/bin/zpipe.c public-domain, test/minilzo-2.10/* GPL-2+, three MIT override stanzas, debian/* MIT, and full stand-alone MIT and GPL-2+ (pointing to /usr/share/common-licenses/GPL-2) texts. License: public-domain is a standard copyright-format short name needing no License paragraph.
Prescan files accounted for: test/minilzo-2.10/{minilzo.c,lzoconf.h,lzodefs.h,minilzo.h,testmini.c,Makefile,README.LZO} all carry Copyright (C) 1996-2017 Markus Franz Xaver (Johannes) Oberhumer with a GPL-2+ grant; debian/copyright names the same holder as Markus F.X.J. Oberhumer (the abbreviation also used inside minilzo.c and the Makefile), so these are neither missing holders nor mis-licensed - covered by Files: test/minilzo-2.10/*.
Grepped the whole tree (gitignore disabled) for Copyright/licence markers: only LICENSE.md, test/minilzo-2.10/COPYING and test/bin/zpipe.c carry notices; the lib/, bin/, bench/, fuzz/ and test/ OCaml sources are headerless and are all covered by the Files: * MIT stanza, matching LICENSE.md's single holder.
test/corpus is absent from the tree; the only references are in test rules, the cram test, bench/b.ml (@runbench) and test source guarded by the SKIP_CORPUS_TESTS patch, which debian/rules exports as true - the corpus-dependent rules (and the cram test needing ../corpus/news, ../corpus/bib) are disabled by the patch's enabled_if.
No binary, minified, generated, or other non-preferred-form files: the tree contains only source (OCaml, C, dune and text files); no _build directory, no images/fonts/PDFs/JARs. lib/lzo is pure OCaml - the GPL miniLZO C stubs are used only by test executables and are not installed.
Read every debian file in full (control, rules, changelog, clean, install, manpages, gbp.conf, debian-dune, dh-ocaml.conf.json, source/format, patches/series and the patch).
All Build-Depends packages verified present in the archive lists (libcmdliner-, liboptint-, libcheckseum-, libalcotest-, libfmt-, libzip-, libbase64-, libcrowbar-, libbstr-ocaml-dev, ocaml-dune, dh-ocaml 3.8).
Standards-Version 4.7.4 vs current Policy 4.7.4.1 (checked via the policy tool): first two components match, not an issue.
uscan found the packaged version as the newest upstream release (upstream 1.6.1, packaged 1.6.1+dfsg2).
Every pointer of debian/copyright to /usr/share/common-licenses names a file that is there (GPL-2).

Not confirmed ◂

Without building, the test phase outcome is unverified: dune runtest -p decompress,rfc1951 will build and run test_lzo.exe and the three crowbar fuzzers, and execute_before_dh_installman must run debian/tmp/usr/bin/decompress --help=groff; none of that is wrong on the face of the sources, only unexecuted here.

Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader was emailed about the review 17 days ago.

Review Information

accepted — allocated to awm 16 days ago, started 16 days ago, completed 16 days ago.

Final Comment

Other Reviews of this Package

Version	Hash	Allocated	Completed	Reviewer	Status	Details
1.6.1+dfsg1-1	adb3e56e…	2026-10-21 13:51	2026-10-21 13:51	dfsg-uploader	rejected	VIEW

Back to Dashboard | View all reviews for this package