DFSG NEW Queue - Review: openstack-pkg-tools 151

Review: openstack-pkg-tools 151

Package Information

Description	Tools and scripts for building Openstack packages in Debian This package contains some useful shell scripts and helpers for building the OpenStack packages in Debian, including: * shared code for maintainer scripts (.config, .postinst, ...). * init script templates to automatically generate init scripts for sysv-rc and systemd. * tools to build backports using sbuild and/or Jenkins based on gbp workflow. * utility to maintain git packaging (to be included in a debian/rules). Even if this package is maintained in order to build OpenStack packages, it is of a general purpose, and it can be used for building any package.
Maintainer	Debian OpenStack <team+openstack@tracker.debian.org>
Changed By	Thomas Goirand <zigo@debian.org>
Sponsor	zigo@debian.org
Distribution	unstable
Architecture	all
VCS	git: https://salsa.debian.org/openstack-team/debian/openstack-pkg-tools.git (browse)
Popcon Installs	55
Binary NEW	Yes (new binary packages of a source already in sid)
Tracker	https://tracker.debian.org/pkg/openstack-pkg-tools
Uploaded	27 days ago

New Package Report

.changes◂

Changed-By	Thomas Goirand <zigo@debian.org>
Architecture	source all
Distribution	unstable
Date	Sat, 10 Oct 2026 14:27:25 +0200
Source	openstack-pkg-tools
Version	151

Changelog◂

openstack-pkg-tools (151) unstable; urgency=medium
 .
   * Added a new python3-pkgos binary package, providing the pkgos command
     line tool, built on oslo.config (option handling, reading
     /etc/pkgos/pkgos.conf) and cliff (--format and --column options, as in
     the OpenStack clients). It ships a first "pkgos rmadison" command,
     which is like rmadison(1) but for osbpo.debian.net: it shows the
     version of a package in every supported distro/OpenStack release
     backports suite, with dynamic suite discovery, threaded index
     fetching, and chronological ordering based on
     /etc/pkgos/{openstack,debian}-release.txt.
   * Added /etc/pkgos/openstack-debian-release.txt, associating each
     OpenStack release with the Debian release(s) it is backported for,
     and completed /etc/pkgos/debian-release.txt with jessie and
     stretch, used when ordering old suites reached with -s.

.dsc◂

Section	devel
Priority	optional
Component	main
Package-List	openstack-pkg-tools deb devel optional arch=all python3-pkgos deb python optional arch=all

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: openstack-pkg-tools
Source: https://salsa.debian.org/openstack-team/debian/openstack-pkg-tools

Files: *
Copyright: 2012-2022, Thomas Goirand <zigo@debian.org>
           2012, Roland Mas <lolando@debian.org>
           2017-2019, Michal Arbet <michal.arbet@ultimum.io>
           2016-2020, Ondřej Nový <onovy@debian.org>
License: Apache-2
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 .
    http://www.apache.org/licenses/LICENSE-2.0
 .
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
 .
 On Debian-based systems the full text of the Apache version 2.0 license
 can be found in `/usr/share/common-licenses/Apache-2.0'.

Review Information

accepted — allocated to awm 27 days ago, started 27 days ago, completed 27 days ago.

Final Comment

Hi,

Some minor issues noted by the LLM review that you may want to look at...

[packaging] Three shipped tools are installed without their man pages

Files: debian/openstack-pkg-tools.manpages, debian/openstack-pkg-tools.install, misc/openstack.profile:12
Evidence: man/pkgos-choose.1, man/pkgos-debcrate.1 and man/pkgos-reportbug.8 exist but are absent from debian/openstack-pkg-tools.manpages; the corresponding /usr/bin binaries are installed by the misc/pkgos* glob, and the shipped lintian profile Disable-Tags: ... binary-without-manpage ... hides the gap.
Problem: Policy 12.1 requires every program/utility to ship its associated man page in the same package; the pages were written but simply never listed, so users of pkgos-choose, pkgos-debcrate and pkgos-reportbug get no documentation (and the tag was disabled rather than fixed).
Fix: Add man/pkgos-choose.1, man/pkgos-debcrate.1 and man/pkgos-reportbug.8 to debian/openstack-pkg-tools.manpages (and re-enable the lintian tag).

[licensing] debian/copyright holder list and year range outdated for the current release

Files: debian/copyright:6-9
Evidence: Copyright: 2012-2022, Thomas Goirand <zigo@debian.org> ... 2016-2020, Ondřej Nový <onovy@debian.org> while e.g. man/pkgos-choose.1:44 says Man page: (c) 2026, Thomas Goirand and debian/po/de.po carries Copyright (C) 2010 United States Government,...,2010-2011 OpenStack LLC / Copyright (C) of this file 2012-2018 Chris Leick; several other debian/po/*.po credit individual translators.
Problem: The Files: * stanza's holder list is incomplete and its year range predates this 2026 upload; file notices from 2026 and the translation copyright holders are not represented. The licence itself (Apache-2 throughout) is correct, so this is an accuracy/completeness nit, not a DFSG problem.
Fix: Refresh the Copyright field: extend the year range and add current contributors (2026 man-page author) and the PO translators, or add a Comment noting translator copyrights.

[packaging] Unreferenced script left in debian/

Files: debian/pkgos-update-theme-packages
Evidence: Full executable shell tool (#!/bin/sh, adds a fonts-font-awesome dependency to OpenStack -doc packages) with no reference from debian/rules, debian/control or any .install file and no man page; it reaches no binary package.
Problem: Dead/orphaned code in the source tree — either a finished tool that should be shipped to users or leftover work-in-progress that should not be uploaded.
Fix: Either install it like the other pkgos-* tools (add to a .install file plus a man page) or remove it from the release.

[packaging] git missing from openstack-pkg-tools Depends/Recommends

Files: debian/control:18-20
Evidence: The package's Depends list python3-debian, python3-pip, gettext, jq, po-debconf, fzf, reportbug and Recommends autopkgtest, madison-lite, pristine-tar contains no git, yet installed tools invoke it (e.g. misc/pkgos-debcrate does git clone/git commit, pkgos-update-release and salsa-scripts/pkgos-salsa-* are git-based); git appears only in Build-Depends (git, line 10).
Problem: Core advertised functionality fails at runtime with a missing git executable on systems without it — inconsistent with the maintainer's habit of listing every other runtime dependency (jq, fzf, reportbug).
Fix: Add git to Depends or Recommends of openstack-pkg-tools.

No obligation to resolve these - the package is OK as-is, but these pedantic observations by an LLM review might be interesting.

Thanks!

Back to Dashboard | View all reviews for this package