DFSG NEW review for pg-stat-tcpinfo version 1.1-1

Summary

• Licensing is DFSG-compliant and debian/copyright is accurate: Yes
• Packaging is of good quality: Yes
• Issues: 0 blocker, 0 important, 0 minor
• debian/watch: version 5
• debian/copyright: machine-readable
• Scan before the review: nothing found

Licensing

The whole tree is under the PostgreSQL licence, which is permissive and DFSG-free. Every upstream file either carries a PostgreSQL Global Development Group copyright notice and the licence text (pg_stat_tcpinfo.c, pg_tcp_info.h, LICENSE) or is covered by them (SQL scripts, Makefile, README, regression data). debian/copyright is DEP-5 with the correct Format URL, the complete licence text inline, and a separate debian/* stanza for Christoph Berg. No non-free terms, no unlicensed file, no binaries, minified code or generated files, and no third-party code whose provenance is unclear.

Packaging

The packaging is the PostgreSQL team's canonical pgxs template: control.in with PGVERSION, pgversions all, ${postgresql:Depends}/${postgresql:Breaks}, debhelper compat 13 via dh $@ --with pgxs, Rules-Requires-Root: no, and an autopkgtest that runs pg_buildext installcheck with Restrictions: allow-stderr. Build-Depends are all satisfiable in the archive, Standards-Version 4.7.4 matches current Policy 4.7.4.1, the changelog is a sane 1.1-1/unstable initial release, and the orig tarball matches the unpacked tree and contains no debian/ directory. No patches are needed (3.0 (quilt) source, empty patch set).

Issues

None.

Verified

• debian/copyright read in full: DEP-5, Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/, Upstream-Name/Source, a Files: * stanza giving the PostgreSQL licence with the full text inline, and a Files: debian/* stanza (2026 Christoph Berg, PostgreSQL). No Files-Excluded is needed: the orig tarball removes nothing.
• All ten files of pg-stat-tcpinfo_1.1.orig.tar.gz are text and match the unpacked tree: pg_stat_tcpinfo.c, pg_tcp_info.h, LICENSE, README.md, Makefile, pg_stat_tcpinfo.control, pg_stat_tcpinfo--1.0.sql, pg_stat_tcpinfo--1.1.sql, sql/pg_stat_tcpinfo.sql, expected/pg_stat_tcpinfo.out. No binaries, minified files, archives, bytecode or generated code in the tree (the prescan listed no such file either).
• Only three copyright holders appear anywhere: pg_stat_tcpinfo.c:6 and LICENSE:3 (Portions Copyright (c) 2025-2026, PostgreSQL Global Development Group), pg_tcp_info.h:14 (Copyright (c) 2026, PostgreSQL Global Development Group), and Christoph Berg in debian/*. All are named in debian/copyright; the prescan's dfsg-author-check likewise found none missing.
• pg_tcp_info.h is, by its own comment, a renamed copy of the layout of the Linux 6.17 UAPI struct tcp_info plus a TCPI_HAS macro; it contains no kernel implementation code, so no additional holder or licence stanza is required for it.
• debian/copyright's Files: * notice (PGDG 1996-2026 plus 1994, The Regents of the University of California) is PostgreSQL's standard notice and is broader than the PGDG 2025-2026 notices in the files themselves; no holder found in the tree is missing, so this is year/attribution drift, not an inaccuracy to fix.
• Both extension scripts (pg_stat_tcpinfo--1.0.sql and --1.1.sql) are identical and no --1.0--1.1 update script is shipped; no Debian upload has ever shipped 1.0, so no in-archive upgrade path is affected (default_version is 1.1).
• Build-Depends checked with apt-cache: architecture-is-64-bit is a virtual package provided by architecture-properties 0.2.6+b2, postgresql-server-dev-all 293, postgresql-all 293 and debhelper-compat 13 are all available; postgresql-all depends on postgresql-18, consistent with the binary package name.
• Packaging matches the pg_buildext(1) example for dh $@ --with pgxs exactly (control.in with PGVERSION, debian/pgversions all, ${postgresql:Depends}/${postgresql:Breaks}, override_dh_installdocs: dh_installdocs --all README.*).
• debian/tests/control uses @ (the binary package generated by the source, per the autopkgtest spec) plus postgresql-common-dev, and debian/tests/installcheck calls pg_buildext installcheck, which the manual documents as the autopkgtest entry point; Restrictions: allow-stderr is present.
• Standards-Version 4.7.4 against Policy 4.7.4.1 (first two components 4.7) is current. debian/changelog is 1.1-1, distribution unstable, urgency medium, signed by the uploader; Homepage and Vcs-Browser/Vcs-Git are present.
• debian/source/format is 3.0 (quilt) with no debian/patches, so there is no series or DEP-3 header to check. .pc/ was ignored throughout, and debian/cargo-checksum.json does not exist.
• uscan found the packaged version as the newest upstream release (upstream 1.1, packaged 1.1).

Not confirmed

• No build or test run was possible (postgresql-server-dev-18 and postgresql-common are not installed on the reviewing system), so the direct calls to jsonb_in/inet_in and the %llu arguments for __u64 members were not checked against the 18 headers; a build would show any warning there.
• Could not verify that pg_virtualenv's temporary cluster listens on 127.0.0.1, which expected/pg_stat_tcpinfo.out assumes; Debian's default cluster configuration should provide it.

Proposed changes

None.