php-amphp-sql 2.1.1-1

Package Information

Description	${phpcomposer:description} This package provides shared interfaces and classes.
Maintainer	Debian PHP PEAR Maintainers <pkg-php-pear@lists.alioth.debian.org>
Changed By	David Prévot <taffit@debian.org>
Sponsor	taffit@debian.org
Distribution	experimental
Architecture	all
VCS	git: https://salsa.debian.org/php-team/pear/php-amphp-sql.git (browse)
Tracker	https://tracker.debian.org/pkg/php-amphp-sql
Uploaded	2 hours ago

New Package Report

.changes◂

Changed-By	David Prévot <taffit@debian.org>
Architecture	source all
Distribution	experimental
Date	Wed, 04 Nov 2026 18:57:51 +0100
Source	php-amphp-sql
Version	2.1.1-1

Changelog◂

php-amphp-sql (2.1.1-1) experimental; urgency=medium
 .
   * Initial release (New symfony dependency)

.dsc◂

Section	php
Priority	optional
Component	main
Package-List	php-amphp-sql deb php optional arch=all

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: SQL
Upstream-Contact: Niklas Keller <me@kelunik.com>
Source: https://github.com/amphp/sql

Files: *
Copyright: 2018-2022 amphp
License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in
 all copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 2 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 1 hour ago.

Report◂

DFSG NEW review for php-amphp-sql version 2.1.1-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: No
Packaging is of good quality: Yes
Issues: 0 blocker, 0 important, 2 minor
debian/watch: version 5
debian/copyright: machine-readable
Scan before the review: nothing found

Licensing

The upstream licence is plain MIT (Expat): LICENSE is the only licence text in the tree, composer.json says "license": "MIT", the source and test files carry no other notices, and the full Expat text is reproduced in debian/copyright, so the licensing itself is DFSG-free and no licence is missing. debian/copyright is DEP-5 but does not describe the package accurately: there is no Files: debian/* stanza, so the packaging is attributed to amphp, 2018-2022, and the Files: * Copyright line truncates the upstream statement by dropping the holders named in LICENSE.

Packaging

Textbook pkg-php-tools packaging: compat 14, dh $@ with dh-sequence-phpcomposer, correct build/test split with phpunit <!nocheck>, tests run through an override that dh skips under nocheck, autoloader generated with phpab/phpabtpl and registered in /usr/share/pkg-php-tools/autoloaders (format matches the one installed example), an autopkgtest that rebuilds the autoloader, a DEP-3 patch adapting the tests to PHPUnit 13, and consistent clean/install/docs files. Standards-Version 4.7.4 matches the reviewing system's Policy (upgrading checklist tops out at 4.7.4). No packaging defect worth reporting.

Issues

minor licensing 1. debian/copyright has no stanza for debian/*, so the packaging files are attributed to amphp 2018-2022 ◂

Files: debian/copyright:6-8
Basis: checked, in the package or with a reference tool
Evidence: Files: * / Copyright: 2018-2022 amphp is the only stanza; copyright-format 5.2 (read with the policy tool) shows Files: debian/* with Copyright: 2010 Daniela Debianizer as the standard way to cover the packaging, and the installed example /usr/share/doc/jsonlint/copyright does the same.
Problem: The catch-all stanza is the last stanza, so debian/control, debian/rules, debian/copyright itself, the patch and the autoloaders file are declared to be copyright 2018-2022 amphp under Expat. That is false: they were written by the uploader in 2026. Policy 12.5 requires the copyright file to be the package's copyright information, and DEP-5 requires the Copyright field of the applicable stanza to be accurate.
Fix: Add a Files: debian/* paragraph with Copyright: 2026 David Prévot <taffit@debian.org> and License: Expat, referencing the existing stand-alone Expat paragraph (no new licence text needed).

minor licensing 2. Files: * drops the holders Aaron Piotrowski and Niklas Keller that LICENSE names next to amphp ◂

Files: debian/copyright:7, LICENSE:3
Basis: checked, in the package or with a reference tool
Evidence: LICENSE:3: Copyright (c) 2018-2022 amphp (Aaron Piotrowski, Niklas Keller, and contributors); debian/copyright:7: Copyright: 2018-2022 amphp.
Problem: DEP-5's Copyright field must state the copyright of the files it covers; the upstream notice names two individuals besides the amphp organisation, and omitting them makes the statement incomplete. The licence grant itself (Expat) is unaffected.
Fix: Reproduce the upstream statement, e.g. Copyright: 2018-2022 amphp (Aaron Piotrowski, Niklas Keller, and contributors), keeping the years as they are.

Verified ◂

Read every upstream file: 16 files in src/, test/SqlConfigTest.php and test/SqlQueryErrorTest.php, LICENSE, README.md, composer.json, phpunit.xml.dist, psalm.xml, .php_cs, .php-cs-fixer.dist.php, .gitignore and .github/workflows/ci.yml. LICENSE (MIT/Expat) is the only licence notice in the tree; no SPDX tags, no All rights reserved, no non-free wording, no other holder.
No vendored or embedded third-party code: composer.json requires only amphp/amp (not shipped here), and src/ contains only the Amp\Sql interfaces/classes with no attribution to other projects.
debian/copyright is DEP-5 with the full Expat text (Expat is not in /usr/share/common-licenses, so quoting it is required and done); all upstream files, including .github/workflows/ci.yml, .php_cs, .php-cs-fixer.dist.php, psalm.xml and phpunit.xml.dist, fall under Files: *.
No built or generated artefacts in the source: src/autoload.php and vendor/ are produced by debian/rules at build time and listed in debian/clean; .phpunit.result.cache likewise; nothing is minified and there are no PDFs, images, fonts or other binaries in the tree.
The single quilt patch (0001-Compatibility-with-recent-PHPUnit-13.patch, 1.9 KB) touches only test/SqlConfigTest.php to switch @dataProvider to #[DataProvider] and static providers; it has From/Date/Subject, is applied in .pc/, and the working-tree test file matches its post-image. Debian ships phpunit 13.4.5 (apt-cache), so the change matches the archive.
php-amphp-amp (the only Composer require) is not yet in the archive but is built by php-amphp-amp 3.1.3-1 waiting in NEW for experimental, so its Build-Depends entry can be satisfied and is not a fault. dh-sequence-phpcomposer is provided by pkg-php-tools 1.50 (apt-cache).
debian/autoloaders/php-amphp-sql (amphp sql Amp/Sql/autoload.php) matches the three-field format of the installed example /usr/share/pkg-php-tools/autoloaders/jsonlint (seld jsonlint Seld/JsonLint/autoload.php), and the installed path /usr/share/php/Amp/Sql matches the PSR-4 mapping in composer.json.
Standards-Version 4.7.4 is current: the Policy upgrading checklist (A10) tops out at version 4.7.4. debhelper compat 14 with dh $@; the override_dh_auto_test running phpunit is skipped by dh under nocheck, so phpunit <!nocheck> in Build-Depends is correct.
The orig tarball amphp-sql-2.1.1 ships test/ (needed for the patch and the test run) and the same file set as the unpacked tree; debian/source/format is 3.0 (quilt), debian/rules builds the autoloader with phpab/phpabtpl and cleans up after it, and debian/tests/control rebuilds the autoloaders with phpabtpl/phpab and declares @, phpab, phpunit and pkg-php-tools.
uscan found the packaged version as the newest upstream release (upstream 2.1.1, packaged 2.1.1).

Not confirmed ◂

Whether PHPUnit 13.4.5 accepts upstream's phpunit.xml.dist, which uses the PHPUnit 9.3 schema (backupStaticAttributes, <coverage><include>): a build would show whether it emits configuration-validation warnings or refuses the file. Not reported, since the maintainer's clean build presumably ran the tests.
pkg-php-tools is not installed on the reviewing system, so dh_phpcomposer's substvars and phpabtpl's --basedir option could not be checked against the helper's own source; the build would show whether the generated ${phpcomposer:*} fields and autoload templates are right.

Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader was emailed about the review 1 hour ago.

Back to Dashboard | View all reviews for this package