php-ast 1.1.4-2
Package Information
| Description | AST extension for PHP 7 This extension exposes the abstract syntax tree generated by PHP 7. This is empty package that depends on default PHP version. |
|---|---|
| Maintainer | Debian PHP PECL Maintainers <team+php-pecl@tracker.debian.org> |
| Changed By | Ondřej Surý <ondrej@debian.org> |
| Sponsor | ondrej@debian.org |
| Distribution | experimental |
| Architecture | any all |
| VCS | git: https://salsa.debian.org/php-team/pecl/php-ast.git (browse) |
| Popcon Installs | 40 |
| Binary NEW | Yes (new binary packages of a source already in sid) |
| Tracker | https://tracker.debian.org/pkg/php-ast |
| Uploaded | 2 hours ago |
New Package Report
.changes
| Date | Sat, 21 Nov 2026 10:04:14 +0100 |
|---|---|
| Source | php-ast |
| Version | 1.1.4-2 |
| Changed-By | Ondřej Surý <ondrej@debian.org> |
| Architecture | source all amd64 |
| Distribution | experimental |
Changelog
php-ast (1.1.4-2) experimental; urgency=medium . * Build-Depend on php-all-dev (>= 2:102~) for PHP 8.6 * Bump Build-Depends to dh-php >= 5.23~
.dsc
| Section | php |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | php-ast deb php optional arch=all php-ast-all-dev deb php optional arch=all php8.6-ast deb php optional arch=any |
debian/copyright
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: php-ast
Source: https://github.com/nikic/php-ast
Files: *
Copyright: 2014 by Nikita Popov.
License: BSD-3-clause
Files: debian/*
Copyright: 2013 Ondřej Surý <ondrej@debian.org>
License: Expat
License: BSD-3-clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
.
* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
.
* Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the following
disclaimer in the documentation and/or other materials provided
with the distribution.
.
* The names of the contributors may not be used to endorse or
promote products derived from this software without specific
prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
License: Expat
Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:
.
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 1 important, 3 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 1 hour ago.
Proposes a replacement debian/watch:
debian/watch in version 5 format
Proposes a replacement debian/copyright:
debian/copyright Format field
Report
DFSG NEW review for php-ast version 1.1.4-2
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 1 important, 3 minor
- debian/watch: old format (version 3)
- debian/copyright: machine-readable, without the current Format URL
- Scan before the review: nothing found
Licensing
debian/copyright is DEP-5 and accurate. The only copyright notice in the tree is ast-1.1.4/LICENSE: 2014 Nikita Popov, BSD-3-Clause, which Files: * names and whose full text debian/copyright reproduces. The debian/ files carry the Expat stanza, also reproduced in full. The generated ast_arginfo.h comes from ast_stub.php, which ships; no non-free wording, third-party licence or unattributed holder exists in the tree. The only defect is the http:// Format: URL, which the report tool flags itself.
Packaging
The packaging is the PHP team's standard dh-php PECL pattern and is sound: correct binary split (arch:all dummy php-ast and php-ast-all-dev, arch:any php8.6-ast), substvars present for compat 10, no patches, sensible gbp.conf and changelog. Two minor points remain: Standards-Version has not moved since 4.5.1, and debian/rules neutralises the test suite's failure exit status.
Issues
important licensing 1. debian/copyright does not declare the current copyright-format 1.0 URL ◂
- Files:
debian/copyright:1 - Basis: found by the review tooling's own checks
- Evidence:
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ - Problem: The first field must be exactly
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/(copyright-format 1.0, "Format" field). Anything else, including thehttp://form and the URLs of the drafts that preceded 1.0, does not declare the file to be in the current format, and a file written to a draft may also use field names and licence short names that 1.0 changed. - Fix: Replace the line as shown under Proposed changes, then check the rest of the file against copyright-format 1.0 (for example
Upstream-Name,Upstream-ContactandSourcein the header, notNameorMaintainer).
minor packaging 2. Standards-Version 4.5.1 is behind the current Policy 4.7.4.1 ◂
- Files:
debian/control:9,debian/control.in:9 - Basis: checked, in the package or with a reference tool
- Evidence:
Standards-Version: 4.5.1 - Problem: The reviewing system's Policy is 4.7.4.1, so the first two components (4.5 against 4.7) are out of date. A version below the current Policy's is a minor packaging defect.
- Fix: Set
Standards-Version: 4.7.4.1in debian/control.in and regenerate debian/control; check Policy appendix A10 for changes since 4.5.1 (none affect this packaging).
minor packaging 3. debian/rules disables the test suite's failure exit status with REPORT_EXIT_STATUS=0 ◂
- Files:
debian/rules:2,debian/changelog (entry 1.0.10-2) - Basis: inferred from what was read, not seen directly
- Evidence:
export REPORT_EXIT_STATUS:=0; changelog 1.0.10-2:* Don't fail on failed tests - Problem: REPORT_EXIT_STATUS is the PHP test runner's switch for returning non-zero when .phpt tests fail. Exported as 0 for the whole build, failing upstream tests do not stop the build, so a regression can be uploaded unnoticed; the changelog records that this was done deliberately in 1.0.10-2. A test suite that cannot fail the build gives no protection.
- Fix: Remove the export so
make test/dh_auto_test honours the runner's exit status, and skip individual tests that legitimately fail with an explicit SKIPIF or exclusion rather than disabling failure reporting globally.
minor packaging 4. debian/watch is in the old version 3 format ◂
- Files:
debian/watch - Basis: found by the review tooling's own checks
- Evidence:
version=3 - Problem: Version 5 is the current format of
debian/watch. - Fix: Convert it to version 5; a mechanical conversion is under Proposed changes.
Verified ◂
- Read all of debian/: control, control.in, rules, changelog, copyright, compat (10), gbp.conf, ast.ini, php-ast.docs, php-ast.php and source/format (3.0 quilt); there are no patches, tests/ or install files.
- Inventoried the upstream tree: package.xml at the top, and ast-1.1.4/{LICENSE,README.md,ast.c,ast_data.c,ast_arginfo.h,ast_str_defs.h,ast_stub.php,config.m4,config.w32,php_ast.h,util.php} plus tests/*.phpt and two test data files. No other LICENSE/COPYING/NOTICE file exists.
- The only copyright notice in the tree is ast-1.1.4/LICENSE (
Copyright (c) 2014 by Nikita Popov., BSD-3-Clause), matched byFiles: *; debian/copyright reproduces the BSD-3-Clause text in full. - debian/* is covered by the later
Files: debian/*stanza (Expat, Ondrej Sury); the Expat text is reproduced in full. Later stanzas overrideFiles: *as required. - grep for non-commercial, no-modification, field-of-use, GPL/LGPL/Apache/MPL/SPDX and public-domain wording found nothing; the tree contains no binaries, minified code or PDFs.
- ast_arginfo.h is generated (
This is a generated file, edit the .stub.php file instead) from ast-1.1.4/ast_stub.php, which is present; ast_data.c and ast_str_defs.h are handwritten, so no generated file lacks its input. - The prescan listed no built files, minified code, PDFs or non-free wording, and its author check found every holder named; the only holder it could have matched is Nikita Popov in LICENSE.
- Build-Depends are satisfiable per apt-cache/madison: php-all-dev 2:102~ in experimental and dh-php 5.23 in unstable; the control's php8.6-ast package matches the PHP 8.6 build set the changelog describes.
- debian/copyright is in DEP-5 format; its Format: value is the older http:// URL, left for the report tool to flag.
- uscan found the packaged version as the newest upstream release (upstream
1.1.4, packaged1.1.4).
Not confirmed ◂
- dh-php is not installed on the reviewing system, so /usr/share/dh-php/pkg-pecl.mk (included by debian/rules) could not be read; how the test step and control generation work is taken from the package's own changelog and control files.
- No build or test run was possible in this read-only review; the extension was assumed to build and the .phpt suite to pass.
Proposed: debian/watch in version 5 format ◂
debian/watch is in an old format. This is the conversion made by uscan --update-watchfile, which has not been run against the upstream site: some defaults differ in version 5, so test it with uscan --report before use.
Version: 5
Source: https://pecl.php.net/package/ast
Matching-Pattern: .*/ast-(\d.*)\.(?:tgz|tbz2|txz|tar\.(?:gz|bz2|xz))
Uversionmangle: s/(\d)RC(\d*)$/$1rc$2/;s/(\d)[_\.\-\+]?((RC|rc|pre|dev|beta|alpha|b|a)[\-\.]?\d*)$/$1~$2/
Proposed: debian/copyright Format field ◂
Replace line 1 of debian/copyright with:
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Uploader's response to the LLM review
Waiting for the uploader's response until , because the review found serious issues.