php-console-getopt 1.4.3-1

Package Information

Description	${phppear:summary} ${phppear:description}
Maintainer	Debian PHP PEAR Maintainers <pkg-php-pear@lists.alioth.debian.org>
Changed By	David Prévot <taffit@debian.org>
Sponsor	taffit@debian.org
Distribution	unstable
Architecture	all
VCS	git: https://salsa.debian.org/php-team/pear/php-console-getopt.git (browse)
Tracker	https://tracker.debian.org/pkg/php-console-getopt
Uploaded	3 hours ago

New Package Report

.changes◂

Source	php-console-getopt
Version	1.4.3-1
Changed-By	David Prévot <taffit@debian.org>
Architecture	source all
Distribution	unstable
Date	Sat, 31 Oct 2026 21:04:41 +0100

Changelog◂

php-console-getopt (1.4.3-1) unstable; urgency=medium
 .
   * Initial release (php-pear dependency, cf. #1152703)

.dsc◂

Section	php
Priority	optional
Component	main
Package-List	php-console-getopt deb php optional arch=all

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: Console_Getopt
Upstream-Contact: Andrei Zmievski <andrei@php.net>
Source: https://github.com/pear/Console_Getopt

Files: *
Copyright: 2001-2015, The PEAR developers
License: BSD-2-clause
 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions are met:
 .
  * Redistributions of source code must retain the above copyright
    notice, this list of conditions and the following disclaimer.
 .
  * Redistributions in binary form must reproduce the above copyright
    notice, this list of conditions and the following disclaimer in the
    documentation and/or other materials provided with the distribution.
 .
 THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
 AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE
 FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
 DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
 SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
 CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
 OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

DFSG Assistant LLM REVIEW 0 blocker, 1 important, 1 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 1 hour ago.

Report◂

DFSG NEW review for php-console-getopt version 1.4.3-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: No
Issues: 0 blocker, 1 important, 1 minor
debian/watch: version 5
debian/copyright: machine-readable
Scan before the review: nothing found

Licensing

Every upstream file is BSD-2-Clause by The PEAR developers; LICENSE, the source headers, composer.json and the current package.xml agree, and debian/copyright reproduces the full licence text and names the holder. No non-free or unlicensed file exists. The only gap is that debian/copyright has no stanza of its own for the Debian packaging, which the Files: * catch-all wrongly attributes to the upstream developers.

Packaging

The packaging follows the pkg-php-pear pattern cleanly (compat 14, dh sequencer, static substvars injected before dh_computeautosubstvars, generated files documented in README.source, autopkgtest present, current Standards-Version). But the binary package depends only on php-common, while Console/Getopt.php unconditionally requires PEAR.php and calls PEAR::raiseError: installed on its own it cannot even load the class. That missing php-pear dependency is what a sponsor would require fixed.

Issues

important packaging 1. php-console-getopt does not depend on php-pear although Console/Getopt.php requires PEAR.php at load time ◂

Files: debian/control, debian/php-console-getopt.substvars-static:4, Console/Getopt.php:21
Basis: checked, in the package or with a reference tool
Evidence: Console/Getopt.php:21: require_once 'PEAR.php'; (and PEAR::raiseError(...) at lines 199, 299, 340, 356); debian/control: Depends: ${misc:Depends}, ${phpcomposer:Debian-require}; debian/php-console-getopt.substvars-static:4: phpcomposer:Debian-require=php-common; apt-cache show php-common shows a 12 kB metapackage whose only Depends is psmisc, whereas apt-cache show php-pear lists "the PEAR base class" among its contents.
Problem: The only runtime relationship is php-common, which ships no PHP classes. A system with just this package's declared dependencies cannot load Console_Getopt at all: the autoloader includes Console/Getopt/Getopt.php, whose first statement is a require_once 'PEAR.php', which is a fatal error when php-pear (the package providing PEAR.php) is absent. Other Debian PEAR modules that use PEAR.php, e.g. php-console-commandline, depend on php-pear for exactly this reason.
Fix: Add php-pear to the binary package's Depends (versioned if the 1:1.10.18+t split is a prerequisite), e.g. Depends: ${misc:Depends}, ${phpcomposer:Debian-require}, php-pear in debian/control.

minor licensing 2. debian/copyright has no Files: debian/* stanza, so the Debian packaging is attributed to The PEAR developers ◂

Files: debian/copyright:6-8
Basis: checked, in the package or with a reference tool
Evidence: The file has exactly one stanza: Files: * / Copyright: 2001-2015, The PEAR developers / License: BSD-2-clause; debian/rules, debian/control, debian/autoload.php.tpl and the rest are written by David Prévot and the Debian PHP PEAR Maintainers (debian/changelog, debian/control).
Problem: Policy 12.5 requires the copyright and licence information of the whole package in debian/copyright; DEP-5 stanza 6.9 makes Files: * the catch-all, so as written the Debian-authored files are stated to be copyrighted 2001-2015 by The PEAR developers under BSD-2-Clause, which is not their provenance or licence.
Fix: Add a later stanza Files: debian/* with Copyright: 2026, David Prévot <taffit@debian.org> (and the Debian PHP PEAR Maintainers, as appropriate) and the licence the packaging is under, plus its short-name License stanza.

Verified ◂

Full tree read (10 upstream files plus debian/): Console/Getopt.php, LICENSE, README.rst, composer.json, package.xml, .travis.yml, .gitignore and the four tests/*.phpt. All are BSD-2-Clause held by The PEAR developers, matching the Files: * stanza and its reproduced licence text; the .phpt tests carry no separate notice and are test data.
The "PHP License" strings in package.xml (lines 156 onwards) are changelog notes describing upstream releases 1.3.0 and older, not the licence of any shipped file; the current package.xml, composer.json and source headers all say BSD-2-Clause.
Prescan finding accounted for: it listed no licence-problem files and reported every copyright holder it found as named in debian/copyright, which the manual read of the tree confirms.
debian/autoload.php, debian/console_getopt.reg and debian/upstream/changelog are generated; their inputs (debian/autoload.php.tpl, package.xml) are in the package and their regeneration is documented in debian/README.source, so the preferred form is present.
Packaging: debhelper compat 14 with the dh sequencer; the execute_before_dh_computeautosubstvars hook injecting the static substvars is valid and timely at compat 14 (dh_computeautosubstvars runs immediately before dh_gencontrol; checked with the debhelper tool and the dh_computeautosubstvars(1) page). override_dh_auto_test needs no nocheck check at compat 14; Build-Depends php-pear/phpunit are correctly marked <!nocheck> and both packages exist in the archive. debian/clean removes the build-time Console/Getopt/ copy.
Patch review: one applied DEP-3 patch with From/Date/Subject and a description, changing strlen($opt_arg) to strlen($opt_arg ?? '') to avoid the PHP 8.1 null deprecation; it matches the .pc copy. debian/source/format 3.0 (quilt), debian/watch, gbp.conf, README.source and upstream/metadata are consistent and present.
debian/tests/control runs phpunit tests with php-pear, phpunit and @ in Depends; Standards-Version 4.7.4 is current for Debian Policy 4.7.x; changelog is a sane initial unstable release; Vcs-* point at the salsa php-team/pear repository.
uscan found the packaged version as the newest upstream release (upstream 1.4.3, packaged 1.4.3).

Not confirmed ◂

Breaks/Replaces name php-pear (<< 1:1.10.18+t), but the archive lists only php-pear 1:1.10.18+submodules+notgz-1, which is below that threshold. Until a php-pear 1:1.10.18+t exists (presumably in NEW), installing php-console-getopt forces removal of the currently shipped php-pear. Could not check the NEW queue.
The package was not built and its tests were not run (build/test results were assumed to succeed).

Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader was emailed about the review 1 hour ago.

Back to Dashboard | View all reviews for this package