php-decimal 1.5.3-2
Package Information
| Description | Arbitrary precision floating-point decimal for PHP Adds support for correctly-rounded arbitrary precision decimal floating-point arithmetic in PHP. This is empty package that depends on default PHP version. |
|---|---|
| Maintainer | Debian PHP PECL Maintainers <team+php-pecl@tracker.debian.org> |
| Changed By | Ondřej Surý <ondrej@debian.org> |
| Sponsor | ondrej@debian.org |
| Distribution | experimental |
| Architecture | any all |
| VCS | git: https://salsa.debian.org/php-team/pecl/php-decimal.git (browse) |
| Popcon Installs | 17 |
| Binary NEW | Yes (new binary packages of a source already in sid) |
| Tracker | https://tracker.debian.org/pkg/php-decimal |
| Uploaded | 2 hours ago |
New Package Report
.changes
| Version | 1.5.3-2 |
|---|---|
| Changed-By | Ondřej Surý <ondrej@debian.org> |
| Architecture | source all amd64 |
| Distribution | experimental |
| Date | Sat, 21 Nov 2026 10:04:19 +0100 |
| Source | php-decimal |
Changelog
php-decimal (1.5.3-2) experimental; urgency=medium . * Add patch to fix FTBFS with PHP 8.6 * Build-Depend on php-all-dev (>= 2:102~) for PHP 8.6 * Bump Build-Depends to dh-php >= 5.23~
.dsc
| Section | php |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | php-decimal deb php optional arch=all php-decimal-all-dev deb php optional arch=all php8.6-decimal deb php optional arch=any |
debian/copyright
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: decimal Upstream-Contact: Rudi Theunissen <rtheunissen@php.net> Source: http://pecl.php.net/package/decimal Files: * Copyright: 2018 Rudi Theunissen License: Expat Files: debian/* Copyright: 2015 Ondřej Surý <ondrej@debian.org> License: Expat License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 1 important, 4 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 1 hour ago.
Proposes a replacement debian/watch:
debian/watch in version 5 format
Proposes a replacement debian/copyright:
debian/copyright Format field
Report
DFSG NEW review for php-decimal version 1.5.3-2
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 1 important, 4 minor
- debian/watch: old format (version 3)
- debian/copyright: machine-readable, without the current Format URL
- Scan before the review: nothing found
Licensing
Every file in the tree is MIT/Expat. decimal-1.5.3/LICENSE, php_decimal.c and php_decimal.h carry Copyright (c) 2018 Rudi Theunissen; config.m4, config.w32, README.md, CHANGELOG.md, the top-level package.xml and all .phpt tests carry no separate notice. Files: * (Rudi Theunissen, Expat) plus the later Files: debian/* (Ondřej Surý, Expat) cover the whole tree, the Expat text is reproduced in full, and there is no non-free wording, no vendored third-party code and no file without a licence. The prescan found no holder that debian/copyright omits, and my own sweep agreed.
Packaging
The package follows the PHP team's dh-php/pkg-pecl.mk pattern: patches are small and applied, the generated three-way binary split matches what the archive already ships in 1.5.3-1, and the changelog and experimental target are consistent with php-all-dev 2:102~ existing only in experimental. Every Build-Depends resolves in the archive. What remains are three minor clean-ups: an old Standards-Version, a stale blanket lintian override for a licence tag nothing triggers, and test failures being deliberately prevented from failing the build.
Issues
important licensing 1. debian/copyright does not declare the current copyright-format 1.0 URL ◂
- Files:
debian/copyright:1 - Basis: found by the review tooling's own checks
- Evidence:
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ - Problem: The first field must be exactly
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/(copyright-format 1.0, "Format" field). Anything else, including thehttp://form and the URLs of the drafts that preceded 1.0, does not declare the file to be in the current format, and a file written to a draft may also use field names and licence short names that 1.0 changed. - Fix: Replace the line as shown under Proposed changes, then check the rest of the file against copyright-format 1.0 (for example
Upstream-Name,Upstream-ContactandSourcein the header, notNameorMaintainer).
minor packaging 2. Standards-Version 4.5.1 is older than the reviewing system's Policy 4.7.4.1 ◂
- Files:
debian/control:10,debian/control.in:10 - Basis: checked, in the package or with a reference tool
- Evidence:
Standards-Version: 4.5.1, against Debian Policy 4.7.4.1 (thepolicytool's version). - Problem: Policy 5.6.11 says an old Standards-Version is not itself a bug, but it means the packaging has not been checked against the Policy changes listed in A10 since 4.5.1, and the value is what reviewers and lintian use to judge the package.
- Fix: Read A10 for 4.5.2 through 4.7.4.1, apply anything that concerns the package, and set
Standards-Version: 4.7.4in bothdebian/controland thecontrol.intemplate it is generated from.
minor packaging 3. debian/source.lintian-overrides silences license-problem-php-license for a source tree that contains no PHP-licensed file ◂
- Files:
debian/source.lintian-overrides:1-2 - Basis: checked, in the package or with a reference tool
- Evidence:
php-decimal source: license-problem-php-license *under the comment# Override invalid PHP license problem for PHP extensions coming from PECL.PHP.NET. - Problem: A grep of the whole source tree finds no PHP License text (
version 3.01,PHP license, Zend Technologies): every file is MIT, asdebian/copyrightsays. The override is therefore copied boilerplate, and its trailing*would also hide a real occurrence of the tag if a future upstream version ever carried PHP-licensed code, which is exactly the kind of licence problem a source package should not suppress. - Fix: Delete
debian/source.lintian-overrides(and do not re-add the override unless a file actually carries the PHP License).
minor packaging 4. debian/rules sets REPORT_EXIT_STATUS=0, so upstream's .phpt test suite can never fail the build ◂
- Files:
debian/rules:2 - Basis: checked, in the package or with a reference tool
- Evidence:
export REPORT_EXIT_STATUS:=0, and the changelog for 1.4.0-2 records* Don't fail on failed tests. - Problem: PHP's
run-tests.phpexits non-zero on failures only when REPORT_EXIT_STATUS is set to a non-zero value, so this export turns the only automated check of this 3000-line C extension into a no-op: a regressed build compiles and ships. There is nodebian/tests, so the 59.phpttests run nowhere else in the archive. - Fix: Drop the export so
make testgates the build; if some test is genuinely broken on a supported architecture, mark that test or use adebian/testsautopkgtest instead of disabling failure reporting for the whole suite.
minor packaging 5. debian/watch is in the old version 3 format ◂
- Files:
debian/watch - Basis: found by the review tooling's own checks
- Evidence:
version=3 - Problem: Version 5 is the current format of
debian/watch. - Fix: Convert it to version 5; a mechanical conversion is under Proposed changes.
Verified ◂
- Prescan: it reported no copyright holder missing from
debian/copyright; I independently grepped the tree forCopyright,(C),©,SPDX-License-Identifier,Licensed under,Permission is hereby granted,GNU,Apache,Mozilla,public domainandAll rights reserved, and found only the Rudi Theunissen MIT notices plus the packaging holder. - All 60 upstream files accounted for:
decimal-1.5.3/LICENSE,php_decimal.candphp_decimal.hcarry the MIT text withCopyright (c) 2018 Rudi Theunissen;config.m4,config.w32,README.md,CHANGELOG.md, top-levelpackage.xmland alltests/php7/**andtests/php8/**.phptfiles carry no separate notice or licence. There is no LICENSE/COPYING/NOTICE/AUTHORS in any subdirectory and no vendored third-party code: the extension links the systemlibmpdec. - No binary, built, generated, minified or PDF file: the tree is C source, m4/JavaScript-format build configuration,
.phpttests, markdown andpackage.xmlonly, and the prescan listed none for this section. debian/php-decimal.phpis not a stray file: per dh_php(1) FILES,debian/package.phpis dh_php's configuration file, and this one holds the single stanzamod debian/decimal.ini, registeringdebian/decimal.ini(the; priority=30 extension=decimal.sofile).dpkg-architecture, used by patch 0001'sMACHINE_INCLUDES, is provided by dpkg-dev, whichbuild-essential 12.12depends on, so it is present in a clean build chroot without a separate Build-Depends.- Build-Depends resolve:
dh-php 5.23in unstable (archive),php-all-dev 2:102~in experimental,libmpdec-dev 4.0.1-6, and debhelper 14.5 on the reviewing system supports compat 10. The experimental distribution in the changelog matches php-all-dev only being available there. - Both patches are applied in the tree as
seriessays:config.m4shows thedpkg-architecturechange andphp_decimal.cshows theINI_INTfallback pluszval_ptr_dtor_nogc;.pc/was ignored throughout. - At compat 10 debhelper does not skip override/hook targets on
nocheck(thedebhelpertool); nothing here puts test-only work outsidedh_auto_test, and no dependency is marked<!nocheck>. - No
debian/testsdirectory: the package has no autopkgtest. - uscan found the packaged version as the newest upstream release (upstream
1.5.3, packaged1.5.3).
Not confirmed ◂
/usr/share/dh-php/pkg-pecl.mkis not installed on the reviewing system (only dh_php(1) is available), so how it maps thedebian/php-decimal.phpconfiguration onto the versionedphp8.6-decimalpackage could not be read; the archive's 1.5.3-1php-decimalisInstalled-Size: 9and depends on php8.4-decimal, which suggests the mapping works as intended.- Whether either patch was forwarded upstream: both have DEP-3
From/Date/Subjectbut noForwardedfield, and no upstream bug reference. - The PHP 8.6 API facts the 0002 patch relies on (that
INI_INTandzval_dtorwere removed and thatzend_ini_long_literalremains) could not be checked against a PHP 8.6 source tree, which is not on the reviewing system. - Why the model asked for what a review has no use for. During this review it asked once for something outside the package and the reviewing system (another file of the sandbox, or a URL), or was given part of the review tooling's own configuration, and that was refused or withheld. A model does this when something it has read tells it to, so look in the package for text addressed to a reviewing program, and treat this report with suspicion. Refused:
grep: "xd://policy" is not a file of the package or of the reviewing system.
Proposed: debian/watch in version 5 format ◂
debian/watch is in an old format. This is the conversion made by uscan --update-watchfile, which has not been run against the upstream site: some defaults differ in version 5, so test it with uscan --report before use.
Version: 5
Source: https://pecl.php.net/package/decimal
Matching-Pattern: /get/decimal-(1\.[\d\.p?]*).tgz
Update-Script: uupdate
Proposed: debian/copyright Format field ◂
Replace line 1 of debian/copyright with:
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Uploader's response to the LLM review
Waiting for the uploader's response until , because the review found serious issues.