php-smbclient 1.1.2-5
Package Information
| Description | PHP wrapper for libsmbclient smbclient is a PHP extension that uses Samba's libsmbclient library to provide Samba related functions and 'smb' streams to PHP programs. This is empty package that depends on default PHP version. |
|---|---|
| Maintainer | Debian PHP PECL Maintainers <team+php-pecl@tracker.debian.org> |
| Changed By | Ondřej Surý <ondrej@debian.org> |
| Sponsor | ondrej@debian.org |
| Distribution | experimental |
| Architecture | any all |
| VCS | git: https://salsa.debian.org/php-team/pecl/php-smbclient.git (browse) |
| Popcon Installs | 401 |
| Binary NEW | Yes (new binary packages of a source already in sid) |
| Tracker | https://tracker.debian.org/pkg/php-smbclient |
| Uploaded | 3 hours ago |
New Package Report
.changes
| Architecture | source all amd64 |
|---|---|
| Distribution | experimental |
| Date | Sat, 21 Nov 2026 10:04:35 +0100 |
| Source | php-smbclient |
| Version | 1.1.2-5 |
| Changed-By | Ondřej Surý <ondrej@debian.org> |
Changelog
php-smbclient (1.1.2-5) experimental; urgency=medium . * Add upstream patches to fix FTBFS with PHP 8.6 * Build-Depend on php-all-dev (>= 2:102~) for PHP 8.6 * Bump Build-Depends to dh-php >= 5.23~
.dsc
| Component | main |
|---|---|
| Package-List | php-smbclient deb php optional arch=all php-smbclient-all-dev deb php optional arch=all php8.6-smbclient deb php optional arch=any |
| Section | php |
| Priority | optional |
debian/copyright
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: php-smbclient
Source: https://github.com/nikic/php-smbclient
Files: *
Copyright: 2015 Eduardo Bacchi Kienetz
2015 Remi Collet
License: BSD-2-clause
Files: debian/*
Copyright: 2013 Ondřej Surý <ondrej@debian.org>
License: Expat
License: BSD-2-clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
.
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in
the documentation and/or other materials provided with the
distribution.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY
WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
POSSIBILITY OF SUCH DAMAGE.
License: Expat
Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:
.
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
DFSG Assistant LLM REVIEW 1 blocker, 1 important, 3 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 2 hours ago.
Proposes a replacement debian/watch:
debian/watch in version 5 format
Proposes a replacement debian/copyright:
debian/copyright Format field
Report
DFSG NEW review for php-smbclient version 1.1.2-5
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: Yes
- Issues: 1 blocker, 1 important, 3 minor
- debian/watch: old format (version 3)
- debian/copyright: machine-readable, without the current Format URL
- Scan before the review: nothing found
Licensing
The licensing itself is DFSG-free: upstream is BSD-2-clause and debian/ is Expat, the two are compatible, and both licence texts are present in debian/copyright. But debian/copyright is inaccurate: the Files: * stanza omits two of the four BSD-2 copyright holders whose notices appear in the LICENSE and in every C source file that is compiled into the extension, and its Source field points at an unrelated GitHub repository instead of the upstream one named by the package's own README and PECL metadata.
Packaging
Packaging is the standard Debian PHP PECL template: dh-php-based rules, generated multi-version binary packages with correct Provides/Breaks/Replaces substvars, patches with DEP-3 headers, and build dependencies that exist in the archive (php-all-dev 2:102~ in experimental, matching the experimental upload). The only faults are a dated Standards-Version and the wrong Source URL in debian/copyright; no policy violation or broken upgrade was found.
Issues
blocker licensing 1. Files: * omits copyright holders Matthew Sachs and Alfred Klomp ◂
- Files:
debian/copyright:7-9,smbclient-1.1.2/LICENSE:1-4,smbclient-1.1.2/php_smbclient.h:6-9,smbclient-1.1.2/smb_streams.c:6-9,smbclient-1.1.2/smbclient.c:6-9 - Basis: checked, in the package or with a reference tool
- Evidence: LICENSE:1-4 and the headers of all three C sources:
Copyright (c) 2003, Matthew Sachs/2009 - 2014, Eduardo Bacchi Kienetz/2013 - 2015, Alfred Klomp/2015, Remi Collet; debian/copyright Files: * only saysCopyright: 2015 Eduardo Bacchi Kienetzand2015 Remi Collet. - Problem: The BSD-2-clause licence requires the copyright notice to be retained in source and binary redistributions. smbclient.c, smb_streams.c and php_smbclient.h are compiled into smbclient.so shipped by php8.6-smbclient, so all three conditions of Policy 2.3 hold: the notices of Matthew Sachs and Alfred Klomp must appear in /usr/share/doc/php8.6-smbclient/copyright. The years given for Eduardo Bacchi Kienetz (2015) are also wrong; they should be 2009-2014.
- Fix: Add Matthew Sachs (2003) and Alfred Klomp (2013-2015) to the Files: * Copyright field (or a dedicated stanza for LICENSE and the C sources), and correct Eduardo Bacchi Kienetz's years to 2009-2014.
important licensing 2. debian/copyright does not declare the current copyright-format 1.0 URL ◂
- Files:
debian/copyright:1 - Basis: found by the review tooling's own checks
- Evidence:
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ - Problem: The first field must be exactly
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/(copyright-format 1.0, "Format" field). Anything else, including thehttp://form and the URLs of the drafts that preceded 1.0, does not declare the file to be in the current format, and a file written to a draft may also use field names and licence short names that 1.0 changed. - Fix: Replace the line as shown under Proposed changes, then check the rest of the file against copyright-format 1.0 (for example
Upstream-Name,Upstream-ContactandSourcein the header, notNameorMaintainer).
minor licensing 3. Source field points to nikic/php-smbclient instead of the upstream repository ◂
- Files:
debian/copyright:3,smbclient-1.1.2/README.md:30-33,package.xml:4 - Basis: checked, in the package or with a reference tool
- Evidence: debian/copyright:
Source: https://github.com/nikic/php-smbclient; upstream README:git clone git://github.com/eduardok/libsmbclient-php.gitand release links togithub.com/eduardok/libsmbclient-php; package.xml<channel>pecl.php.net</channel>and controlHomepage: http://pecl.php.net/smbclient. - Problem: DEP-5 defines Source as the URL of the upstream source. The value names a repository that the package's own README and PECL metadata contradict, so the file points readers at the wrong project.
- Fix: Set Source to the upstream repository, e.g. https://github.com/eduardok/libsmbclient-php, or to https://pecl.php.net/package/smbclient.
minor packaging 4. Standards-Version 4.5.1 is older than the current 4.7.4.1 ◂
- Files:
debian/control:10,debian/control.in:10 - Basis: checked, in the package or with a reference tool
- Evidence:
Standards-Version: 4.5.1; the reviewing system's Policy is 4.7.4.1. - Problem: Policy 4.7.4.1 is current; a Standards-Version whose first two components differ (4.5 against 4.7) means the package has not been checked against the changes in those releases.
- Fix: Review the Policy changes since 4.5.1, bump Standards-Version to 4.7.4.1 in debian/control.in (and the generated debian/control), and record the change in debian/changelog.
minor packaging 5. debian/watch is in the old version 3 format ◂
- Files:
debian/watch - Basis: found by the review tooling's own checks
- Evidence:
version=3 - Problem: Version 5 is the current format of
debian/watch. - Fix: Convert it to version 5; a mechanical conversion is under Proposed changes.
Verified ◂
- Copyright scan: the one holder it flagged, Matthew Sachs, is reported as a blocker together with Alfred Klomp, who is named in the same LICENSE and in the headers of smbclient.c, smb_streams.c and php_smbclient.h at lines 6-9 and is also absent from debian/copyright.
- No other file in the tree carries a copyright or licence notice: the PHPUnit tests in smbclient-1.1.2/tests/ (including setup-share.sh), README.md, config.m4, phpunit.xml.dist, smbclient.stub.php and the two generated arginfo headers have none and are covered by the project-wide BSD-2 statement in LICENSE/README/package.xml.
- smbclient_arginfo.h and smbclient_legacy_arginfo.h are generated files (header says
This is a generated file, edit the .stub.php file instead); their generator input smbclient.stub.php is shipped, so they are not a missing-source DFSG problem. - The README's mention of the PHP License 2.02 is historical (
Before that, libsmbclient-php was licensed under ...); the current licence stated there, in LICENSE and in package.xml is BSD 2-clause. - readme/scanner check: the prescan listed no built binaries, archives, PDFs, minified code or non-free/DFSG-rejected wording anywhere in the tree, and none was found by grepping for licence terms.
- Licence compatibility: BSD-2-clause (upstream, including the two patches' context) and Expat (debian/) are compatible and both full texts are in debian/copyright; no embedded third-party library was found.
- All files under debian/ were read: control, control.in, compat (10), rules, changelog, gbp.conf, smbclient.ini, php-smbclient.php, source/format, both patches and series. debian/control is the dh-php-generated form of control.in (php-smbclient and php-smbclient-all-dev as arch:all metapackages, php8.6-smbclient as arch:any) and is consistent with it.
- Both patches carry From/Date/Subject headers; the tree shows them applied and the series order matches. debian/patches/0002 has From: Remi Collet, who is named in the copyright file.
- debhelper compat 10 is supported (debhelper 14.5 lists v11 as discouraged and v7 as deprecated, v10 is neither), and the relationship substvars named in debian/control are needed at compat 10.
- Build dependencies exist in the archive: php-all-dev 2:102~ (experimental madison, 2026-11-21), dh-php 5.23 (unstable), libsmbclient-dev 2:4.25.1+dfsg-1; the experimental distribution matches the PHP 8.6 dependency.
- No maintainer scripts, .maintscript files, install/links/docs files or debian/tests directory exist to review; dh-php generates the extension's maintainer script handling.
- uscan found upstream releases with
debian/watch; a newer upstream version is available (upstream1.2.0~dev, packaged1.1.2), which is not a fault of the package.
Not confirmed ◂
- dh-php is not installed on the reviewing system, so /usr/share/dh-php/pkg-pecl.mk and dh_php's control/ini generation could not be inspected; the packaging was judged on the generated control, and that pkg-pecl.mk exists in dh-php 5.23 and produces these packages is assumed.
- No network access was available to check whether https://github.com/nikic/php-smbclient exists or is a mirror; the Source finding rests on the package's own README and package.xml naming github.com/eduardok/libsmbclient-php and pecl.php.net.
Proposed: debian/watch in version 5 format ◂
debian/watch is in an old format. This is the conversion made by uscan --update-watchfile, which has not been run against the upstream site: some defaults differ in version 5, so test it with uscan --report before use.
Version: 5
Source: https://pecl.php.net/package/smbclient
Matching-Pattern: .*/smbclient-(\d.*)\.(?:tgz|tbz2|txz|tar\.(?:gz|bz2|xz))
Uversionmangle: s/(\d)RC(\d*)$/$1rc$2/;s/(\d)[_\.\-\+]?((RC|rc|pre|dev|beta|alpha|b|a)[\-\.]?\d*)$/$1~$2/
Proposed: debian/copyright Format field ◂
Replace line 1 of debian/copyright with:
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Uploader's response to the LLM review
Waiting for the uploader's response until , because the review found serious issues.