DFSG NEW Queue

DFSG, Licensing & New Packages Team

php-uploadprogress 2.0.2++-6

Package Information

Descriptionfile upload progress tracking extension for PHP

An PHP extension to track progress of a file upload.

This is empty package that depends on default PHP version.

MaintainerDebian PHP PECL Maintainers <team+php-pecl@tracker.debian.org>
Changed ByOndřej Surý <ondrej@debian.org>
Sponsorondrej@debian.org
Distributionexperimental
Architectureany all
VCSgit: https://salsa.debian.org/php-team/pecl/php-uploadprogress.git (browse)
Popcon Installs98
Binary NEWYes (new binary packages of a source already in sid)
Trackerhttps://tracker.debian.org/pkg/php-uploadprogress
Uploaded3 hours ago

New Package Report

.changes◂
Architecturesource all amd64
Distributionexperimental
DateSat, 21 Nov 2026 10:04:37 +0100
Sourcephp-uploadprogress
Version2.0.2++-6
Changed-ByOndřej Surý <ondrej@debian.org>
Changelog◂
php-uploadprogress (2.0.2++-6) experimental; urgency=medium
 .
   * Add patch to fix FTBFS with PHP 8.6
   * Build-Depend on php-all-dev (>= 2:102~) for PHP 8.6
   * Bump Build-Depends to dh-php >= 5.23~
.dsc◂
Sectionphp
Priorityoptional
Componentmain
Package-Listphp-uploadprogress deb php optional arch=all
php-uploadprogress-all-dev deb php optional arch=all
php8.6-uploadprogress deb php optional arch=any
debian/copyright◂
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: uploadprogress
Source: http://pecl.php.net/package/uploadprogress

Files: *
Copyright: 2015 Christian Stocker
	   2015 Ben Ramsey
License: PHP-3.01

Files: debian/*
Copyright: 2015 Ondřej Surý <ondrej@debian.org>
License: Expat

License: PHP-3.01
 --------------------------------------------------------------------
                   The PHP License, version 3.01
 Copyright (c) 1999 - 2011 The PHP Group. All rights reserved.
 --------------------------------------------------------------------
 .
 Redistribution and use in source and binary forms, with or without
 modification, is permitted provided that the following conditions
 are met:
 .
   1. Redistributions of source code must retain the above copyright
      notice, this list of conditions and the following disclaimer.
 .
   2. Redistributions in binary form must reproduce the above copyright
      notice, this list of conditions and the following disclaimer in
      the documentation and/or other materials provided with the
      distribution.
 .
   3. The name "PHP" must not be used to endorse or promote products
      derived from this software without prior written permission. For
      written permission, please contact group@php.net.
 .
   4. Products derived from this software may not be called "PHP", nor
      may "PHP" appear in their name, without prior written permission
      from group@php.net.  You may indicate that your software works in
      conjunction with PHP by saying "Foo for PHP" instead of calling
      it "PHP Foo" or "phpfoo"
 .
   5. The PHP Group may publish revised and/or new versions of the
      license from time to time. Each version will be given a
      distinguishing version number.
      Once covered code has been published under a particular version
      of the license, you may always continue to use it under the terms
      of that version. You may also choose to use such covered code
      under the terms of any subsequent version of the license
      published by the PHP Group. No one other than the PHP Group has
      the right to modify the terms applicable to covered code created
      under this License.
 .
   6. Redistributions of any form whatsoever must retain the following
      acknowledgment:
      "This product includes PHP software, freely available from
      <http://www.php.net/software/>".
 .
 THIS SOFTWARE IS PROVIDED BY THE PHP DEVELOPMENT TEAM ``AS IS'' AND
 ANY EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
 THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
 PARTICULAR PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE PHP
 DEVELOPMENT TEAM OR ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
 INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
 (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
 SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
 HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
 STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
 ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
 OF THE POSSIBILITY OF SUCH DAMAGE.

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the
 "Software"), to deal in the Software without restriction, including
 without limitation the rights to use, copy, modify, merge, publish,
 distribute, sublicense, and/or sell copies of the Software, and to
 permit persons to whom the Software is furnished to do so, subject to
 the following conditions:
 .
 The above copyright notice and this permission notice shall be
 included in all copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
 BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
 ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

DFSG Assistant LLM REVIEW 1 blocker, 1 important, 5 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 2 hours ago.

Proposes a replacement debian/watch: debian/watch in version 5 format

Proposes a replacement debian/copyright: debian/copyright Format field

Report◂

DFSG NEW review for php-uploadprogress version 2.0.2++-6

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: No
  • Packaging is of good quality: Yes
  • Issues: 1 blocker, 1 important, 5 minor
  • debian/watch: old format (version 3)
  • debian/copyright: machine-readable, without the current Format URL
  • Scan before the review: nothing found

Licensing

PHP-3.01 is a DFSG-free licence, and debian/copyright carries its full text (and the full Expat text for debian/*); every one of the 49 upstream files is covered by the two stanzas, and no other holder, licence or restriction appears in the tree. The file is not accurate, though: the Copyright field of Files: * names Christian Stocker and Ben Ramsey, while every source file names The PHP Group as the copyright holder.

Packaging

The package follows the Debian PHP team's dh-php PECL pattern: 3.0 (quilt) source format, a single documented one-hunk DEP-3 patch, all build and runtime dependencies present in the archive, a coherent changelog and sane Vcs-* fields. The remaining problems are minor: a missing comma between two relationship substvars in Depends, a Build-Depends minimum for debhelper far below the declared compat level, and a Standards-Version two minor releases old.

Issues

blocker licensing 1. Files: * does not name The PHP Group, the copyright holder stated in uploadprogress.c and php_uploadprogress.h ◂
  • Files: debian/copyright:5-8 (Files: * stanza), debian/copyright:17, uploadprogress-2.0.2/uploadprogress.c:5, uploadprogress-2.0.2/php_uploadprogress.h:5, uploadprogress-2.0.2/LICENSE:3
  • Basis: checked, in the package or with a reference tool
  • Evidence: Files: * gives Copyright: 2015 Christian Stocker / 2015 Ben Ramsey, but uploadprogress.c and php_uploadprogress.h say | Copyright (c) The PHP Group, and LICENSE:3 says Copyright (c) 1999 - 2021 The PHP Group. All rights reserved. The only occurrence of the holder in debian/copyright is line 17, Copyright (c) 1999 - 2011 The PHP Group. All rights reserved., inside the copied PHP-3.01 licence text.
  • Problem: Policy 2.3 requires the copyright notices of files compiled into a binary package to be reproduced in debian/copyright. uploadprogress.c and php_uploadprogress.h are compiled into php8.6-uploadprogress, and their notice names The PHP Group, which the Copyright field does not. The 1999-2011 line at line 17 is the PHP Group's boilerplate in the licence text, not the notice of these files (2015 headers say simply (c) The PHP Group), so the Copyright field is stale and names the wrong entity.
  • Fix: Record The PHP Group as the holder in the Files: * stanza, e.g. Copyright: The PHP Group (with 1999-2021 The PHP Group for the LICENSE file), keeping Stocker and Ramsey as authors if desired.
important licensing 2. debian/copyright does not declare the current copyright-format 1.0 URL ◂
  • Files: debian/copyright:1
  • Basis: found by the review tooling's own checks
  • Evidence: Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
  • Problem: The first field must be exactly Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ (copyright-format 1.0, "Format" field). Anything else, including the http:// form and the URLs of the drafts that preceded 1.0, does not declare the file to be in the current format, and a file written to a draft may also use field names and licence short names that 1.0 changed.
  • Fix: Replace the line as shown under Proposed changes, then check the rest of the file against copyright-format 1.0 (for example Upstream-Name, Upstream-Contact and Source in the header, not Name or Maintainer).
minor packaging 3. Depends in all three binary stanzas lacks a comma between ${pecl:Depends} and ${shlibs:Depends} ◂
  • Files: debian/control:19-20, debian/control:39-40, debian/control:59-60, debian/control.in:19-20
  • Basis: checked, in the package or with a reference tool
  • Evidence: ${pecl:Depends} is followed on the next line by ${shlibs:Depends}, with no comma after the first substvar.
  • Problem: Policy 7.1 requires package names in a relationship field to be separated by commas; after substvar expansion the two values would run together into one invalid term. It has not broken a build only because the two are never both non-empty: in the published 2.0.2++-4 binaries ${pecl:Depends} is empty for php8.4-uploadprogress (Depends: ucf, php8.4-common, libc6 (>= 2.4), phpapi-20240924) and ${shlibs:Depends} is empty for the architecture-independent meta packages.
  • Fix: Add the missing comma after ${pecl:Depends} in the three stanzas of debian/control and in debian/control.in.
minor packaging 4. Build-Depends allows a debhelper older than the declared compat level 10 ◂
  • Files: debian/control:6, debian/compat:1
  • Basis: inferred from what was read, not seen directly
  • Evidence: Build-Depends: debhelper (>= 2.0~), while debian/compat contains 10.
  • Problem: No debhelper 2.x implements compatibility level 10; the versioned build dependency does not express the debhelper release the package actually needs, so a build environment that satisfies the declared dependency cannot honour debian/compat.
  • Fix: Use debhelper-compat (= 13) in Build-Depends and delete debian/compat (or at least require the debhelper release that introduced compat 10).
minor packaging 5. Standards-Version 4.5.1 is behind current Policy 4.7.4.1 ◂
  • Files: debian/control:9
  • Basis: checked, in the package or with a reference tool
  • Evidence: Standards-Version: 4.5.1; the reviewing system's Debian Policy is 4.7.4.1.
  • Problem: The declared Policy version is two minor releases old (Policy 4.5 against 4.7).
  • Fix: Bump Standards-Version to 4.7.4 after checking its upgrading checklist.
minor packaging 6. debian/watch is in the old version 3 format ◂
  • Files: debian/watch
  • Basis: found by the review tooling's own checks
  • Evidence: version=3
  • Problem: Version 5 is the current format of debian/watch.
  • Fix: Convert it to version 5; a mechanical conversion is under Proposed changes.
minor packaging 7. uscan finds only upstream versions older than the packaged one ◂
  • Files: debian/watch
  • Basis: found by the review tooling's own checks
  • Evidence: upstream 2.0.2, packaged 2.0.2++
  • Problem: The newest version uscan finds with debian/watch is older than the version in debian/changelog, so the watch file does not find the packaged release: it may look in the wrong place, or the versions may need mangling to compare.
  • Fix: Check where debian/watch looks and how it mangles versions.
Verified ◂
  • Read all 49 files outside debian/ (C sources, headers, stub, generated arginfo, config files, 8 test scripts, 10 plain-text mock fixtures, examples, package.xml): every file that carries a notice has the PHP Group PHP-3.01 header; no other holder, licence or non-free wording appears.
  • The two arginfo headers state they are generated, and their generator input uploadprogress-2.0.2/uploadprogress.stub.php is in the tree, so they do not lack their preferred form.
  • debian/copyright contains the complete PHP-3.01 text (matching uploadprogress-2.0.2/LICENSE apart from the copyright year range 1999-2011 vs 1999-2021) and the complete Expat text; both short names match the texts.
  • Patch 0001 creates no files (8 added lines in uploadprogress.c) and has DEP-3 From/Date/Subject headers; the added INI_STR/INI_BOOL fallbacks sit inside the PHP >= 8.0 branch where they are used.
  • The examples are documentation only: debian/php-uploadprogress.examples installs only */examples/*.php unchanged, with their notices.
  • The license-problem-php-license source override is consistent with Debian shipping php8.x under PHP-3.01 in main; PHP-3.01 has no non-commercial or field-of-use term.
  • Build-Depends targets exist: dh-php 5.23 and php-all-dev 2:102~ are in the archive (experimental/unstable), and ucf, php-common and libapache2-mod-php are known packages.
  • The published 2.0.2++-4 binaries show the dh-php-generated relationship fields are valid (php8.4-uploadprogress: Depends: ucf, php8.4-common, libc6 (>= 2.4), phpapi-20240924), so the substvar comma issue has not caused a build failure so far.
  • uploadprogress.c and php_uploadprogress.h credit Doru Petrescu as a derivation source but head the file as PHP-3.01 by The PHP Group; no separate licence or copyright notice for that code is present in the tree.
Not confirmed ◂
  • /usr/share/dh-php/pkg-pecl.mk is not installed on the reviewing system, so I could not read how dh-php 5.23 generates debian/control or whether compat 10 is sufficient for it.
  • The PHP 8.6 INI macro replacement in the patch could not be compiled or checked against PHP 8.6 headers, which are not on the system.
Proposed: debian/watch in version 5 format ◂

debian/watch is in an old format. This is the conversion made by uscan --update-watchfile, which has not been run against the upstream site: some defaults differ in version 5, so test it with uscan --report before use.

Version: 5

Source: https://pecl.php.net/package/uploadprogress
Matching-Pattern: /get/uploadprogress-([\d\.p?]*).tgz
Update-Script: uupdate
Proposed: debian/copyright Format field ◂

Replace line 1 of debian/copyright with:

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

Uploader's response to the LLM review

Waiting for the uploader's response until , because the review found serious issues.

Back to Dashboard | View all reviews for this package