php-xml-util 1.4.5-2
Package Information
| Description | ${phppear:summary} ${phppear:description} |
|---|---|
| Maintainer | Debian PHP PEAR Maintainers <pkg-php-pear@lists.alioth.debian.org> |
| Changed By | David Prévot <taffit@debian.org> |
| Sponsor | taffit@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/php-team/pear/php-xml-util.git (browse) |
| Tracker | https://tracker.debian.org/pkg/php-xml-util |
| Uploaded | 3 days ago |
| Supersedes | 1.4.5-1 |
New Package Report
.changes
| Architecture | source all |
|---|---|
| Distribution | unstable |
| Date | Tue, 03 Nov 2026 01:00:07 +0100 |
| Source | php-xml-util |
| Version | 1.4.5-2 |
| Changed-By | David Prévot <taffit@debian.org> |
Changelog
php-xml-util (1.4.5-2) unstable; urgency=medium . * Update debian/copyright
.dsc
| Section | php |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | php-xml-util deb php optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: XML_Util
Upstream-Contact: Chuck Burgess <ashnazg@php.net>
Source: https://github.com/pear/Archive_Tar
Files: *
Copyright: 2003-2008 Stephan Schmidt <schst@php.net>
License: BSD-3-clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
.
* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
.
* Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
.
* The name of the author may not be used to endorse or promote products
derived from this software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
DFSG Assistant LLM REVIEW 0 blocker, 1 important, 1 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 3 days ago.
Report
DFSG NEW review for php-xml-util version 1.4.5-2
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: Yes
- Issues: 0 blocker, 1 important, 1 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
The code itself is DFSG-free: XML/Util.php, examples/*.php and package.xml carry the three-clause BSD licence (composer.json agrees, BSD-3-Clause), and the full notice is reproduced in debian/copyright with the correct short name. But debian/copyright does not describe every file accurately: it has no stanza for the Debian packaging, so its only stanza (Files: *, Copyright 2003-2008 Stephan Schmidt) claims the upstream holder's copyright over debian/rules, debian/control and the Debian-authored patches, and its Source: field points at a different upstream package (Archive_Tar). Both need fixing before the file can be called accurate.
Packaging
Packaging follows the pkg-php-pear practice: debhelper compat 14 with a minimal dh invocation, debhelper and phpunit gated with <!nocheck> (so the override_dh_auto_test wrapper is correctly skipped on nocheck), pre-generated pkg-php-tools substvars appended before dh_computeautosubstvars, an autopkgtest that runs the upstream suite against the installed autoloader, salsa Vcs-* fields and Standards-Version 4.7.4. The Replaces/Breaks on php-pear correctly covers the archive version that still provides php-xml-util. No packaging fault found.
Issues
important licensing 1. debian/copyright has no Files: debian/* stanza and names Stephan Schmidt as copyright holder of the Debian packaging ◂
- Files:
debian/copyright:6-8 (the only Files stanza); debian/rules, debian/control, debian/patches/0004-*, debian/patches/0005-* - Basis: checked, in the package or with a reference tool
- Evidence: The file has exactly one stanza:
Files: */Copyright: 2003-2008 Stephan Schmidt <schst@php.net>/License: BSD-3-clause.debian/changelogand the From:/Date: lines of patches 0004 and 0005 show the Debian packaging and those two patches are written by David Prévot taffit@debian.org (2026). - Problem: A DEP-5 copyright file must cover the whole source tree, and since
Files: *is anchored at the top and*matches/, it also matches everything under debian/, attributing the packaging, the Debian-specific patches and the generated debian/autoload.php and debian/xml_util.reg to Stephan Schmidt. The copyright holder and licence of the Debian packaging are therefore stated wrongly (and the packaging licence is not stated at all). - Fix: Add a later stanza, e.g.
Files: debian/*/Copyright: 2026 David Prévot <taffit@debian.org>/License: BSD-3-clause(or whichever licence the packaging is meant to carry), so it overridesFiles: *for the debian/ directory.
minor licensing 2. debian/copyright Source field points to the Archive_Tar upstream, not XML_Util ◂
- Files:
debian/copyright:4 - Basis: checked, in the package or with a reference tool
- Evidence:
Source: https://github.com/pear/Archive_Tar, whiledebian/controlhasHomepage: https://github.com/pear/XML_UtilandUpstream-Name: XML_Util. - Problem: The Source field names the wrong upstream project, so the copyright file misdirects anyone looking for where the source came from; it is a leftover copy-paste from another pkg-php-pear package.
- Fix: Change the field to
Source: https://github.com/pear/XML_Util.
Verified ◂
- Licence evidence collected over the whole tree: XML/Util.php:11-12 and 42 (
Copyright (c) 2003-2008 Stephan Schmidt, three-clause BSD text), examples/example.php:14-15 and examples/example2.php:14-15 (same header), package.xml:34 (<license uri="http://opensource.org/licenses/bsd-license">BSD License</license>), composer.json ("license": "BSD-3-Clause"). The tests/*.php files carry no per-file notice and are covered by Files: *. - The 17
PHP License/ php.net/license strings in package.xml and debian/xml_util.reg are inside<changelog><release>entries for versions 0.1-1.1.4 (the relicensing is recorded at package.xml:389,Changed license to New BSD License); they are historical release metadata, not a licence claim on any file in the tree. - No file in the tree carries a restriction, non-commercial or no-modification term, and no third-party vendored code or separate LICENSE/COPYING/NOTICE file exists; the only holders found are Stephan Schmidt (source and examples), plus Chuck Burgess and Davey Shafik listed as PEAR leads/helper in package.xml/composer.json, which are authorship credits, not copyright notices.
- debian/autoload.php and debian/autoload.php.tpl are phpab/phpabtpl output with their generator input composer.json and the template committed beside them (regenerated by the
updatetarget in debian/rules); debian/xml_util.reg is the PEAR registry generated from package.xml by the same target. Their sources are therefore in the package. - Prescan author check found only Stephan Schmidt, who is named in debian/copyright; no holder is missing.
- debian/rules: compat 14, plain
dh $@; phpunit and php-pear are <!nocheck>, and dh skips override_dh_auto_test under nocheck (checked with the debhelper tool/sequence), so the override needs no nocheck test itself. dh_computeautosubstvars is part of the compat-14 sequence and the execute_before_ hook is valid. - debian/tests/control: Test-Command runs phpunit with the installed /usr/share/php/XML/Util/autoload.php against the source-tree tests; Depends on php-pear, phpunit and @. The PHPUnit-13 test fixes in patches 0004/0005 match the phpunit 13.4.5 in unstable.
- debian/control: Standards-Version 4.7.4 matches current Policy 4.7.4.1; Multi-Arch: foreign on an Architecture: all pure-PHP package; Replaces/Breaks on php-pear (<< 1:1.10.18+t) covers the archive's php-pear 1:1.10.18+submodules+notgz-1, which still Provides php-xml-util.
- The substvars appended from debian/php-xml-util.substvars-static leave ${phpcomposer:Debian-recommend} and similar undefined; dpkg-gencontrol substitutes an empty value with a warning (deb-substvars(5):
If a variable is referred to but not defined it generates a warning and an empty value is assumed), so the built control fields are empty rather than literal. - Patches 0001-0003 are upstream commits with
Origin: upstreamheaders, still needed because they postdate 1.4.5; 0004-0005 are DEP-3 formatted Debian test fixes for PHPUnit 13. - uscan found the packaged version as the newest upstream release (upstream
1.4.5, packaged1.4.5).
Not confirmed ◂
- Whether php-pear 1:1.10.18+t (the version named in the Replaces/Breaks relations) will be the upload that drops the bundled XML_Util; not in the archive/new-queue lists yet, but the current 1:1.10.18+submodules+notgz-1 is correctly below that version.
debian/watchlooks atgithub.com/pear/xml_util, but theSourcefield ofdebian/copyrightnamesgithub.com/pear/archive_tar. Whether these are the same upstream was not checked.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader hasn't responded yet, and is welcome to at any time. The 24-hour hold has ended, so the package is now open for review as usual.