DFSG NEW Queue

DFSG, Licensing & New Packages Team

php-zstd 0.18.0-1

Package Information

DescriptionZstandard extension for PHP

PHP extension for compression and decompression with Zstandard library.

This is empty package that depends on default PHP version.

MaintainerDebian PHP PECL Maintainers <team+php-pecl@tracker.debian.org>
Changed ByOndřej Surý <ondrej@debian.org>
Sponsorondrej@debian.org
Distributionexperimental
Architectureany all
VCSgit: https://salsa.debian.org/php-team/pecl/php-zstd.git (browse)
Popcon Installs61
Binary NEWYes (new binary packages of a source already in sid)
Trackerhttps://tracker.debian.org/pkg/php-zstd
Uploaded3 hours ago

New Package Report

.changes◂
Version0.18.0-1
Changed-ByOndřej Surý <ondrej@debian.org>
Architecturesource all amd64
Distributionexperimental
DateSat, 21 Nov 2026 10:04:41 +0100
Sourcephp-zstd
Changelog◂
php-zstd (0.18.0-1) experimental; urgency=medium
 .
   * New upstream version 0.18.0
   * Build-Depend on php-all-dev (>= 2:102~) for PHP 8.6
   * Add patch to relax test expectation for PHP 8.6 (Courtesy of Remi Collet)
   * Bump Build-Depends to dh-php >= 5.23~
.dsc◂
Package-Listphp-zstd deb php optional arch=all
php-zstd-all-dev deb php optional arch=all
php8.6-zstd deb php optional arch=any
Sectionphp
Priorityoptional
Componentmain
debian/copyright◂
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: zstd
Upstream-Contact: Tatsuya KAMIJO <kjdev@php.net>
Source: http://pecl.php.net/package/zstd

Files: *
Copyright: 2015 Tatsuya KAMIJO
License: Expat

Files: debian/*
Copyright: 2015 Ondřej Surý <ondrej@debian.org>
License: Expat

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the
 "Software"), to deal in the Software without restriction, including
 without limitation the rights to use, copy, modify, merge, publish,
 distribute, sublicense, and/or sell copies of the Software, and to
 permit persons to whom the Software is furnished to do so, subject to
 the following conditions:
 .
 The above copyright notice and this permission notice shall be
 included in all copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
 BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
 ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

DFSG Assistant LLM REVIEW

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 2 hours ago.

Proposes a replacement debian/watch: debian/watch in version 5 format

Proposes a replacement debian/copyright: debian/copyright Format field

Report◂

DFSG NEW review for php-zstd version 0.18.0-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: No
  • Packaging is of good quality: Yes
  • Issues: 1 blocker, 1 important, 3 minor; 1 more from the model's own knowledge, under Not confirmed
  • debian/watch: old format (version 3)
  • debian/copyright: machine-readable, without the current Format URL
  • Scan before the review: 17 found

Licensing

The extension's own code is Expat (MIT) and needs nothing fixed, but debian/copyright declares Files: * to be Expat and names only Tatsuya KAMIJO, while the source package also ships a complete copy of libzstd under zstd-0.18.0/zstd/, licensed BSD-3-Clause or GPL-2 (see its own LICENSE and COPYING) and copyrighted by Meta Platforms, Inc. and affiliates, Yann Collet and Tino Reichardt. The BSD-3-Clause notice is therefore misdescribed, its holders are unnamed and its required text is absent. All licences involved are DFSG-free, but debian/copyright is wrong, so the answer is no until it is corrected.

Packaging

Conventional, correct dh-php packaging: generated control with the expected per-PHP-version packages and substvars, the system libzstd via --with-libzstd, DEP-14 gbp config, 3.0 (quilt) with two documented upstream patches, sane changelog. Only minor issues: an obsolete Standards-Version, the fully unused bundled libzstd copy in the source package, and REPORT_EXIT_STATUS=0, which stops the PHP test suite from ever failing the build with no autopkgtest to compensate.

Issues

blocker licensing 1. Files: * calls the bundled libzstd Expat; it is BSD-3-Clause or GPL-2, and Meta Platforms, Yann Collet and Tino Reichardt are unnamed ◂
  • Files: debian/copyright:6-8, zstd-0.18.0/zstd/LICENSE:1-6, zstd-0.18.0/zstd/COPYING:1-4, zstd-0.18.0/zstd/lib/common/zstd_common.c:1-9, zstd-0.18.0/zstd/lib/common/threading.c:1-12
  • Basis: checked, in the package or with a reference tool
  • Evidence: debian/copyright: Files: * / Copyright: 2015 Tatsuya KAMIJO / License: Expat. zstd-0.18.0/zstd/lib/common/zstd_common.c: Copyright (c) Meta Platforms, Inc. and affiliates. ... This source code is licensed under both the BSD-style license (found in the LICENSE file ...) and the GPLv2 (found in the COPYING file ...). zstd-0.18.0/zstd/lib/common/threading.c: Copyright (c) 2016 Tino Reichardt.
  • Problem: The catch-all stanza covers zstd-0.18.0/zstd/**: about 120 files of libzstd (COPYING is GPL-2, LICENSE is BSD-3-Clause, headers of xxhash.c name Yann Collet). debian/copyright states a single wrong licence for them, names none of their holders and reproduces no BSD-3-Clause text, which is not in /usr/share/common-licenses. The source package is distributed with these files, so Policy 12.5 and copyright-format require an accurate description and the licence text; a wrong licence is a blocker wherever in the tree the file is.
  • Fix: Add a stanza such as Files: zstd-0.18.0/zstd/* with Copyright: 2016-present Meta Platforms, Inc. and affiliates, 2016 Tino Reichardt, Yann Collet and License: BSD-3-clause or GPL-2, plus a stand-alone License: BSD-3-clause paragraph carrying the text from zstd-0.18.0/zstd/LICENSE and a License: GPL-2 paragraph pointing at /usr/share/common-licenses/GPL-2. Keep the existing Expat stanza for the rest of the tree and for debian/*.
important licensing 2. debian/copyright does not declare the current copyright-format 1.0 URL ◂
  • Files: debian/copyright:1
  • Basis: found by the review tooling's own checks
  • Evidence: Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
  • Problem: The first field must be exactly Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ (copyright-format 1.0, "Format" field). Anything else, including the http:// form and the URLs of the drafts that preceded 1.0, does not declare the file to be in the current format, and a file written to a draft may also use field names and licence short names that 1.0 changed.
  • Fix: Replace the line as shown under Proposed changes, then check the rest of the file against copyright-format 1.0 (for example Upstream-Name, Upstream-Contact and Source in the header, not Name or Maintainer).
minor packaging 3. Source package embeds a full, unused copy of libzstd that Debian already ships ◂
  • Files: debian/rules:3, zstd-0.18.0/zstd/, zstd-0.18.0/config.m4:38-96
  • Basis: checked, in the package or with a reference tool
  • Evidence: debian/rules: PECL_CONFIGURE_MAINT_APPEND := --with-libzstd; Build-Depends: libzstd-dev; config.m4 compiles the bundled sources only in the else branch taken when --with-libzstd is not given.
  • Problem: Every Debian build is forced to use the system libzstd, so the 120-file, ~500 KB bundled copy under zstd-0.18.0/zstd/ is dead weight in the source package, duplicates a library Debian already maintains (libzstd-dev 1.5.7), will drift from it, and is the sole reason debian/copyright is currently inaccurate.
  • Fix: Either drop it from the upstream tarball (Files-Excluded: zstd-0.18.0/zstd with the matching uscan repack, since the build always passes --with-libzstd), or keep it deliberately and describe it fully in debian/copyright per the blocker above.
minor packaging 4. Standards-Version 4.5.1 is older than the current Policy 4.7.4.1 ◂
  • Files: debian/control:11, debian/control.in:11
  • Basis: checked, in the package or with a reference tool
  • Evidence: Standards-Version: 4.5.1 versus Debian Policy 4.7.4.1 (policy tool).
  • Problem: The declared Policy version is two minor series behind, so the package has not been reviewed against Policy 4.6.x/4.7.x; the first two components decide this, and 4.5 is old.
  • Fix: Bump Standards-Version in debian/control.in (dh-php regenerates debian/control) to 4.7.4.1 after checking the 4.6/4.7 upgrading checklist, or at least to 4.6.0.
minor packaging 5. debian/watch is in the old version 3 format ◂
  • Files: debian/watch
  • Basis: found by the review tooling's own checks
  • Evidence: version=3
  • Problem: Version 5 is the current format of debian/watch.
  • Fix: Convert it to version 5; a mechanical conversion is under Proposed changes.
Verified ◂
  • All 15 zstd-compressed files are test fixtures consumed by the .phpt suite, not build artifacts: zstd-0.18.0/tests/files/ob_001.zstd, ob_003.zstd, ob_004.zstd, ob_007.zstd, ob_008.zstd, ob_011.zstd, ob_012.zstd, ob_013.zstd, ob_014.zstd, ob_015.zstd, ob_016.zstd, ob_017.zstd, ob_018.zstd, ob_data.zstd and ob_dcz.zstd are compared by the corresponding ob_*.phpt/ob_dcz_*.phpt tests, and zstd-0.18.0/tests/streaming.zst is read by 010.phpt. They are inputs, not installed.
  • zstd-0.18.0/tests/data.dic is the zstd dictionary fixture read by dictionary*.phpt, alias.phpt, named_args.phpt and inc_*.phpt; zstd-0.18.0/tests/files/ob_dcz.zstd is the compressed-page fixture of ob_dcz_*.phpt. Test data, not installed.
  • The prescan's kjdev holder is Tatsuya KAMIJO (package.xml lead <user>kjdev</user>, kjdev@php.net), who is named in Files: *; only the bundled-libzstd holders are genuinely missing.
  • Read in full: debian/copyright, control, control.in, rules, changelog, compat, gbp.conf, php-zstd.php, zstd.ini, source.lintian-overrides, source/format, patches/series and both patches. Upstream: package.xml, README.md, config.m4, LICENSE, and the headers of zstd.c, php_zstd.h and zstd/COPYING, zstd/LICENSE; the rest of the tree checked by grep for copyright/licence wording.
  • The extension's own files (zstd.c, php_zstd.h, LICENSE, tests) are Expat 2015 kjdev, so Files: * matches them; the tree has no other licence files besides zstd-0.18.0/LICENSE and the two in zstd-0.18.0/zstd/.
  • libzstd-dev 1.5.7, php-all-dev 2:102~ (experimental) and dh-php 5.23 all exist in the archive; pkg-config, which config.m4 requires, comes in through php8.4-dev, a dependency of php-all-dev, so no Build-Depends is missing.
  • Both patches carry DEP-3 headers and apply to real paths (package.xml and zstd-0.18.0/tests/streams_7.phpt); neither changes licence or vendor code. debian/patches/series lists both.
  • The changelog's experimental distribution and 0.18.0-1 version fit the PHP 8.6 dependency (php-all-dev 2:102~) and close #1123428 earlier; no PHP-licensed file exists, so the license-problem-php-license lintian override is merely stale.
  • uscan found the packaged version as the newest upstream release (upstream 0.18.0, packaged 0.18.0).
Not confirmed ◂
  • dh-php's pkg-pecl.mk is not installed on the reviewing system, so how the build locates config.m4 inside the zstd-0.18.0/ subdirectory could not be read; the package is assumed to build, as the archive data shows.
  • Whether this is a fault: REPORT_EXIT_STATUS=0 makes the .phpt suite unable to fail the build, with no autopkgtest to run it instead. The model reported it as a minor packaging issue from its own knowledge of something outside the package, which it did not check with a tool, so it is not counted among the issues. Files: debian/rules:2, debian/changelog:120-125.
    Evidence: debian/rules: export REPORT_EXIT_STATUS:=0; changelog 0.10.0-2: Don't fail on failed tests.
    Problem: PHP's run-tests.php exits non-zero on FAIL/BORKED/LEAK/WARN unless REPORT_EXIT_STATUS is 0, so dh_auto_test always succeeds and the ~80 tests under zstd-0.18.0/tests/ never gate anything; there is no debian/tests, so a regression they catch is noticed nowhere.
    Fix: Drop the override (or set it to a non-zero value) so real failures fail the build; if some tests are known-unstable on new PHP versions, skip them with --SKIPIF-- or exclude them explicitly in the test invocation instead of disabling exit status reporting.
Proposed: debian/watch in version 5 format ◂

debian/watch is in an old format. This is the conversion made by uscan --update-watchfile, which has not been run against the upstream site: some defaults differ in version 5, so test it with uscan --report before use.

Version: 5

Source: https://pecl.php.net/package/zstd
Matching-Pattern: /get/zstd-([\d\.p?]*).tgz
Update-Script: uupdate
Proposed: debian/copyright Format field ◂

Replace line 1 of debian/copyright with:

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

Uploader's response to the LLM review

Waiting for the uploader's response until , because the review found serious issues.

Back to Dashboard | View all reviews for this package