DFSG NEW Queue

DFSG, Licensing & New Packages Team

Review: picolibc 1.8.11-1

Review Information

accepted — allocated to awm 1 month, 11 days ago, started 1 month, 11 days ago, completed 1 month, 11 days ago.

Final Comment

There is a typo in your debian/control that you could fix, and maybe
some URLs that are referenced which you could switch to https, but
sure... Read the full review notes for details!

Public Notes

1 month, 11 days ago ● public

duck

duck - check URL redirections  : env PERL5OPT=-m-lib=. duck (1)

E: debian/control: Vcs-Git: git://keithp.com/git/picolibc.git -b debian: ERROR (Certainty:certain)
   fatal: unable to connect to keithp.com:
   keithp.com[0: 63.227.221.253]: errno=Connection refused

E: debian/control: Vcs-Browser: https://keithp.com/cgit/picolibc.git/: ERROR (Certainty:certain)
   Curl:0 HTTP:404 No error 

E: debian/copyright:4: URL: https://keithp.com/git/picolibc: ERROR (Certainty:possible)
   Curl:0 HTTP:404 No error 

I: debian/copyright:2746: URL: http://www.ti.com: INFORMATION (Certainty:possible)
   URL schema changed from HTTP to HTTPS during redirect(s): http://www.ti.com -> https://www.ti.com
   Please investigate and update the URL eventually, to avoid unnecessary redirects!

I: debian/copyright:6155: URL: http://www.apache.org/licenses/LICENSE-2.0: INFORMATION (Certainty:wild-guess)
   Curl:0 HTTP:200 No error 
   Website seems to be outdated, is probably a parked domain or for sale. Please update your links!
   Matching regular expression(s):
    m/\breplaced with\b/i

I: debian/copyright:6155: URL: http://www.apache.org/licenses/LICENSE-2.0: INFORMATION (Certainty:wild-guess)
   URL schema changed from HTTP to HTTPS during redirect(s): http://www.apache.org -> https://www.apache.org
   Please investigate and update the URL eventually, to avoid unnecessary redirects!

I: debian/copyright:6084: URL: http://www.opensource.org/licenses: INFORMATION (Certainty:possible)
   URL schema changed from HTTP to HTTPS during redirect(s): http://www.opensource.org -> https://opensource.org
   Please investigate and update the URL eventually, to avoid unnecessary redirects!

I: debian/copyright:5955: URL: http://www.opensource.org/licenses: INFORMATION (Certainty:possible)
   URL schema changed from HTTP to HTTPS during redirect(s): http://www.opensource.org -> https://opensource.org
   Please investigate and update the URL eventually, to avoid unnecessary redirects!

I: debian/copyright:5946: URL: http://www.opensource.org/licenses: INFORMATION (Certainty:possible)
   URL schema changed from HTTP to HTTPS during redirect(s): http://www.opensource.org -> https://opensource.org
   Please investigate and update the URL eventually, to avoid unnecessary redirects!

E: debian/control: Homepage: https://keithp.com/picolibc: ERROR (Certainty:certain)
   Curl:28 HTTP:200 Timeout was reached Operation timed out after 60001 milliseconds with 7937 out of 50205 bytes received
1 month, 11 days ago ● public

vulture

Command: vulture .
Exit code: 3

libc/ctype/mkctype-extended.py:69: unused attribute 'canonical_combining' (60% confidence)
libc/ctype/mkctype-extended.py:70: unused attribute 'bidirectional' (60% confidence)
libc/ctype/mkctype-extended.py:72: unused attribute 'decimal' (60% confidence)
libc/ctype/mkctype-extended.py:73: unused attribute 'digit' (60% confidence)
libc/ctype/mkctype-extended.py:74: unused attribute 'numeric' (60% confidence)
libc/ctype/mkctype-extended.py:75: unused attribute 'mirrored' (60% confidence)
libc/ctype/mkctype-extended.py:76: unused attribute 'name_1_0' (60% confidence)
libc/ctype/mkctype-extended.py:77: unused attribute 'comment' (60% confidence)
libc/ctype/mkctype-extended.py:80: unused attribute 'titlecase' (60% confidence)
libc/ctype/mkctype-extended.py:87: unused attribute 'titlecase' (60% confidence)
libc/ctype/mkctype.py:69: unused attribute 'canonical_combining' (60% confidence)
libc/ctype/mkctype.py:70: unused attribute 'bidirectional' (60% confidence)
libc/ctype/mkctype.py:72: unused attribute 'decimal' (60% confidence)
libc/ctype/mkctype.py:73: unused attribute 'digit' (60% confidence)
libc/ctype/mkctype.py:74: unused attribute 'numeric' (60% confidence)
libc/ctype/mkctype.py:75: unused attribute 'mirrored' (60% confidence)
libc/ctype/mkctype.py:76: unused attribute 'name_1_0' (60% confidence)
libc/ctype/mkctype.py:77: unused attribute 'comment' (60% confidence)
libc/ctype/mkctype.py:80: unused attribute 'titlecase' (60% confidence)
libc/ctype/mkctype.py:87: unused attribute 'titlecase' (60% confidence)
libc/ctype/mkctype_class.py:69: unused attribute 'canonical_combining' (60% confidence)
libc/ctype/mkctype_class.py:70: unused attribute 'bidirectional' (60% confidence)
libc/ctype/mkctype_class.py:72: unused attribute 'decimal' (60% confidence)
libc/ctype/mkctype_class.py:73: unused attribute 'digit' (60% confidence)
libc/ctype/mkctype_class.py:74: unused attribute 'numeric' (60% confidence)
libc/ctype/mkctype_class.py:75: unused attribute 'mirrored' (60% confidence)
libc/ctype/mkctype_class.py:76: unused attribute 'name_1_0' (60% confidence)
libc/ctype/mkctype_class.py:77: unused attribute 'comment' (60% confidence)
libc/ctype/mkctype_class.py:80: unused attribute 'titlecase' (60% confidence)
libc/ctype/mkctype_class.py:87: unused attribute 'titlecase' (60% confidence)
libc/stdlib/mk-jis-charsets.py:218: unused variable 'min_unicode' (60% confidence)
libc/stdlib/mk-jis-charsets.py:219: unused variable 'max_unicode' (60% confidence)
libc/stdlib/mk-jis-charsets.py:257: unused variable 'first_col' (60% confidence)
libc/stdlib/mk-jis-charsets.py:258: unused variable 'last_col' (60% confidence)
1 month, 11 days ago ● public

CME fix

Command: cme fix --verbose dpkg
Exit code: 2


Reading package lists... 0%

Reading package lists... 100%

Reading package lists... Done

Building dependency tree... 0%

Building dependency tree... 0%

Building dependency tree... 50%

Building dependency tree... 50%

Building dependency tree... Done

Reading state information... 0% 

Reading state information... 0%

Reading state information... Done
cme: running fix on dpkg configuration...
Connecting to api.ftp-master.debian.org to check 6 package versions. Please wait...
Got info from api.ftp-master.debian.org for 6 packages.
Warning in 'control source Standards-Version': Current standards version is '4.7.3'. Please read https://www.debian.org/doc/debian-policy/upgrading-checklist.html for the changes that may be needed on your package
to upgrade it from standard version '4.7.0' to '4.7.3'.

Offending value: '4.7.0'
Warning in 'control source Vcs-Git': An unencrypted transport protocol is used for this URI. It is recommended to use a secure transport such as HTTPS for anonymous read-only access.
Offending value: 'git://keithp.com/git/picolibc.git -b debian'
Warning: copyright 'Upsream-Contact' is confusingly close to 'Upstream-Contact' (edit distance is 1). Is there a typo ?
Configuration item 'copyright Files:".clang-format
.editorconfig
.gitattributes
.github/Dockerfile
.github/Dockerfile-check-format
.github/Dockerfile-coreboot
.github/Dockerfile-zephyr
.github/do-build
.github/do-cmake-test
.github/do-linux-misc
.github/do-many
.github/do-run
.github/do-test
.github/do-test-noopt
.github/do-zephyr
.github/linux-files.txt
.github/linux-packages.txt
.github/workflows/Makefile
.github/workflows/check-format.yml
.github/workflows/head
.github/workflows/head-coreboot
.github/workflows/head-native
.github/workflows/head-zephyr
.github/workflows/linux.yml
.github/workflows/make-workflow
.github/workflows/make-workflow-coreboot
.github/workflows/make-workflow-native
.github/workflows/make-workflow-zephyr
.github/workflows/native.yml
.github/workflows/steps-head
.github/workflows/variants
.github/workflows/zephyr.yml
.github/zephyr
.github/zephyr-files.txt
.github/zephyr-packages.txt
.gitignore
README.md
cmake/TC-clang-thumbv6m.cmake
cmake/TC-clang-thumbv7m.cmake
cmake/TC-rx.cmake
cmake/TC-thumbv6m.cmake
cmake/TC-thumbv7m.cmake
cmake/have-bitfields-in-packed-structs.c
cmake/have-cc-inhibit-loop-to-libcall.c
doc/build.md
doc/ctype.md
doc/embedsource.md
doc/init.md
doc/linking.md
doc/locking.md
doc/os.md
doc/picolibc.svg
doc/printf.md
doc/releasing.md
doc/testing.md
doc/tls.md
doc/using.md
hello-world/README.md
libc/ctype/ctype.tex
libc/include/sys/_tz_structs.h
libc/libc.in.xml
libc/machine/aarch64/sys/fcntl.h
libc/machine/hexagon/longjmp.S
libc/machine/hexagon/meson.build
libc/machine/hexagon/setjmp.S
libc/machine/hexagon/tls.c
libc/machine/necv70/necv70.tex
libc/machine/nvptx/clock.c
libc/machine/riscv/xlenint.h
libc/machine/xtensa/xtensa.tex
libc/ssp/ssp.tex
libc/stdlib/mul_overflow.h
libc/string/wcstrings.tex
libc/time/strftime.c
libc/time/tzset.c
libc/xdr/README
libm/complex/CMakeLists.txt
libm/complex/complex.tex
libm/fenv/fenv.tex
libm/ld/files
libm/libm.in.xml
picocrt/machine/aarch64/crt0.S
picocrt/machine/hexagon/crt0_standalone.S
picocrt/machine/hexagon/crt0_standalone.c
picocrt/machine/hexagon/meson.build
picolibc.h.in
picolibc.ld.in
picolibc.specs.in
scripts/checkpatch
scripts/cross-aarch64-linux-gnu.txt
scripts/cross-aarch64-none-elf.txt
scripts/cross-aarch64-zephyr-elf.txt
scripts/cross-arc-zephyr-elf.txt
scripts/cross-arc64-zephyr-elf.txt
scripts/cross-arm-none-eabi.txt
scripts/cross-arm-zephyr-eabi.txt
scripts/cross-avr.txt
scripts/cross-clang-aarch64-none-elf.txt
scripts/cross-clang-arm-none-eabi.txt
scripts/cross-clang-cortex-r82.txt
scripts/cross-clang-hexagon.txt
scripts/cross-clang-msp430.txt
scripts/cross-clang-riscv64-unknown-elf.txt
scripts/cross-clang-riscv64-zephyr-elf.txt
scripts/cross-clang-rv32imafc.txt
scripts/cross-clang-rv32imafdc-unknown-elf.txt
scripts/cross-clang-thumb-none-eabi.txt
scripts/cross-clang-thumbv6m-none-eabi.txt
scripts/cross-clang-thumbv7-a-none-eabi.txt
scripts/cross-clang-thumbv7e+dp-none-eabi.txt
scripts/cross-clang-thumbv7e+fp-none-eabi.txt
scripts/cross-clang-thumbv7m-none-eabi.txt
scripts/cross-clang-x86.txt
scripts/cross-clang-x86_64.txt
scripts/cross-coreboot-arm-eabi.txt
scripts/cross-coreboot-i386-elf.txt
scripts/cross-coreboot-riscv-elf.txt
scripts/cross-coreboot-x86_64-elf.txt
scripts/cross-cortex-a9-none-eabi.txt
scripts/cross-i686-linux-gnu.txt
scripts/cross-lm32-unknown-elf.txt
scripts/cross-loongarch64-unknown-elf.txt
scripts/cross-m68k-linux-gnu.txt
scripts/cross-m68k-unknown-elf.txt
scripts/cross-microblazeel-zephyr-elf.txt
scripts/cross-mips-linux-gnu.txt
scripts/cross-mips-zephyr-elf.txt
scripts/cross-mips64-linux-gnuabi64.txt
scripts/cross-mipsel-linux-gnu.txt
scripts/cross-msp430-unknown-elf.txt
scripts/cross-msp430.txt
scripts/cross-nios2-zephyr-elf.txt
scripts/cross-or1k-elf.txt
scripts/cross-or1k-unknown-elf.txt
scripts/cross-power9-fp128.txt
scripts/cross-power9.txt
scripts/cross-powerpc64-linux-gnu.txt
scripts/cross-powerpc64le-linux-gnu.txt
scripts/cross-riscv64-unknown-elf.txt
scripts/cross-riscv64-zephyr-elf.txt
scripts/cross-rv32imac.txt
scripts/cross-rv32imac_zicsr_zbb.txt
scripts/cross-rx-zephyr-elf.txt
scripts/cross-sh-unknown-elf.txt
scripts/cross-sparc-zephyr-elf.txt
scripts/cross-sparc64-linux-gnu.txt
scripts/cross-thumbv8_1m-none-eabi.txt
scripts/cross-thumbv8m_main_fp-none-eabi.txt
scripts/cross-x86-linux-gnu.txt
scripts/cross-x86_64-linux-gnu.txt
scripts/cross-x86_64-zephyr-elf.txt
scripts/cross-xtensa-dc233c_zephyr-elf.txt
scripts/cross-xtensa-esp32-elf.txt
scripts/cross-xtensa-espressif_esp32_zephyr-elf.txt
scripts/cross-xtensa-espressif_esp32s2_zephyr-elf.txt
scripts/cross-xtensa-intel_apl_adsp_zephyr-elf.txt
scripts/cross-xtensa-intel_s1000_zephyr-elf.txt
scripts/cross-xtensa-lx106-elf.txt
scripts/cross-xtensa-nxp_imx8m_adsp_zephyr-elf.txt
scripts/cross-xtensa-nxp_imx_adsp_zephyr-elf.txt
scripts/cross-xtensa-sample_controller_zephyr-elf.txt
scripts/do-arm-tk
scripts/do-clang-hexagon-configure
scripts/duplicate-names
scripts/monitor-e9
scripts/run-hexagon
scripts/run-lm32
scripts/test-picolibc
semihost/machine/hexagon/hexagon_close.c
semihost/machine/hexagon/hexagon_errno.c
semihost/machine/hexagon/hexagon_exit.c
semihost/machine/hexagon/hexagon_flen.c
semihost/machine/hexagon/hexagon_ftell.c
semihost/machine/hexagon/hexagon_get_cmdline.c
semihost/machine/hexagon/hexagon_isatty.c
semihost/machine/hexagon/hexagon_lseek.c
semihost/machine/hexagon/hexagon_open.c
semihost/machine/hexagon/hexagon_read.c
semihost/machine/hexagon/hexagon_semihost.c
semihost/machine/hexagon/hexagon_semihost.h
semihost/machine/hexagon/hexagon_stub.c
semihost/machine/hexagon/hexagon_unlink.c
semihost/machine/hexagon/hexagon_write.c
semihost/machine/hexagon/meson.build
semihost/machine/x86/bios.ld
test/CP720
test/complex-funcs.c
test/long_double_gen.5c
test/long_double_vec.h
test/test-argv.c
test/test-atomic.c
test/test-math/.clang-format-ignore
test/test-math/Makefile
test/test-math/math-test-copyright
test/test-math/test-complex.5c
test/test-math/test-float.5c
test/test-stdio/test-sprintf-time.c
test/test-strftime.c
test/test-wcsftime.c
test/testsuite/newlib.time/tzset.c" Copyright' has a wrong value:
	Undefined mandatory value.

Back to Dashboard | View all reviews for this package