Review: protoc-gen-doc 1.5.1-1
New Package Report
.changes
| Changed-By | Simon Josefsson |
|---|---|
| Architecture | source all amd64 |
| Distribution | unstable |
| Date | Wed, 18 Mar 2026 16:01:29 +0100 |
| Source | protoc-gen-doc |
| Version | 1.5.1-1 |
Changelog
protoc-gen-doc (1.5.1-1) unstable; urgency=medium . * Initial release (Closes: #1131418)
.dsc
| Package-List | golang-github-pseudomuto-protoc-gen-doc-dev deb golang optional arch=all protoc-gen-doc deb devel optional arch=any |
|---|---|
| Section | golang |
| Priority | optional |
| Component | main |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Source: https://github.com/pseudomuto/protoc-gen-doc Upstream-Name: protoc-gen-doc Upstream-Contact: TODO Files: * Copyright: 2014 David Muto License: Expat Files: debian/* Copyright: 2026 Simon Josefsson <simon@josefsson.org> License: Expat Comment: Debian packaging is licensed under the same terms as upstream License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Review Information
rejected — allocated to siretart 24 days ago, started 24 days ago, completed 24 days ago.
Final Comment
I am rejecting this package due to the files in thirdparty/.
The thirdparty/github.com/mwitkow/go-proto-validators/ component refers to an external LICENSE file that is not included in the source, making its legal status unclear and non-compliant with Debian's licensing requirements.
Since upstream uses thirdparty/generate.go to download these files, I suggest you:
- Remove the thirdparty/ files from the upstream source (e.g., using a +dfsg version).
- Move the download logic to an autopkgtest that fetches these files during testing.
Bundling them in the source package without their respective licenses makes it difficult to ensure DFSG compliance. Please clarify the copyright/license for any bundled code or repack the source as suggested before re-uploading.
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 1.5.1+ds-1 | 24cc9b03… | 2026-03-24 10:34 | 2026-03-24 10:36 | siretart | accepted | VIEW |
Public Notes
24 days ago
● public
Lintian
Command: lintian -Iiv -L '>=warning' --show-overrides --color=never ../$(basename $PWD)_*.changes
Exit code: 0
N:
W: protoc-gen-doc: no-manual-page [usr/bin/protoc-gen-doc]
N:
N: Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have
N: a manual page
N:
N: Note that though the man program has the capability to check for several
N: program names in the NAMES section, each of these programs should have its
N: own manual page (a symbolic link to the appropriate manual page is
N: sufficient) because other manual page viewers such as xman or tkman don't
N: support this.
N:
N: If the name of the manual page differs from the binary by case, man may be
N: able to find it anyway; however, it is still best practice to match the
N: exact capitalization of the executable in the manual page.
N:
N: If the manual pages are provided by another package on which this package
N: depends, Lintian may not be able to determine that manual pages are
N: available. In this case, after confirming that all binaries do have manual
N: pages after this package and its dependencies are installed, please add a
N: Lintian override.
N:
N: Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
N: for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: binary-without-manpage
N:
N:
N: false positive: this is not a documentation package
O: protoc-gen-doc: documentation-package-not-architecture-independent
N:
N: Documentation packages usually shouldn't carry anything that requires
N: recompiling on various architectures, in order to save space on mirrors.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: fields/architecture
N: