DFSG NEW Queue

DFSG, Licensing & New Packages Team

pthash 2.0.0+git20260727.aea5613-1

Package Information

Descriptionlibrary for fast and compact minimal perfect hash functions

PTHash is a C++ library implementing fast and compact minimal perfect hash functions.

This package contains the header-only library and a pkg-config file.

MaintainerDebian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org>
Changed ByAndreas Tille <tille@debian.org>
Sponsortille@debian.org
Distributionunstable
Architectureall
VCSgit: https://salsa.debian.org/med-team/pthash.git (browse)
Closes#1154452
Trackerhttps://tracker.debian.org/pkg/pthash
Uploaded1 hour ago

New Package Report

.changes◂
Changed-ByAndreas Tille <tille@debian.org>
Architecturesource all
Distributionunstable
DateThu, 19 Nov 2026 16:59:22 +0100
Sourcepthash
Version2.0.0+git20260727.aea5613-1
Changelog◂
pthash (2.0.0+git20260727.aea5613-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1154452)
.dsc◂
Componentmain
Package-Listlibpthash-dev deb libdevel optional arch=all
Sectionlibdevel
Priorityoptional
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: pthash
Upstream-Contact: Giulio Ermanno Pibiri
Source: https://github.com/jermp/pthash

Files: *
Copyright: 2020-2024 Giulio Ermanno Pibiri
           2020-2024 Roberto Trani
License: Expat

Files: debian/*
Copyright: 2026 Andreas Tille <tille@debian.org>
License: Expat

Files: debian/missing-sources/*.hpp
Copyright: 2019 Giulio Ermanno Pibiri
Comment: This header is the contents of the external/mm_file git submodule of
 the upstream pthash repository (https://github.com/jermp/mm_file), commit
 5b5291360488095ce3617c48af0f5145fdf9e710.  It is not part of the upstream
 tarball itself and is therefore shipped as a missing source file.
License: Expat

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and
 associated documentation files (the "Software"), to deal in the Software without restriction, including
 without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the
 following conditions:
 .
 The above copyright notice and this permission notice shall be included in all copies or substantial
 portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT
 LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO
 EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 USE OR OTHER DEALINGS IN THE SOFTWARE.

DFSG Assistant LLM REVIEW 1 blocker, 1 important, 1 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 1 hour ago.

Report◂

DFSG NEW review for pthash version 2.0.0+git20260727.aea5613-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: No
  • Packaging is of good quality: Yes
  • Issues: 1 blocker, 1 important, 1 minor
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: nothing found

Licensing

The licence itself is free (Expat/MIT, full text in debian/copyright) and all upstream files are covered by a DEP-5 stanza. However, debian/copyright's Files: * stanza names only two of the six copyright holders that upstream's LICENSE states for the work, and gives 2020-2024 where LICENSE says 2020-2025. Four holders of code that libpthash-dev installs (the PHOBIC headers) are missing, so the file is inaccurate.

Packaging

The packaging is sound for a header-only C++ library: debhelper compat 14, a correct arch:all -dev package with pkg-config file and dependency on libbits-dev/libxxhash-dev, DEP-3 patches that replace the absent submodules with Debian packages or shipped sources, and an autopkgtest that compiles the shipped tests. Only a minor provenance nit in debian/missing-sources.

Issues

blocker licensing 1. Files: * omits four copyright holders named in LICENSE (Stefan Hermann, Hans-Peter Lehmann, Peter Sanders, Stefan Walzer) ◂
  • Files: debian/copyright:6-9, LICENSE:3
  • Basis: checked, in the package or with a reference tool
  • Evidence: LICENSE: Copyright 2020-2025 Giulio Ermanno Pibiri, Roberto Trani, Stefan Hermann, Hans-Peter Lehmann, Peter Sanders, Stefan Walzer; debian/copyright: Copyright: 2020-2024 Giulio Ermanno Pibiri / 2020-2024 Roberto Trani
  • Problem: Every upstream file is covered by Files: *, whose Copyright field understates the holders of the whole work. The library headers with the PHOBIC implementation (e.g. include/dense_partitioned_phf.hpp, include/utils/bucketers.hpp) are installed by libpthash-dev and contain no copyright notice of their own, so under Debian Policy 2.3 the notice must be in debian/copyright; four holders are missing there. This is an inaccurate debian/copyright, not merely a missing notice in a file that is not shipped.
  • Fix: Add the four holders and upstream's year range to the Files: * Copyright field, e.g. 2020-2025 Giulio Ermanno Pibiri, Roberto Trani, Stefan Hermann, Hans-Peter Lehmann, Peter Sanders, Stefan Walzer; leave the Expat text as is.
important packaging 2. uscan reports a warning for debian/watch ◂
  • Files: debian/watch

  • Basis: found by the review tooling's own checks

  • Evidence:

    The following paragraph isn't well formatted, skipping it: << ==EOF==
    # pufferfish and sshash require the pthash snapshot at commit e04a1920, which
    # is 30 commits after the last tagged release (v2.0.0).
    # Template: Github
    # Dist: https://github.com/jermp/pthash
    
    ==EOF==
    
  • Problem: uscan must run without errors or warnings and find the upstream releases.

  • Fix: Correct debian/watch so that uscan --report runs cleanly.

minor packaging 3. debian/missing-sources fetch scripts download unpinned master, and parser.hpp's origin commit is unrecorded ◂
  • Files: debian/missing-sources/get_cmd_line_parser:2, debian/missing-sources/get_mm_file:2, debian/copyright:15-20
  • Basis: checked, in the package or with a reference tool
  • Evidence: wget https://raw.githubusercontent.com/jermp/cmd_line_parser/refs/heads/master/include/parser.hpp; wget https://raw.githubusercontent.com/jermp/mm_file/refs/heads/master/include/mm_file/mm_file.hpp; copyright Comment pins only mm_file ... commit 5b5291360488095ce3617c48af0f5145fdf9e710
  • Problem: mm_file.hpp and parser.hpp are not in the upstream tarball; the only record of what was shipped is these scripts, which fetch a moving branch. The copyright Comment documents a commit for mm_file that the script does not use, and records no commit or repository at all for parser.hpp, so the shipped files cannot be reproduced or audited later.
  • Fix: Pin both wget URLs to the commit used and extend the Comment (or add a second one) to record the repository and commit of parser.hpp, as done for mm_file.
Verified ◂
  • Read all of debian/: control, rules, changelog, copyright, .install/.docs/.examples, patches/series and all four patches, pthash.pc, tests/control and run-unit-test, README.test, upstream/metadata, salsa-ci.yml, source/format.
  • The scan's only listed item is LICENSE:3; the four extra names there are the blocker reported above.
  • debian/copyright is DEP-5 with a correct Format URL, full Expat text, Files: *, Files: debian/* and a Files: debian/missing-sources/*.hpp stanza that overrides debian/* for those two headers; no Files-Excluded.
  • A case-insensitive grep for Copyright/(C)/©/SPDX/licence phrases over the whole tree finds notices only in LICENSE and debian/copyright; no per-file licence headers exist, so no other holder or licence text is hidden in the sources.
  • external/bits, external/xxHash, external/mm_file and external/cmd_line_parser are empty submodule mount points; no third-party vendored code is shipped, and the two submodule headers used are shipped under debian/missing-sources instead.
  • All upstream material (tests, scripts, benchmarks, CI, images) falls under the single Expat Files: * stanza; the licences are compatible.
  • img/pthash.png and img/pthash_on_dark.png are the README logo images; benchmarks/results-07-09-25/.png, the .json and the .log are outputs of script/run_benchmark.py and script/plot_.py, which are shipped; binary files were not opened.
  • libbits-dev is not in the archive but is built by libbits 0.0~git20261030.c449567-1 in NEW, so Build-Depends/Depends on it are satisfiable; libxxhash-dev is in unstable and ships xxh3.h used by include/utils/hasher.hpp.
  • Standards-Version 4.7.4 against Policy 4.7.4.1: first two components current, not an issue.
  • Compat 14: dh_gencontrol adds relationship substvars itself; ${misc:Depends} is present anyway.
  • The mm_file symlink created in override_dh_auto_build is required: headers include "mm_file/mm_file.hpp", and the install places the header at /usr/include/pthash/mm_file/mm_file.hpp to match pthash.pc's -I/usr/include/pthash.
  • Patches enable CTest so dh_auto_test actually runs the three test_* programs, drop the references to absent submodules, and carry Description/Author/Last-Update headers.
  • Debian Med's alioth.debian.org maintainer address is still used by current Debian Med packages (checked fastqc), so not reported.
  • uscan found the packaged version as the newest upstream release (upstream 2.0.0+git20260727.aea5613, packaged 2.0.0+git20260727.aea5613).
Not confirmed ◂
  • debian/missing-sources/parser.hpp and mm_file.hpp carry no copyright or licence notice of their own; their Expat attribution to Giulio Ermanno Pibiri (2019) rests on debian/copyright and could not be checked against the separate upstream repositories without network access.
  • No CMake target links xxhash and debian/tests/run-unit-test uses only pkg-config --cflags, although include/utils/hasher.hpp calls XXH64/XXH128; if these are not inline, link would fail. The build is assumed to pass, so this is not reported as an issue.
  • The PNG files (img/, benchmarks/results-07-09-25/) were not opened.
Proposed changes ◂

None.

Uploader's response to the LLM review

Waiting for the uploader's response until , because the review found serious issues.

Back to Dashboard | View all reviews for this package